[PATCH 00/10] git-annex special-remote hubiC support

[PATCH 00/10] git-annex special-remote hubiC support

[Efraim Flashner]

We don't have git-annex yet, but this doesn't rely on the actual package for
packaging, and will help people using guix on a foreign distro with git-annex.
While working on this I learned a lot about python packaging in guix. A big
thanks to the authors of the pypi importer, that saved me quite a bit of
time in this process.

In the end I didn't need python2-functools32; it turned out I had just forgotten
to add (argument `(#:python ,python-2)) to the python2- packages and
git-annex-remote-hubic.

Efraim Flashner (10):
  gnu: Add python-pytest-cov.
  gnu: Add python-wheel.
  gnu: python-requests: Update to 2.8.1.
  gnu: Add python-keystoneclient.
  gnu: Add python2-futures.
  gnu: Add python-swiftclient.
  gnu: Add python-rauth.
  gnu: Add python-pyasn1-modules.
  gnu: Add python2-functools32.
  gnu: Add git-annex-remote-hubic.

 gnu/packages/openstack.scm       | 126 ++++++++++++++++++++++++++-
 gnu/packages/python.scm          | 179 +++++++++++++++++++++++++++++++++++++--
 gnu/packages/version-control.scm |  33 ++++++++
 3 files changed, 328 insertions(+), 10 deletions(-)

-- 
2.6.2

[PATCH 01/10] gnu: Add python-pytest-cov.

[Efraim Flashner]

* gnu/packages/python.scm (python-pytest-cov, python2-pytest-cov): New
  variable.
---
 gnu/packages/python.scm | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 3385393..d8fca79 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -1630,6 +1630,34 @@ and many external plugins.")
 (define-public python2-pytest
   (package-with-python2 python-pytest))
 
+(define-public python-pytest-cov
+  (package
+    (name "python-pytest-cov")
+    (version "2.2.0")
+    (source
+      (origin
+        (method url-fetch)
+        (uri (pypi-uri "pytest-cov" version))
+        (sha256
+          (base32
+           "1lf9jsmhqk5nc4w3kzwglmdzjvmi7ajvrsnwv826j3bn0wzx8c92"))))
+  (build-system python-build-system)
+  (inputs
+   `(("python-coverage" ,python-coverage)
+     ("python-pytest" ,python-pytest)))
+  (native-inputs
+   `(("python-setuptools" ,python-setuptools)))
+  (home-page "https://github.com/pytest-dev/pytest-cov")
+  (synopsis "Pytest plugin for measuring coverage")
+  (description
+   "Pytest-cov produces coverage reports.  It supports centralised testing and
+distributed testing in both load and each modes.  It also supports coverage
+of subprocesses.")
+  (license license:expat)))
+
+(define-public python2-pytest-cov
+  (package-with-python2 python-pytest-cov))
+
 (define-public python-pytest-runner
   (package
     (name "python-pytest-runner")
-- 
2.6.2

[PATCH 02/10] gnu: Add python-wheel.

[Efraim Flashner]

* gnu/packages/python.scm (python-wheel, python2-wheel): New variable.
---
 gnu/packages/python.scm | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index d8fca79..b110921 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -2161,6 +2161,34 @@ with sensible defaults out of the box.")
 (define-public python2-click
   (package-with-python2 python-click))
 
+(define-public python-wheel
+  (package
+    (name "python-wheel")
+    (version "0.26.0")
+      (source
+        (origin
+          (method url-fetch)
+          (uri (pypi-uri "wheel" version))
+          (sha256
+            (base32
+             "032k1ajijbqnv0z0k88bhf75mdimi18fcmm28mss90610lw3bbga"))))
+  (build-system python-build-system)
+  (native-inputs
+   `(("python-setuptools" ,python-setuptools)))
+  (inputs
+   `(("python-jsonschema" ,python-jsonschema)
+     ("python-pytest-cov" ,python-pytest-cov)))
+  (home-page "https://bitbucket.org/pypa/wheel/")
+  (synopsis "Built-package format for Python")
+  (description
+   "A wheel is a ZIP-format archive with a specially formatted filename and the
+.whl extension.  It is designed to contain all the files for a PEP 376
+compatible install in a way that is very close to the on-disk format.")
+  (license license:expat)))
+
+(define-public python2-wheel
+  (package-with-python2 python-wheel))
+
 (define-public python-requests
   (package
     (name "python-requests")
-- 
2.6.2

[PATCH 03/10] gnu: python-requests: Update to 2.8.1.

[Efraim Flashner]

* gnu/packages/python.scm (python-requests): Update to 2.8.1.
[native-inputs]: Move python-setuptools here.
[inputs]: Add python-py, python-pytest, python-pytest-cov, python-wheel.
[arguments]: Enable tests.
---
 gnu/packages/python.scm | 19 ++++++++++---------
 1 file changed, 10 insertions(+), 9 deletions(-)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index b110921..8084831 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -2192,21 +2192,22 @@ compatible install in a way that is very close to the on-disk format.")
 (define-public python-requests
   (package
     (name "python-requests")
-    (version "2.8.0")
+    (version "2.8.1")
     (source (origin
              (method url-fetch)
-             (uri
-              (string-append
-               "https://pypi.python.org/packages/source/r/requests/requests-"
-               version ".tar.gz"))
+             (uri (pypi-uri "requests" version))
              (sha256
               (base32
-               "0yrvj8hfnabrdxds59w6d6887sn5j0jlgpmcq04lk4k0kdc07w5j"))))
+               "0ny2nr1sqr4hcn3903ghmh7w2yni8shlfv240a8c9p6wyidqvzl4"))))
     (build-system python-build-system)
+    (native-inputs
+     `(("python-setuptools" ,python-setuptools)))
     (inputs
-     `(("python-setuptools" ,python-setuptools)
-       ("python-certifi" ,python-certifi)))
-    (arguments `(#:tests? #f)) ; no tests
+     `(("python-certifi" ,python-certifi)
+       ("python-py" ,python-py)
+       ("python-pytest" ,python-pytest)
+       ("python-pytest-cov" ,python-pytest-cov)
+       ("python-wheel" ,python-wheel)))
     (home-page "http://python-requests.org/")
     (synopsis "Python HTTP library")
     (description
-- 
2.6.2

[PATCH 04/10] gnu: Add python-keystoneclient.

[Efraim Flashner]

* gnu/packages/openstack.scm (python-keystoneclient)
(python2-keystoneclient): New variables.
---
 gnu/packages/openstack.scm | 73 +++++++++++++++++++++++++++++++++++++++++++++-
 1 file changed, 72 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/openstack.scm b/gnu/packages/openstack.scm
index 2578292..faf6ebf 100644
--- a/gnu/packages/openstack.scm
+++ b/gnu/packages/openstack.scm
@@ -19,12 +19,14 @@
 
 (define-module (gnu packages openstack)
   #:use-module (gnu packages python)
+  #:use-module (gnu packages tls)
   #:use-module (gnu packages version-control)
   #:use-module (guix build-system python)
   #:use-module (guix download)
   #:use-module ((guix licenses)
                 #:select (asl2.0))
-  #:use-module (guix packages))
+  #:use-module (guix packages)
+  #:use-module (srfi srfi-1))
 
 (define-public python-bandit
   (package
@@ -679,3 +681,72 @@ handling.")
 
 (define-public python2-oslo.utils
   (package-with-python2 python-oslo.utils))
+
+(define-public python-keystoneclient
+  (package
+    (name "python-keystoneclient")
+    (version "1.8.1")
+      (source
+        (origin
+          (method url-fetch)
+          (uri (pypi-uri "python-keystoneclient" version))
+          (sha256
+            (base32
+             "1w4csvkah67rfpxylxnvs2s3594i0f9isy8pf4gnsqs5zirvjaa4"))))
+  (build-system python-build-system)
+  (native-inputs
+   `(("python-setuptools" ,python-setuptools)
+     ;; and some packages for the tests
+     ("openssl" ,openssl)
+     ("python-coverage" ,python-coverage)
+     ("python-discover" ,python-discover)
+     ("python-fixtures" ,python-fixtures)
+     ("python-hacking" ,python-hacking)
+     ("python-keyring" ,python-keyring)
+     ("python-lxml" ,python-lxml)
+     ("python-mock" ,python-mock)
+     ("python-mox3" ,python-mox3)
+     ("python-oauthlib" ,python-oauthlib)
+     ("python-oslosphinx" ,python-oslosphinx)
+     ("python-oslotest" ,python-oslotest)
+     ("python-pycrypto" ,python-pycrypto)
+     ("python-requests-mock" ,python-requests-mock)
+     ("python-sphinx" ,python-sphinx)
+     ("python-temptest-lib" ,python-tempest-lib)
+     ("python-testrepository" ,python-testrepository)
+     ("python-testresources" ,python-testresources)
+     ("python-testtools" ,python-testtools)
+     ("python-webob" ,python-webob)))
+  (inputs
+   `(("python-babel" ,python-babel)
+     ("python-debtcollector" ,python-debtcollector)
+     ("python-iso8601" ,python-iso8601)
+     ("python-netaddr" ,python-netaddr)
+     ("python-oslo.config" ,python-oslo.config)
+     ("python-oslo.i18n" ,python-oslo.i18n)
+     ("python-oslo.serialization" ,python-oslo.serialization)
+     ("python-oslo.utils" ,python-oslo.utils)
+     ("python-pbr" ,python-pbr)
+     ("python-prettytable" ,python-prettytable)
+     ("python-requests" ,python-requests)
+     ("python-six" ,python-six)
+     ("python-stevedore" ,python-stevedore)))
+  (home-page "http://www.openstack.org/")
+  (synopsis "Client Library for OpenStack Identity")
+  (description
+   "Python-keystoneclient is the identity service used by OpenStack for
+authentication (authN) and high-level authorization (authZ).  It currently
+supports token-based authN with user/service authZ, and is scalable to support
+OAuth, SAML, and OpenID in future versions.  Out of the box, Keystone uses
+SQLite for its identity store database, with the option to connect to external
+LDAP.")
+  (license asl2.0)))
+
+(define-public python2-keystoneclient
+  (let ((keystoneclient (package-with-python2 python-keystoneclient)))
+    (package (inherit keystoneclient)
+      (native-inputs
+       `(("python2-oauthlib" ,python2-oauthlib)
+         ,@(alist-delete
+            "python-oauthlib"
+            (package-native-inputs keystoneclient)))))))
-- 
2.6.2

[PATCH 05/10] gnu: Add python2-futures.

[Efraim Flashner]

* gnu/packages/python.scm (python2-futures): New variable.
---
 gnu/packages/python.scm | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 8084831..21aa8fa 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -6063,3 +6063,26 @@ automatically detect a wide range of file encodings.")
 
 (define-public python2-chardet
   (package-with-python2 python-chardet))
+
+(define-public python2-futures
+  (package
+    (name "python2-futures")
+    (version "3.0.3")
+      (source
+        (origin
+        (method url-fetch)
+          (uri (pypi-uri "futures" version))
+        (sha256
+          (base32
+           "1vcb34dqhzkhbq1957vdjszhhm5y3j9ba88dgwhqx2zynhmk9qig"))))
+  (build-system python-build-system)
+  (arguments
+   `(#:python ,python-2))
+  (native-inputs
+   `(("python2-setuptools" ,python2-setuptools)))
+  (home-page "https://github.com/agronholm/pythonfutures")
+  (synopsis
+   "Backport of the concurrent.futures package from Python 3.2")
+  (description
+   "Backport of the concurrent.futures package from Python 3.2")
+  (license bsd-3)))
-- 
2.6.2

[PATCH 06/10] gnu: Add python-swiftclient.

[Efraim Flashner]

* gnu/packages/openstack.scm (python-swiftclient, python2-swiftclient):
New variables.
---
 gnu/packages/openstack.scm | 53 ++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 53 insertions(+)

diff --git a/gnu/packages/openstack.scm b/gnu/packages/openstack.scm
index faf6ebf..186c56d 100644
--- a/gnu/packages/openstack.scm
+++ b/gnu/packages/openstack.scm
@@ -750,3 +750,56 @@ LDAP.")
          ,@(alist-delete
             "python-oauthlib"
             (package-native-inputs keystoneclient)))))))
+
+(define-public python-swiftclient
+  (package
+    (name "python-swiftclient")
+    (version "2.6.0")
+    (source
+      (origin
+        (method url-fetch)
+        (uri (pypi-uri "python-swiftclient" version))
+        (sha256
+          (base32
+           "1j33l4z9vqh0scfncl4fxg01zr1hgqxhhai6gvcih1gccqm4nd7p"))))
+  (build-system python-build-system)
+  (native-inputs
+   `(("python-pbr", python-pbr)
+     ("python-setuptools" ,python-setuptools)
+     ;; some packages are needed for the tests
+     ("python-coverage" ,python-coverage)
+     ("python-discover" ,python-discover)
+     ("python-hacking" ,python-hacking)
+     ("python-mock" ,python-mock)
+     ("python-oslosphinx" ,python-oslosphinx)
+     ("python-keystoneclient" ,python-keystoneclient)
+     ("python-sphinx" ,python-sphinx)
+     ("python-testrepository" ,python-testrepository)
+     ("python-testtools" ,python-testtools)))
+  (inputs
+   `(("python-requests" ,python-requests)
+     ("python-six" ,python-six)))
+  (home-page "http://www.openstack.org/")
+  (synopsis "OpenStack Object Storage API Client Library")
+  (description
+   "OpenStack Object Storage (code-named Swift) creates redundant, scalable
+object storage using clusters of standardized servers to store petabytes of
+accessible data.  It is not a file system or real-time data storage system, but
+rather a long-term storage system for a more permanent type of static data that
+can be retrieved, leveraged, and then updated if necessary.  Primary examples of
+data that best fit this type of storage model are virtual machine images, photo
+storage, email storage and backup archiving. Having no central \"brain\" or
+master point of control provides greater scalability, redundancy and permanence.")
+  (license asl2.0)))
+
+(define-public python2-swiftclient
+  (let ((swiftclient (package-with-python2 python-swiftclient)))
+    (package (inherit swiftclient)
+      (inputs
+       `(("python2-futures" ,python2-futures)
+         ,@(package-inputs swiftclient)))
+      (native-inputs
+       `(("python2-keystoneclient" ,python2-keystoneclient)
+         ,@(alist-delete
+            "python-keystoneclient"
+            (package-native-inputs swiftclient)))))))
-- 
2.6.2

[PATCH 07/10] gnu: Add python-rauth.

[Efraim Flashner]

* gnu/packages/python.scm (python-rauth, python2-rauth): New variables.
---
 gnu/packages/python.scm | 33 +++++++++++++++++++++++++++++++++
 1 file changed, 33 insertions(+)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 21aa8fa..5c71aac 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -6064,6 +6064,39 @@ automatically detect a wide range of file encodings.")
 (define-public python2-chardet
   (package-with-python2 python-chardet))
 
+(define-public python-rauth
+  (package
+    (name "python-rauth")
+    (version "0.7.2")
+      (source
+        (origin
+          (method url-fetch)
+          (uri (pypi-uri "rauth" version))
+          (sha256
+            (base32
+             "00pq7zw429hhza9c0qzxiqp77m653jv09z92nralnmzwdf6pzicf"))))
+    (build-system python-build-system)
+    (arguments
+     `(#:test-target "check"))
+    (native-inputs
+     `(("python-setuptools" ,python-setuptools)))
+    (inputs
+     `(("python-requests" ,python-requests)))
+    (home-page "https://github.com/litl/rauth")
+    (synopsis "Python library for OAuth 1.0/a, 2.0, and Ofly")
+    (description
+     "Rauth is a Python library for OAuth 1.0/a, 2.0, and Ofly.  It also
+provides service wrappers for convenient connection initialization and
+authenticated session objects providing things like keep-alive.")
+    (license license:expat)))
+
+(define-public python2-rauth
+  (let ((rauth (package-with-python2 python-rauth)))
+    (package (inherit rauth)
+      (native-inputs
+       `(("python2-unittest2", python2-unittest2)
+         ,@(package-native-inputs rauth))))))
+
 (define-public python2-futures
   (package
     (name "python2-futures")
-- 
2.6.2

[PATCH 08/10] gnu: Add python-pyasn1-modules.

[Efraim Flashner]

* gnu/packages/python.scm (python-pyasn1-modules)
(python2-pyasn1-modules): New variables.
---
 gnu/packages/python.scm | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 5c71aac..0323399 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -5634,6 +5634,30 @@ suitable for a wide range of protocols based on the ASN.1 specification.")
 (define-public python2-pyasn1
   (package-with-python2 python-pyasn1))
 
+(define-public python-pyasn1-modules
+  (package
+    (name "python-pyasn1-modules")
+    (version "0.0.8")
+    (source
+      (origin
+        (method url-fetch)
+        (uri (pypi-uri "pyasn1-modules" version))
+        (sha256
+          (base32
+           "0drqgw81xd3fxdlg89kgd79zzrabvfncvkbybi2wr6w2y4s1jmhh"))))
+  (build-system python-build-system)
+  (native-inputs
+   `(("python-pyasn1" ,python-pyasn1)
+     ("python-setuptools" ,python-setuptools)))
+  (home-page "http://sourceforge.net/projects/pyasn1/")
+  (synopsis "Collection of ASN.1-based protocols modules")
+  (description
+   "Pyasn1-modules is a collection of ASN.1-based protocols modules.")
+  (license bsd-3)))
+
+(define-public python2-pyasn1-modules
+  (package-with-python2 python-pyasn1-modules))
+
 (define-public python2-ipaddress
   (package
     (name "python2-ipaddress")
-- 
2.6.2

[PATCH 09/10] gnu: Add python2-functools32.

[Efraim Flashner]

* gnu/packages/python.scm (python2-functools32): New variable.
---
 gnu/packages/python.scm | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 0323399..ab0f56e 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -6121,6 +6121,30 @@ authenticated session objects providing things like keep-alive.")
        `(("python2-unittest2", python2-unittest2)
          ,@(package-native-inputs rauth))))))
 
+(define-public python2-functools32
+  (package
+    (name "python2-functools32")
+    (version "3.2.3-2")
+    (source
+      (origin
+        (method url-fetch)
+        (uri (pypi-uri "functools32" version))
+        (sha256
+          (base32
+           "0v8ya0b58x47wp216n1zamimv4iw57cxz3xxhzix52jkw3xks9gn"))))
+    (build-system python-build-system)
+    (arguments
+     `(#:python ,python-2
+       #:tests? #f)) ; no test target
+    (native-inputs
+     `(("python2-setuptools" ,python2-setuptools)))
+    (home-page "https://github.com/MiCHiLU/python-functools32")
+    (synopsis
+     "Backport of the functools module from Python 3.2.3")
+    (description
+     "Backport of the functools module from Python 3.2.3 for use on 2.7 and PyPy.")
+    (license license:expat)))
+
 (define-public python2-futures
   (package
     (name "python2-futures")
-- 
2.6.2

[PATCH 10/10] gnu: Add git-annex-remote-hubic.

[Efraim Flashner]

* gnu/packages/version-control.scm (git-annex-remote-hubic): New variable.
---
 gnu/packages/version-control.scm | 33 +++++++++++++++++++++++++++++++++
 1 file changed, 33 insertions(+)

diff --git a/gnu/packages/version-control.scm b/gnu/packages/version-control.scm
index b132663..e134d81 100644
--- a/gnu/packages/version-control.scm
+++ b/gnu/packages/version-control.scm
@@ -52,6 +52,7 @@
   #:use-module (gnu packages ncurses)
   #:use-module (gnu packages ssh)
   #:use-module (gnu packages web)
+  #:use-module (gnu packages openstack)
   #:use-module (gnu packages perl)
   #:use-module (gnu packages pkg-config)
   #:use-module (gnu packages python)
@@ -925,3 +926,35 @@ any project with more than one developer, is one of Aegis's major functions.")
 a history browser.  It can also stage hunks for commit, or colorize the
 output of the 'git' command.")
     (license gpl2+)))
+
+(define-public git-annex-remote-hubic
+  (package
+    (name "git-annex-remote-hubic")
+    (version "0.3.1")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append
+                    "https://github.com/Schnouki/" name "/archive/v"
+                    version ".tar.gz"))
+              (file-name (string-append name "-" version))
+              (sha256
+               (base32
+                "196g3jkaybjx11nbr51n0cjps3wjzb145ab76y717diqvvxp5v4r"))))
+    (build-system python-build-system)
+    (arguments
+     `(#:python ,python-2))
+    (native-inputs
+    `(("python2-setuptools" ,python2-setuptools)
+      ;; some extras for the tests
+      ("python2-futures" ,python2-futures)
+      ("python2-six" ,python2-six)))
+    (inputs
+     `(("python2-dateutil" ,python2-dateutil)
+       ("python2-rauth" ,python2-rauth)
+       ("python2-swiftclient" ,python2-swiftclient)))
+    (home-page "https://github.com/Schnouki/git-annex-remote-hubic/")
+    (synopsis "Use hubic as a git-annex remote")
+    (description
+     "Git annex remote hubic allows you to use your hubiC account as a \"special
+repository\".")
+    (license gpl3+)))
-- 
2.6.2

Re: [PATCH 07/10] gnu: Add python-rauth.

[Efraim Flashner]

[-- Attachment #1.1: Type: text/plain, Size: 1236 bytes --]

On Thu,  3 Dec 2015 16:43:28 +0200
Efraim Flashner <efraim@flashner.co.il> wrote:

> * gnu/packages/python.scm (python-rauth, python2-rauth): New variables.
> ---
>  gnu/packages/python.scm | 33 +++++++++++++++++++++++++++++++++
>  1 file changed, 33 insertions(+)
> 
> diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
> index 21aa8fa..5c71aac 100644
> --- a/gnu/packages/python.scm
> +++ b/gnu/packages/python.scm
> @@ -6064,6 +6064,39 @@ automatically detect a wide range of file encodings.")
>  (define-public python2-chardet
>    (package-with-python2 python-chardet))
>  
> +(define-public python-rauth
> +  (package
> +    (name "python-rauth")
> +    (version "0.7.2")
> +      (source
> +        (origin
> +          (method url-fetch)
> +          (uri (pypi-uri "rauth" version))
> +          (sha256
> +            (base32
> +             "00pq7zw429hhza9c0qzxiqp77m653jv09z92nralnmzwdf6pzicf"))))
> [...]

messed up this part of the indentation, new version attached

-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: 0001-gnu-Add-python-rauth.patch --]
[-- Type: text/x-patch, Size: 1952 bytes --]

From 75fcd98b28693975f17d8d6d03f19481acbbd210 Mon Sep 17 00:00:00 2001
From: Efraim Flashner <efraim@flashner.co.il>
Date: Sun, 22 Nov 2015 22:43:51 +0200
Subject: [PATCH 1/4] gnu: Add python-rauth.

* gnu/packages/python.scm (python-rauth, python2-rauth): New variables.
---
 gnu/packages/python.scm | 33 +++++++++++++++++++++++++++++++++
 1 file changed, 33 insertions(+)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 21aa8fa..cececfb 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -6064,6 +6064,39 @@ automatically detect a wide range of file encodings.")
 (define-public python2-chardet
   (package-with-python2 python-chardet))
 
+(define-public python-rauth
+  (package
+    (name "python-rauth")
+    (version "0.7.2")
+    (source
+      (origin
+        (method url-fetch)
+        (uri (pypi-uri "rauth" version))
+        (sha256
+          (base32
+           "00pq7zw429hhza9c0qzxiqp77m653jv09z92nralnmzwdf6pzicf"))))
+    (build-system python-build-system)
+    (arguments
+     `(#:test-target "check"))
+    (native-inputs
+     `(("python-setuptools" ,python-setuptools)))
+    (inputs
+     `(("python-requests" ,python-requests)))
+    (home-page "https://github.com/litl/rauth")
+    (synopsis "Python library for OAuth 1.0/a, 2.0, and Ofly")
+    (description
+     "Rauth is a Python library for OAuth 1.0/a, 2.0, and Ofly.  It also
+provides service wrappers for convenient connection initialization and
+authenticated session objects providing things like keep-alive.")
+    (license license:expat)))
+
+(define-public python2-rauth
+  (let ((rauth (package-with-python2 python-rauth)))
+    (package (inherit rauth)
+      (native-inputs
+       `(("python2-unittest2", python2-unittest2)
+         ,@(package-native-inputs rauth))))))
+
 (define-public python2-futures
   (package
     (name "python2-futures")
-- 
2.6.2


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH 01/10] gnu: Add python-pytest-cov.

[Ricardo Wurmus]

Efraim Flashner <efraim@flashner.co.il> writes:

> +  (build-system python-build-system)
> +  (inputs
> +   `(("python-coverage" ,python-coverage)
> +     ("python-pytest" ,python-pytest)))

If these Python modules need to be available at runtime they really
should be propagated-inputs.  If they are needed at test time only, they
should be native-inputs.  For Python packages there is rarely a good
reason to use inputs unless they are library bindings.

I think many of our Python packages actually need to declare many more
inputs as propagated inputs.

> +  (native-inputs
> +   `(("python-setuptools" ,python-setuptools)))

~~ Ricardo

Re: [PATCH 07/10] gnu: Add python-rauth.

[Ricardo Wurmus]

Efraim Flashner <efraim@flashner.co.il> writes:

> * gnu/packages/python.scm (python-rauth, python2-rauth): New variables.
> ---
>  gnu/packages/python.scm | 33 +++++++++++++++++++++++++++++++++
>  1 file changed, 33 insertions(+)
>
> diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
> index 21aa8fa..5c71aac 100644
> --- a/gnu/packages/python.scm
> +++ b/gnu/packages/python.scm
> @@ -6064,6 +6064,39 @@ automatically detect a wide range of file encodings.")
>  (define-public python2-chardet
>    (package-with-python2 python-chardet))
>  
> +(define-public python-rauth
> +  (package
> +    (name "python-rauth")
> +    (version "0.7.2")
> +      (source
> +        (origin
> +          (method url-fetch)
> +          (uri (pypi-uri "rauth" version))
> +          (sha256
> +            (base32
> +             "00pq7zw429hhza9c0qzxiqp77m653jv09z92nralnmzwdf6pzicf"))))
> +    (build-system python-build-system)
> +    (arguments
> +     `(#:test-target "check"))
> +    (native-inputs
> +     `(("python-setuptools" ,python-setuptools)))
> +    (inputs
> +     `(("python-requests" ,python-requests)))

I think this should be a propagated input.

> +    (home-page "https://github.com/litl/rauth")
> +    (synopsis "Python library for OAuth 1.0/a, 2.0, and Ofly")
> +    (description
> +     "Rauth is a Python library for OAuth 1.0/a, 2.0, and Ofly.  It also
> +provides service wrappers for convenient connection initialization and
> +authenticated session objects providing things like keep-alive.")
> +    (license license:expat)))

Otherwise OK.

> +(define-public python2-rauth
> +  (let ((rauth (package-with-python2 python-rauth)))
> +    (package (inherit rauth)
> +      (native-inputs
> +       `(("python2-unittest2", python2-unittest2)
> +         ,@(package-native-inputs rauth))))))
> +

Lookin’ good!

~~ Ricardo

Re: [PATCH 10/10] gnu: Add git-annex-remote-hubic.

[Ricardo Wurmus]

Efraim Flashner <efraim@flashner.co.il> writes:

> +(define-public git-annex-remote-hubic
> +  (package
> +    (name "git-annex-remote-hubic")
> +    (version "0.3.1")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append
> +                    "https://github.com/Schnouki/" name "/archive/v"
> +                    version ".tar.gz"))
> +              (file-name (string-append name "-" version))

You should also append “.tar.gz”.

> +              (sha256
> +               (base32
> +                "196g3jkaybjx11nbr51n0cjps3wjzb145ab76y717diqvvxp5v4r"))))
> +    (build-system python-build-system)
> +    (arguments
> +     `(#:python ,python-2))
> +    (native-inputs
> +    `(("python2-setuptools" ,python2-setuptools)
> +      ;; some extras for the tests
> +      ("python2-futures" ,python2-futures)
> +      ("python2-six" ,python2-six)))
> +    (inputs
> +     `(("python2-dateutil" ,python2-dateutil)
> +       ("python2-rauth" ,python2-rauth)
> +       ("python2-swiftclient" ,python2-swiftclient)))

These are probably propagated-inputs.

> +    (home-page "https://github.com/Schnouki/git-annex-remote-hubic/")
> +    (synopsis "Use hubic as a git-annex remote")

I don’t know what “hubic” is but in the description you spell it as
“hubiC”.  Which spelling is correct?

> +    (description
> +     "Git annex remote hubic allows you to use your hubiC account as a \"special
> +repository\".")

I found it difficult to read this description because the first four
words are actually the name of the package.  In this case I’d suggest
replacing “Git annex remote hubic” with the generic “This package”; but
then you should also add “with git-annex” after “special repository”.

~~ Ricardo

Re: [PATCH 09/10] gnu: Add python2-functools32.

[Ricardo Wurmus]

Efraim Flashner <efraim@flashner.co.il> writes:

> +(define-public python2-functools32
> +  (package
> +    (name "python2-functools32")
> +    (version "3.2.3-2")
> +    (source
> +      (origin
> +        (method url-fetch)
> +        (uri (pypi-uri "functools32" version))
> +        (sha256
> +          (base32
> +           "0v8ya0b58x47wp216n1zamimv4iw57cxz3xxhzix52jkw3xks9gn"))))
> +    (build-system python-build-system)
> +    (arguments
> +     `(#:python ,python-2
> +       #:tests? #f)) ; no test target
> +    (native-inputs
> +     `(("python2-setuptools" ,python2-setuptools)))
> +    (home-page "https://github.com/MiCHiLU/python-functools32")
> +    (synopsis
> +     "Backport of the functools module from Python 3.2.3")
> +    (description
> +     "Backport of the functools module from Python 3.2.3 for use on 2.7 and PyPy.")

We need the description to be a full sentence.  “This package backports
the @code{functools} module ...”.  Something about “for use on” sounds
odd to me; maybe “for use with older versions of Python and with PyPy”?

Re: [PATCH 01/10] gnu: Add python-pytest-cov.

[Efraim Flashner]

[-- Attachment #1.1: Type: text/plain, Size: 1010 bytes --]

On Thu, 3 Dec 2015 23:25:26 +0100
Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> wrote:

> Efraim Flashner <efraim@flashner.co.il> writes:
> 
> > +  (build-system python-build-system)
> > +  (inputs
> > +   `(("python-coverage" ,python-coverage)
> > +     ("python-pytest" ,python-pytest)))  
> 
> If these Python modules need to be available at runtime they really
> should be propagated-inputs.  If they are needed at test time only, they
> should be native-inputs.  For Python packages there is rarely a good
> reason to use inputs unless they are library bindings.
> 
> I think many of our Python packages actually need to declare many more
> inputs as propagated inputs.
> 
> > +  (native-inputs
> > +   `(("python-setuptools" ,python-setuptools)))  
> 
> ~~ Ricardo



-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: 0001-gnu-Add-python-pytest-cov.patch --]
[-- Type: text/x-patch, Size: 1753 bytes --]

From 645f979af579abb97a69b1a8814034f4c2d9b499 Mon Sep 17 00:00:00 2001
From: Efraim Flashner <efraim@flashner.co.il>
Date: Mon, 23 Nov 2015 17:12:52 +0200
Subject: [PATCH 01/10] gnu: Add python-pytest-cov.

* gnu/packages/python.scm (python-pytest-cov, python2-pytest-cov): New
variables.
---
 gnu/packages/python.scm | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index d01c1d3..280f0c9 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -1634,6 +1634,34 @@ and many external plugins.")
 (define-public python2-pytest
   (package-with-python2 python-pytest))
 
+(define-public python-pytest-cov
+  (package
+    (name "python-pytest-cov")
+    (version "2.2.0")
+    (source
+      (origin
+        (method url-fetch)
+        (uri (pypi-uri "pytest-cov" version))
+        (sha256
+          (base32
+           "1lf9jsmhqk5nc4w3kzwglmdzjvmi7ajvrsnwv826j3bn0wzx8c92"))))
+  (build-system python-build-system)
+  (propagated-inputs
+   `(("python-coverage" ,python-coverage)
+     ("python-pytest" ,python-pytest)))
+  (native-inputs
+   `(("python-setuptools" ,python-setuptools)))
+  (home-page "https://github.com/pytest-dev/pytest-cov")
+  (synopsis "Pytest plugin for measuring coverage")
+  (description
+   "Pytest-cov produces coverage reports.  It supports centralised testing and
+distributed testing in both load and each modes.  It also supports coverage
+of subprocesses.")
+  (license license:expat)))
+
+(define-public python2-pytest-cov
+  (package-with-python2 python-pytest-cov))
+
 (define-public python-pytest-runner
   (package
     (name "python-pytest-runner")
-- 
2.6.2


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH 02/10] gnu: Add python-wheel.

[Efraim Flashner]

[-- Attachment #1.1: Type: text/plain, Size: 1934 bytes --]

On Thu,  3 Dec 2015 16:43:23 +0200
Efraim Flashner <efraim@flashner.co.il> wrote:

> * gnu/packages/python.scm (python-wheel, python2-wheel): New variable.
> ---
>  gnu/packages/python.scm | 28 ++++++++++++++++++++++++++++
>  1 file changed, 28 insertions(+)
> 
> diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
> index d8fca79..b110921 100644
> --- a/gnu/packages/python.scm
> +++ b/gnu/packages/python.scm
> @@ -2161,6 +2161,34 @@ with sensible defaults out of the box.")
>  (define-public python2-click
>    (package-with-python2 python-click))
>  
> +(define-public python-wheel
> +  (package
> +    (name "python-wheel")
> +    (version "0.26.0")
> +      (source
> +        (origin
> +          (method url-fetch)
> +          (uri (pypi-uri "wheel" version))
> +          (sha256
> +            (base32
> +             "032k1ajijbqnv0z0k88bhf75mdimi18fcmm28mss90610lw3bbga"))))
> +  (build-system python-build-system)
> +  (native-inputs
> +   `(("python-setuptools" ,python-setuptools)))
> +  (inputs
> +   `(("python-jsonschema" ,python-jsonschema)
> +     ("python-pytest-cov" ,python-pytest-cov)))
> +  (home-page "https://bitbucket.org/pypa/wheel/")
> +  (synopsis "Built-package format for Python")
> +  (description
> +   "A wheel is a ZIP-format archive with a specially formatted filename and the
> +.whl extension.  It is designed to contain all the files for a PEP 376
> +compatible install in a way that is very close to the on-disk format.")
> +  (license license:expat)))
> +
> +(define-public python2-wheel
> +  (package-with-python2 python-wheel))
> +
>  (define-public python-requests
>    (package
>      (name "python-requests")



-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: 0002-gnu-Add-python-wheel.patch --]
[-- Type: text/x-patch, Size: 1750 bytes --]

From 3cf9101ca83470ef4f19dd270b5afd689be02569 Mon Sep 17 00:00:00 2001
From: Efraim Flashner <efraim@flashner.co.il>
Date: Mon, 23 Nov 2015 18:44:57 +0200
Subject: [PATCH 02/10] gnu: Add python-wheel.

* gnu/packages/python.scm (python-wheel, python2-wheel): New variables.
---
 gnu/packages/python.scm | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 280f0c9..442270c 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -2165,6 +2165,33 @@ with sensible defaults out of the box.")
 (define-public python2-click
   (package-with-python2 python-click))
 
+(define-public python-wheel
+  (package
+    (name "python-wheel")
+    (version "0.26.0")
+      (source
+        (origin
+          (method url-fetch)
+          (uri (pypi-uri "wheel" version))
+          (sha256
+            (base32
+             "032k1ajijbqnv0z0k88bhf75mdimi18fcmm28mss90610lw3bbga"))))
+  (build-system python-build-system)
+  (native-inputs
+   `(("python-setuptools" ,python-setuptools)
+     ("python-jsonschema" ,python-jsonschema)
+     ("python-pytest-cov" ,python-pytest-cov)))
+  (home-page "https://bitbucket.org/pypa/wheel/")
+  (synopsis "Built-package format for Python")
+  (description
+   "A wheel is a ZIP-format archive with a specially formatted filename and the
+.whl extension.  It is designed to contain all the files for a PEP 376
+compatible install in a way that is very close to the on-disk format.")
+  (license license:expat)))
+
+(define-public python2-wheel
+  (package-with-python2 python-wheel))
+
 (define-public python-requests
   (package
     (name "python-requests")
-- 
2.6.2


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH 03/10] gnu: python-requests: Update to 2.8.1.

[Efraim Flashner]

[-- Attachment #1.1: Type: text/plain, Size: 2151 bytes --]

On Thu,  3 Dec 2015 16:43:24 +0200
Efraim Flashner <efraim@flashner.co.il> wrote:

> * gnu/packages/python.scm (python-requests): Update to 2.8.1.
> [native-inputs]: Move python-setuptools here.
> [inputs]: Add python-py, python-pytest, python-pytest-cov, python-wheel.
> [arguments]: Enable tests.
> ---
>  gnu/packages/python.scm | 19 ++++++++++---------
>  1 file changed, 10 insertions(+), 9 deletions(-)
> 
> diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
> index b110921..8084831 100644
> --- a/gnu/packages/python.scm
> +++ b/gnu/packages/python.scm
> @@ -2192,21 +2192,22 @@ compatible install in a way that is very close to the on-disk format.")
>  (define-public python-requests
>    (package
>      (name "python-requests")
> -    (version "2.8.0")
> +    (version "2.8.1")
>      (source (origin
>               (method url-fetch)
> -             (uri
> -              (string-append
> -               "https://pypi.python.org/packages/source/r/requests/requests-"
> -               version ".tar.gz"))
> +             (uri (pypi-uri "requests" version))
>               (sha256
>                (base32
> -               "0yrvj8hfnabrdxds59w6d6887sn5j0jlgpmcq04lk4k0kdc07w5j"))))
> +               "0ny2nr1sqr4hcn3903ghmh7w2yni8shlfv240a8c9p6wyidqvzl4"))))
>      (build-system python-build-system)
> +    (native-inputs
> +     `(("python-setuptools" ,python-setuptools)))
>      (inputs
> -     `(("python-setuptools" ,python-setuptools)
> -       ("python-certifi" ,python-certifi)))
> -    (arguments `(#:tests? #f)) ; no tests
> +     `(("python-certifi" ,python-certifi)
> +       ("python-py" ,python-py)
> +       ("python-pytest" ,python-pytest)
> +       ("python-pytest-cov" ,python-pytest-cov)
> +       ("python-wheel" ,python-wheel)))
>      (home-page "http://python-requests.org/")
>      (synopsis "Python HTTP library")
>      (description



-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: 0003-gnu-python-requests-Update-to-2.8.1.patch --]
[-- Type: text/x-patch, Size: 2026 bytes --]

From be148f5b00d667ceeade4c71d67534116152750b Mon Sep 17 00:00:00 2001
From: Efraim Flashner <efraim@flashner.co.il>
Date: Mon, 23 Nov 2015 17:58:07 +0200
Subject: [PATCH 03/10] gnu: python-requests: Update to 2.8.1.

* gnu/packages/python.scm (python-requests): Update to 2.8.1.
[native-inputs]: Move python-setuptools here.
[inputs]: Remove python-certifi.
[propagated-inputs]: Add python-py, python-pytest, python-pytest-cov,
python-wheel.
[arguments]: Enable tests.
---
 gnu/packages/python.scm | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 442270c..0f3e3e7 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -2195,21 +2195,21 @@ compatible install in a way that is very close to the on-disk format.")
 (define-public python-requests
   (package
     (name "python-requests")
-    (version "2.8.0")
+    (version "2.8.1")
     (source (origin
              (method url-fetch)
-             (uri
-              (string-append
-               "https://pypi.python.org/packages/source/r/requests/requests-"
-               version ".tar.gz"))
+             (uri (pypi-uri "requests" version))
              (sha256
               (base32
-               "0yrvj8hfnabrdxds59w6d6887sn5j0jlgpmcq04lk4k0kdc07w5j"))))
+               "0ny2nr1sqr4hcn3903ghmh7w2yni8shlfv240a8c9p6wyidqvzl4"))))
     (build-system python-build-system)
-    (inputs
-     `(("python-setuptools" ,python-setuptools)
-       ("python-certifi" ,python-certifi)))
-    (arguments `(#:tests? #f)) ; no tests
+    (native-inputs
+     `(("python-setuptools" ,python-setuptools)))
+    (propagated-inputs
+     `(("python-py" ,python-py)
+       ("python-pytest" ,python-pytest)
+       ("python-pytest-cov" ,python-pytest-cov)
+       ("python-wheel" ,python-wheel)))
     (home-page "http://python-requests.org/")
     (synopsis "Python HTTP library")
     (description
-- 
2.6.2


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH 04/10] gnu: Add python-keystoneclient.

[Efraim Flashner]

[-- Attachment #1.1: Type: text/plain, Size: 4377 bytes --]

On Thu,  3 Dec 2015 16:43:25 +0200
Efraim Flashner <efraim@flashner.co.il> wrote:

> * gnu/packages/openstack.scm (python-keystoneclient)
> (python2-keystoneclient): New variables.
> ---
>  gnu/packages/openstack.scm | 73 +++++++++++++++++++++++++++++++++++++++++++++-
>  1 file changed, 72 insertions(+), 1 deletion(-)
> 
> diff --git a/gnu/packages/openstack.scm b/gnu/packages/openstack.scm
> index 2578292..faf6ebf 100644
> --- a/gnu/packages/openstack.scm
> +++ b/gnu/packages/openstack.scm
> @@ -19,12 +19,14 @@
>  
>  (define-module (gnu packages openstack)
>    #:use-module (gnu packages python)
> +  #:use-module (gnu packages tls)
>    #:use-module (gnu packages version-control)
>    #:use-module (guix build-system python)
>    #:use-module (guix download)
>    #:use-module ((guix licenses)
>                  #:select (asl2.0))
> -  #:use-module (guix packages))
> +  #:use-module (guix packages)
> +  #:use-module (srfi srfi-1))
>  
>  (define-public python-bandit
>    (package
> @@ -679,3 +681,72 @@ handling.")
>  
>  (define-public python2-oslo.utils
>    (package-with-python2 python-oslo.utils))
> +
> +(define-public python-keystoneclient
> +  (package
> +    (name "python-keystoneclient")
> +    (version "1.8.1")
> +      (source
> +        (origin
> +          (method url-fetch)
> +          (uri (pypi-uri "python-keystoneclient" version))
> +          (sha256
> +            (base32
> +             "1w4csvkah67rfpxylxnvs2s3594i0f9isy8pf4gnsqs5zirvjaa4"))))
> +  (build-system python-build-system)
> +  (native-inputs
> +   `(("python-setuptools" ,python-setuptools)
> +     ;; and some packages for the tests
> +     ("openssl" ,openssl)
> +     ("python-coverage" ,python-coverage)
> +     ("python-discover" ,python-discover)
> +     ("python-fixtures" ,python-fixtures)
> +     ("python-hacking" ,python-hacking)
> +     ("python-keyring" ,python-keyring)
> +     ("python-lxml" ,python-lxml)
> +     ("python-mock" ,python-mock)
> +     ("python-mox3" ,python-mox3)
> +     ("python-oauthlib" ,python-oauthlib)
> +     ("python-oslosphinx" ,python-oslosphinx)
> +     ("python-oslotest" ,python-oslotest)
> +     ("python-pycrypto" ,python-pycrypto)
> +     ("python-requests-mock" ,python-requests-mock)
> +     ("python-sphinx" ,python-sphinx)
> +     ("python-temptest-lib" ,python-tempest-lib)
> +     ("python-testrepository" ,python-testrepository)
> +     ("python-testresources" ,python-testresources)
> +     ("python-testtools" ,python-testtools)
> +     ("python-webob" ,python-webob)))
> +  (inputs
> +   `(("python-babel" ,python-babel)
> +     ("python-debtcollector" ,python-debtcollector)
> +     ("python-iso8601" ,python-iso8601)
> +     ("python-netaddr" ,python-netaddr)
> +     ("python-oslo.config" ,python-oslo.config)
> +     ("python-oslo.i18n" ,python-oslo.i18n)
> +     ("python-oslo.serialization" ,python-oslo.serialization)
> +     ("python-oslo.utils" ,python-oslo.utils)
> +     ("python-pbr" ,python-pbr)
> +     ("python-prettytable" ,python-prettytable)
> +     ("python-requests" ,python-requests)
> +     ("python-six" ,python-six)
> +     ("python-stevedore" ,python-stevedore)))
> +  (home-page "http://www.openstack.org/")
> +  (synopsis "Client Library for OpenStack Identity")
> +  (description
> +   "Python-keystoneclient is the identity service used by OpenStack for
> +authentication (authN) and high-level authorization (authZ).  It currently
> +supports token-based authN with user/service authZ, and is scalable to support
> +OAuth, SAML, and OpenID in future versions.  Out of the box, Keystone uses
> +SQLite for its identity store database, with the option to connect to external
> +LDAP.")
> +  (license asl2.0)))
> +
> +(define-public python2-keystoneclient
> +  (let ((keystoneclient (package-with-python2 python-keystoneclient)))
> +    (package (inherit keystoneclient)
> +      (native-inputs
> +       `(("python2-oauthlib" ,python2-oauthlib)
> +         ,@(alist-delete
> +            "python-oauthlib"
> +            (package-native-inputs keystoneclient)))))))



-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: 0004-gnu-Add-python-keystoneclient.patch --]
[-- Type: text/x-patch, Size: 4103 bytes --]

From 6837ac485125476040469289072e6f59a7139939 Mon Sep 17 00:00:00 2001
From: Efraim Flashner <efraim@flashner.co.il>
Date: Mon, 23 Nov 2015 20:29:12 +0200
Subject: [PATCH 04/10] gnu: Add python-keystoneclient.

* gnu/packages/openstack.scm (python-keystoneclient)
(python2-keystoneclient): New variables.
---
 gnu/packages/openstack.scm | 73 +++++++++++++++++++++++++++++++++++++++++++++-
 1 file changed, 72 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/openstack.scm b/gnu/packages/openstack.scm
index 2578292..43f957b 100644
--- a/gnu/packages/openstack.scm
+++ b/gnu/packages/openstack.scm
@@ -19,12 +19,14 @@
 
 (define-module (gnu packages openstack)
   #:use-module (gnu packages python)
+  #:use-module (gnu packages tls)
   #:use-module (gnu packages version-control)
   #:use-module (guix build-system python)
   #:use-module (guix download)
   #:use-module ((guix licenses)
                 #:select (asl2.0))
-  #:use-module (guix packages))
+  #:use-module (guix packages)
+  #:use-module (srfi srfi-1))
 
 (define-public python-bandit
   (package
@@ -679,3 +681,72 @@ handling.")
 
 (define-public python2-oslo.utils
   (package-with-python2 python-oslo.utils))
+
+(define-public python-keystoneclient
+  (package
+    (name "python-keystoneclient")
+    (version "1.8.1")
+    (source
+      (origin
+        (method url-fetch)
+        (uri (pypi-uri "python-keystoneclient" version))
+        (sha256
+          (base32
+           "1w4csvkah67rfpxylxnvs2s3594i0f9isy8pf4gnsqs5zirvjaa4"))))
+  (build-system python-build-system)
+  (native-inputs
+   `(("python-setuptools" ,python-setuptools)
+     ;; and some packages for the tests
+     ("openssl" ,openssl)
+     ("python-coverage" ,python-coverage)
+     ("python-discover" ,python-discover)
+     ("python-fixtures" ,python-fixtures)
+     ("python-hacking" ,python-hacking)
+     ("python-keyring" ,python-keyring)
+     ("python-lxml" ,python-lxml)
+     ("python-mock" ,python-mock)
+     ("python-mox3" ,python-mox3)
+     ("python-oauthlib" ,python-oauthlib)
+     ("python-oslosphinx" ,python-oslosphinx)
+     ("python-oslotest" ,python-oslotest)
+     ("python-pycrypto" ,python-pycrypto)
+     ("python-requests-mock" ,python-requests-mock)
+     ("python-sphinx" ,python-sphinx)
+     ("python-temptest-lib" ,python-tempest-lib)
+     ("python-testrepository" ,python-testrepository)
+     ("python-testresources" ,python-testresources)
+     ("python-testtools" ,python-testtools)
+     ("python-webob" ,python-webob)))
+  (propagated-inputs
+   `(("python-babel" ,python-babel)
+     ("python-debtcollector" ,python-debtcollector)
+     ("python-iso8601" ,python-iso8601)
+     ("python-netaddr" ,python-netaddr)
+     ("python-oslo.config" ,python-oslo.config)
+     ("python-oslo.i18n" ,python-oslo.i18n)
+     ("python-oslo.serialization" ,python-oslo.serialization)
+     ("python-oslo.utils" ,python-oslo.utils)
+     ("python-pbr" ,python-pbr)
+     ("python-prettytable" ,python-prettytable)
+     ("python-requests" ,python-requests)
+     ("python-six" ,python-six)
+     ("python-stevedore" ,python-stevedore)))
+  (home-page "http://www.openstack.org/")
+  (synopsis "Client Library for OpenStack Identity")
+  (description
+   "Python-keystoneclient is the identity service used by OpenStack for
+authentication (authN) and high-level authorization (authZ).  It currently
+supports token-based authN with user/service authZ, and is scalable to support
+OAuth, SAML, and OpenID in future versions.  Out of the box, Keystone uses
+SQLite for its identity store database, with the option to connect to external
+LDAP.")
+  (license asl2.0)))
+
+(define-public python2-keystoneclient
+  (let ((keystoneclient (package-with-python2 python-keystoneclient)))
+    (package (inherit keystoneclient)
+      (native-inputs
+       `(("python2-oauthlib" ,python2-oauthlib)
+         ,@(alist-delete
+            "python-oauthlib"
+            (package-native-inputs keystoneclient)))))))
-- 
2.6.2


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH 05/10] gnu: Add python2-futures.

[Efraim Flashner]

[-- Attachment #1.1: Type: text/plain, Size: 1572 bytes --]

On Thu,  3 Dec 2015 16:43:26 +0200
Efraim Flashner <efraim@flashner.co.il> wrote:

> * gnu/packages/python.scm (python2-futures): New variable.
> ---
>  gnu/packages/python.scm | 23 +++++++++++++++++++++++
>  1 file changed, 23 insertions(+)
> 
> diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
> index 8084831..21aa8fa 100644
> --- a/gnu/packages/python.scm
> +++ b/gnu/packages/python.scm
> @@ -6063,3 +6063,26 @@ automatically detect a wide range of file encodings.")
>  
>  (define-public python2-chardet
>    (package-with-python2 python-chardet))
> +
> +(define-public python2-futures
> +  (package
> +    (name "python2-futures")
> +    (version "3.0.3")
> +      (source
> +        (origin
> +        (method url-fetch)
> +          (uri (pypi-uri "futures" version))
> +        (sha256
> +          (base32
> +           "1vcb34dqhzkhbq1957vdjszhhm5y3j9ba88dgwhqx2zynhmk9qig"))))
> +  (build-system python-build-system)
> +  (arguments
> +   `(#:python ,python-2))
> +  (native-inputs
> +   `(("python2-setuptools" ,python2-setuptools)))
> +  (home-page "https://github.com/agronholm/pythonfutures")
> +  (synopsis
> +   "Backport of the concurrent.futures package from Python 3.2")
> +  (description
> +   "Backport of the concurrent.futures package from Python 3.2")
> +  (license bsd-3)))



-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: 0005-gnu-Add-python2-futures.patch --]
[-- Type: text/x-patch, Size: 1411 bytes --]

From df0147499612f48681b3503270abafc3f5082781 Mon Sep 17 00:00:00 2001
From: Efraim Flashner <efraim@flashner.co.il>
Date: Tue, 24 Nov 2015 22:33:31 +0200
Subject: [PATCH 05/10] gnu: Add python2-futures.

* gnu/packages/python.scm (python2-futures): New variable.
---
 gnu/packages/python.scm | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 0f3e3e7..a6c665c 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -6620,3 +6620,26 @@ of the SSL peer.")
     (arguments `(#:python ,python-2))
     (propagated-inputs
      `(("python2-pyopenssl" ,python2-pyopenssl)))))
+
+(define-public python2-futures
+  (package
+    (name "python2-futures")
+    (version "3.0.3")
+    (source
+      (origin
+      (method url-fetch)
+        (uri (pypi-uri "futures" version))
+      (sha256
+        (base32
+         "1vcb34dqhzkhbq1957vdjszhhm5y3j9ba88dgwhqx2zynhmk9qig"))))
+  (build-system python-build-system)
+  (arguments
+   `(#:python ,python-2))
+  (native-inputs
+   `(("python2-setuptools" ,python2-setuptools)))
+  (home-page "https://github.com/agronholm/pythonfutures")
+  (synopsis
+   "Backport of the concurrent.futures package from Python 3.2")
+  (description
+   "Backport of the concurrent.futures package from Python 3.2")
+  (license bsd-3)))
-- 
2.6.2


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH 06/10] gnu: Add python-swiftclient.

[Efraim Flashner]

[-- Attachment #1.1: Type: text/plain, Size: 3247 bytes --]

On Thu,  3 Dec 2015 16:43:27 +0200
Efraim Flashner <efraim@flashner.co.il> wrote:

> * gnu/packages/openstack.scm (python-swiftclient, python2-swiftclient):
> New variables.
> ---
>  gnu/packages/openstack.scm | 53 ++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 53 insertions(+)
> 
> diff --git a/gnu/packages/openstack.scm b/gnu/packages/openstack.scm
> index faf6ebf..186c56d 100644
> --- a/gnu/packages/openstack.scm
> +++ b/gnu/packages/openstack.scm
> @@ -750,3 +750,56 @@ LDAP.")
>           ,@(alist-delete
>              "python-oauthlib"
>              (package-native-inputs keystoneclient)))))))
> +
> +(define-public python-swiftclient
> +  (package
> +    (name "python-swiftclient")
> +    (version "2.6.0")
> +    (source
> +      (origin
> +        (method url-fetch)
> +        (uri (pypi-uri "python-swiftclient" version))
> +        (sha256
> +          (base32
> +           "1j33l4z9vqh0scfncl4fxg01zr1hgqxhhai6gvcih1gccqm4nd7p"))))
> +  (build-system python-build-system)
> +  (native-inputs
> +   `(("python-pbr", python-pbr)
> +     ("python-setuptools" ,python-setuptools)
> +     ;; some packages are needed for the tests
> +     ("python-coverage" ,python-coverage)
> +     ("python-discover" ,python-discover)
> +     ("python-hacking" ,python-hacking)
> +     ("python-mock" ,python-mock)
> +     ("python-oslosphinx" ,python-oslosphinx)
> +     ("python-keystoneclient" ,python-keystoneclient)
> +     ("python-sphinx" ,python-sphinx)
> +     ("python-testrepository" ,python-testrepository)
> +     ("python-testtools" ,python-testtools)))
> +  (inputs
> +   `(("python-requests" ,python-requests)
> +     ("python-six" ,python-six)))
> +  (home-page "http://www.openstack.org/")
> +  (synopsis "OpenStack Object Storage API Client Library")
> +  (description
> +   "OpenStack Object Storage (code-named Swift) creates redundant, scalable
> +object storage using clusters of standardized servers to store petabytes of
> +accessible data.  It is not a file system or real-time data storage system, but
> +rather a long-term storage system for a more permanent type of static data that
> +can be retrieved, leveraged, and then updated if necessary.  Primary examples of
> +data that best fit this type of storage model are virtual machine images, photo
> +storage, email storage and backup archiving. Having no central \"brain\" or
> +master point of control provides greater scalability, redundancy and permanence.")
> +  (license asl2.0)))
> +
> +(define-public python2-swiftclient
> +  (let ((swiftclient (package-with-python2 python-swiftclient)))
> +    (package (inherit swiftclient)
> +      (inputs
> +       `(("python2-futures" ,python2-futures)
> +         ,@(package-inputs swiftclient)))
> +      (native-inputs
> +       `(("python2-keystoneclient" ,python2-keystoneclient)
> +         ,@(alist-delete
> +            "python-keystoneclient"
> +            (package-native-inputs swiftclient)))))))



-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: 0006-gnu-Add-python-swiftclient.patch --]
[-- Type: text/x-patch, Size: 3059 bytes --]

From 9207e8e3ae7cc78e6377cd811ce30454fce42081 Mon Sep 17 00:00:00 2001
From: Efraim Flashner <efraim@flashner.co.il>
Date: Mon, 23 Nov 2015 20:27:37 +0200
Subject: [PATCH 06/10] gnu: Add python-swiftclient.

* gnu/packages/openstack.scm (python-swiftclient, python2-swiftclient):
New variables.
---
 gnu/packages/openstack.scm | 53 ++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 53 insertions(+)

diff --git a/gnu/packages/openstack.scm b/gnu/packages/openstack.scm
index 43f957b..d0f65f0 100644
--- a/gnu/packages/openstack.scm
+++ b/gnu/packages/openstack.scm
@@ -750,3 +750,56 @@ LDAP.")
          ,@(alist-delete
             "python-oauthlib"
             (package-native-inputs keystoneclient)))))))
+
+(define-public python-swiftclient
+  (package
+    (name "python-swiftclient")
+    (version "2.6.0")
+    (source
+      (origin
+        (method url-fetch)
+        (uri (pypi-uri "python-swiftclient" version))
+        (sha256
+          (base32
+           "1j33l4z9vqh0scfncl4fxg01zr1hgqxhhai6gvcih1gccqm4nd7p"))))
+  (build-system python-build-system)
+  (native-inputs
+   `(("python-pbr", python-pbr)
+     ("python-setuptools" ,python-setuptools)
+     ;; some packages are needed for the tests
+     ("python-coverage" ,python-coverage)
+     ("python-discover" ,python-discover)
+     ("python-hacking" ,python-hacking)
+     ("python-mock" ,python-mock)
+     ("python-oslosphinx" ,python-oslosphinx)
+     ("python-keystoneclient" ,python-keystoneclient)
+     ("python-sphinx" ,python-sphinx)
+     ("python-testrepository" ,python-testrepository)
+     ("python-testtools" ,python-testtools)))
+  (propagated-inputs
+   `(("python-requests" ,python-requests)
+     ("python-six" ,python-six)))
+  (home-page "http://www.openstack.org/")
+  (synopsis "OpenStack Object Storage API Client Library")
+  (description
+   "OpenStack Object Storage (code-named Swift) creates redundant, scalable
+object storage using clusters of standardized servers to store petabytes of
+accessible data.  It is not a file system or real-time data storage system, but
+rather a long-term storage system for a more permanent type of static data that
+can be retrieved, leveraged, and then updated if necessary.  Primary examples of
+data that best fit this type of storage model are virtual machine images, photo
+storage, email storage and backup archiving. Having no central \"brain\" or
+master point of control provides greater scalability, redundancy and permanence.")
+  (license asl2.0)))
+
+(define-public python2-swiftclient
+  (let ((swiftclient (package-with-python2 python-swiftclient)))
+    (package (inherit swiftclient)
+      (propagated-inputs
+       `(("python2-futures" ,python2-futures)
+         ,@(package-inputs swiftclient)))
+      (native-inputs
+       `(("python2-keystoneclient" ,python2-keystoneclient)
+         ,@(alist-delete
+            "python-keystoneclient"
+            (package-native-inputs swiftclient)))))))
-- 
2.6.2


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH 07/10] gnu: Add python-rauth.

[Efraim Flashner]

[-- Attachment #1.1: Type: text/plain, Size: 2335 bytes --]

On Fri, 4 Dec 2015 10:53:42 +0100
Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> wrote:

> Efraim Flashner <efraim@flashner.co.il> writes:
> 
> > * gnu/packages/python.scm (python-rauth, python2-rauth): New variables.
> > ---
> >  gnu/packages/python.scm | 33 +++++++++++++++++++++++++++++++++
> >  1 file changed, 33 insertions(+)
> >
> > diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
> > index 21aa8fa..5c71aac 100644
> > --- a/gnu/packages/python.scm
> > +++ b/gnu/packages/python.scm
> > @@ -6064,6 +6064,39 @@ automatically detect a wide range of file encodings.")
> >  (define-public python2-chardet
> >    (package-with-python2 python-chardet))
> >  
> > +(define-public python-rauth
> > +  (package
> > +    (name "python-rauth")
> > +    (version "0.7.2")
> > +      (source
> > +        (origin
> > +          (method url-fetch)
> > +          (uri (pypi-uri "rauth" version))
> > +          (sha256
> > +            (base32
> > +             "00pq7zw429hhza9c0qzxiqp77m653jv09z92nralnmzwdf6pzicf"))))
> > +    (build-system python-build-system)
> > +    (arguments
> > +     `(#:test-target "check"))
> > +    (native-inputs
> > +     `(("python-setuptools" ,python-setuptools)))
> > +    (inputs
> > +     `(("python-requests" ,python-requests)))  
> 
> I think this should be a propagated input.
> 
> > +    (home-page "https://github.com/litl/rauth")
> > +    (synopsis "Python library for OAuth 1.0/a, 2.0, and Ofly")
> > +    (description
> > +     "Rauth is a Python library for OAuth 1.0/a, 2.0, and Ofly.  It also
> > +provides service wrappers for convenient connection initialization and
> > +authenticated session objects providing things like keep-alive.")
> > +    (license license:expat)))  
> 
> Otherwise OK.
> 
> > +(define-public python2-rauth
> > +  (let ((rauth (package-with-python2 python-rauth)))
> > +    (package (inherit rauth)
> > +      (native-inputs
> > +       `(("python2-unittest2", python2-unittest2)
> > +         ,@(package-native-inputs rauth))))))
> > +  
> 
> Lookin’ good!
> 
> ~~ Ricardo



-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: 0007-gnu-Add-python-rauth.patch --]
[-- Type: text/x-patch, Size: 1932 bytes --]

From 5382b2ad55475cfcf0ea7589cba4a58b87e352eb Mon Sep 17 00:00:00 2001
From: Efraim Flashner <efraim@flashner.co.il>
Date: Sun, 22 Nov 2015 22:43:51 +0200
Subject: [PATCH 07/10] gnu: Add python-rauth.

* gnu/packages/python.scm (python-rauth, python2-rauth): New variables.
---
 gnu/packages/python.scm | 33 +++++++++++++++++++++++++++++++++
 1 file changed, 33 insertions(+)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index a6c665c..8defd9e 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -6621,6 +6621,39 @@ of the SSL peer.")
     (propagated-inputs
      `(("python2-pyopenssl" ,python2-pyopenssl)))))
 
+(define-public python-rauth
+  (package
+    (name "python-rauth")
+    (version "0.7.2")
+    (source
+      (origin
+        (method url-fetch)
+        (uri (pypi-uri "rauth" version))
+        (sha256
+          (base32
+           "00pq7zw429hhza9c0qzxiqp77m653jv09z92nralnmzwdf6pzicf"))))
+    (build-system python-build-system)
+    (arguments
+     `(#:test-target "check"))
+    (native-inputs
+     `(("python-setuptools" ,python-setuptools)))
+    (propagated-inputs
+     `(("python-requests" ,python-requests)))
+    (home-page "https://github.com/litl/rauth")
+    (synopsis "Python library for OAuth 1.0/a, 2.0, and Ofly")
+    (description
+     "Rauth is a Python library for OAuth 1.0/a, 2.0, and Ofly.  It also
+provides service wrappers for convenient connection initialization and
+authenticated session objects providing things like keep-alive.")
+    (license license:expat)))
+
+(define-public python2-rauth
+  (let ((rauth (package-with-python2 python-rauth)))
+    (package (inherit rauth)
+      (native-inputs
+       `(("python2-unittest2", python2-unittest2)
+         ,@(package-native-inputs rauth))))))
+
 (define-public python2-futures
   (package
     (name "python2-futures")
-- 
2.6.2


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH 08/10] gnu: Add python-pyasn1-modules.

[Efraim Flashner]

[-- Attachment #1.1: Type: text/plain, Size: 1799 bytes --]

On Thu,  3 Dec 2015 16:43:29 +0200
Efraim Flashner <efraim@flashner.co.il> wrote:

> * gnu/packages/python.scm (python-pyasn1-modules)
> (python2-pyasn1-modules): New variables.
> ---
>  gnu/packages/python.scm | 24 ++++++++++++++++++++++++
>  1 file changed, 24 insertions(+)
> 
> diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
> index 5c71aac..0323399 100644
> --- a/gnu/packages/python.scm
> +++ b/gnu/packages/python.scm
> @@ -5634,6 +5634,30 @@ suitable for a wide range of protocols based on the ASN.1 specification.")
>  (define-public python2-pyasn1
>    (package-with-python2 python-pyasn1))
>  
> +(define-public python-pyasn1-modules
> +  (package
> +    (name "python-pyasn1-modules")
> +    (version "0.0.8")
> +    (source
> +      (origin
> +        (method url-fetch)
> +        (uri (pypi-uri "pyasn1-modules" version))
> +        (sha256
> +          (base32
> +           "0drqgw81xd3fxdlg89kgd79zzrabvfncvkbybi2wr6w2y4s1jmhh"))))
> +  (build-system python-build-system)
> +  (native-inputs
> +   `(("python-pyasn1" ,python-pyasn1)
> +     ("python-setuptools" ,python-setuptools)))
> +  (home-page "http://sourceforge.net/projects/pyasn1/")
> +  (synopsis "Collection of ASN.1-based protocols modules")
> +  (description
> +   "Pyasn1-modules is a collection of ASN.1-based protocols modules.")
> +  (license bsd-3)))
> +
> +(define-public python2-pyasn1-modules
> +  (package-with-python2 python-pyasn1-modules))
> +
>  (define-public python2-ipaddress
>    (package
>      (name "python2-ipaddress")



-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: 0008-gnu-Add-python-pyasn1-modules.patch --]
[-- Type: text/x-patch, Size: 1672 bytes --]

From c5aebbe46c9fb665ae614c303fc84cc300524036 Mon Sep 17 00:00:00 2001
From: Efraim Flashner <efraim@flashner.co.il>
Date: Tue, 24 Nov 2015 18:25:36 +0200
Subject: [PATCH 08/10] gnu: Add python-pyasn1-modules.

* gnu/packages/python.scm (python-pyasn1-modules)
(python2-pyasn1-modules): New variables.
---
 gnu/packages/python.scm | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 8defd9e..6be60d6 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -5636,6 +5636,31 @@ suitable for a wide range of protocols based on the ASN.1 specification.")
 (define-public python2-pyasn1
   (package-with-python2 python-pyasn1))
 
+(define-public python-pyasn1-modules
+  (package
+    (name "python-pyasn1-modules")
+    (version "0.0.8")
+    (source
+      (origin
+        (method url-fetch)
+        (uri (pypi-uri "pyasn1-modules" version))
+        (sha256
+          (base32
+           "0drqgw81xd3fxdlg89kgd79zzrabvfncvkbybi2wr6w2y4s1jmhh"))))
+  (build-system python-build-system)
+  (native-inputs
+   `(("python-setuptools" ,python-setuptools)))
+   (propagated-inputs
+    `(("python-pyasn1" ,python-pyasn1)))
+  (home-page "http://sourceforge.net/projects/pyasn1/")
+  (synopsis "Collection of ASN.1-based protocols modules")
+  (description
+   "Pyasn1-modules is a collection of ASN.1-based protocols modules.")
+  (license bsd-3)))
+
+(define-public python2-pyasn1-modules
+  (package-with-python2 python-pyasn1-modules))
+
 (define-public python2-ipaddress
   (package
     (name "python2-ipaddress")
-- 
2.6.2


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH 09/10] gnu: Add python2-functools32.

[Efraim Flashner]

[-- Attachment #1.1: Type: text/plain, Size: 1471 bytes --]

On Fri, 4 Dec 2015 11:00:02 +0100
Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> wrote:

> Efraim Flashner <efraim@flashner.co.il> writes:
> 
> > +(define-public python2-functools32
> > +  (package
> > +    (name "python2-functools32")
> > +    (version "3.2.3-2")
> > +    (source
> > +      (origin
> > +        (method url-fetch)
> > +        (uri (pypi-uri "functools32" version))
> > +        (sha256
> > +          (base32
> > +           "0v8ya0b58x47wp216n1zamimv4iw57cxz3xxhzix52jkw3xks9gn"))))
> > +    (build-system python-build-system)
> > +    (arguments
> > +     `(#:python ,python-2
> > +       #:tests? #f)) ; no test target
> > +    (native-inputs
> > +     `(("python2-setuptools" ,python2-setuptools)))
> > +    (home-page "https://github.com/MiCHiLU/python-functools32")
> > +    (synopsis
> > +     "Backport of the functools module from Python 3.2.3")
> > +    (description
> > +     "Backport of the functools module from Python 3.2.3 for use on 2.7 and PyPy.")  
> 
> We need the description to be a full sentence.  “This package backports
> the @code{functools} module ...”.  Something about “for use on” sounds
> odd to me; maybe “for use with older versions of Python and with PyPy”?



-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: 0009-gnu-Add-python2-functools32.patch --]
[-- Type: text/x-patch, Size: 1680 bytes --]

From 6ada745850aaf5b382487c1b3078876eee89426d Mon Sep 17 00:00:00 2001
From: Efraim Flashner <efraim@flashner.co.il>
Date: Thu, 3 Dec 2015 16:04:54 +0200
Subject: [PATCH 09/10] gnu: Add python2-functools32.

* gnu/packages/python.scm (python2-functools32): New variable.
---
 gnu/packages/python.scm | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 6be60d6..401f546 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -6679,6 +6679,31 @@ authenticated session objects providing things like keep-alive.")
        `(("python2-unittest2", python2-unittest2)
          ,@(package-native-inputs rauth))))))
 
+(define-public python2-functools32
+  (package
+    (name "python2-functools32")
+    (version "3.2.3-2")
+    (source
+      (origin
+        (method url-fetch)
+        (uri (pypi-uri "functools32" version))
+        (sha256
+          (base32
+           "0v8ya0b58x47wp216n1zamimv4iw57cxz3xxhzix52jkw3xks9gn"))))
+    (build-system python-build-system)
+    (arguments
+     `(#:python ,python-2
+       #:tests? #f)) ; no test target
+    (native-inputs
+     `(("python2-setuptools" ,python2-setuptools)))
+    (home-page "https://github.com/MiCHiLU/python-functools32")
+    (synopsis
+     "Backport of the functools module from Python 3.2.3")
+    (description
+     "This package is a backport of the @code{functools} module from Python
+3.2.3 for use with older versions of Python and PyPy.")
+    (license license:expat)))
+
 (define-public python2-futures
   (package
     (name "python2-futures")
-- 
2.6.2


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH 10/10] gnu: Add git-annex-remote-hubic.

[Efraim Flashner]

[-- Attachment #1.1: Type: text/plain, Size: 2432 bytes --]

On Fri, 4 Dec 2015 10:57:27 +0100
Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> wrote:

> Efraim Flashner <efraim@flashner.co.il> writes:
> 
> > +(define-public git-annex-remote-hubic
> > +  (package
> > +    (name "git-annex-remote-hubic")
> > +    (version "0.3.1")
> > +    (source (origin
> > +              (method url-fetch)
> > +              (uri (string-append
> > +                    "https://github.com/Schnouki/" name "/archive/v"
> > +                    version ".tar.gz"))
> > +              (file-name (string-append name "-" version))  
> 
> You should also append “.tar.gz”.
> 
> > +              (sha256
> > +               (base32
> > +                "196g3jkaybjx11nbr51n0cjps3wjzb145ab76y717diqvvxp5v4r"))))
> > +    (build-system python-build-system)
> > +    (arguments
> > +     `(#:python ,python-2))
> > +    (native-inputs
> > +    `(("python2-setuptools" ,python2-setuptools)
> > +      ;; some extras for the tests
> > +      ("python2-futures" ,python2-futures)
> > +      ("python2-six" ,python2-six)))
> > +    (inputs
> > +     `(("python2-dateutil" ,python2-dateutil)
> > +       ("python2-rauth" ,python2-rauth)
> > +       ("python2-swiftclient" ,python2-swiftclient)))  
> 
> These are probably propagated-inputs.
> 
> > +    (home-page "https://github.com/Schnouki/git-annex-remote-hubic/")
> > +    (synopsis "Use hubic as a git-annex remote")  
> 
> I don’t know what “hubic” is but in the description you spell it as
> “hubiC”.  Which spelling is correct?

hubic.com is one of those free online storage places, and in their image they
spell it "hubiC," but it's unlikely people will search for it like that, so
I've made them all "hubic."

> 
> > +    (description
> > +     "Git annex remote hubic allows you to use your hubiC account as a \"special
> > +repository\".")  
> 
> I found it difficult to read this description because the first four
> words are actually the name of the package.  In this case I’d suggest
> replacing “Git annex remote hubic” with the generic “This package”; but
> then you should also add “with git-annex” after “special repository”.
> 
> ~~ Ricardo



-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: 0010-gnu-Add-git-annex-remote-hubic.patch --]
[-- Type: text/x-patch, Size: 2400 bytes --]

From 88877256de8eaa36fa87a99ed433b2c65663a972 Mon Sep 17 00:00:00 2001
From: Efraim Flashner <efraim@flashner.co.il>
Date: Mon, 30 Nov 2015 20:55:01 +0200
Subject: [PATCH 10/10] gnu: Add git-annex-remote-hubic.

* gnu/packages/version-control.scm (git-annex-remote-hubic): New variable.
---
 gnu/packages/version-control.scm | 33 +++++++++++++++++++++++++++++++++
 1 file changed, 33 insertions(+)

diff --git a/gnu/packages/version-control.scm b/gnu/packages/version-control.scm
index 6861e35..d5d95f7 100644
--- a/gnu/packages/version-control.scm
+++ b/gnu/packages/version-control.scm
@@ -54,6 +54,7 @@
   #:use-module (gnu packages ncurses)
   #:use-module (gnu packages ssh)
   #:use-module (gnu packages web)
+  #:use-module (gnu packages openstack)
   #:use-module (gnu packages perl)
   #:use-module (gnu packages pkg-config)
   #:use-module (gnu packages python)
@@ -983,3 +984,35 @@ fetching updates) over a collection of version control repositories.  It
 supports a large number of version control systems: Git, Subversion,
 Mercurial, Bazaar, Darcs, CVS, Fossil, and Veracity.")
     (license gpl2+)))
+
+(define-public git-annex-remote-hubic
+  (package
+    (name "git-annex-remote-hubic")
+    (version "0.3.1")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append
+                    "https://github.com/Schnouki/" name "/archive/v"
+                    version ".tar.gz"))
+              (file-name (string-append name "-" version ".tar.gz"))
+              (sha256
+               (base32
+                "196g3jkaybjx11nbr51n0cjps3wjzb145ab76y717diqvvxp5v4r"))))
+    (build-system python-build-system)
+    (arguments
+     `(#:python ,python-2))
+    (native-inputs
+    `(("python2-setuptools" ,python2-setuptools)
+      ;; some extras for the tests
+      ("python2-futures" ,python2-futures)
+      ("python2-six" ,python2-six)))
+    (propagated-inputs
+     `(("python2-dateutil" ,python2-dateutil)
+       ("python2-rauth" ,python2-rauth)
+       ("python2-swiftclient" ,python2-swiftclient)))
+    (home-page "https://github.com/Schnouki/git-annex-remote-hubic/")
+    (synopsis "Use hubic as a git-annex remote")
+    (description
+     "This package allows you to use your hubic account as a \"special
+repository\" with git-annex.")
+    (license gpl3+)))
-- 
2.6.2


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH 01/10] gnu: Add python-pytest-cov.

[Ricardo Wurmus]

Efraim Flashner <efraim@flashner.co.il> writes:

> From 645f979af579abb97a69b1a8814034f4c2d9b499 Mon Sep 17 00:00:00 2001
> From: Efraim Flashner <efraim@flashner.co.il>
> Date: Mon, 23 Nov 2015 17:12:52 +0200
> Subject: [PATCH 01/10] gnu: Add python-pytest-cov.

> * gnu/packages/python.scm (python-pytest-cov, python2-pytest-cov): New
> variables.
> ---
>  gnu/packages/python.scm | 28 ++++++++++++++++++++++++++++
>  1 file changed, 28 insertions(+)

> diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
> index d01c1d3..280f0c9 100644
> --- a/gnu/packages/python.scm
> +++ b/gnu/packages/python.scm
> @@ -1634,6 +1634,34 @@ and many external plugins.")
>  (define-public python2-pytest
>    (package-with-python2 python-pytest))
 
> +(define-public python-pytest-cov
> +  (package
> +    (name "python-pytest-cov")
> +    (version "2.2.0")
> +    (source
> +      (origin
> +        (method url-fetch)
> +        (uri (pypi-uri "pytest-cov" version))
> +        (sha256
> +          (base32
> +           "1lf9jsmhqk5nc4w3kzwglmdzjvmi7ajvrsnwv826j3bn0wzx8c92"))))
> +  (build-system python-build-system)
> +  (propagated-inputs
> +   `(("python-coverage" ,python-coverage)
> +     ("python-pytest" ,python-pytest)))
> +  (native-inputs
> +   `(("python-setuptools" ,python-setuptools)))
> +  (home-page "https://github.com/pytest-dev/pytest-cov")
> +  (synopsis "Pytest plugin for measuring coverage")
> +  (description
> +   "Pytest-cov produces coverage reports.  It supports centralised testing and
> +distributed testing in both load and each modes.  It also supports coverage
> +of subprocesses.")

I just noticed that I don’t understand the second sentence.  What does
“in both load and each modes” mean?

Also, I think we need to use American English, so even though
“centralised” looks perfectly fine to me, I believe it should be
“centralized”.

It would be great if you could clarify the description.  If you don’t
have push access, I can take care of pushing the patch set then.

~~ Ricardo

Re: [PATCH 02/10] gnu: Add python-wheel.

[Ricardo Wurmus]

Efraim Flashner <efraim@flashner.co.il> writes:
> From 3cf9101ca83470ef4f19dd270b5afd689be02569 Mon Sep 17 00:00:00 2001
> From: Efraim Flashner <efraim@flashner.co.il>
> Date: Mon, 23 Nov 2015 18:44:57 +0200
> Subject: [PATCH 02/10] gnu: Add python-wheel.

> * gnu/packages/python.scm (python-wheel, python2-wheel): New variables.
> ---
>  gnu/packages/python.scm | 27 +++++++++++++++++++++++++++
>  1 file changed, 27 insertions(+)

> diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
> index 280f0c9..442270c 100644
> --- a/gnu/packages/python.scm
> +++ b/gnu/packages/python.scm
> @@ -2165,6 +2165,33 @@ with sensible defaults out of the box.")
>  (define-public python2-click
>    (package-with-python2 python-click))
 
> +(define-public python-wheel
> +  (package
> +    (name "python-wheel")
> +    (version "0.26.0")
> +      (source

The indentation is wrong here (and affects all following lines of this
sub-expression).

> +        (origin
> +          (method url-fetch)
> +          (uri (pypi-uri "wheel" version))
> +          (sha256
> +            (base32

I also think that the indentation is wrong here.  My Emacs aligns
“(base32” with the “s” of “(sha256”.

> +             "032k1ajijbqnv0z0k88bhf75mdimi18fcmm28mss90610lw3bbga"))))
> +  (build-system python-build-system)
> +  (native-inputs
> +   `(("python-setuptools" ,python-setuptools)
> +     ("python-jsonschema" ,python-jsonschema)
> +     ("python-pytest-cov" ,python-pytest-cov)))
> +  (home-page "https://bitbucket.org/pypa/wheel/")
> +  (synopsis "Built-package format for Python")

I don’t know what this means.

> +  (description
> +   "A wheel is a ZIP-format archive with a specially formatted filename and the
> +.whl extension.  It is designed to contain all the files for a PEP 376
> +compatible install in a way that is very close to the on-disk format.")

Okay, but what does this package provide?  Is it a library to create
or inspect wheel packages?

I apologise for not bringing this up earlier, but this is the first time
I actually read the description.  (Before that I only paid attention to
the input types.)

~~ Ricardo

Re: [PATCH 03/10] gnu: python-requests: Update to 2.8.1.

[Ricardo Wurmus]

This new patch looks good to me!

~~ Ricardo

Re: [PATCH 04/10] gnu: Add python-keystoneclient.

[Ricardo Wurmus]

Efraim Flashner <efraim@flashner.co.il> writes:

> From 6837ac485125476040469289072e6f59a7139939 Mon Sep 17 00:00:00 2001
> From: Efraim Flashner <efraim@flashner.co.il>
> Date: Mon, 23 Nov 2015 20:29:12 +0200
> Subject: [PATCH 04/10] gnu: Add python-keystoneclient.

> * gnu/packages/openstack.scm (python-keystoneclient)
> (python2-keystoneclient): New variables.
> ---
>  gnu/packages/openstack.scm | 73 +++++++++++++++++++++++++++++++++++++++++++++-
>  1 file changed, 72 insertions(+), 1 deletion(-)

> diff --git a/gnu/packages/openstack.scm b/gnu/packages/openstack.scm
> index 2578292..43f957b 100644
> --- a/gnu/packages/openstack.scm
> +++ b/gnu/packages/openstack.scm
> @@ -19,12 +19,14 @@
 
>  (define-module (gnu packages openstack)
>    #:use-module (gnu packages python)
> +  #:use-module (gnu packages tls)
>    #:use-module (gnu packages version-control)
>    #:use-module (guix build-system python)
>    #:use-module (guix download)
>    #:use-module ((guix licenses)
>                  #:select (asl2.0))
> -  #:use-module (guix packages))
> +  #:use-module (guix packages)
> +  #:use-module (srfi srfi-1))
 
>  (define-public python-bandit
>    (package
> @@ -679,3 +681,72 @@ handling.")
 
>  (define-public python2-oslo.utils
>    (package-with-python2 python-oslo.utils))
> +
> +(define-public python-keystoneclient
> +  (package
> +    (name "python-keystoneclient")
> +    (version "1.8.1")
> +    (source
> +      (origin
> +        (method url-fetch)
> +        (uri (pypi-uri "python-keystoneclient" version))
> +        (sha256
> +          (base32
> +           "1w4csvkah67rfpxylxnvs2s3594i0f9isy8pf4gnsqs5zirvjaa4"))))

The indentation is a bit off.  If this was the only thing I could fix
this before pushing, but I still have some other comments.

> +  (build-system python-build-system)
> +  (native-inputs
> +   `(("python-setuptools" ,python-setuptools)
> +     ;; and some packages for the tests
> +     ("openssl" ,openssl)
> +     ("python-coverage" ,python-coverage)
> +     ("python-discover" ,python-discover)
> +     ("python-fixtures" ,python-fixtures)
> +     ("python-hacking" ,python-hacking)
> +     ("python-keyring" ,python-keyring)
> +     ("python-lxml" ,python-lxml)
> +     ("python-mock" ,python-mock)
> +     ("python-mox3" ,python-mox3)
> +     ("python-oauthlib" ,python-oauthlib)
> +     ("python-oslosphinx" ,python-oslosphinx)
> +     ("python-oslotest" ,python-oslotest)
> +     ("python-pycrypto" ,python-pycrypto)
> +     ("python-requests-mock" ,python-requests-mock)
> +     ("python-sphinx" ,python-sphinx)

This doesn’t look like it’s needed for the tests.  Maybe you could move
it above the comment (or remove the comment)?

> +     ("python-temptest-lib" ,python-tempest-lib)
> +     ("python-testrepository" ,python-testrepository)
> +     ("python-testresources" ,python-testresources)
> +     ("python-testtools" ,python-testtools)
> +     ("python-webob" ,python-webob)))

Wow!  That’s a very long list of test dependencies.  Thanks for your
patience in tracking them down rather than taking the easy route of
disabling tests!

> +  (propagated-inputs
> +   `(("python-babel" ,python-babel)
> +     ("python-debtcollector" ,python-debtcollector)
> +     ("python-iso8601" ,python-iso8601)
> +     ("python-netaddr" ,python-netaddr)
> +     ("python-oslo.config" ,python-oslo.config)
> +     ("python-oslo.i18n" ,python-oslo.i18n)
> +     ("python-oslo.serialization" ,python-oslo.serialization)
> +     ("python-oslo.utils" ,python-oslo.utils)
> +     ("python-pbr" ,python-pbr)
> +     ("python-prettytable" ,python-prettytable)
> +     ("python-requests" ,python-requests)
> +     ("python-six" ,python-six)
> +     ("python-stevedore" ,python-stevedore)))
> +  (home-page "http://www.openstack.org/")
> +  (synopsis "Client Library for OpenStack Identity")
> +  (description
> +   "Python-keystoneclient is the identity service used by OpenStack for
> +authentication (authN) and high-level authorization (authZ).  It currently
> +supports token-based authN with user/service authZ, and is scalable to support
> +OAuth, SAML, and OpenID in future versions.  Out of the box, Keystone uses
> +SQLite for its identity store database, with the option to connect to external
> +LDAP.")

I wonder: if it does uses Sqlite by default, how come sqlite is not
among the inputs?  Does it bundle sqlite sources?  Or does it just fail
by default unless sqlite is installed?

> +  (license asl2.0)))
> +
> +(define-public python2-keystoneclient
> +  (let ((keystoneclient (package-with-python2 python-keystoneclient)))
> +    (package (inherit keystoneclient)
> +      (native-inputs
> +       `(("python2-oauthlib" ,python2-oauthlib)
> +         ,@(alist-delete
> +            "python-oauthlib"
> +            (package-native-inputs keystoneclient)))))))

Okay!

~~ Ricardo

Re: [PATCH 05/10] gnu: Add python2-futures.

[Ricardo Wurmus]

It looks like the attached patch is the same as the old version.  It
still has the same indentation issues in the source/origin expression
and the description is invalid (sentence fragment).

Could you please send an updated patch?

~~ Ricardo

Re: [PATCH 06/10] gnu: Add python-swiftclient.

[Ricardo Wurmus]

> From 9207e8e3ae7cc78e6377cd811ce30454fce42081 Mon Sep 17 00:00:00 2001
> From: Efraim Flashner <efraim@flashner.co.il>
> Date: Mon, 23 Nov 2015 20:27:37 +0200
> Subject: [PATCH 06/10] gnu: Add python-swiftclient.

> * gnu/packages/openstack.scm (python-swiftclient, python2-swiftclient):
> New variables.
> ---
>  gnu/packages/openstack.scm | 53 ++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 53 insertions(+)

> diff --git a/gnu/packages/openstack.scm b/gnu/packages/openstack.scm
> index 43f957b..d0f65f0 100644
> --- a/gnu/packages/openstack.scm
> +++ b/gnu/packages/openstack.scm
> @@ -750,3 +750,56 @@ LDAP.")
>           ,@(alist-delete
>              "python-oauthlib"
>              (package-native-inputs keystoneclient)))))))
> +
> +(define-public python-swiftclient
> +  (package
> +    (name "python-swiftclient")
> +    (version "2.6.0")
> +    (source
> +      (origin
> +        (method url-fetch)
> +        (uri (pypi-uri "python-swiftclient" version))
> +        (sha256
> +          (base32
> +           "1j33l4z9vqh0scfncl4fxg01zr1hgqxhhai6gvcih1gccqm4nd7p"))))

The alignment of “(base32” is too far to the right, I think.  (Are you
using Emacs to automatically align expressions?)

> +  (build-system python-build-system)
> +  (native-inputs
> +   `(("python-pbr", python-pbr)
> +     ("python-setuptools" ,python-setuptools)
> +     ;; some packages are needed for the tests
> +     ("python-coverage" ,python-coverage)
> +     ("python-discover" ,python-discover)
> +     ("python-hacking" ,python-hacking)
> +     ("python-mock" ,python-mock)
> +     ("python-oslosphinx" ,python-oslosphinx)
> +     ("python-keystoneclient" ,python-keystoneclient)
> +     ("python-sphinx" ,python-sphinx)

Sphix is probably for generating documentation, so I’d move this above
the comment because it could be misunderstood.

> +     ("python-testrepository" ,python-testrepository)
> +     ("python-testtools" ,python-testtools)))
> +  (propagated-inputs
> +   `(("python-requests" ,python-requests)
> +     ("python-six" ,python-six)))
> +  (home-page "http://www.openstack.org/")
> +  (synopsis "OpenStack Object Storage API Client Library")
> +  (description
> +   "OpenStack Object Storage (code-named Swift) creates redundant, scalable
> +object storage using clusters of standardized servers to store petabytes of
> +accessible data.  It is not a file system or real-time data storage system, but
> +rather a long-term storage system for a more permanent type of static data that
> +can be retrieved, leveraged, and then updated if necessary.  Primary examples of
> +data that best fit this type of storage model are virtual machine images, photo
> +storage, email storage and backup archiving. Having no central \"brain\" or
                                               ^___ two spaces, please :)
                                               
> +master point of control provides greater scalability, redundancy and permanence.")

(Is it just me or are these lines really just a bit little longer than
usual?)

> +  (license asl2.0)))
> +
> +(define-public python2-swiftclient
> +  (let ((swiftclient (package-with-python2 python-swiftclient)))
> +    (package (inherit swiftclient)
> +      (propagated-inputs
> +       `(("python2-futures" ,python2-futures)
> +         ,@(package-inputs swiftclient)))

I think this should be “package-propagated-inputs” instead of
“package-inputs”.

> +      (native-inputs
> +       `(("python2-keystoneclient" ,python2-keystoneclient)
> +         ,@(alist-delete
> +            "python-keystoneclient"
> +            (package-native-inputs swiftclient)))))))
> -- 
> 2.6.2

Otherwise okay.

~~ Ricardo

Re: [PATCH 07/10] gnu: Add python-rauth.

[Ricardo Wurmus]

Aside from the alignment of “(base32” this looks okay now.  I’ll wait
for the other patches in this series before pushing it, though.

Thanks!

~~ Ricardo

Re: [PATCH 08/10] gnu: Add python-pyasn1-modules.

[Ricardo Wurmus]

Efraim Flashner <efraim@flashner.co.il> writes:

> +  (synopsis "Collection of ASN.1-based protocols modules")
> +  (description
> +   "Pyasn1-modules is a collection of ASN.1-based protocols modules.")

I’m not entirely happy with this description (and the synopsis).  It’s a
bit awkward.  Is this better?

    (synopsis "ASN.1 codec implementations")
    (description
     "Pyasn1-modules is a collection of Python modules providing ASN.1
    types and implementations of ASN.1-based codecs and protocols.")

I don’t know.  What do you think?

~~ Ricardo

Re: [PATCH 09/10] gnu: Add python2-functools32.

[Ricardo Wurmus]

Looking good now (with the exception of the minor cosmetic misalignment
of the “(base32” line).

~~ Ricardo

Re: [PATCH 01/10] gnu: Add python-pytest-cov.

[Efraim Flashner]

[-- Attachment #1: Type: text/plain, Size: 1423 bytes --]

On Fri, 11 Dec 2015 15:03:39 +0100
Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> wrote:

> Efraim Flashner <efraim@flashner.co.il> writes:
> 
...
> > +  (description
> > +   "Pytest-cov produces coverage reports.  It supports centralised testing and
> > +distributed testing in both load and each modes.  It also supports coverage
> > +of subprocesses.")  
> 
> I just noticed that I don’t understand the second sentence.  What does
> “in both load and each modes” mean?

I don't actually know, but it likely refers to how packages are used in
python. I can grok "loading a module" but I'm not sure what each is. I'll
look into it and try to figure that out.

> 
> Also, I think we need to use American English, so even though
> “centralised” looks perfectly fine to me, I believe it should be
> “centralized”.

Makes sense :)

> 
> It would be great if you could clarify the description.  If you don’t
> have push access, I can take care of pushing the patch set then.
> 
> ~~ Ricardo

Sorry for taking so long, I got distracted for a bit, and then it turned out
git-annex-remote-hubic needed some loving to get working, and isn't actually
quite there yet :/

-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH 01/10] gnu: Add python-pytest-cov.

[Ricardo Wurmus]

Efraim Flashner <efraim@flashner.co.il> writes:

> On Fri, 11 Dec 2015 15:03:39 +0100
> Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> wrote:
>
>> Efraim Flashner <efraim@flashner.co.il> writes:
>> 
> ...
>> > +  (description
>> > +   "Pytest-cov produces coverage reports.  It supports centralised testing and
>> > +distributed testing in both load and each modes.  It also supports coverage
>> > +of subprocesses.")  
>> 
>> I just noticed that I don’t understand the second sentence.  What does
>> “in both load and each modes” mean?
>
> I don't actually know, but it likely refers to how packages are used in
> python. I can grok "loading a module" but I'm not sure what each is. I'll
> look into it and try to figure that out.

Ah, so thats

    in both “load” and “each” modes.

I read this unquoted and it didn’t make any sense at all.  Maybe it’s
sufficient to just quote the terms?  Or if they are code keywords wrap
them in “@code{...}”?

~~ Ricardo

Re: [PATCH 09/10] gnu: Add python2-functools32.

[Efraim Flashner]

[-- Attachment #1.1: Type: text/plain, Size: 441 bytes --]

On Fri, 11 Dec 2015 15:30:58 +0100
Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> wrote:

> Looking good now (with the exception of the minor cosmetic misalignment
> of the “(base32” line).
> 
> ~~ Ricardo

attached

-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: 0006-gnu-Add-python2-functools32.patch --]
[-- Type: text/x-patch, Size: 1676 bytes --]

From cdf2c14910ce50a98071950d725534fa2a02f4b4 Mon Sep 17 00:00:00 2001
From: Efraim Flashner <efraim@flashner.co.il>
Date: Thu, 3 Dec 2015 16:04:54 +0200
Subject: [PATCH 6/9] gnu: Add python2-functools32.

* gnu/packages/python.scm (python2-functools32): New variable.
---
 gnu/packages/python.scm | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 33b6002..6af2bce 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -6683,6 +6683,31 @@ authenticated session objects providing things like keep-alive.")
        `(("python2-unittest2", python2-unittest2)
          ,@(package-native-inputs rauth))))))
 
+(define-public python2-functools32
+  (package
+    (name "python2-functools32")
+    (version "3.2.3-2")
+    (source
+      (origin
+        (method url-fetch)
+        (uri (pypi-uri "functools32" version))
+        (sha256
+         (base32
+          "0v8ya0b58x47wp216n1zamimv4iw57cxz3xxhzix52jkw3xks9gn"))))
+    (build-system python-build-system)
+    (arguments
+     `(#:python ,python-2
+       #:tests? #f)) ; no test target
+    (native-inputs
+     `(("python2-setuptools" ,python2-setuptools)))
+    (home-page "https://github.com/MiCHiLU/python-functools32")
+    (synopsis
+     "Backport of the functools module from Python 3.2.3")
+    (description
+     "This package is a backport of the @code{functools} module from Python
+3.2.3 for use with older versions of Python and PyPy.")
+    (license license:expat)))
+
 (define-public python2-futures
   (package
     (name "python2-futures")
-- 
2.6.4


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH 08/10] gnu: Add python-pyasn1-modules.

[Efraim Flashner]

[-- Attachment #1.1: Type: text/plain, Size: 1020 bytes --]

On Fri, 11 Dec 2015 15:29:39 +0100
Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> wrote:

> Efraim Flashner <efraim@flashner.co.il> writes:
> 
> > +  (synopsis "Collection of ASN.1-based protocols modules")
> > +  (description
> > +   "Pyasn1-modules is a collection of ASN.1-based protocols modules.")  
> 
> I’m not entirely happy with this description (and the synopsis).  It’s a
> bit awkward.  Is this better?
> 
>     (synopsis "ASN.1 codec implementations")
>     (description
>      "Pyasn1-modules is a collection of Python modules providing ASN.1
>     types and implementations of ASN.1-based codecs and protocols.")
> 
> I don’t know.  What do you think?
> 
> ~~ Ricardo

I like yours better. It also meshes better with the synopsis and description
of python-pyasn1.

-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: 0005-gnu-Add-python-pyasn1-modules.patch --]
[-- Type: text/x-patch, Size: 1736 bytes --]

From 79a6fb93e874a08786fe1a396c3491d978bef112 Mon Sep 17 00:00:00 2001
From: Efraim Flashner <efraim@flashner.co.il>
Date: Tue, 24 Nov 2015 18:25:36 +0200
Subject: [PATCH 5/9] gnu: Add python-pyasn1-modules.

* gnu/packages/python.scm (python-pyasn1-modules)
(python2-pyasn1-modules): New variables.
---
 gnu/packages/python.scm | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index dddc50e..33b6002 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -5608,6 +5608,32 @@ suitable for a wide range of protocols based on the ASN.1 specification.")
 (define-public python2-pyasn1
   (package-with-python2 python-pyasn1))
 
+(define-public python-pyasn1-modules
+  (package
+    (name "python-pyasn1-modules")
+    (version "0.0.8")
+    (source
+      (origin
+        (method url-fetch)
+        (uri (pypi-uri "pyasn1-modules" version))
+        (sha256
+         (base32
+          "0drqgw81xd3fxdlg89kgd79zzrabvfncvkbybi2wr6w2y4s1jmhh"))))
+    (build-system python-build-system)
+    (native-inputs
+     `(("python-setuptools" ,python-setuptools)))
+    (propagated-inputs
+     `(("python-pyasn1" ,python-pyasn1)))
+    (home-page "http://sourceforge.net/projects/pyasn1/")
+    (synopsis "ASN.1 codec implementations")
+    (description
+     "Pyasn1-modules is a collection of Python modules providing ASN.1 types and
+implementations of ASN.1-based codecs and protocols.")
+    (license bsd-3)))
+
+(define-public python2-pyasn1-modules
+  (package-with-python2 python-pyasn1-modules))
+
 (define-public python2-ipaddress
   (package
     (name "python2-ipaddress")
-- 
2.6.4


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH 02/10] gnu: Add python-wheel.

[Efraim Flashner]

[-- Attachment #1.1: Type: text/plain, Size: 2018 bytes --]

On Fri, 11 Dec 2015 15:07:34 +0100
Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> wrote:

> Efraim Flashner <efraim@flashner.co.il> writes:
>  [...]   
> 
> The indentation is wrong here (and affects all following lines of this
> sub-expression).
> 
>  [...]  
> 
> I also think that the indentation is wrong here.  My Emacs aligns
> “(base32” with the “s” of “(sha256”.
>

I've fixed this so now the tabulation is correct and the base32 aligns with
the sha256. I've seen base32 with both 1 and 2 spaces but I personally don't
have a preference as long as the hash doesn't go beyond 80 spaces.

> 
> > +             "032k1ajijbqnv0z0k88bhf75mdimi18fcmm28mss90610lw3bbga"))))
> > +  (build-system python-build-system)
> > +  (native-inputs
> > +   `(("python-setuptools" ,python-setuptools)
> > +     ("python-jsonschema" ,python-jsonschema)
> > +     ("python-pytest-cov" ,python-pytest-cov)))
> > +  (home-page "https://bitbucket.org/pypa/wheel/")
> > +  (synopsis "Built-package format for Python")  
> 
> I don’t know what this means.

This I copied directly from their website. From a reference that I know, .deb
files have everything they need to be installed in a system, they just need
to be unpacked and the files placed in their locations.

> 
>  [...]  
> 
> Okay, but what does this package provide?  Is it a library to create
> or inspect wheel packages?

This specifically I don't know, but I assume it is to create and use wheel bundles.

> I apologise for not bringing this up earlier, but this is the first time
> I actually read the description.  (Before that I only paid attention to
> the input types.)
> 
> ~~ Ricardo

Not a problem :)

I've expanded the description and added @code{...} tags to try to make it clearer.

-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: 0009-gnu-python-wheel-Clarify-description.patch --]
[-- Type: text/x-patch, Size: 2726 bytes --]

From fc5ca92c9bc0466e581cf806174104a5112346cc Mon Sep 17 00:00:00 2001
From: Efraim Flashner <efraim@flashner.co.il>
Date: Sun, 27 Dec 2015 09:39:51 +0200
Subject: [PATCH 9/9] gnu: python-wheel: Clarify description.

* gnu/packages/python.scm (python-wheel): Do it.
---
 gnu/packages/python.scm | 42 +++++++++++++++++++++++-------------------
 1 file changed, 23 insertions(+), 19 deletions(-)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 50137bd..3ed14b5 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -2146,25 +2146,29 @@ with sensible defaults out of the box.")
   (package
     (name "python-wheel")
     (version "0.26.0")
-      (source
-        (origin
-          (method url-fetch)
-          (uri (pypi-uri "wheel" version))
-          (sha256
-            (base32
-             "032k1ajijbqnv0z0k88bhf75mdimi18fcmm28mss90610lw3bbga"))))
-  (build-system python-build-system)
-  (native-inputs
-   `(("python-setuptools" ,python-setuptools)
-     ("python-jsonschema" ,python-jsonschema)
-     ("python-pytest-cov" ,python-pytest-cov)))
-  (home-page "https://bitbucket.org/pypa/wheel/")
-  (synopsis "Built-package format for Python")
-  (description
-   "A wheel is a ZIP-format archive with a specially formatted filename and the
-.whl extension.  It is designed to contain all the files for a PEP 376
-compatible install in a way that is very close to the on-disk format.")
-  (license license:expat)))
+    (source
+      (origin
+        (method url-fetch)
+        (uri (pypi-uri "wheel" version))
+        (sha256
+         (base32
+          "032k1ajijbqnv0z0k88bhf75mdimi18fcmm28mss90610lw3bbga"))))
+    (build-system python-build-system)
+    (native-inputs
+     `(("python-setuptools" ,python-setuptools)
+       ("python-jsonschema" ,python-jsonschema)
+       ("python-pytest-cov" ,python-pytest-cov)))
+    (home-page "https://bitbucket.org/pypa/wheel/")
+    (synopsis "Built-package format for Python")
+    (description
+     "A wheel is a ZIP-format archive with a specially formatted filename and
+the @code{.whl} extension.  It is designed to contain all the files for a PEP
+376 compatible install in a way that is very close to the on-disk format.  Many
+packages will be properly installed with only the @code{Unpack} step and the
+unpacked archive preserves enough information to @code{Spread} (copy data and
+scripts to their final locations) at any later time.  Wheel files can be
+installed with a newer @code{pip} or with wheel's own command line utility.")
+    (license license:expat)))
 
 (define-public python2-wheel
   (package-with-python2 python-wheel))
-- 
2.6.4


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH 04/10] gnu: Add python-keystoneclient.

[Efraim Flashner]

[-- Attachment #1.1: Type: text/plain, Size: 5206 bytes --]

On Fri, 11 Dec 2015 15:15:35 +0100
Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> wrote:

> Efraim Flashner <efraim@flashner.co.il> writes:
> 
>  [...]  
> 
>  [...]  
> 
>  [...]  
>  
>  [...]  
>  
>  [...]  
>  
> >  (define-public python2-oslo.utils
> >    (package-with-python2 python-oslo.utils))
> > +
> > +(define-public python-keystoneclient
> > +  (package
> > +    (name "python-keystoneclient")
> > +    (version "1.8.1")
> > +    (source
> > +      (origin
> > +        (method url-fetch)
> > +        (uri (pypi-uri "python-keystoneclient" version))
> > +        (sha256
> > +          (base32
> > +           "1w4csvkah67rfpxylxnvs2s3594i0f9isy8pf4gnsqs5zirvjaa4"))))  
> 
> The indentation is a bit off.  If this was the only thing I could fix
> this before pushing, but I still have some other comments.
> 
> > +  (build-system python-build-system)
> > +  (native-inputs
> > +   `(("python-setuptools" ,python-setuptools)
> > +     ;; and some packages for the tests
> > +     ("openssl" ,openssl)
> > +     ("python-coverage" ,python-coverage)
> > +     ("python-discover" ,python-discover)
> > +     ("python-fixtures" ,python-fixtures)
> > +     ("python-hacking" ,python-hacking)
> > +     ("python-keyring" ,python-keyring)
> > +     ("python-lxml" ,python-lxml)
> > +     ("python-mock" ,python-mock)
> > +     ("python-mox3" ,python-mox3)
> > +     ("python-oauthlib" ,python-oauthlib)
> > +     ("python-oslosphinx" ,python-oslosphinx)
> > +     ("python-oslotest" ,python-oslotest)
> > +     ("python-pycrypto" ,python-pycrypto)
> > +     ("python-requests-mock" ,python-requests-mock)
> > +     ("python-sphinx" ,python-sphinx)  
> 
> This doesn’t look like it’s needed for the tests.  Maybe you could move
> it above the comment (or remove the comment)?

Do you mean python-sphinx or all of the above? (Just read the next one about
python-sphinx being for documentation, moved that one.) Openssl isn't a
declared test dependency, but testing failed without it.

> 
> > +     ("python-temptest-lib" ,python-tempest-lib)
> > +     ("python-testrepository" ,python-testrepository)
> > +     ("python-testresources" ,python-testresources)
> > +     ("python-testtools" ,python-testtools)
> > +     ("python-webob" ,python-webob)))  
> 
> Wow!  That’s a very long list of test dependencies.  Thanks for your
> patience in tracking them down rather than taking the easy route of
> disabling tests!

Openstack is pretty good about declaring dependencies, with both a
requirements.txt and a test-requirements.txt in the source tree, and that
helped a lot.
https://git.openstack.org/cgit/openstack/python-keystoneclient/tree/?h=1.8.1

> 
> > +  (propagated-inputs
> > +   `(("python-babel" ,python-babel)
> > +     ("python-debtcollector" ,python-debtcollector)
> > +     ("python-iso8601" ,python-iso8601)
> > +     ("python-netaddr" ,python-netaddr)
> > +     ("python-oslo.config" ,python-oslo.config)
> > +     ("python-oslo.i18n" ,python-oslo.i18n)
> > +     ("python-oslo.serialization" ,python-oslo.serialization)
> > +     ("python-oslo.utils" ,python-oslo.utils)
> > +     ("python-pbr" ,python-pbr)
> > +     ("python-prettytable" ,python-prettytable)
> > +     ("python-requests" ,python-requests)
> > +     ("python-six" ,python-six)
> > +     ("python-stevedore" ,python-stevedore)))
> > +  (home-page "http://www.openstack.org/")
> > +  (synopsis "Client Library for OpenStack Identity")
> > +  (description
> > +   "Python-keystoneclient is the identity service used by OpenStack for
> > +authentication (authN) and high-level authorization (authZ).  It currently
> > +supports token-based authN with user/service authZ, and is scalable to support
> > +OAuth, SAML, and OpenID in future versions.  Out of the box, Keystone uses
> > +SQLite for its identity store database, with the option to connect to external
> > +LDAP.")  
> 
> I wonder: if it does uses Sqlite by default, how come sqlite is not
> among the inputs?  Does it bundle sqlite sources?  Or does it just fail
> by default unless sqlite is installed?
> 

It doesn't bundle sqlite, and it looks like the included description doesn't
differentiate too much between keystone and keystoneclient. As per the name,
keystoneclient connects to keystone, which would need sqlite.

> > +  (license asl2.0)))
> > +
> > +(define-public python2-keystoneclient
> > +  (let ((keystoneclient (package-with-python2 python-keystoneclient)))
> > +    (package (inherit keystoneclient)
> > +      (native-inputs
> > +       `(("python2-oauthlib" ,python2-oauthlib)
> > +         ,@(alist-delete
> > +            "python-oauthlib"
> > +            (package-native-inputs keystoneclient)))))))  
> 
> Okay!
> 
> ~~ Ricardo

2.0.0 was tagged about 4 weeks ago, but it ended up needing more packages
packaged and more dependencies updated and it looks like a project for
another time.

-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: 0001-gnu-Add-python-keystoneclient.patch --]
[-- Type: text/x-patch, Size: 4185 bytes --]

From 63b7c408bfd97a79554907f527469ab93826d390 Mon Sep 17 00:00:00 2001
From: Efraim Flashner <efraim@flashner.co.il>
Date: Mon, 23 Nov 2015 20:29:12 +0200
Subject: [PATCH 1/9] gnu: Add python-keystoneclient.

* gnu/packages/openstack.scm (python-keystoneclient)
(python2-keystoneclient): New variables.
---
 gnu/packages/openstack.scm | 73 +++++++++++++++++++++++++++++++++++++++++++++-
 1 file changed, 72 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/openstack.scm b/gnu/packages/openstack.scm
index 2578292..32507ad 100644
--- a/gnu/packages/openstack.scm
+++ b/gnu/packages/openstack.scm
@@ -19,12 +19,14 @@
 
 (define-module (gnu packages openstack)
   #:use-module (gnu packages python)
+  #:use-module (gnu packages tls)
   #:use-module (gnu packages version-control)
   #:use-module (guix build-system python)
   #:use-module (guix download)
   #:use-module ((guix licenses)
                 #:select (asl2.0))
-  #:use-module (guix packages))
+  #:use-module (guix packages)
+  #:use-module (srfi srfi-1))
 
 (define-public python-bandit
   (package
@@ -679,3 +681,72 @@ handling.")
 
 (define-public python2-oslo.utils
   (package-with-python2 python-oslo.utils))
+
+(define-public python-keystoneclient
+  (package
+    (name "python-keystoneclient")
+    (version "1.8.1")
+    (source
+      (origin
+        (method url-fetch)
+        (uri (pypi-uri "python-keystoneclient" version))
+        (sha256
+         (base32
+          "1w4csvkah67rfpxylxnvs2s3594i0f9isy8pf4gnsqs5zirvjaa4"))))
+    (build-system python-build-system)
+    (native-inputs
+     `(("python-setuptools" ,python-setuptools)
+       ("python-sphinx" ,python-sphinx)
+       ;; and some packages for the tests
+       ("openssl" ,openssl)
+       ("python-coverage" ,python-coverage)
+       ("python-discover" ,python-discover)
+       ("python-fixtures" ,python-fixtures)
+       ("python-hacking" ,python-hacking)
+       ("python-keyring" ,python-keyring)
+       ("python-lxml" ,python-lxml)
+       ("python-mock" ,python-mock)
+       ("python-mox3" ,python-mox3)
+       ("python-oauthlib" ,python-oauthlib)
+       ("python-oslosphinx" ,python-oslosphinx)
+       ("python-oslotest" ,python-oslotest)
+       ("python-pycrypto" ,python-pycrypto)
+       ("python-requests-mock" ,python-requests-mock)
+       ("python-temptest-lib" ,python-tempest-lib)
+       ("python-testrepository" ,python-testrepository)
+       ("python-testresources" ,python-testresources)
+       ("python-testtools" ,python-testtools)
+       ("python-webob" ,python-webob)))
+    (propagated-inputs
+     `(("python-babel" ,python-babel)
+       ("python-debtcollector" ,python-debtcollector)
+       ("python-iso8601" ,python-iso8601)
+       ("python-netaddr" ,python-netaddr)
+       ("python-oslo.config" ,python-oslo.config)
+       ("python-oslo.i18n" ,python-oslo.i18n)
+       ("python-oslo.serialization" ,python-oslo.serialization)
+       ("python-oslo.utils" ,python-oslo.utils)
+       ("python-pbr" ,python-pbr)
+       ("python-prettytable" ,python-prettytable)
+       ("python-requests" ,python-requests)
+       ("python-six" ,python-six)
+       ("python-stevedore" ,python-stevedore)))
+    (home-page "http://www.openstack.org/")
+    (synopsis "Client Library for OpenStack Identity")
+    (description
+     "Python-keystoneclient is the identity service used by OpenStack for
+authentication (authN) and high-level authorization (authZ).  It currently
+supports token-based authN with user/service authZ, and is scalable to support
+OAuth, SAML, and OpenID in future versions.  Out of the box, Keystone uses
+SQLite for its identity store database, with the option to connect to external
+LDAP.")
+    (license asl2.0)))
+
+(define-public python2-keystoneclient
+  (let ((keystoneclient (package-with-python2 python-keystoneclient)))
+    (package (inherit keystoneclient)
+      (native-inputs
+       `(("python2-oauthlib" ,python2-oauthlib)
+         ,@(alist-delete
+            "python-oauthlib"
+            (package-native-inputs keystoneclient)))))))
-- 
2.6.4


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH 06/10] gnu: Add python-swiftclient.

[Efraim Flashner]

[-- Attachment #1.1: Type: text/plain, Size: 4012 bytes --]

On Fri, 11 Dec 2015 15:22:31 +0100
Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> wrote:

>  [...]  
> 
>  [...]  
> 
> > diff --git a/gnu/packages/openstack.scm b/gnu/packages/openstack.scm
> > index 43f957b..d0f65f0 100644
> > --- a/gnu/packages/openstack.scm
> > +++ b/gnu/packages/openstack.scm
> > @@ -750,3 +750,56 @@ LDAP.")
> >           ,@(alist-delete
> >              "python-oauthlib"
> >              (package-native-inputs keystoneclient)))))))
> > +
> > +(define-public python-swiftclient
> > +  (package
> > +    (name "python-swiftclient")
> > +    (version "2.6.0")
> > +    (source
> > +      (origin
> > +        (method url-fetch)
> > +        (uri (pypi-uri "python-swiftclient" version))
> > +        (sha256
> > +          (base32
> > +           "1j33l4z9vqh0scfncl4fxg01zr1hgqxhhai6gvcih1gccqm4nd7p"))))  
> 
> The alignment of “(base32” is too far to the right, I think.  (Are you
> using Emacs to automatically align expressions?)

I'm actually using vim. Haven't gotten the hang of emacs yet.

> 
> > +  (build-system python-build-system)
> > +  (native-inputs
> > +   `(("python-pbr", python-pbr)
> > +     ("python-setuptools" ,python-setuptools)
> > +     ;; some packages are needed for the tests
> > +     ("python-coverage" ,python-coverage)
> > +     ("python-discover" ,python-discover)
> > +     ("python-hacking" ,python-hacking)
> > +     ("python-mock" ,python-mock)
> > +     ("python-oslosphinx" ,python-oslosphinx)
> > +     ("python-keystoneclient" ,python-keystoneclient)
> > +     ("python-sphinx" ,python-sphinx)  
> 
> Sphix is probably for generating documentation, so I’d move this above
> the comment because it could be misunderstood.

ok

> 
> > +     ("python-testrepository" ,python-testrepository)
> > +     ("python-testtools" ,python-testtools)))
> > +  (propagated-inputs
> > +   `(("python-requests" ,python-requests)
> > +     ("python-six" ,python-six)))
> > +  (home-page "http://www.openstack.org/")
> > +  (synopsis "OpenStack Object Storage API Client Library")
> > +  (description
> > +   "OpenStack Object Storage (code-named Swift) creates redundant, scalable
> > +object storage using clusters of standardized servers to store petabytes of
> > +accessible data.  It is not a file system or real-time data storage system, but
> > +rather a long-term storage system for a more permanent type of static data that
> > +can be retrieved, leveraged, and then updated if necessary.  Primary examples of
> > +data that best fit this type of storage model are virtual machine images, photo
> > +storage, email storage and backup archiving. Having no central \"brain\" or  
>                                                ^___ two spaces, please :)
>                                                
> > +master point of control provides greater scalability, redundancy and permanence.")  
> 
> (Is it just me or are these lines really just a bit little longer than
> usual?)

I checked, this one ended at 82, so I fixed it.

> > +  (license asl2.0)))
> > +
> > +(define-public python2-swiftclient
> > +  (let ((swiftclient (package-with-python2 python-swiftclient)))
> > +    (package (inherit swiftclient)
> > +      (propagated-inputs
> > +       `(("python2-futures" ,python2-futures)
> > +         ,@(package-inputs swiftclient)))  
> 
> I think this should be “package-propagated-inputs” instead of
> “package-inputs”.

good catch!

> 
> > +      (native-inputs
> > +       `(("python2-keystoneclient" ,python2-keystoneclient)
> > +         ,@(alist-delete
> > +            "python-keystoneclient"
> > +            (package-native-inputs swiftclient)))))))
> > -- 
> > 2.6.2  
> 
> Otherwise okay.
> 
> ~~ Ricardo


-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: 0003-gnu-Add-python-swiftclient.patch --]
[-- Type: text/x-patch, Size: 3111 bytes --]

From 362fad2c72336a3becc92bb6583ec46add9432af Mon Sep 17 00:00:00 2001
From: Efraim Flashner <efraim@flashner.co.il>
Date: Mon, 23 Nov 2015 20:27:37 +0200
Subject: [PATCH 3/9] gnu: Add python-swiftclient.

* gnu/packages/openstack.scm (python-swiftclient, python2-swiftclient):
New variables.
---
 gnu/packages/openstack.scm | 54 ++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 54 insertions(+)

diff --git a/gnu/packages/openstack.scm b/gnu/packages/openstack.scm
index 32507ad..b84a61c 100644
--- a/gnu/packages/openstack.scm
+++ b/gnu/packages/openstack.scm
@@ -750,3 +750,57 @@ LDAP.")
          ,@(alist-delete
             "python-oauthlib"
             (package-native-inputs keystoneclient)))))))
+
+(define-public python-swiftclient
+  (package
+    (name "python-swiftclient")
+    (version "2.6.0")
+    (source
+      (origin
+        (method url-fetch)
+        (uri (pypi-uri "python-swiftclient" version))
+        (sha256
+         (base32
+          "1j33l4z9vqh0scfncl4fxg01zr1hgqxhhai6gvcih1gccqm4nd7p"))))
+    (build-system python-build-system)
+    (native-inputs
+     `(("python-pbr", python-pbr)
+       ("python-setuptools" ,python-setuptools)
+       ("python-sphinx" ,python-sphinx)
+       ;; some packages are needed for the tests
+       ("python-coverage" ,python-coverage)
+       ("python-discover" ,python-discover)
+       ("python-hacking" ,python-hacking)
+       ("python-mock" ,python-mock)
+       ("python-oslosphinx" ,python-oslosphinx)
+       ("python-keystoneclient" ,python-keystoneclient)
+       ("python-testrepository" ,python-testrepository)
+       ("python-testtools" ,python-testtools)))
+    (propagated-inputs
+     `(("python-requests" ,python-requests)
+       ("python-six" ,python-six)))
+    (home-page "http://www.openstack.org/")
+    (synopsis "OpenStack Object Storage API Client Library")
+    (description
+     "OpenStack Object Storage (code-named Swift) creates redundant, scalable
+object storage using clusters of standardized servers to store petabytes of
+accessible data.  It is not a file system or real-time data storage system, but
+rather a long-term storage system for a more permanent type of static data that
+can be retrieved, leveraged, and then updated if necessary.  Primary examples of
+data that best fit this type of storage model are virtual machine images, photo
+storage, email storage and backup archiving.  Having no central \"brain\" or
+master point of control provides greater scalability, redundancy and
+permanence.")
+  (license asl2.0)))
+
+(define-public python2-swiftclient
+  (let ((swiftclient (package-with-python2 python-swiftclient)))
+    (package (inherit swiftclient)
+      (propagated-inputs
+       `(("python2-futures" ,python2-futures)
+         ,@(package-propagated-inputs swiftclient)))
+      (native-inputs
+       `(("python2-keystoneclient" ,python2-keystoneclient)
+         ,@(alist-delete
+            "python-keystoneclient"
+            (package-native-inputs swiftclient)))))))
-- 
2.6.4


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH 01/10] gnu: Add python-pytest-cov.

[Efraim Flashner]

[-- Attachment #1.1: Type: text/plain, Size: 710 bytes --]

On Sun, 20 Dec 2015 14:43:47 +0100
Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> wrote:

> Efraim Flashner <efraim@flashner.co.il> writes:
> 
>  [...]  
>  [...]  
>  [...]  
>  [...]  
>  [...]  
>  [...]  
> 
> Ah, so thats
> 
>     in both “load” and “each” modes.
> 
> I read this unquoted and it didn’t make any sense at all.  Maybe it’s
> sufficient to just quote the terms?  Or if they are code keywords wrap
> them in “@code{...}”?
> 
> ~~ Ricardo



-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: 0008-gnu-python-pytest-cov-Clarify-description.patch --]
[-- Type: text/x-patch, Size: 1889 bytes --]

From 29533e0bd8f50d3b7e46d3b3eabf090cfb1c87bd Mon Sep 17 00:00:00 2001
From: Efraim Flashner <efraim@flashner.co.il>
Date: Sun, 27 Dec 2015 09:00:14 +0200
Subject: [PATCH 8/9] gnu: python-pytest-cov: Clarify description.

* gnu/packages/python.scm (python-pytest-cov): Do it.
---
 gnu/packages/python.scm | 24 ++++++++++++------------
 1 file changed, 12 insertions(+), 12 deletions(-)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 6af2bce..50137bd 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -1632,18 +1632,18 @@ and many external plugins.")
         (sha256
           (base32
            "1lf9jsmhqk5nc4w3kzwglmdzjvmi7ajvrsnwv826j3bn0wzx8c92"))))
-  (build-system python-build-system)
-  (propagated-inputs
-   `(("python-coverage" ,python-coverage)
-     ("python-pytest" ,python-pytest)))
-  (native-inputs
-   `(("python-setuptools" ,python-setuptools)))
-  (home-page "https://github.com/pytest-dev/pytest-cov")
-  (synopsis "Pytest plugin for measuring coverage")
-  (description
-   "Pytest-cov produces coverage reports.  It supports centralised testing and
-distributed testing in both load and each modes.  It also supports coverage
-of subprocesses.")
+    (build-system python-build-system)
+    (propagated-inputs
+     `(("python-coverage" ,python-coverage)
+       ("python-pytest" ,python-pytest)))
+    (native-inputs
+     `(("python-setuptools" ,python-setuptools)))
+    (home-page "https://github.com/pytest-dev/pytest-cov")
+    (synopsis "Pytest plugin for measuring coverage")
+    (description
+     "Pytest-cov produces coverage reports.  It supports centralised testing and
+distributed testing in both @code{load} and @code{each} modes.  It also
+supports coverage of subprocesses.")
   (license license:expat)))
 
 (define-public python2-pytest-cov
-- 
2.6.4


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH 05/10] gnu: Add python2-futures.

[Efraim Flashner]

[-- Attachment #1.1: Type: text/plain, Size: 582 bytes --]

On Fri, 11 Dec 2015 15:17:45 +0100
Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> wrote:

> It looks like the attached patch is the same as the old version.  It
> still has the same indentation issues in the source/origin expression
> and the description is invalid (sentence fragment).
> 
> Could you please send an updated patch?
> 
> ~~ Ricardo

attached

-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: 0002-gnu-Add-python2-futures.patch --]
[-- Type: text/x-patch, Size: 1410 bytes --]

From e500011ab8eb69cb0191f25340ea285a3ac3baf7 Mon Sep 17 00:00:00 2001
From: Efraim Flashner <efraim@flashner.co.il>
Date: Tue, 24 Nov 2015 22:33:31 +0200
Subject: [PATCH 2/9] gnu: Add python2-futures.

* gnu/packages/python.scm (python2-futures): New variable.
---
 gnu/packages/python.scm | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 164907e..cf34f21 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -6623,3 +6623,26 @@ the standard library.")
 
 (define-public python2-contextlib2
   (package-with-python2 python-contextlib2))
+
+(define-public python2-futures
+  (package
+    (name "python2-futures")
+    (version "3.0.3")
+    (source
+      (origin
+        (method url-fetch)
+        (uri (pypi-uri "futures" version))
+        (sha256
+         (base32
+          "1vcb34dqhzkhbq1957vdjszhhm5y3j9ba88dgwhqx2zynhmk9qig"))))
+    (build-system python-build-system)
+    (arguments
+     `(#:python ,python-2))
+    (native-inputs
+     `(("python2-setuptools" ,python2-setuptools)))
+    (home-page "https://github.com/agronholm/pythonfutures")
+    (synopsis
+     "Backport of the concurrent.futures package from Python 3.2")
+    (description
+     "Backport of the concurrent.futures package from Python 3.2")
+    (license bsd-3)))
-- 
2.6.4


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH 07/10] gnu: Add python-rauth.

[Efraim Flashner]

[-- Attachment #1.1: Type: text/plain, Size: 496 bytes --]

On Fri, 11 Dec 2015 15:23:58 +0100
Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> wrote:

> Aside from the alignment of “(base32” this looks okay now.  I’ll wait
> for the other patches in this series before pushing it, though.
> 
> Thanks!
> 
> ~~ Ricardo

attached

-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: 0004-gnu-Add-python-rauth.patch --]
[-- Type: text/x-patch, Size: 1938 bytes --]

From 999b07b40249c0905cea32f9d1ad3a1b1bab6376 Mon Sep 17 00:00:00 2001
From: Efraim Flashner <efraim@flashner.co.il>
Date: Sun, 22 Nov 2015 22:43:51 +0200
Subject: [PATCH 4/9] gnu: Add python-rauth.

* gnu/packages/python.scm (python-rauth, python2-rauth): New variables.
---
 gnu/packages/python.scm | 33 +++++++++++++++++++++++++++++++++
 1 file changed, 33 insertions(+)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index cf34f21..dddc50e 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -6624,6 +6624,39 @@ the standard library.")
 (define-public python2-contextlib2
   (package-with-python2 python-contextlib2))
 
+(define-public python-rauth
+  (package
+    (name "python-rauth")
+    (version "0.7.2")
+    (source
+      (origin
+        (method url-fetch)
+        (uri (pypi-uri "rauth" version))
+        (sha256
+         (base32
+          "00pq7zw429hhza9c0qzxiqp77m653jv09z92nralnmzwdf6pzicf"))))
+    (build-system python-build-system)
+    (arguments
+     `(#:test-target "check"))
+    (native-inputs
+     `(("python-setuptools" ,python-setuptools)))
+    (propagated-inputs
+     `(("python-requests" ,python-requests)))
+    (home-page "https://github.com/litl/rauth")
+    (synopsis "Python library for OAuth 1.0/a, 2.0, and Ofly")
+    (description
+     "Rauth is a Python library for OAuth 1.0/a, 2.0, and Ofly.  It also
+provides service wrappers for convenient connection initialization and
+authenticated session objects providing things like keep-alive.")
+    (license license:expat)))
+
+(define-public python2-rauth
+  (let ((rauth (package-with-python2 python-rauth)))
+    (package (inherit rauth)
+      (native-inputs
+       `(("python2-unittest2", python2-unittest2)
+         ,@(package-native-inputs rauth))))))
+
 (define-public python2-futures
   (package
     (name "python2-futures")
-- 
2.6.4


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH 01/10] gnu: Add python-pytest-cov.

[Ricardo Wurmus]

Efraim Flashner <efraim@flashner.co.il> writes:

> On Sun, 20 Dec 2015 14:43:47 +0100
> Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> wrote:
>
>> Ah, so thats
>> 
>>     in both “load” and “each” modes.
>> 
>> I read this unquoted and it didn’t make any sense at all.  Maybe it’s
>> sufficient to just quote the terms?  Or if they are code keywords wrap
>> them in “@code{...}”?


> From 29533e0bd8f50d3b7e46d3b3eabf090cfb1c87bd Mon Sep 17 00:00:00 2001
> From: Efraim Flashner <efraim@flashner.co.il>
> Date: Sun, 27 Dec 2015 09:00:14 +0200
> Subject: [PATCH 8/9] gnu: python-pytest-cov: Clarify description.

> * gnu/packages/python.scm (python-pytest-cov): Do it.
> ---
>  gnu/packages/python.scm | 24 ++++++++++++------------
>  1 file changed, 12 insertions(+), 12 deletions(-)

> diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
> index 6af2bce..50137bd 100644
> --- a/gnu/packages/python.scm
> +++ b/gnu/packages/python.scm
> @@ -1632,18 +1632,18 @@ and many external plugins.")
>          (sha256
>            (base32
>             "1lf9jsmhqk5nc4w3kzwglmdzjvmi7ajvrsnwv826j3bn0wzx8c92"))))
> -  (build-system python-build-system)
> -  (propagated-inputs
> -   `(("python-coverage" ,python-coverage)
> -     ("python-pytest" ,python-pytest)))
> -  (native-inputs
> -   `(("python-setuptools" ,python-setuptools)))
> -  (home-page "https://github.com/pytest-dev/pytest-cov")
> -  (synopsis "Pytest plugin for measuring coverage")
> -  (description
> -   "Pytest-cov produces coverage reports.  It supports centralised testing and
> -distributed testing in both load and each modes.  It also supports coverage
> -of subprocesses.")
> +    (build-system python-build-system)
> +    (propagated-inputs
> +     `(("python-coverage" ,python-coverage)
> +       ("python-pytest" ,python-pytest)))
> +    (native-inputs
> +     `(("python-setuptools" ,python-setuptools)))
> +    (home-page "https://github.com/pytest-dev/pytest-cov")
> +    (synopsis "Pytest plugin for measuring coverage")
> +    (description
> +     "Pytest-cov produces coverage reports.  It supports centralised testing and
> +distributed testing in both @code{load} and @code{each} modes.  It also
> +supports coverage of subprocesses.")
>    (license license:expat)))

Why has the indentation changed for all lines since ‘(build-system
...)’?  The description is clearer now, thanks.

~~ Ricardo

Re: [PATCH 09/10] gnu: Add python2-functools32.

[Ricardo Wurmus]

Efraim Flashner <efraim@flashner.co.il> writes:

> On Fri, 11 Dec 2015 15:30:58 +0100
> Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> wrote:
>
>> Looking good now (with the exception of the minor cosmetic misalignment
>> of the “(base32” line).
>> 
>> ~~ Ricardo
>
> attached

Thanks, this looks good.

~~ Ricardo

Re: [PATCH 01/10] gnu: Add python-pytest-cov.

[Efraim Flashner]

[-- Attachment #1: Type: text/plain, Size: 2359 bytes --]

On Wed, 30 Dec 2015 15:10:06 +0100
Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> wrote:

> Efraim Flashner <efraim@flashner.co.il> writes:
> 
>  [...]  
>  [...]  
> 
> 
>  [...]  
> 
>  [...]  
> 
> > diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
> > index 6af2bce..50137bd 100644
> > --- a/gnu/packages/python.scm
> > +++ b/gnu/packages/python.scm
> > @@ -1632,18 +1632,18 @@ and many external plugins.")
> >          (sha256
> >            (base32
> >             "1lf9jsmhqk5nc4w3kzwglmdzjvmi7ajvrsnwv826j3bn0wzx8c92"))))
> > -  (build-system python-build-system)
> > -  (propagated-inputs
> > -   `(("python-coverage" ,python-coverage)
> > -     ("python-pytest" ,python-pytest)))
> > -  (native-inputs
> > -   `(("python-setuptools" ,python-setuptools)))
> > -  (home-page "https://github.com/pytest-dev/pytest-cov")
> > -  (synopsis "Pytest plugin for measuring coverage")
> > -  (description
> > -   "Pytest-cov produces coverage reports.  It supports centralised testing and
> > -distributed testing in both load and each modes.  It also supports coverage
> > -of subprocesses.")
> > +    (build-system python-build-system)
> > +    (propagated-inputs
> > +     `(("python-coverage" ,python-coverage)
> > +       ("python-pytest" ,python-pytest)))
> > +    (native-inputs
> > +     `(("python-setuptools" ,python-setuptools)))
> > +    (home-page "https://github.com/pytest-dev/pytest-cov")
> > +    (synopsis "Pytest plugin for measuring coverage")
> > +    (description
> > +     "Pytest-cov produces coverage reports.  It supports centralised testing and
> > +distributed testing in both @code{load} and @code{each} modes.  It also
> > +supports coverage of subprocesses.")
> >    (license license:expat)))  
> 
> Why has the indentation changed for all lines since ‘(build-system
> ...)’?  The description is clearer now, thanks.
> 
> ~~ Ricardo

before it was
(define-public python-pytest-cov
  (package
    (name "python-pytest-cov")
...
  (build-system python-build-system)
...

So I had it lined up with package instead of indented 2 more spaces.

-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH 01/10] gnu: Add python-pytest-cov.

[Ricardo Wurmus]

Efraim Flashner <efraim@flashner.co.il> writes:

> On Wed, 30 Dec 2015 15:10:06 +0100
> Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> wrote:
>
>> Efraim Flashner <efraim@flashner.co.il> writes:
>> 
>>  [...]  
>>  [...]  
>> 
>> 
>>  [...]  
>> 
>>  [...]  
>> 
>> > diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
>> > index 6af2bce..50137bd 100644
>> > --- a/gnu/packages/python.scm
>> > +++ b/gnu/packages/python.scm
>> > @@ -1632,18 +1632,18 @@ and many external plugins.")
>> >          (sha256
>> >            (base32
>> >             "1lf9jsmhqk5nc4w3kzwglmdzjvmi7ajvrsnwv826j3bn0wzx8c92"))))
>> > -  (build-system python-build-system)
>> > -  (propagated-inputs
>> > -   `(("python-coverage" ,python-coverage)
>> > -     ("python-pytest" ,python-pytest)))
>> > -  (native-inputs
>> > -   `(("python-setuptools" ,python-setuptools)))
>> > -  (home-page "https://github.com/pytest-dev/pytest-cov")
>> > -  (synopsis "Pytest plugin for measuring coverage")
>> > -  (description
>> > -   "Pytest-cov produces coverage reports.  It supports centralised testing and
>> > -distributed testing in both load and each modes.  It also supports coverage
>> > -of subprocesses.")
>> > +    (build-system python-build-system)
>> > +    (propagated-inputs
>> > +     `(("python-coverage" ,python-coverage)
>> > +       ("python-pytest" ,python-pytest)))
>> > +    (native-inputs
>> > +     `(("python-setuptools" ,python-setuptools)))
>> > +    (home-page "https://github.com/pytest-dev/pytest-cov")
>> > +    (synopsis "Pytest plugin for measuring coverage")
>> > +    (description
>> > +     "Pytest-cov produces coverage reports.  It supports centralised testing and
>> > +distributed testing in both @code{load} and @code{each} modes.  It also
>> > +supports coverage of subprocesses.")
>> >    (license license:expat)))  
>> 
>> Why has the indentation changed for all lines since ‘(build-system
>> ...)’?  The description is clearer now, thanks.
>> 
>> ~~ Ricardo
>
> before it was
> (define-public python-pytest-cov
>   (package
>     (name "python-pytest-cov")
> ...
>   (build-system python-build-system)
> ...
>
> So I had it lined up with package instead of indented 2 more spaces.

Ah, I see, and someone already pushed the wrong version.  The commit
summary should probably be updated to mention this indentation change.

~~ Ricardo

Re: [PATCH 01/10] gnu: Add python-pytest-cov.

[Mathieu Lirzin]

Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> writes:

> Ah, I see, and someone already pushed the wrong version.  The commit
> summary should probably be updated to mention this indentation change.
>
> ~~ Ricardo

I don't think so.  The current policy is to silently fix indentation
when doing a significant change.

--
Mathieu Lirzin

Re: [PATCH 01/10] gnu: Add python-pytest-cov.

[Ricardo Wurmus]

Mathieu Lirzin <mthl@gnu.org> writes:

> Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> writes:
>
>> Ah, I see, and someone already pushed the wrong version.  The commit
>> summary should probably be updated to mention this indentation change.
>
> I don't think so.  The current policy is to silently fix indentation
> when doing a significant change.

Oh, okay.  Thanks for the correction.

~~ Ricardo

Re: [PATCH 01/10] gnu: Add python-pytest-cov.

[Ludovic Courtès]

Efraim Flashner <efraim@flashner.co.il> skribis:

> From 29533e0bd8f50d3b7e46d3b3eabf090cfb1c87bd Mon Sep 17 00:00:00 2001
> From: Efraim Flashner <efraim@flashner.co.il>
> Date: Sun, 27 Dec 2015 09:00:14 +0200
> Subject: [PATCH 8/9] gnu: python-pytest-cov: Clarify description.
>
> * gnu/packages/python.scm (python-pytest-cov): Do it.

LGTM.

Thanks, and sorry for the delay.  I think Ricardo implicitly okayed this
patch in the discussion, but probably being explicit would avoid
misunderstandings and delays.  :-)

Ludo'.

Re: [PATCH 05/10] gnu: Add python2-futures.

[Ludovic Courtès]

Efraim Flashner <efraim@flashner.co.il> skribis:

> On Fri, 11 Dec 2015 15:17:45 +0100
> Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> wrote:
>
>> It looks like the attached patch is the same as the old version.  It
>> still has the same indentation issues in the source/origin expression
>> and the description is invalid (sentence fragment).

[...]

> +    (home-page "https://github.com/agronholm/pythonfutures")
> +    (synopsis
> +     "Backport of the concurrent.futures package from Python 3.2")
> +    (description
> +     "Backport of the concurrent.futures package from Python 3.2")

Ricardo’s comment about the description still applies.  Could you fix it
and expound a little bit?

TIA,
Ludo’.

Re: [PATCH 04/10] gnu: Add python-keystoneclient.

[Ludovic Courtès]

Efraim Flashner <efraim@flashner.co.il> skribis:

> From 63b7c408bfd97a79554907f527469ab93826d390 Mon Sep 17 00:00:00 2001
> From: Efraim Flashner <efraim@flashner.co.il>
> Date: Mon, 23 Nov 2015 20:29:12 +0200
> Subject: [PATCH 1/9] gnu: Add python-keystoneclient.
>
> * gnu/packages/openstack.scm (python-keystoneclient)
> (python2-keystoneclient): New variables.

I think this can go in.

Ludo’.

Re: [PATCH 02/10] gnu: Add python-wheel.

[Ludovic Courtès]

Efraim Flashner <efraim@flashner.co.il> skribis:

> From fc5ca92c9bc0466e581cf806174104a5112346cc Mon Sep 17 00:00:00 2001
> From: Efraim Flashner <efraim@flashner.co.il>
> Date: Sun, 27 Dec 2015 09:39:51 +0200
> Subject: [PATCH 9/9] gnu: python-wheel: Clarify description.
>
> * gnu/packages/python.scm (python-wheel): Do it.

[...]

> +    (home-page "https://bitbucket.org/pypa/wheel/")
> +    (synopsis "Built-package format for Python")

While at it, please change the synopsis to:

  Format for built Python packages

which is hopefully clearer.

Otherwise LGTM, thanks.

Ludo’.

Re: [PATCH 06/10] gnu: Add python-swiftclient.

[Ludovic Courtès]

Efraim Flashner <efraim@flashner.co.il> skribis:

> From 362fad2c72336a3becc92bb6583ec46add9432af Mon Sep 17 00:00:00 2001
> From: Efraim Flashner <efraim@flashner.co.il>
> Date: Mon, 23 Nov 2015 20:27:37 +0200
> Subject: [PATCH 3/9] gnu: Add python-swiftclient.
>
> * gnu/packages/openstack.scm (python-swiftclient, python2-swiftclient):
> New variables.

[...]

> +    (native-inputs
> +     `(("python-pbr", python-pbr)
> +       ("python-setuptools" ,python-setuptools)
> +       ("python-sphinx" ,python-sphinx)
> +       ;; some packages are needed for the tests

The comment should rather be:

  ;; The following packages are needed for the tests.

OK with this change, thanks.

Ludo’.

Re: [PATCH 07/10] gnu: Add python-rauth.

[Ludovic Courtès]

Efraim Flashner <efraim@flashner.co.il> skribis:

> On Fri, 11 Dec 2015 15:23:58 +0100
> Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> wrote:
>
>> Aside from the alignment of “(base32” this looks okay now.  I’ll wait
>> for the other patches in this series before pushing it, though.

[...]

> From 999b07b40249c0905cea32f9d1ad3a1b1bab6376 Mon Sep 17 00:00:00 2001
> From: Efraim Flashner <efraim@flashner.co.il>
> Date: Sun, 22 Nov 2015 22:43:51 +0200
> Subject: [PATCH 4/9] gnu: Add python-rauth.
>
> * gnu/packages/python.scm (python-rauth, python2-rauth): New variables.

I second Ricardo’s OK.

Thanks,
Ludo’.

Re: [PATCH 08/10] gnu: Add python-pyasn1-modules.

[Ludovic Courtès]

Efraim Flashner <efraim@flashner.co.il> skribis:

> From 79a6fb93e874a08786fe1a396c3491d978bef112 Mon Sep 17 00:00:00 2001
> From: Efraim Flashner <efraim@flashner.co.il>
> Date: Tue, 24 Nov 2015 18:25:36 +0200
> Subject: [PATCH 5/9] gnu: Add python-pyasn1-modules.
>
> * gnu/packages/python.scm (python-pyasn1-modules)
> (python2-pyasn1-modules): New variables.

LGTM.

Re: [PATCH 09/10] gnu: Add python2-functools32.

[Ludovic Courtès]

Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> skribis:

> Efraim Flashner <efraim@flashner.co.il> writes:
>
>> On Fri, 11 Dec 2015 15:30:58 +0100
>> Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> wrote:
>>
>>> Looking good now (with the exception of the minor cosmetic misalignment
>>> of the “(base32” line).
>>> 
>>> ~~ Ricardo
>>
>> attached
>
> Thanks, this looks good.

Agreed.  Looks like it feel through the cracks as well; Efraim?  :-)

Ludo’.

Re: [PATCH 04/10] gnu: Add python-keystoneclient.

[Ricardo Wurmus]

Efraim Flashner <efraim@flashner.co.il> writes:

>> > +  (build-system python-build-system)
>> > +  (native-inputs
>> > +   `(("python-setuptools" ,python-setuptools)
>> > +     ;; and some packages for the tests
>> > +     ("openssl" ,openssl)
>> > +     ("python-coverage" ,python-coverage)
>> > +     ("python-discover" ,python-discover)
>> > +     ("python-fixtures" ,python-fixtures)
>> > +     ("python-hacking" ,python-hacking)
>> > +     ("python-keyring" ,python-keyring)
>> > +     ("python-lxml" ,python-lxml)
>> > +     ("python-mock" ,python-mock)
>> > +     ("python-mox3" ,python-mox3)
>> > +     ("python-oauthlib" ,python-oauthlib)
>> > +     ("python-oslosphinx" ,python-oslosphinx)
>> > +     ("python-oslotest" ,python-oslotest)
>> > +     ("python-pycrypto" ,python-pycrypto)
>> > +     ("python-requests-mock" ,python-requests-mock)
>> > +     ("python-sphinx" ,python-sphinx)  
>> 
>> This doesn’t look like it’s needed for the tests.  Maybe you could move
>> it above the comment (or remove the comment)?
>
> Do you mean python-sphinx or all of the above? (Just read the next one about
> python-sphinx being for documentation, moved that one.) Openssl isn't a
> declared test dependency, but testing failed without it.

I just meant “python-sphinx”.

~~ Ricardo