swh-plugins-lv2: New variable [WIP]

swh-plugins-lv2: New variable [WIP]

[Florian Paul Schmidt]

[-- Attachment #1: Type: text/plain, Size: 178 bytes --]

Just pushing this out to get some feedback (I'll need to package more 
audio plugins and this might be a good start to talk about possible issues)

See the attached diff..

Flo


[-- Attachment #2: 0001-swh-plugins-lv2-New-variable.patch --]
[-- Type: text/plain, Size: 2032 bytes --]

From 905622fe8bf6522765002a2ee3f7815b5bf458ea Mon Sep 17 00:00:00 2001
From: Florian Paul Schmidt <mista.tapas@gmx.net>
Date: Wed, 2 Dec 2015 15:30:14 +0100
Subject: [PATCH] swh-plugins-lv2: New variable

---
 gnu/packages/audio.scm | 40 ++++++++++++++++++++++++++++++++++++++++
 1 file changed, 40 insertions(+)

diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
index db3f912..ed2c746 100644
--- a/gnu/packages/audio.scm
+++ b/gnu/packages/audio.scm
@@ -1891,3 +1891,43 @@ access to ALSA PCM devices, taking care of the many functions required to
 open, initialise and use a hw: device in mmap mode, and providing floating
 point audio data.")
     (license license:gpl3+)))
+
+(define-public swh-plugins-lv2
+  (let ((commit "5098e09e255eaed14e0d40ca5e7e6dfcb782d7ea"))
+    (package
+      (name "swh-plugins-lv2")
+      (version (string-append "2015-11-11-"commit))
+      (source (origin
+              (method url-fetch)
+              (uri (string-append "https://github.com/swh/"
+                                  "lv2/archive/"
+                                  commit ".zip"))
+              (sha256
+               (base32
+                "11c6y4nfw5kz7647axpgdaryiiwwrplnkdbkglx362cbcmhpvds8"))))
+    (build-system gnu-build-system)
+    (arguments
+     `(#:phases
+       (alist-cons-after
+        'unpack 'patch-makefile-and-enter-directory
+        (lambda
+            _
+          (substitute* "Makefile"
+            (("/usr/local") (assoc-ref %outputs "out"))
+            (("install:") "install: install-system")))
+        (alist-delete
+         'check
+         (alist-delete
+          'configure
+          %standard-phases)))
+       #:make-flags '("CC=gcc")))
+    (inputs
+     `(("lv2" ,lv2)
+       ("unzip" ,unzip)
+       ("fftw" ,fftw)
+       ("libxslt" ,libxslt)))
+    (home-page "http://plugin.org.uk")
+    (synopsis "SWH Plugins in LV2 format")
+    (description
+     "A collection of Steve Harris' audui plugins in LV2 format.")
+    (license license:gpl3+))))
-- 
2.5.0

Re: swh-plugins-lv2: New variable [WIP] v2

[Florian Paul Schmidt]

[-- Attachment #1: Type: text/plain, Size: 270 bytes --]



On 12/06/2015 11:44 PM, Florian Paul Schmidt wrote:
> Just pushing this out to get some feedback (I'll need to package more
> audio plugins and this might be a good start to talk about possible issues)

Updated complete patch with some whitespace and typos fixed

Flo

[-- Attachment #2: 0001-swh-plugins-lv2-New-variable.patch --]
[-- Type: text/plain, Size: 2033 bytes --]

From 6dee84494a522921baacbcad8c7618c9eb709eb1 Mon Sep 17 00:00:00 2001
From: Florian Paul Schmidt <mista.tapas@gmx.net>
Date: Wed, 2 Dec 2015 15:30:14 +0100
Subject: [PATCH] swh-plugins-lv2: New variable

---
 gnu/packages/audio.scm | 40 ++++++++++++++++++++++++++++++++++++++++
 1 file changed, 40 insertions(+)

diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
index db3f912..ec91c33 100644
--- a/gnu/packages/audio.scm
+++ b/gnu/packages/audio.scm
@@ -1891,3 +1891,43 @@ access to ALSA PCM devices, taking care of the many functions required to
 open, initialise and use a hw: device in mmap mode, and providing floating
 point audio data.")
     (license license:gpl3+)))
+
+(define-public swh-plugins-lv2
+  (let ((commit "5098e09e255eaed14e0d40ca5e7e6dfcb782d7ea"))
+    (package
+      (name "swh-plugins-lv2")
+      (version (string-append "2015-11-11-" commit))
+      (source (origin
+              (method url-fetch)
+              (uri (string-append "https://github.com/swh/"
+                                  "lv2/archive/"
+                                  commit ".zip"))
+              (sha256
+               (base32
+                "11c6y4nfw5kz7647axpgdaryiiwwrplnkdbkglx362cbcmhpvds8"))))
+    (build-system gnu-build-system)
+    (arguments
+     `(#:phases
+       (alist-cons-after
+        'unpack 'patch-makefile-and-enter-directory
+        (lambda
+            _
+          (substitute* "Makefile"
+            (("/usr/local") (assoc-ref %outputs "out"))
+            (("install:") "install: install-system")))
+        (alist-delete
+         'check
+         (alist-delete
+          'configure
+          %standard-phases)))
+       #:make-flags '("CC=gcc")))
+    (inputs
+     `(("lv2" ,lv2)
+       ("unzip" ,unzip)
+       ("fftw" ,fftw)
+       ("libxslt" ,libxslt)))
+    (home-page "http://plugin.org.uk")
+    (synopsis "SWH Plugins in LV2 format")
+    (description
+     "A collection of Steve Harris' audio plugins in LV2 format.")
+    (license license:gpl3+))))
-- 
2.5.0

Re: swh-plugins-lv2: New variable [WIP] v2

[Ricardo Wurmus]

Hi Florian,

thanks for the patch!

> From 6dee84494a522921baacbcad8c7618c9eb709eb1 Mon Sep 17 00:00:00 2001
> From: Florian Paul Schmidt <mista.tapas@gmx.net>
> Date: Wed, 2 Dec 2015 15:30:14 +0100
> Subject: [PATCH] swh-plugins-lv2: New variable

The commit message should be:

    gnu: Add swh-plugins-lv2.

    * gnu/packages/audio.scm (swh-plugins-lv2): New variable.

> ---
>  gnu/packages/audio.scm | 40 ++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 40 insertions(+)

> diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
> index db3f912..ec91c33 100644
> --- a/gnu/packages/audio.scm
> +++ b/gnu/packages/audio.scm
> @@ -1891,3 +1891,43 @@ access to ALSA PCM devices, taking care of the many functions required to
>  open, initialise and use a hw: device in mmap mode, and providing floating
>  point audio data.")
>      (license license:gpl3+)))
> +
> +(define-public swh-plugins-lv2
> +  (let ((commit "5098e09e255eaed14e0d40ca5e7e6dfcb782d7ea"))

We usually don’t use full commit hashes.  You could probably trim it to
the first six characters or so.

It would also be nice to state in a comment why you used this commit
(e.g. because that’s the latest commit as of now, and there haven’t been
any releases).

> +    (package
> +      (name "swh-plugins-lv2")
> +      (version (string-append "2015-11-11-" commit))
> +      (source (origin
> +              (method url-fetch)
> +              (uri (string-append "https://github.com/swh/"
> +                                  "lv2/archive/"
> +                                  commit ".zip"))

There is no good reason to use “.zip” here.  “.tar.gz” will work just
fine and you won’t need the “unzip” input then.

> +              (sha256
> +               (base32
> +                "11c6y4nfw5kz7647axpgdaryiiwwrplnkdbkglx362cbcmhpvds8"))))
> +    (build-system gnu-build-system)
> +    (arguments
> +     `(#:phases
> +       (alist-cons-after

Please use ‘modify-phases’ instead of the ‘alist-*’ stuff.

> +        'unpack 'patch-makefile-and-enter-directory
> +        (lambda
> +            _

This should not be on its own line.

> +          (substitute* "Makefile"
> +            (("/usr/local") (assoc-ref %outputs "out"))

I don’t think this is really necessary.  You could just add a definition
for “PREFIX” to the make-flags.

> +            (("install:") "install: install-system")))


> +        (alist-delete
> +         'check

Use “#:tests? #f” instead with a note why tests are disabled.

> +         (alist-delete
> +          'configure

Also here please add a note why.

> +          %standard-phases)))
> +       #:make-flags '("CC=gcc")))
> +    (inputs
> +     `(("lv2" ,lv2)
> +       ("unzip" ,unzip)

You don’t need “unzip” (see above), but had you actually needed it you
should have added it to “native-inputs”.

> +       ("fftw" ,fftw)
> +       ("libxslt" ,libxslt)))
> +    (home-page "http://plugin.org.uk")
> +    (synopsis "SWH Plugins in LV2 format")
> +    (description
> +     "A collection of Steve Harris' audio plugins in LV2 format.")

“guix lint” probably complains about this description, because it is a
sentence fragment, not a full sentence.  It would also be nice if this
would include a list of plugin classes that are among this collection.
People who are looking for a chorus effect with “guix package -s
chorus”, for example, would not find this package.  It doesn’t have to
be the complete list of plugins, but the categories that are covered
should be mentioned (e.g. “filters” instead of “lowpass, butterworth,
simple comb, ...”).

> +    (license license:gpl3+))))

Could you please send an updated patch (after running your final version
through “guix lint”)?

Thanks!

~~ Ricardo

Re: swh-plugins-lv2: New variable [WIP] v2

[Florian Paul Schmidt]

On 12/07/2015 10:17 PM, Ricardo Wurmus wrote:
> Hi Florian,
>
> thanks for the patch!

Hi rekado,

thanks for the feedback :)

> The commit message should be:
>
>      gnu: Add swh-plugins-lv2.
>
>      * gnu/packages/audio.scm (swh-plugins-lv2): New variable.

Oh drats, no more -a -m "lalalala" commits. OK, noted. This is 
definitely more helpful than the multi-section changelog style GNU 
documentation. Thanks.

>> +(define-public swh-plugins-lv2
>> +  (let ((commit "5098e09e255eaed14e0d40ca5e7e6dfcb782d7ea"))
>
> We usually don’t use full commit hashes.  You could probably trim it to
> the first six characters or so.

Oh, OK, I wasn't aware github allowed this. Noted.

> It would also be nice to state in a comment why you used this commit
> (e.g. because that’s the latest commit as of now, and there haven’t been
> any releases).

OK

>> +                                  commit ".zip"))
>
> There is no good reason to use “.zip” here.  “.tar.gz” will work just
> fine and you won’t need the “unzip” input then.

OK

>> +       (alist-cons-after
>
> Please use ‘modify-phases’ instead of the ‘alist-*’ stuff.

OK, noted. I think I searched through other packages to come up with this.

fps@cherry ~/src/guix [env]$ grep "#:phases (alist-cons-after" 
gnu/packages/*.scm | wc -l
53

etc..

>
>> +        'unpack 'patch-makefile-and-enter-directory
>> +        (lambda
>> +            _
>
> This should not be on its own line.

OK, this is a stylistic choice I disagree with but I can live with it ;)

>
>> +          (substitute* "Makefile"
>> +            (("/usr/local") (assoc-ref %outputs "out"))
>
> I don’t think this is really necessary.  You could just add a definition
> for “PREFIX” to the make-flags.

Are you sure? In the makefile PREFIX is set with the = operator instead 
of the ?= operator. Oh, but you might be right..

>> +        (alist-delete
>> +         'check
>
> Use “#:tests? #f” instead with a note why tests are disabled.

OK

>> +         (alist-delete
>> +          'configure
>
> Also here please add a note why.

OK

>> +       ("unzip" ,unzip)
>
> You don’t need “unzip” (see above), but had you actually needed it you
> should have added it to “native-inputs”.

OK

>> +    (description
>> +     "A collection of Steve Harris' audio plugins in LV2 format.")
>
> “guix lint” probably complains about this description, because it is a
> sentence fragment, not a full sentence.

It didn't. But terminals are still somewhat messy in GuixSD. This is for 
example the lint output I get (except for the additional line breaks 
introduced by my mail client):

fps@cherry ~/src/guix [env]$ ./pre-inst-env guix lint swh-plugins-lv2
;;; note: source file /home/fps/src/guix/gnu/packages/audio.scm
;;;       newer than compiled /home/fps/src/guix/gnu/packages/audio.go
fps@cherry ~/src/guix [env]$ 
-11-11-5098e09e255eaed14e0d40ca5e7e6dfcb782d7ea [formatting]...me]...ive]...

See how the new prompt is in the middle of the lint output? I suspect 
broken terminfo entries or something (command editing in bash is 
seriously broken as well for commands longer than a line).. If I add a 
trailing whitespace in the package definition I get:

fps@cherry ~/src/guix [env]$ ./pre-inst-env guix lint swh-plugins-lv2
;;; note: source file /home/fps/src/guix/gnu/packages/audio.scm
;;;       newer than compiled /home/fps/src/guix/gnu/packages/audio.go
gnu/packages/audio.scm:1897:4: 
swh-plugins-lv2-2015-11-11-5098e09e255eaed14e0d40ca5e7e6dfcb782d7ea: 
trailing white space on line 1929
fps@cherry ~/src/guix [env]$

So lint didn't complain before really, but it garbled some of its own 
output so it's hard to tell. Or maybe it tried to be smart with using 
the terminal and failed :)

It would also be nice if this
> would include a list of plugin classes that are among this collection.
> People who are looking for a chorus effect with “guix package -s
> chorus”, for example, would not find this package.  It doesn’t have to
> be the complete list of plugins, but the categories that are covered
> should be mentioned (e.g. “filters” instead of “lowpass, butterworth,
> simple comb, ...”).

OK

> Could you please send an updated patch (after running your final version
> through “guix lint”)?

Sure, as I did before :)

It'll be a while until I get to updating it.. Thanks again for the 
feedback..

Regards,
Flo

Re: swh-plugins-lv2: New variable [WIP] v2

[Ricardo Wurmus]

Florian Paul Schmidt <mista.tapas@gmx.net> writes:

>>> +       (alist-cons-after
>>
>> Please use ‘modify-phases’ instead of the ‘alist-*’ stuff.
>
> OK, noted. I think I searched through other packages to come up with this.
>
> fps@cherry ~/src/guix [env]$ grep "#:phases (alist-cons-after" 
> gnu/packages/*.scm | wc -l
> 53

That’s the way we did things before the nice ‘modify-phases’ macro was
written.  One problem with the ‘alist-*’ stuff is that adding or
removing phases affects the indentation of all following phases, which
makes the output of ‘git diff’ less useful.

~~ Ricardo

Re: swh-plugins-lv2: New variable [WIP] v2

[Ludovic Courtès]

Florian Paul Schmidt <mista.tapas@gmx.net> skribis:

> fps@cherry ~/src/guix [env]$ ./pre-inst-env guix lint swh-plugins-lv2
> ;;; note: source file /home/fps/src/guix/gnu/packages/audio.scm
> ;;;       newer than compiled /home/fps/src/guix/gnu/packages/audio.go
> fps@cherry ~/src/guix [env]$
> -11-11-5098e09e255eaed14e0d40ca5e7e6dfcb782d7ea
> [formatting]...me]...ive]...
>
> See how the new prompt is in the middle of the lint output? I suspect
> broken terminfo entries or something (command editing in bash is
> seriously broken as well for commands longer than a line).. If I add a
> trailing whitespace in the package definition I get:

As discussed on IRC yesterday, this appears to be due to careless use of
‘\r’ in (guix scripts lint) to return to the beginning of the line,
which doesn’t actually erase the line (it does erase it in shell-mode,
but that’s probably an exception.)  Leo has ideas on how to fix it.

Thanks,
Ludo’.

Re: swh-plugins-lv2: New variable [WIP] v2

[Mark H Weaver]

Ricardo Wurmus <rekado@elephly.net> writes:

>> +(define-public swh-plugins-lv2
>> +  (let ((commit "5098e09e255eaed14e0d40ca5e7e6dfcb782d7ea"))
>
> We usually don’t use full commit hashes.  You could probably trim it to
> the first six characters or so.

I would recommend using at least 10 characters, maybe more.  We should
use enough characters to ensure that the commit id remains unique for as
long as this package version remains in use -- keeping in mind that for
purposes of reproducing old experiments, someone might try to build this
package+version several years from now.

      Mark

Re: swh-plugins-lv2: New variable [WIP] v2

[Ludovic Courtès]

Mark H Weaver <mhw@netris.org> skribis:

> Ricardo Wurmus <rekado@elephly.net> writes:
>
>>> +(define-public swh-plugins-lv2
>>> +  (let ((commit "5098e09e255eaed14e0d40ca5e7e6dfcb782d7ea"))
>>
>> We usually don’t use full commit hashes.  You could probably trim it to
>> the first six characters or so.
>
> I would recommend using at least 10 characters, maybe more.  We should
> use enough characters to ensure that the commit id remains unique for as
> long as this package version remains in use -- keeping in mind that for
> purposes of reproducing old experiments, someone might try to build this
> package+version several years from now.

I sympathize with this.  I would think 10 digits is more than needed,
though: With 6 hex digits, it takes on average 16^6 = 16M commits before
the 6-digit ID is ambiguous, and with 8 hex digits that goes to
4 billion commits (Emacs has around 123,000 commits as an example.)

But anyway, to be super-safe, we could use the full SHA1 in the URL, but
strip it in the ‘version’ field so that it remains readable.

Thoughts?

Thanks,
Ludo’.

Re: swh-plugins-lv2: New variable [WIP] v2

[Leo Famulari]

On Tue, Dec 08, 2015 at 09:52:30AM +0100, Ludovic Courtès wrote:
> Mark H Weaver <mhw@netris.org> skribis:
> 
> > Ricardo Wurmus <rekado@elephly.net> writes:
> >
> >>> +(define-public swh-plugins-lv2
> >>> +  (let ((commit "5098e09e255eaed14e0d40ca5e7e6dfcb782d7ea"))
> >>
> >> We usually don’t use full commit hashes.  You could probably trim it to
> >> the first six characters or so.
> >
> > I would recommend using at least 10 characters, maybe more.  We should
> > use enough characters to ensure that the commit id remains unique for as
> > long as this package version remains in use -- keeping in mind that for
> > purposes of reproducing old experiments, someone might try to build this
> > package+version several years from now.
> 
> I sympathize with this.  I would think 10 digits is more than needed,
> though: With 6 hex digits, it takes on average 16^6 = 16M commits before
> the 6-digit ID is ambiguous, and with 8 hex digits that goes to
> 4 billion commits (Emacs has around 123,000 commits as an example.)
> 
> But anyway, to be super-safe, we could use the full SHA1 in the URL, but
> strip it in the ‘version’ field so that it remains readable.
> 
> Thoughts?

I don't see a reason to not use the full hash. I know the odds but why
discard the information? We can't complain about it being ugly given the
aesthetics of /gnu/store. ;)

> 
> Thanks,
> Ludo’.
> 

Re: swh-plugins-lv2: New variable [WIP] v2

[Ludovic Courtès]

Leo Famulari <leo@famulari.name> skribis:

> On Tue, Dec 08, 2015 at 09:52:30AM +0100, Ludovic Courtès wrote:
>> Mark H Weaver <mhw@netris.org> skribis:
>> 
>> > Ricardo Wurmus <rekado@elephly.net> writes:
>> >
>> >>> +(define-public swh-plugins-lv2
>> >>> +  (let ((commit "5098e09e255eaed14e0d40ca5e7e6dfcb782d7ea"))
>> >>
>> >> We usually don’t use full commit hashes.  You could probably trim it to
>> >> the first six characters or so.
>> >
>> > I would recommend using at least 10 characters, maybe more.  We should
>> > use enough characters to ensure that the commit id remains unique for as
>> > long as this package version remains in use -- keeping in mind that for
>> > purposes of reproducing old experiments, someone might try to build this
>> > package+version several years from now.
>> 
>> I sympathize with this.  I would think 10 digits is more than needed,
>> though: With 6 hex digits, it takes on average 16^6 = 16M commits before
>> the 6-digit ID is ambiguous, and with 8 hex digits that goes to
>> 4 billion commits (Emacs has around 123,000 commits as an example.)
>> 
>> But anyway, to be super-safe, we could use the full SHA1 in the URL, but
>> strip it in the ‘version’ field so that it remains readable.
>> 
>> Thoughts?
>
> I don't see a reason to not use the full hash. I know the odds but why
> discard the information? We can't complain about it being ugly given the
> aesthetics of /gnu/store. ;)

The ‘version’ field shows up in user interfaces, where aesthetics do
matter IMO.  WDYT?

(In some cases, it’s also a good way to avoid hitting limitations on the
shebang length and on the AF_UNIX socket name length.)

Ludo’.

Re: swh-plugins-lv2: New variable [WIP] v2

[Leo Famulari]

On Wed, Dec 09, 2015 at 09:56:37PM +0100, Ludovic Courtès wrote:
> Leo Famulari <leo@famulari.name> skribis:
> 
> > On Tue, Dec 08, 2015 at 09:52:30AM +0100, Ludovic Courtès wrote:
> >> Mark H Weaver <mhw@netris.org> skribis:
> >> 
> >> > Ricardo Wurmus <rekado@elephly.net> writes:
> >> >
> >> >>> +(define-public swh-plugins-lv2
> >> >>> +  (let ((commit "5098e09e255eaed14e0d40ca5e7e6dfcb782d7ea"))
> >> >>
> >> >> We usually don’t use full commit hashes.  You could probably trim it to
> >> >> the first six characters or so.
> >> >
> >> > I would recommend using at least 10 characters, maybe more.  We should
> >> > use enough characters to ensure that the commit id remains unique for as
> >> > long as this package version remains in use -- keeping in mind that for
> >> > purposes of reproducing old experiments, someone might try to build this
> >> > package+version several years from now.
> >> 
> >> I sympathize with this.  I would think 10 digits is more than needed,
> >> though: With 6 hex digits, it takes on average 16^6 = 16M commits before
> >> the 6-digit ID is ambiguous, and with 8 hex digits that goes to
> >> 4 billion commits (Emacs has around 123,000 commits as an example.)
> >> 
> >> But anyway, to be super-safe, we could use the full SHA1 in the URL, but
> >> strip it in the ‘version’ field so that it remains readable.
> >> 
> >> Thoughts?
> >
> > I don't see a reason to not use the full hash. I know the odds but why
> > discard the information? We can't complain about it being ugly given the
> > aesthetics of /gnu/store. ;)
> 
> The ‘version’ field shows up in user interfaces, where aesthetics do
> matter IMO.  WDYT?
> 
> (In some cases, it’s also a good way to avoid hitting limitations on the
> shebang length and on the AF_UNIX socket name length.)

Okay, then I like your idea of using the full SHA1 in URLs but
truncating it in the 'version' field.

> 
> Ludo’.

Re: swh-plugins-lv2: New variable [WIP] v2

[Leo Famulari]

On Mon, Dec 07, 2015 at 10:17:38PM +0100, Ricardo Wurmus wrote:
> Hi Florian,
> 
> thanks for the patch!
> 
> > From 6dee84494a522921baacbcad8c7618c9eb709eb1 Mon Sep 17 00:00:00 2001
> > From: Florian Paul Schmidt <mista.tapas@gmx.net>
> > Date: Wed, 2 Dec 2015 15:30:14 +0100
> > Subject: [PATCH] swh-plugins-lv2: New variable
> 
> The commit message should be:
> 
>     gnu: Add swh-plugins-lv2.
> 
>     * gnu/packages/audio.scm (swh-plugins-lv2): New variable.
> 
> > ---
> >  gnu/packages/audio.scm | 40 ++++++++++++++++++++++++++++++++++++++++
> >  1 file changed, 40 insertions(+)
> 
> > diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
> > index db3f912..ec91c33 100644
> > --- a/gnu/packages/audio.scm
> > +++ b/gnu/packages/audio.scm
> > @@ -1891,3 +1891,43 @@ access to ALSA PCM devices, taking care of the many functions required to
> >  open, initialise and use a hw: device in mmap mode, and providing floating
> >  point audio data.")
> >      (license license:gpl3+)))
> > +
> > +(define-public swh-plugins-lv2
> > +  (let ((commit "5098e09e255eaed14e0d40ca5e7e6dfcb782d7ea"))
> 
> We usually don’t use full commit hashes.  You could probably trim it to
> the first six characters or so.

Why is that?

> 
> It would also be nice to state in a comment why you used this commit
> (e.g. because that’s the latest commit as of now, and there haven’t been
> any releases).
> 
> > +    (package
> > +      (name "swh-plugins-lv2")
> > +      (version (string-append "2015-11-11-" commit))
> > +      (source (origin
> > +              (method url-fetch)
> > +              (uri (string-append "https://github.com/swh/"
> > +                                  "lv2/archive/"
> > +                                  commit ".zip"))
> 
> There is no good reason to use “.zip” here.  “.tar.gz” will work just
> fine and you won’t need the “unzip” input then.
> 
> > +              (sha256
> > +               (base32
> > +                "11c6y4nfw5kz7647axpgdaryiiwwrplnkdbkglx362cbcmhpvds8"))))
> > +    (build-system gnu-build-system)
> > +    (arguments
> > +     `(#:phases
> > +       (alist-cons-after
> 
> Please use ‘modify-phases’ instead of the ‘alist-*’ stuff.
> 
> > +        'unpack 'patch-makefile-and-enter-directory
> > +        (lambda
> > +            _
> 
> This should not be on its own line.
> 
> > +          (substitute* "Makefile"
> > +            (("/usr/local") (assoc-ref %outputs "out"))
> 
> I don’t think this is really necessary.  You could just add a definition
> for “PREFIX” to the make-flags.
> 
> > +            (("install:") "install: install-system")))
> 
> 
> > +        (alist-delete
> > +         'check
> 
> Use “#:tests? #f” instead with a note why tests are disabled.
> 
> > +         (alist-delete
> > +          'configure
> 
> Also here please add a note why.
> 
> > +          %standard-phases)))
> > +       #:make-flags '("CC=gcc")))
> > +    (inputs
> > +     `(("lv2" ,lv2)
> > +       ("unzip" ,unzip)
> 
> You don’t need “unzip” (see above), but had you actually needed it you
> should have added it to “native-inputs”.
> 
> > +       ("fftw" ,fftw)
> > +       ("libxslt" ,libxslt)))
> > +    (home-page "http://plugin.org.uk")
> > +    (synopsis "SWH Plugins in LV2 format")
> > +    (description
> > +     "A collection of Steve Harris' audio plugins in LV2 format.")
> 
> “guix lint” probably complains about this description, because it is a
> sentence fragment, not a full sentence.  It would also be nice if this
> would include a list of plugin classes that are among this collection.
> People who are looking for a chorus effect with “guix package -s
> chorus”, for example, would not find this package.  It doesn’t have to
> be the complete list of plugins, but the categories that are covered
> should be mentioned (e.g. “filters” instead of “lowpass, butterworth,
> simple comb, ...”).
> 
> > +    (license license:gpl3+))))
> 
> Could you please send an updated patch (after running your final version
> through “guix lint”)?
> 
> Thanks!
> 
> ~~ Ricardo
> 
> 

Re: swh-plugins-lv2: New variable [WIP, v2]

[Florian Paul Schmidt]

[-- Attachment #1: Type: text/plain, Size: 304 bytes --]

On 12/06/2015 11:44 PM, Florian Paul Schmidt wrote:
> Just pushing this out to get some feedback (I'll need to package more
> audio plugins and this might be a good start to talk about possible issues)

Updated the patch, since it seems the other version didn't get submitted..

Flo


-- 
https://fps.io

[-- Attachment #2: 0001-gnu-Add-package-swh-plugins-lv2.patch --]
[-- Type: text/plain, Size: 2552 bytes --]

From 28546dffbb862241f37651f3f33a5dadb84a9e63 Mon Sep 17 00:00:00 2001
From: Florian Paul Schmidt <mista.tapas@gmx.net>
Date: Thu, 10 Dec 2015 15:13:36 +0100
Subject: [PATCH] gnu: Add package swh-plugins-lv2

* gnu/packages/audio.scm: New variable: swh-plugins-lv2
---
 gnu/packages/audio.scm | 48 ++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 48 insertions(+)

diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
index 6a8347a..2fca640 100644
--- a/gnu/packages/audio.scm
+++ b/gnu/packages/audio.scm
@@ -1953,3 +1953,51 @@ access to ALSA PCM devices, taking care of the many functions required to
 open, initialise and use a hw: device in mmap mode, and providing floating
 point audio data.")
     (license license:gpl3+)))
+
+(define-public swh-plugins-lv2
+  ;; latest available revision and
+  ;; no releases yet 
+  (let ((commit "5098e09e255eaed14e0d40ca5e7e6dfcb782d7ea"))
+    (package
+      (name "swh-plugins-lv2")
+      (version (string-append "20151111-" (substring commit 0 10)))
+      (source (origin
+              (method url-fetch)
+              (uri (string-append "https://github.com/swh/"
+                                  "lv2/archive/"
+                                  commit ".tar.gz"))
+              (sha256
+               (base32
+                "0ysc1chzhdsw3xxsdj5rvw7lcll3xw6yyha20irfnk2pla22vb7i"))))
+    (build-system gnu-build-system)
+    (arguments
+     `(#:phases
+       (alist-cons-after
+        'unpack 'patch-makefile-and-enter-directory
+        ;; makefile's install target doesn't install
+        (lambda _
+          (substitute* "Makefile"
+            (("install:") "install: install-system")))
+        ;; no configure script
+        (alist-delete
+         'configure
+         %standard-phases))
+       #:make-flags (list
+                     "CC=gcc"
+                     (string-append "PREFIX="
+                                    (assoc-ref %outputs "out")))
+       ;; no check target
+       #:tests? #f))
+    (inputs
+     `(("lv2" ,lv2)
+       ("fftw" ,fftw)
+       ("libxslt" ,libxslt)))
+    (home-page "http://plugin.org.uk")
+    (synopsis "SWH plugins in LV2 format")
+    (description
+     "Swh-plugins-lv2 is a collection of Steve Harris' audio plugins in LV2
+format.  Plugin classes include: dynamic (compressor, limiter), time (delay,
+chorus, flanger), ringmodulator, distortion, filters, pitchshift,
+oscillators, emulation (valve, tape), bit fiddling (decimator, pointer-
+cast), etc.")
+    (license license:gpl3+))))
-- 
2.6.3

Re: swh-plugins-lv2: New variable [WIP, v2]

[Ricardo Wurmus]

Hi Flo,

> On 12/06/2015 11:44 PM, Florian Paul Schmidt wrote:
>> Just pushing this out to get some feedback (I'll need to package more
>> audio plugins and this might be a good start to talk about possible issues)
>
> Updated the patch, since it seems the other version didn't get submitted..

I’m so sorry for not noticing this email earlier!  Shortly before the
first anniversary of your patch I’ve rebased and updated it.  There’s
been a release since you submitted this, I switched to modify-phases
syntax, added pkg-config to the native-inputs (because otherwise it
wouldn’t find FFTW), moved libxslt to native-inputs, and changed “fftw”
to “fftwf” (because that’s the library pkg-config actually looks for).

Now the FFT plugins are built correctly as well.

Pushed to master as 18f3d92b39faaa881c65e5838434059f2f8ced75.

Thanks again for the patch and my apologies for not handling this
earlier!

~~ Ricardo