From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andreas Enge Subject: Re: [PATCH]: xfce4-power-manager: new variable Date: Fri, 4 Dec 2015 18:16:14 +0100 Message-ID: <20151204171614.GB7216@debian> References: <56604C07.2040900@gmx.net> <5660B6E2.3090108@gmx.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:55262) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a4ty0-00063d-6f for guix-devel@gnu.org; Fri, 04 Dec 2015 12:16:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a4txx-00048l-Gb for guix-devel@gnu.org; Fri, 04 Dec 2015 12:16:20 -0500 Received: from mout.kundenserver.de ([217.72.192.73]:51133) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a4txx-00048f-6n for guix-devel@gnu.org; Fri, 04 Dec 2015 12:16:17 -0500 Content-Disposition: inline In-Reply-To: <5660B6E2.3090108@gmx.net> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Florian Paul Schmidt Cc: guix-devel@gnu.org On Thu, Dec 03, 2015 at 10:40:50PM +0100, Florian Paul Schmidt wrote: > Removed some inputs (see attached patch). Seems to still build and run.. I usually work the other way round. I start with empty inputs and look at the output of the configure phase, then add inputs one by one. This leads to cleaner packages, I think. Notice that it is not enough to make the binary distinction between building and not building. Sometimes optional inputs are useful to have (I tend to be maximalist and add as many optional inputs as possible). Andreas