[PATCH] gnu: ladspa: Update urls.

[PATCH] gnu: ladspa: Update urls.

[Alex Vong]

[-- Attachment #1: Type: text/plain, Size: 346 bytes --]

Hi,

I have noticed <http://www.ladspa.org/> is not accessible anymore,
causing ladspa to FTBFS on my laptop. Can anyone confirm this? Hydra's
last build was on 2015-10-13. The patch updates the home page to the
self-documented header file "ladspa.h" and updates the source url to
slackware's mirror of ladspa. Does this look fine?

Cheers,
Alex

[-- Attachment #2: 0001-gnu-ladspa-Update-urls.patch --]
[-- Type: text/x-diff, Size: 1508 bytes --]

From 855da386120d18325c2e2fa9ba880808f16a759c Mon Sep 17 00:00:00 2001
From: Alex Vong <alexvong1995@gmail.com>
Date: Thu, 12 Nov 2015 01:19:44 +0800
Subject: [PATCH] gnu: ladspa: Update urls.

* gnu/packages/audio.scm (ladspa): Update source and home page url.
---
 gnu/packages/audio.scm | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
index db3f912..8243f31 100644
--- a/gnu/packages/audio.scm
+++ b/gnu/packages/audio.scm
@@ -758,7 +758,7 @@ plugin function as a JACK application.")
     (source (origin
              (method url-fetch)
              (uri (string-append
-                   "http://www.ladspa.org/download/ladspa_sdk_"
+                   "http://slackware.org.uk/slacky/slackware-13.0/multimedia/ladspa/1.13/src/ladspa_sdk_"
                    version
                    ".tgz"))
              (sha256
@@ -781,7 +781,8 @@ plugin function as a JACK application.")
               (("^CC.*")            "CC = gcc\n")
               (("^CPP.*")           "CPP = g++\n"))))
         (alist-delete 'build %standard-phases))))
-    (home-page "http://ladspa.org")
+    (home-page "https://community.ardour.org/files/doxygen/ladspa_8h_source.html")  ; Since the home page is gone,
+    ;; we provide a link to the self-documented header file.
     (synopsis "Linux Audio Developer's Simple Plugin API (LADSPA)")
     (description
      "LADSPA is a standard that allows software audio processors and effects
-- 
2.6.3

Re: [PATCH] gnu: ladspa: Update urls.

[Efraim Flashner]

[-- Attachment #1: Type: text/plain, Size: 941 bytes --]

On Thu, 12 Nov 2015 21:51:57 +0800
Alex Vong <alexvong1995@gmail.com> wrote:

> Hi,
> 
> I have noticed <http://www.ladspa.org/> is not accessible anymore,
> causing ladspa to FTBFS on my laptop. Can anyone confirm this? Hydra's
> last build was on 2015-10-13. The patch updates the home page to the
> self-documented header file "ladspa.h" and updates the source url to
> slackware's mirror of ladspa. Does this look fine?
> 
> Cheers,
> Alex

              (uri (string-append
-                   "http://www.ladspa.org/download/ladspa_sdk_"
+                   "http://slackware.org.uk/slacky/slackware-13.0/multimedia/ladspa/1.13/src/ladspa_sdk_"

near the end of the url, change the 1.13 to: " version "

-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH] gnu: ladspa: Update urls.

[Alex Vong]

[-- Attachment #1: Type: text/plain, Size: 1038 bytes --]

Good Catch!

On 12/11/2015, Efraim Flashner <efraim@flashner.co.il> wrote:
> On Thu, 12 Nov 2015 21:51:57 +0800
> Alex Vong <alexvong1995@gmail.com> wrote:
>
>> Hi,
>>
>> I have noticed <http://www.ladspa.org/> is not accessible anymore,
>> causing ladspa to FTBFS on my laptop. Can anyone confirm this? Hydra's
>> last build was on 2015-10-13. The patch updates the home page to the
>> self-documented header file "ladspa.h" and updates the source url to
>> slackware's mirror of ladspa. Does this look fine?
>>
>> Cheers,
>> Alex
>
>               (uri (string-append
> -                   "http://www.ladspa.org/download/ladspa_sdk_"
> +
> "http://slackware.org.uk/slacky/slackware-13.0/multimedia/ladspa/1.13/src/ladspa_sdk_"
>
> near the end of the url, change the 1.13 to: " version "
>
> --
> Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
> GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
> Confidentiality cannot be guaranteed on emails sent or received unencrypted
>

[-- Attachment #2: 0001-gnu-ladspa-Update-urls.patch --]
[-- Type: text/x-diff, Size: 1557 bytes --]

From b9360b2173d2b51c8077ed1b4aa27cfb82d2becd Mon Sep 17 00:00:00 2001
From: Alex Vong <alexvong1995@gmail.com>
Date: Thu, 12 Nov 2015 01:19:44 +0800
Subject: [PATCH] gnu: ladspa: Update urls.

* gnu/packages/audio.scm (ladspa): Update source and home page url.
---
 gnu/packages/audio.scm | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
index a6899a0..9ed21bd 100644
--- a/gnu/packages/audio.scm
+++ b/gnu/packages/audio.scm
@@ -758,7 +758,9 @@ plugin function as a JACK application.")
     (source (origin
              (method url-fetch)
              (uri (string-append
-                   "http://www.ladspa.org/download/ladspa_sdk_"
+                   "http://slackware.org.uk/slacky/slackware-13.0/multimedia/ladspa/"
+                   version
+                   "/src/ladspa_sdk_"
                    version
                    ".tgz"))
              (sha256
@@ -781,7 +783,8 @@ plugin function as a JACK application.")
               (("^CC.*")            "CC = gcc\n")
               (("^CPP.*")           "CPP = g++\n"))))
         (alist-delete 'build %standard-phases))))
-    (home-page "http://ladspa.org")
+    (home-page "https://community.ardour.org/files/doxygen/ladspa_8h_source.html")  ; Since the home page is gone,
+    ;; we provide a link to the self-documented header file.
     (synopsis "Linux Audio Developer's Simple Plugin API (LADSPA)")
     (description
      "LADSPA is a standard that allows software audio processors and effects
-- 
2.6.3

Re: [PATCH] gnu: ladspa: Update urls.

[Ludovic Courtès]

Alex Vong <alexvong1995@gmail.com> skribis:

> I have noticed <http://www.ladspa.org/> is not accessible anymore,
> causing ladspa to FTBFS on my laptop. Can anyone confirm this?

Confirmed.  And the bad thing is that:

  guix lint -c source,home-page ladspa

does not report anything, because the HTTP server return 200; the domain
name is basically squatted.

Thanks,
Ludo’.

Re: [PATCH] gnu: ladspa: Update urls.

[Alex Kost]

Alex Vong (2015-11-12 17:34 +0300) wrote:

[...]
> diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
> index a6899a0..9ed21bd 100644
> --- a/gnu/packages/audio.scm
> +++ b/gnu/packages/audio.scm
> @@ -758,7 +758,9 @@ plugin function as a JACK application.")
>      (source (origin
>               (method url-fetch)
>               (uri (string-append
> -                   "http://www.ladspa.org/download/ladspa_sdk_"
> +                   "http://slackware.org.uk/slacky/slackware-13.0/multimedia/ladspa/"
> +                   version
> +                   "/src/ladspa_sdk_"
>                     version
>                     ".tgz"))

Please keep lines within 78 columns.  Split that long string, for
example like this:

             (uri (string-append
                   "http://slackware.org.uk/slacky/slackware-13.0"
                   "/multimedia/ladspa/" version
                   "/src/ladspa_sdk_" version ".tgz"))


>               (sha256
> @@ -781,7 +783,8 @@ plugin function as a JACK application.")
>                (("^CC.*")            "CC = gcc\n")
>                (("^CPP.*")           "CPP = g++\n"))))
>          (alist-delete 'build %standard-phases))))
> -    (home-page "http://ladspa.org")
> +    (home-page "https://community.ardour.org/files/doxygen/ladspa_8h_source.html")  ; Since the home page is gone,
> +    ;; we provide a link to the self-documented header file.

This ^^^ is an unusual way to write a comment.  I think it's better to
do it like this:

    ;; Since the home page is gone, we provide a link to the
    ;; self-documented header file.
    (home-page
     "https://community.ardour.org/files/doxygen/ladspa_8h_source.html")

Also as the home-page line is too long, I split it into 2 lines.

-- 
Alex

Re: [PATCH] gnu: ladspa: Update urls.

[Alex Vong]

From c3ed8c2b8dc3c6527d38ebb68b1561dd2f67db4d Mon Sep 17 00:00:00 2001
From: Alex Vong <alexvong1995@gmail.com>
Date: Thu, 12 Nov 2015 01:19:44 +0800
Subject: [PATCH] gnu: ladspa: Update urls.

* gnu/packages/audio.scm (ladspa): Update source and home page url.
---
 gnu/packages/audio.scm | 15 ++++++++++-----
 1 file changed, 10 insertions(+), 5 deletions(-)

diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
index a6899a0..e85913b 100644
--- a/gnu/packages/audio.scm
+++ b/gnu/packages/audio.scm
@@ -757,10 +757,12 @@ plugin function as a JACK application.")
     (version "1.13")
     (source (origin
              (method url-fetch)
-             (uri (string-append
-                   "http://www.ladspa.org/download/ladspa_sdk_"
-                   version
-                   ".tgz"))
+             (uri (string-append "http://slackware.org.uk/"
+                                 "slacky/slackware-13.0/multimedia/ladspa/"
+                                 version
+                                 "/src/ladspa_sdk_"
+                                 version
+                                 ".tgz"))
              (sha256
               (base32
                "0srh5n2l63354bc0srcrv58rzjkn4gv8qjqzg8dnq3rs4m7kzvdm"))))
@@ -781,7 +783,10 @@ plugin function as a JACK application.")
               (("^CC.*")            "CC = gcc\n")
               (("^CPP.*")           "CPP = g++\n"))))
         (alist-delete 'build %standard-phases))))
-    (home-page "http://ladspa.org")
+    ;; Since the home page is gone,
+    ;; we provide a link to the self-documented header file.
+    (home-page
+     "https://community.ardour.org/files/doxygen/ladspa_8h_source.html")
     (synopsis "Linux Audio Developer's Simple Plugin API (LADSPA)")
     (description
      "LADSPA is a standard that allows software audio processors and effects
-- 
2.6.3