From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andreas Enge Subject: Re: [PATCH 2/2] gnu: Add Mlucas. Date: Sat, 7 Nov 2015 05:27:28 +0100 Message-ID: <20151107042728.GA9731@debian.upm.edu.my> References: <20151025141201.0f64fc35@debian> <87twpdamn0.fsf@denknerd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:51480) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zuv6Q-0000RM-NN for guix-devel@gnu.org; Fri, 06 Nov 2015 23:27:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zuv6N-000573-IK for guix-devel@gnu.org; Fri, 06 Nov 2015 23:27:46 -0500 Received: from mout.kundenserver.de ([212.227.126.130]:49297) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zuv6N-00056z-8u for guix-devel@gnu.org; Fri, 06 Nov 2015 23:27:43 -0500 Content-Disposition: inline In-Reply-To: <87twpdamn0.fsf@denknerd.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Paul van der Walt Cc: guix-devel@gnu.org Hello! I must admit I was put off looking at this patch by the addition of the flags system, of which I do not understand the justification. Basically, it seems to be an additional layer on top of what we already have in our different build systems. We have #:configure-flags and #:make-flags, and in extreme cases we can set environment variables such as CPPFLAGS and so on in an additional phase. Commonly used flags can be added to the build systems once and for all, for others, my impression is that we already have the mechanisms for doing it on a per package basis. Which problem does this part of the patch solve? On Mon, Oct 26, 2015 at 12:34:59PM +0100, Paul van der Walt wrote: > > * gnu/packages/mlucas.scm: New file. > I'm not an expert, and i'm not 100% sure on this so it's an honest > question, but does this application really deserve a new package file? > Shouldn't mlucas perhaps be added to maths.scm? It should go to algebra.scm, which regroups tools of symbolic, exact computation (whereas maths.scm contains tools for numerical computation). Andreas