From mboxrd@z Thu Jan 1 00:00:00 1970 From: Efraim Flashner Subject: Re: 01/01: gnu: Add pbzip2. Date: Thu, 22 Oct 2015 20:31:38 +0300 Message-ID: <20151022203138.2a2d2528@debian-netbook> References: <20151022142819.17853.79652@vcs.savannah.gnu.org> <877fmfj5l4.fsf@netris.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/b7U4OuW8059G1pAhLoETn.d"; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:38407) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZpJiR-00067C-4f for guix-devel@gnu.org; Thu, 22 Oct 2015 13:31:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZpJiN-0003VD-NE for guix-devel@gnu.org; Thu, 22 Oct 2015 13:31:51 -0400 Received: from flashner.co.il ([178.62.234.194]:35480) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZpJiN-0003V2-DX for guix-devel@gnu.org; Thu, 22 Oct 2015 13:31:47 -0400 In-Reply-To: <877fmfj5l4.fsf@netris.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Mark H Weaver Cc: guix-devel@gnu.org --Sig_/b7U4OuW8059G1pAhLoETn.d Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Thu, 22 Oct 2015 11:17:11 -0400 Mark H Weaver wrote: > Efraim Flashner writes: >=20 > > efraim pushed a commit to branch master > > in repository guix. > > > > commit 5d47eab0242d6f89a6837123141acdae68745328 > > Author: Efraim Flashner > > Date: Thu Oct 22 13:12:07 2015 +0300 > > > > gnu: Add pbzip2. > > =20 > > * gnu/packages/compression.scm (pbzip2): New variable. =20 >=20 > Thanks for this, but did you post it to guix-devel for review? > It would be good to do so in the future. Oops, definately forgot that this time. I'll be better about that in the fu= ture. >=20 > Please see below for comments. >=20 > > --- > > gnu/packages/compression.scm | 33 +++++++++++++++++++++++++++++++++ > > 1 files changed, 33 insertions(+), 0 deletions(-) > > > > diff --git a/gnu/packages/compression.scm b/gnu/packages/compression.scm > > index 941844b..0bb3919 100644 > > --- a/gnu/packages/compression.scm > > +++ b/gnu/packages/compression.scm > > @@ -7,6 +7,7 @@ > > ;;; Copyright =C2=A9 2015 Ricardo Wurmus > > ;;; Copyright =C2=A9 2015 Leo Famulari > > ;;; Copyright =C2=A9 2015 Jeff Mickey > > +;;; Copyright =C2=A9 2015 Efraim Flashner > > ;;; > > ;;; This file is part of GNU Guix. > > ;;; > > @@ -225,6 +226,38 @@ decompression.") > > "See LICENSE in the distribution.")) > > (home-page "http://www.bzip.org/")))) > > =20 > > +(define-public pbzip2 > > + (package > > + (name "pbzip2") > > + (version "1.1.12") > > + (source (origin > > + (method url-fetch) > > + (uri (string-append "https://launchpad.net/pbzip2/1.1/" v= ersion > > + "/+download/" name "-" version ".tar.g= z")) =20 >=20 > The quote (") on the line above should be aligned with the quote on the > line above it. Ok >=20 > Also, instead of hard coding "1.1" in the URI, please use > 'version-major+minor' instead. You'll find many examples of it in > gnu/packages/*.scm Ok, found one :). I wasn't sure what (version-major+minor version) was befo= re >=20 > > + (sha256 > > + (base32 > > + "1vk6065dv3a47p86vmp8hv3n1ygd9hraz0gq89gvzlx7lmcb6fsp")= ))) > > + (build-system gnu-build-system) > > + (inputs > > + `(("bzip2", bzip2))) > > + (arguments > > + `(#:tests? #f ; no tests > > + #:phases (modify-phases %standard-phases > > + (replace 'configure > > + (lambda* (#:key outputs #:allow-other-keys) > > + (substitute* "Makefile" > > + (("/usr") (assoc-ref outputs "out"= ))) > > + #t))))) =20 >=20 > The alignment of the lines above is very confusing, to say the least. >=20 > Anyway, it would be better to simply remove the 'configure' phase and > instead add this: >=20 > #:make-flags (list (string-append "PREFIX=3D" %output)) That sure is shorter than what I had there before. fixed. >=20 > > + (home-page "http://compression.ca/pbzip2/") > > + (synopsis "Parallel bzip2 implementation") > > + (description > > + "Pbzip2 is a parallel implementation of the bzip2 block-sorting f= ile > > +compressor that uses pthreads and achieves near-linear speedup on SMP = machines. > > +The output of this version is fully compatible with bzip2 v1.0.2 (ie: = anything > > +compressed with pbzip2 can be decompressed with bzip2).") =20 >=20 > s/ie:/i.e./ ok >=20 > > + (license (license:non-copyleft "file://COPYING" > > + "See COPYING in the distribution."))))= =20 >=20 > Please align the open quotes. ok >=20 > Thanks, > Mark I'll hold onto my patch for a little bit longer to see if anyone else has a= ny suggestions, and then I'll push the fixes. --=20 Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7=9D = =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --Sig_/b7U4OuW8059G1pAhLoETn.d Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCgAGBQJWKR16AAoJEPTB05F+rO6TemoQAKY+31VwXAJLjWhy9HwArEBR 43ndBazfMbB77lb5iJtR9S0qycRx+G9XQ+yf/MZGkie3pcf3VEDxEjt7dKM3JQBa 3tB5Kg8UpsEp1bnRnYG1W+z1TqxnO6QFbu7XOuEuV6yeZkNke7p6n7l2lPhgryjU 5Kup2qEE6qTdud0zTyzpXrMyfETp+VoIRvYq9SiiGlgy9IEtvfK7jLVmswBCVrmZ tAiszj4VZpgHArQpc8ZJLC827QyD0k9WkDzJFzlWD3xV/rY5/REzwwAM9Gvo3oFn Z4Txfi1OF+X2RF7BC42Ld2DV8vlnVgYTu5TjmTkYvWCD6eMc6JBMLyKGA6zK2v4y ouPQgzJw67D5zk48SBHDDzA0j86/n61F13Loa1+ogMDynNyn/iGYx08JP/9aPXKs R1JK6CqVZlKPwdOCuyL0JS3YGMGHiEX0Z0pPe6l7LKukgz1UWxUmiosHrA7vLdnT 4RMdJJOgNqJM7qG2Y8DYtL7mqaIl1EhQyIuIoB5dgAonEQCqNRlUyCjZqJxrDPum XgYdOp6kYxNUeAnFWsS7ZpIIGxplz59Izd/tVAn7AGoJ3fap+6pBChhyZqsLLSr5 0b29z8s7i4hlEgm0JndxzcwHl4gf7Y1RhispxI+eKXJeEOBfAydjrS/0ksl04mqQ 8Y5JPDedqEO81YbM0CaE =98of -----END PGP SIGNATURE----- --Sig_/b7U4OuW8059G1pAhLoETn.d--