From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Bavier Subject: Re: [PATCH 032/151] gnu: Add ghc-hspec-discover. Date: Tue, 20 Oct 2015 04:59:49 -0500 Message-ID: <20151020045949.2d1b2791@openmailbox.org> References: <1444911697-15515-22-git-send-email-paul@denknerd.org> <1445266613-11794-1-git-send-email-ericbavier@openmailbox.org> <87twpl4qhn.fsf@denknerd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:50976) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZoYIQ-0003z5-En for guix-devel@gnu.org; Tue, 20 Oct 2015 10:53:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZoYIL-0001zj-6l for guix-devel@gnu.org; Tue, 20 Oct 2015 10:53:50 -0400 Received: from smtp10.openmailbox.org ([62.4.1.44]:54647) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZoYIK-0001yo-TS for guix-devel@gnu.org; Tue, 20 Oct 2015 10:53:45 -0400 In-Reply-To: <87twpl4qhn.fsf@denknerd.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Paul van der Walt Cc: guix-devel@gnu.org On Tue, 20 Oct 2015 15:30:12 +0200 Paul van der Walt wrote: > Hi Eric, > > I'm starting to fix up your comments. Thanks! I'll have another chance to look through more patches later today. > When i'm done, should i git push -f to the wip-haskell-platform-7.10.2-a > branch, or should i drop that one and create a new one? I think force pushing is fine. I'll make sure to do a 'git pull' before continuing to review. `~Eric