From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eric Bavier <ericbavier@openmailbox.org>
Subject: Re: [PATCH 19/43] gnu: ghc-setenv: New variable.
Date: Mon, 19 Oct 2015 09:14:38 -0500
Message-ID: <20151019091438.54b21d2a@openmailbox.org>
References: <1444911697-15515-1-git-send-email-paul@denknerd.org>
	<1444911697-15515-19-git-send-email-paul@denknerd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39823)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ericbavier@openmailbox.org>) id 1ZoFmQ-0008Ji-GZ
	for guix-devel@gnu.org; Mon, 19 Oct 2015 15:07:35 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ericbavier@openmailbox.org>) id 1ZoFmM-0003Qk-5T
	for guix-devel@gnu.org; Mon, 19 Oct 2015 15:07:34 -0400
Received: from smtp17.openmailbox.org ([62.4.1.51]:55898)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ericbavier@openmailbox.org>) id 1ZoFmL-0003Qf-SY
	for guix-devel@gnu.org; Mon, 19 Oct 2015 15:07:30 -0400
In-Reply-To: <1444911697-15515-19-git-send-email-paul@denknerd.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Paul van der Walt <paul@denknerd.org>
Cc: guix-devel@gnu.org

On Thu, 15 Oct 2015 14:21:13 +0200
Paul van der Walt <paul@denknerd.org> wrote:

> * gnu/packages/haskell.scm (ghc-setenv): New variable.
> 
> diff --git a/gnu/packages/haskell.scm b/gnu/packages/haskell.scm
> index cb2af0a..ad6547b 100644
> --- a/gnu/packages/haskell.scm
> +++ b/gnu/packages/haskell.scm
> @@ -20,7 +20,7 @@
>  
>  (define-module (gnu packages haskell)
>    #:use-module (ice-9 regex)
> -  #:use-module ((guix licenses) #:select (bsd-3 lgpl2.1))
> +  #:use-module ((guix licenses) #:select (bsd-3 lgpl2.1 expat))
>    #:use-module (guix packages)
>    #:use-module (guix download)
>    #:use-module (guix utils)
> @@ -592,6 +592,29 @@ for encoding UTF8 strings to Word8 lists and back, and for reading and writing
>  UTF8 without truncation.")
>      (license bsd-3)))
>  
> +(define-public ghc-setenv
> +  (package
> +    (name "ghc-setenv")
> +    (version "0.1.1.3")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append
> +             "http://hackage.haskell.org/package/setenv/setenv-"
> +             version
> +             ".tar.gz"))
> +       (sha256
> +        (base32
> +         "0cnbgrvb9byyahb37zlqrj05rj25v190crgcw8wmlgf0mwwxyn73"))))
> +    (build-system haskell-build-system)
> +    (home-page
> +     "http://hackage.haskell.org/package/setenv")

Please put the string on the same line as a field name.

> +    (synopsis
> +     "A cross-platform library for setting environment variables")

Ditto.  (Note: A realize the patch on the wip-haskell-platform-7.10.2-a
is slightly different, but the same issues are there)

> +    (description
> +     "A cross-platform library for setting environment variables.")

In both the synopsis and the description, we don't really care about
the "cross-platform" nature of this package.  Could you adjust the
wording a bit?

`~Eric