From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eric Bavier <ericbavier@openmailbox.org>
Subject: Re: [PATCH 13/43] gnu: ghc-old-time: Add variable.
Date: Mon, 19 Oct 2015 08:46:37 -0500
Message-ID: <20151019084637.3cf8a0e2@openmailbox.org>
References: <1444911697-15515-1-git-send-email-paul@denknerd.org>
	<1444911697-15515-13-git-send-email-paul@denknerd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60153)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ericbavier@openmailbox.org>) id 1ZoFLH-0003y6-Ac
	for guix-devel@gnu.org; Mon, 19 Oct 2015 14:39:32 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ericbavier@openmailbox.org>) id 1ZoFLD-0004cE-AO
	for guix-devel@gnu.org; Mon, 19 Oct 2015 14:39:31 -0400
Received: from smtp16.openmailbox.org ([62.4.1.50]:48112)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ericbavier@openmailbox.org>) id 1ZoFLD-0004bx-1I
	for guix-devel@gnu.org; Mon, 19 Oct 2015 14:39:27 -0400
In-Reply-To: <1444911697-15515-13-git-send-email-paul@denknerd.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Paul van der Walt <paul@denknerd.org>
Cc: guix-devel@gnu.org

First line of commit message should rather be:

"gnu: Add ghc-old-time"

On Thu, 15 Oct 2015 14:21:07 +0200
Paul van der Walt <paul@denknerd.org> wrote:

> * gnu/packages/haskell.scm (ghc-old-time): New variable.
> ---
>  gnu/packages/haskell.scm | 36 ++++++++++++++++++++++++++++++++++++
>  1 file changed, 36 insertions(+)
> 
> diff --git a/gnu/packages/haskell.scm b/gnu/packages/haskell.scm
> index 7950d7e..2b607d1 100644
> --- a/gnu/packages/haskell.scm
> +++ b/gnu/packages/haskell.scm
> @@ -386,6 +386,42 @@ provides instances for types from the base, containers, dlist and old-locale
>  packages.")
>      (license bsd-3)))
>  
> +(define-public ghc-old-time
> +  (package
> +    (name "ghc-old-time")
> +    (version "1.1.0.3")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append
> +             "http://hackage.haskell.org/package/old-time/old-time-"
> +             version
> +             ".tar.gz"))
> +       (sha256
> +        (base32
> +         "1h9b26s3kfh2k0ih4383w90ibji6n0iwamxp6rfp2lbq1y5ibjqw"))))
> +    (build-system haskell-build-system)
> +    (arguments
> +     `(#:phases
> +       (alist-cons-before
> +        'configure 'fix-/bin/sh
> +        (lambda _
> +          ;; Use `sh', not `/bin/sh'.
> +          (substitute* (find-files "." "Makefile|configure")
> +            (("/bin/sh")
> +             "sh")))

Is this not already handled by the 'patch-source-shebangs' and
'patch-generated-file-shebangs' phases?

This package is used in the "gnu: ghc-xmonad-contrib: Update to
version 0.11.4." patch, so it should be moved before it.

`~Eric