* Re: 01/02: gnu: libbluray: Upgrade to 0.9.1.
[not found] ` <E1ZjRFx-0006O7-AY@vcs.savannah.gnu.org>
@ 2015-10-06 16:28 ` Ludovic Courtès
2015-10-06 17:28 ` Efraim Flashner
2015-10-06 17:41 ` Andreas Enge
0 siblings, 2 replies; 6+ messages in thread
From: Ludovic Courtès @ 2015-10-06 16:28 UTC (permalink / raw)
To: Efraim Flashner; +Cc: guix-devel
Efraim Flashner <efraim@flashner.co.il> skribis:
> commit 3f9f176b3a98a8c7dedb40f7fd14e8b5b3f45906
> Author: Efraim Flashner <efraim@flashner.co.il>
> Date: Tue Oct 6 15:04:12 2015 +0300
>
> gnu: libbluray: Upgrade to 0.9.1.
>
> * gnu/packages/video.scm (libbluray): Upgrade to 0.9.1.
> [inputs]: Add "ant" and "icedtea7" to native-inputs.
> [arguments]: Set environment variable "JAVA_HOME".
Do you know what libbluray uses Java for?
I think it would be good to be able to watch videos without having to
pull Icedtea and its dependencies, if possible.
Thanks,
Ludo’.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: 01/02: gnu: libbluray: Upgrade to 0.9.1.
2015-10-06 16:28 ` 01/02: gnu: libbluray: Upgrade to 0.9.1 Ludovic Courtès
@ 2015-10-06 17:28 ` Efraim Flashner
2015-10-06 19:25 ` Ludovic Courtès
2015-10-06 17:41 ` Andreas Enge
1 sibling, 1 reply; 6+ messages in thread
From: Efraim Flashner @ 2015-10-06 17:28 UTC (permalink / raw)
To: Ludovic Courtès; +Cc: guix-devel
[-- Attachment #1.1: Type: text/plain, Size: 1605 bytes --]
On Tue, 06 Oct 2015 18:28:21 +0200
ludo@gnu.org (Ludovic Courtès) wrote:
> Efraim Flashner <efraim@flashner.co.il> skribis:
>
> > commit 3f9f176b3a98a8c7dedb40f7fd14e8b5b3f45906
> > Author: Efraim Flashner <efraim@flashner.co.il>
> > Date: Tue Oct 6 15:04:12 2015 +0300
> >
> > gnu: libbluray: Upgrade to 0.9.1.
> >
> > * gnu/packages/video.scm (libbluray): Upgrade to 0.9.1.
> > [inputs]: Add "ant" and "icedtea7" to native-inputs.
> > [arguments]: Set environment variable "JAVA_HOME".
>
> Do you know what libbluray uses Java for?
Truthfully, I'm not too sure. I have the commit for checking to make sure it
was available
(https://git.videolan.org/?p=libbluray.git;a=commitdiff;h=84ffa5d2e36a5b92dbd8cdeee1e9dc332dcf1b57)
and I've checked their mailinglist, but no discussion around it being there.
> I think it would be good to be able to watch videos without having to
> pull Icedtea and its dependencies, if possible.
Agreed, which is why I stuck it in native-inputs, drawing from java.scm as
inspiration.
> Thanks,
> Ludo’.
It turns out I typo'd in the commit message, the version is 0.9.0 and not
0.9.1. I dug around in configure.ac a bit more and found a flag to not
require ant and java at compile time, and would have the package at the same
state it was at pre-update in terms of java support.
-Efraim
--
Efraim Flashner <efraim@flashner.co.il> אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: 0001-gnu-libbluray-Remove-java-as-native-input.patch --]
[-- Type: text/x-patch, Size: 1779 bytes --]
From 2da45ebe56e4ac9821ae0f563346c97b3819d1df Mon Sep 17 00:00:00 2001
From: Efraim Flashner <efraim@flashner.co.il>
Date: Tue, 6 Oct 2015 20:22:09 +0300
Subject: [PATCH] gnu: libbluray: Remove java as native-input.
* gnu/packages/video.scm (libbluray)[inputs]: Remove "ant" and "icedtea"
as native-inputs.
[arguments]: Remove environmental variable "JAVA_HOME". Add configure
flag to disable java.
---
gnu/packages/video.scm | 13 ++-----------
1 file changed, 2 insertions(+), 11 deletions(-)
diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
index c36d7a8..5ec225e 100644
--- a/gnu/packages/video.scm
+++ b/gnu/packages/video.scm
@@ -51,7 +51,6 @@
#:use-module (gnu packages gnupg)
#:use-module (gnu packages gtk)
#:use-module (gnu packages image)
- #:use-module (gnu packages java)
#:use-module (gnu packages linux)
#:use-module (gnu packages lua)
#:use-module (gnu packages mp3)
@@ -823,16 +822,8 @@ YouTube.com and a few more sites.")
(base32
"0kb9znxk6610vi0fjhqxn4z5i98nvxlsz1f8dakj99rg42livdl4"))))
(build-system gnu-build-system)
- (arguments
- `(#:phases
- (modify-phases %standard-phases
- (add-after 'configure 'java-home
- (lambda* (#:key inputs #:allow-other-keys)
- (setenv "JAVA_HOME" (assoc-ref inputs "icedtea7"))
- #t)))))
- (native-inputs `(("ant" ,ant)
- ("icedtea7" ,icedtea7 "jdk")
- ("pkg-config" ,pkg-config)))
+ (arguments `(#:configure-flags '("--disable-bdjava")))
+ (native-inputs `(("pkg-config" ,pkg-config)))
(inputs
`(("doxygen" ,doxygen)
("fontconfig" ,fontconfig)
--
2.6.1
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: 01/02: gnu: libbluray: Upgrade to 0.9.1.
2015-10-06 16:28 ` 01/02: gnu: libbluray: Upgrade to 0.9.1 Ludovic Courtès
2015-10-06 17:28 ` Efraim Flashner
@ 2015-10-06 17:41 ` Andreas Enge
2015-10-06 17:45 ` Efraim Flashner
1 sibling, 1 reply; 6+ messages in thread
From: Andreas Enge @ 2015-10-06 17:41 UTC (permalink / raw)
To: Ludovic Courtès; +Cc: guix-devel
On Tue, Oct 06, 2015 at 06:28:21PM +0200, Ludovic Courtès wrote:
> I think it would be good to be able to watch videos without having to
> pull Icedtea and its dependencies, if possible.
Notice that since icedtea does not build on arm, this update prevents
compilation of essentially all video playing software on arm:
http://hydra.gnu.org/eval/107331#tabs-now-fail
Also, if the added inputs are not strictly necessary for the update, it
would have been preferable to create two commits.
Andreas
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: 01/02: gnu: libbluray: Upgrade to 0.9.1.
2015-10-06 17:41 ` Andreas Enge
@ 2015-10-06 17:45 ` Efraim Flashner
2015-10-06 18:28 ` Andreas Enge
0 siblings, 1 reply; 6+ messages in thread
From: Efraim Flashner @ 2015-10-06 17:45 UTC (permalink / raw)
To: Andreas Enge; +Cc: guix-devel
[-- Attachment #1: Type: text/plain, Size: 935 bytes --]
On Tue, 6 Oct 2015 19:41:32 +0200
Andreas Enge <andreas@enge.fr> wrote:
> On Tue, Oct 06, 2015 at 06:28:21PM +0200, Ludovic Courtès wrote:
> > I think it would be good to be able to watch videos without having to
> > pull Icedtea and its dependencies, if possible.
>
> Notice that since icedtea does not build on arm, this update prevents
> compilation of essentially all video playing software on arm:
> http://hydra.gnu.org/eval/107331#tabs-now-fail
Yikes! Thats not good at all. That seems like a really good reason to apply
the second patch to take out java and put in the compile flag.
> Also, if the added inputs are not strictly necessary for the update, it
> would have been preferable to create two commits.
I was not as thorough as I should've been during the update process, and I
didn't see the compile flag until after, so at the time I believed it was
necessary.
> Andreas
>
-Efraim
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: 01/02: gnu: libbluray: Upgrade to 0.9.1.
2015-10-06 17:45 ` Efraim Flashner
@ 2015-10-06 18:28 ` Andreas Enge
0 siblings, 0 replies; 6+ messages in thread
From: Andreas Enge @ 2015-10-06 18:28 UTC (permalink / raw)
To: Efraim Flashner; +Cc: guix-devel
On Tue, Oct 06, 2015 at 08:45:44PM +0300, Efraim Flashner wrote:
> Yikes! Thats not good at all. That seems like a really good reason to apply
> the second patch to take out java and put in the compile flag.
Very well, thanks for your quick reaction!
Andreas
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: 01/02: gnu: libbluray: Upgrade to 0.9.1.
2015-10-06 17:28 ` Efraim Flashner
@ 2015-10-06 19:25 ` Ludovic Courtès
0 siblings, 0 replies; 6+ messages in thread
From: Ludovic Courtès @ 2015-10-06 19:25 UTC (permalink / raw)
To: Efraim Flashner; +Cc: guix-devel
Efraim Flashner <efraim@flashner.co.il> skribis:
> On Tue, 06 Oct 2015 18:28:21 +0200
> ludo@gnu.org (Ludovic Courtès) wrote:
>
>> Efraim Flashner <efraim@flashner.co.il> skribis:
>>
>> > commit 3f9f176b3a98a8c7dedb40f7fd14e8b5b3f45906
>> > Author: Efraim Flashner <efraim@flashner.co.il>
>> > Date: Tue Oct 6 15:04:12 2015 +0300
>> >
>> > gnu: libbluray: Upgrade to 0.9.1.
>> >
>> > * gnu/packages/video.scm (libbluray): Upgrade to 0.9.1.
>> > [inputs]: Add "ant" and "icedtea7" to native-inputs.
>> > [arguments]: Set environment variable "JAVA_HOME".
>>
>> Do you know what libbluray uses Java for?
>
> Truthfully, I'm not too sure. I have the commit for checking to make sure it
> was available
> (https://git.videolan.org/?p=libbluray.git;a=commitdiff;h=84ffa5d2e36a5b92dbd8cdeee1e9dc332dcf1b57)
> and I've checked their mailinglist, but no discussion around it being there.
Apparently BD-J is something that “allows bonus content on Blu-ray Disc
titles to be far more sophisticated than bonus content provided by
standard DVD”:
https://en.wikipedia.org/wiki/BD-J
If this eventually turns out to be common and/or desired, we could maybe
add a separate variant of libbluray that includes this feature.
> From 2da45ebe56e4ac9821ae0f563346c97b3819d1df Mon Sep 17 00:00:00 2001
> From: Efraim Flashner <efraim@flashner.co.il>
> Date: Tue, 6 Oct 2015 20:22:09 +0300
> Subject: [PATCH] gnu: libbluray: Remove java as native-input.
>
> * gnu/packages/video.scm (libbluray)[inputs]: Remove "ant" and "icedtea"
> as native-inputs.
> [arguments]: Remove environmental variable "JAVA_HOME". Add configure
> flag to disable java.
LGTM, thanks!
Ludo’.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-10-06 21:20 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20151006122208.24501.87369@vcs.savannah.gnu.org>
[not found] ` <E1ZjRFx-0006O7-AY@vcs.savannah.gnu.org>
2015-10-06 16:28 ` 01/02: gnu: libbluray: Upgrade to 0.9.1 Ludovic Courtès
2015-10-06 17:28 ` Efraim Flashner
2015-10-06 19:25 ` Ludovic Courtès
2015-10-06 17:41 ` Andreas Enge
2015-10-06 17:45 ` Efraim Flashner
2015-10-06 18:28 ` Andreas Enge
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.