[PATCH] gnu: qt-4: Disable webkit build.

[PATCH] gnu: qt-4: Disable webkit build.

[Andreas Enge]

[-- Attachment #1: Type: text/plain, Size: 240 bytes --]

Hello,

the attached patch removes the webkit module from qt-4, in the same spirit
as removing chromium from qt-5 some time ago. My main motivation was to work
around the build failure on armhf; the patched qt-4 now builds there.

Andreas


[-- Attachment #2: 0001-gnu-qt-4-Disable-webkit-build.patch --]
[-- Type: text/plain, Size: 1124 bytes --]

From 0da0716aea020d0b053fe1dab6b66d7de6cbd18c Mon Sep 17 00:00:00 2001
From: Andreas Enge <andreas@enge.fr>
Date: Sun, 4 Oct 2015 00:51:21 +0200
Subject: [PATCH] gnu: qt-4: Disable webkit build.

* gnu/packages/qt.scm (qt-4)[arguments]: Add configure flag to disable
  building the webkit module.
---
 gnu/packages/qt.scm | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/gnu/packages/qt.scm b/gnu/packages/qt.scm
index ce5ab65..7699ee8 100644
--- a/gnu/packages/qt.scm
+++ b/gnu/packages/qt.scm
@@ -288,6 +288,9 @@ developers using C++ or QML, a CSS & JavaScript like language.")
                       "-confirm-license"
                       ;; explicitly link with dbus instead of dlopening it
                       "-dbus-linked"
+                      ;; Skip the webkit module; it fails to build on armhf
+                      ;; and, apart from that, may pose security risks.
+                      "-no-webkit"
                       ;; drop special machine instructions not supported
                       ;; on all instances of the target
                       ,@(if (string-prefix? "x86_64"
-- 
2.5.0

Re: [PATCH] gnu: qt-4: Disable webkit build.

[Ludovic Courtès]

Andreas Enge <andreas@enge.fr> skribis:

> the attached patch removes the webkit module from qt-4, in the same spirit
> as removing chromium from qt-5 some time ago. My main motivation was to work
> around the build failure on armhf; the patched qt-4 now builds there.

LGTM.  I think we should also rm -rf the code in a snippet.

Besides, would our WebKit be picked up if we added it as an input?

Please keep <http://bugs.gnu.org/21288> updated and mention it in the
commit log.

Thanks!

Ludo’.

Re: [PATCH] gnu: qt-4: Disable webkit build.

[Andreas Enge]

On Sun, Oct 04, 2015 at 10:15:26AM +0200, Ludovic Courtès wrote:
> LGTM.  I think we should also rm -rf the code in a snippet.

Good point.

> Besides, would our WebKit be picked up if we added it as an input?

I do not think so, I did not see any configure option of the kind.
Anyway, the real aim would be to get rid of qt-4 altogether; but we have
a few packages that still require it and that have no new version that
could be compiled with qt-5.

> Please keep <http://bugs.gnu.org/21288> updated and mention it in the
> commit log.

Will do, although, as mentioned above, I would only consider progress on
qt-5 as real progress.

Andreas

Re: [PATCH] gnu: qt-4: Disable webkit build.

[Ludovic Courtès]

Andreas Enge <andreas@enge.fr> skribis:

> Will do, although, as mentioned above, I would only consider progress on
> qt-5 as real progress.

Yes, but Qt 4 will not disappear overnight; currently there is 1.8 times
more packages using Qt 4 than Qt 5.

Thanks,
Ludo’.