From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andreas Enge Subject: Re: [PATCH] gnu: openblas: Fix configure flags on armhf and take target Date: Fri, 2 Oct 2015 20:01:07 +0200 Message-ID: <20151002180107.GA4868@debian> References: <20151001084613.GA6497@debian> <87twqar0c8.fsf@netris.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:38383) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zi4eT-0008NM-MG for guix-devel@gnu.org; Fri, 02 Oct 2015 14:01:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zi4eO-0002Nk-4i for guix-devel@gnu.org; Fri, 02 Oct 2015 14:01:49 -0400 Received: from mout.kundenserver.de ([212.227.126.130]:59715) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zi4eN-0002Nf-Ri for guix-devel@gnu.org; Fri, 02 Oct 2015 14:01:44 -0400 Content-Disposition: inline In-Reply-To: <87twqar0c8.fsf@netris.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Mark H Weaver Cc: guix-devel@gnu.org Hi Mark, On Thu, Oct 01, 2015 at 12:59:51PM -0400, Mark H Weaver wrote: > It's not your fault, but the fact that (%current-system) returns a > "system" string (e.g. "mips64el-linux") but (%current-target-system) > returns a GNU triplet (e.g. "mips64el-unknown-linux-gnu") is very > confusing. The fact that we use (or (%current-target-system) > (%current-system)) in many places, and name variables like the one > above "system" reinforces that confusion. > > To mitigate this, how about renaming the variable above to > 'system-or-triplet'? sorry, your message arrived in my inbox right after I pushed the patch. > Another possible issue is that our Hurd port seems to use "i586" in > several places. I'm not sure if we have to check for that as well. > Maybe we need a helper procedure to check for Intel systems. First one would need to know what will happen on hurd, after that, this might be a good idea. Andreas