all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Andreas Enge <andreas@enge.fr>
To: Mark H Weaver <mhw@netris.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: openblas: Fix configure flags on armhf and take target
Date: Fri, 2 Oct 2015 20:01:07 +0200	[thread overview]
Message-ID: <20151002180107.GA4868@debian> (raw)
In-Reply-To: <87twqar0c8.fsf@netris.org>

Hi Mark,

On Thu, Oct 01, 2015 at 12:59:51PM -0400, Mark H Weaver wrote:
> It's not your fault, but the fact that (%current-system) returns a
> "system" string (e.g. "mips64el-linux") but (%current-target-system)
> returns a GNU triplet (e.g. "mips64el-unknown-linux-gnu") is very
> confusing.  The fact that we use (or (%current-target-system)
> (%current-system)) in many places, and name variables like the one
> above "system" reinforces that confusion.
> 
> To mitigate this, how about renaming the variable above to
> 'system-or-triplet'?

sorry, your message arrived in my inbox right after I pushed the patch.

> Another possible issue is that our Hurd port seems to use "i586" in
> several places.  I'm not sure if we have to check for that as well.
> Maybe we need a helper procedure to check for Intel systems.

First one would need to know what will happen on hurd, after that, this
might be a good idea.

Andreas

  parent reply	other threads:[~2015-10-02 18:01 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-01  8:46 [PATCH] gnu: openblas: Fix configure flags on armhf and take target Andreas Enge
2015-10-01 13:25 ` Ludovic Courtès
2015-10-01 17:36   ` Andreas Enge
2015-10-01 16:59 ` Mark H Weaver
2015-10-01 20:50   ` Ludovic Courtès
2015-10-02 18:01   ` Andreas Enge [this message]
2015-10-13  6:20   ` Ricardo Wurmus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151002180107.GA4868@debian \
    --to=andreas@enge.fr \
    --cc=guix-devel@gnu.org \
    --cc=mhw@netris.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.