From mboxrd@z Thu Jan  1 00:00:00 1970
From: Pjotr Prins <pjotr.public12@thebird.nl>
Subject: Re: [PATCH 2/2] gnu: Add ruby-simplecov.
Date: Thu, 17 Sep 2015 07:20:45 +0200
Message-ID: <20150917052045.GB9866@thebird.nl>
References: <55f8ead6.KirY0UdOBnhexzdH%pjotr.public12@thebird.nl>
	<87oah27lnp.fsf@elephly.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36454)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pjotr2015@thebird.nl>) id 1ZcRek-0000y6-GZ
	for guix-devel@gnu.org; Thu, 17 Sep 2015 01:22:51 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pjotr2015@thebird.nl>) id 1ZcReh-0007or-C7
	for guix-devel@gnu.org; Thu, 17 Sep 2015 01:22:50 -0400
Received: from mail.thebird.nl ([95.154.246.10]:58232)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pjotr2015@thebird.nl>) id 1ZcReh-0007og-6M
	for guix-devel@gnu.org; Thu, 17 Sep 2015 01:22:47 -0400
Content-Disposition: inline
In-Reply-To: <87oah27lnp.fsf@elephly.net>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Ricardo Wurmus <rekado@elephly.net>
Cc: guix-devel@gnu.org

The dependency is only for those cases that use HTML output. I am
using it for cucumber which don't needs it. Feel free to put in the
dependency. And push it.

Pj.


On Wed, Sep 16, 2015 at 11:34:18AM +0200, Ricardo Wurmus wrote:
> Hi Pjotr,
>=20
> > * gnu/packages/ruby.scm (ruby-simplecov): New variable.
>=20
> [...]
>=20
> > +  (propagated-inputs
> > +    `(("ruby-docile" ,ruby-docile)
> > +      ("ruby-json" ,ruby-json)))
> > +    (arguments
> > +     '(#:tests? #f)) ; needs github-markup, among others
> > +  (synopsis "Code coverage for Ruby")
>=20
> I find it very surprising to see only =E2=80=9Cdocile=E2=80=9D and =E2=80=
=9Cjson=E2=80=9D as inputs and
> not =E2=80=9Cruby-simplecov-html=E2=80=9D.  According to
> https://rubygems.org/gems/simplecov =E2=80=9Csimplecov-html=E2=80=9D is=
 a runtime
> dependency.
>=20
> With my Ruby packages I=E2=80=99ve been closely following the dependenc=
ies as
> they are declared on rubygems.org.
>=20
> I=E2=80=99ve sent a patch to add =E2=80=9Cruby-simplecov-html=E2=80=9D =
to the ML a couple of
> minutes ago, so maybe you could update your patch and add it as an
> input.
>=20
> > +  (description "Code coverage analysis tool for Ruby.  It uses Ruby'=
s
> > +built-in Coverage library to gather code coverage data, but makes
> > +processing its results much easier by providing a clean API to filte=
r,
> > +group, merge, format, and display those results, giving you a comple=
te
> > +code coverage suite that can be set up with just a couple lines of
> > +code.
> > +")
>=20
> The closing quote and the closing parenthesis should be on the same lin=
e
> as the period.  The rest looks good to me.
>=20
> ~~ Ricardo
>=20

--=20