From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pjotr Prins Subject: Re: [PATCH] gnu: Add ruby-bio-logger. Date: Thu, 17 Sep 2015 07:12:03 +0200 Message-ID: <20150917051203.GA9800@thebird.nl> References: <55f907bb.9/Upvwvparw1Ma9U%pjotr.public12@thebird.nl> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="gKMricLos+KVdGMg" Content-Transfer-Encoding: 7bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:34763) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZcRWR-0008KW-LK for guix-devel@gnu.org; Thu, 17 Sep 2015 01:14:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZcRWO-0003Eo-B0 for guix-devel@gnu.org; Thu, 17 Sep 2015 01:14:15 -0400 Received: from mail.thebird.nl ([95.154.246.10]:57900) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZcRWO-0003B0-2y for guix-devel@gnu.org; Thu, 17 Sep 2015 01:14:12 -0400 Content-Disposition: inline In-Reply-To: List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Ricardo Wurmus Cc: guix-devel@gnu.org --gKMricLos+KVdGMg Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hopefully OK now. On Wed, Sep 16, 2015 at 06:02:59PM +0200, Ricardo Wurmus wrote: > Hi Pjotr, >=20 > > * gnu/packages/ruby.scm (ruby-bio-logger): New variable. >=20 > [...] > =20 > > +(define-public ruby-bio-logger > > + (package > > + (name "ruby-bio-logger") > > + (version "1.0.1") > > + (source > > + (origin > > + (method url-fetch) > > + (uri (rubygems-uri "bio-logger" version)) > > + (sha256 > > + (base32 > > + "02pylfy8nkdqzyzplvnhn1crzmfkj1zmi3qjhrj2f2imlxvycd28"))= )) >=20 > This opening quote of this string should be aligned with the =E2=80=9Cb= =E2=80=9D in > =E2=80=9Cbase64=E2=80=9D. Likewise, the opening parenthesis of =E2=80=9C= (base32 ...)=E2=80=9D should be > aligned with the =E2=80=9Cs=E2=80=9D in =E2=80=9C(sha256 ...)=E2=80=9D,= and =E2=80=9C(origin=E2=80=9D should be aligned > with the =E2=80=9Cs=E2=80=9D of =E2=80=9C(source=E2=80=9D. >=20 > Are you using Emacs to indent? In many cases you can just use =E2=80=98= M-x > indent-sexp=E2=80=99. >=20 > > + (build-system ruby-build-system) > > + (propagated-inputs `(("ruby-log4r" ,ruby-log4r))) > > + (arguments > > + '(#:tests? #f)) ; no test suite > > + (synopsis "Log4r wrapper for Ruby with extra features") > > + (description "Library with extra logging features on top of > > +ruby-log4r (not specific to bioinformatics)") >=20 > This is not a complete description as it is not a full sentence. A > minimal description might be >=20 > =E2=80=9CBio-logger is a wrapper around Log4r adding extra logging fe= atures > such as x, y, and z.=E2=80=9D >=20 > The README at the Github site is rather detailed; mentioning a few of > the added features in the description would be nice. >=20 > > + (home-page "https://github.com/pjotrp/bioruby-logger-plugin") > > + (license license:expat))) > > + > > (define-public ruby-atoulme-antwrap > > (package > > (name "ruby-atoulme-antwrap") >=20 > ~~ Ricardo >=20 --=20 --gKMricLos+KVdGMg Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0001-gnu-Add-ruby-bio-logger.patch" >From 4acfc340705bd2a9e91f9b7a74ccf93a27185b17 Mon Sep 17 00:00:00 2001 Date: Wed, 16 Sep 2015 06:06:26 +0000 Subject: [PATCH] gnu: Add ruby-bio-logger. To: guix-devel@gnu.org From: Pjotr Prins * gnu/packages/ruby.scm (ruby-bio-logger): New variable. --- gnu/packages/ruby.scm | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/gnu/packages/ruby.scm b/gnu/packages/ruby.scm index 7dc46b6..be44bed 100644 --- a/gnu/packages/ruby.scm +++ b/gnu/packages/ruby.scm @@ -1147,3 +1147,22 @@ It is intended to replace Gherkin 2 and be used by all Cucumber implementations to parse '.feature' files.") (home-page "https://github.com/cucumber/gherkin3") (license license:expat))) + +(define-public ruby-bio-logger + (package + (name "ruby-bio-logger") + (version "1.0.1") + (source + (origin + (method url-fetch) + (uri (rubygems-uri "bio-logger" version)) + (sha256 + (base32 + "02pylfy8nkdqzyzplvnhn1crzmfkj1zmi3qjhrj2f2imlxvycd28")))) + (build-system ruby-build-system) + (propagated-inputs `(("ruby-log4r" ,ruby-log4r))) + (synopsis "Log4r wrapper for Ruby") + (description "Bio-logger is a wrapper around Log4r adding extra +logging features such as filtering and fine grained logging.") + (home-page "https://github.com/pjotrp/bioruby-logger-plugin") + (license license:expat))) -- 2.4.3 --gKMricLos+KVdGMg--