From mboxrd@z Thu Jan 1 00:00:00 1970 From: Efraim Flashner Subject: Re: [PATCH] gnu: Add keepassx. Date: Wed, 16 Sep 2015 21:56:25 +0300 Message-ID: <20150916215625.3a99aadf@debian-netbook> References: <1442398930-4941-1-git-send-email-efraim@flashner.co.il> <20150916140203.26ff781e@debian-netbook> <87d1ximfqn.fsf@openmailbox.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/TXvwweWnAkT5/Xfi1Tejrd6"; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:35824) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZcHsz-0003FO-RD for guix-devel@gnu.org; Wed, 16 Sep 2015 14:56:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZcHsv-0003is-NE for guix-devel@gnu.org; Wed, 16 Sep 2015 14:56:53 -0400 Received: from [178.62.234.194] (port=40934 helo=flashner.co.il) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZcHsv-0003ig-E2 for guix-devel@gnu.org; Wed, 16 Sep 2015 14:56:49 -0400 In-Reply-To: <87d1ximfqn.fsf@openmailbox.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: guix-devel@gnu.org --Sig_/TXvwweWnAkT5/Xfi1Tejrd6 Content-Type: multipart/mixed; boundary="MP_/ysStBLTPQjAxl3YjwlJyHQ." --MP_/ysStBLTPQjAxl3YjwlJyHQ. Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On Wed, 16 Sep 2015 19:33:04 +0200 Mathieu Lirzin wrote: > Efraim Flashner writes: >=20 > > Efraim Flashner wrote: > > > >> * gnu/packages/password-utils.scm (keepassx): New variable. >=20 > [...] >=20 > >> +(define-public keepassx > >> + (package > >> + (name "keepassx") > >> + (version "2.0-beta2") > ^^^ > Any reason why you don't choose the stable version 0.4.3 ? If it builds > correctly on guix, we should use it instead and change the name of this > package definition to "keepassx-2". keepass 0.4.3 was released in March 2010 https://www.keepassx.org/news/2010/03/213. work on 2.0 started that Septemb= er and has progressed slowly since then. The android port accepts version 1 or= 2 of .kdb files. also building 0.4.3 failed for me with the following error: /tmp/nix-build-keepassx-0.4.3.drv-0/keepassx-0.4.3/src/lib/random.cpp: In function ?void initStdRand()?: /tmp/nix-build-keepassx-0.4.3.drv-0/keepassx-0.4.3/src/lib/random.cpp:98:19: error: ?getpid? was not declared in this scope stream << getpid(); ^ src/CMakeFiles/keepassx.dir/build.make:611: recipe for target 'src/CMakeFiles/keepassx.dir/lib/random.cpp.o' failed make[2]: *** [src/CMakeFiles/keepassx.dir/lib/random.cpp.o] Error 1 make[2]: *** Waiting for unfinished jobs.... make[2]: Leaving directory '/tmp/nix-build-keepassx-0.4.3.drv-0/build' CMakeFiles/Makefile2:81: recipe for target 'src/CMakeFiles/keepassx.dir/all' failed make[1]: *** [src/CMakeFiles/keepassx.dir/all] Error 2 make[1]: Leaving directory '/tmp/nix-build-keepassx-0.4.3.drv-0/build' Makefile:119: recipe for target 'all' failed make: *** [all] Error 2 phase `build' failed after 47 seconds >=20 > >> + (source > >> + (origin > >> + (method url-fetch) > >> + (uri (string-append > >> "https://github.com/keepassx/keepassx/archive/" > >> + version ".tar.gz")) > >> + (sha256 > >> + (base32 > >> "0ljf9ws3wh62zd0gyb0vk2qw6pqsmxrlybrfs5mqahf44q92ca2q")))) >=20 > Guix lint is complaining about bad filename for the tarball, can you add > this? >=20 > (file-name (string-append name "-" version ".tar.gz")) i'm normally better about spotting that >=20 > >> + (description " [...] You can put all your passwords in > >> one database, which is locked with one master key or a thumb-drive. Y= ou > >> only have to remember one single master password or insert the > >> thumb-drive to unlock the whole database. [...] ") >=20 > This two sentences seems redundant, what about something like this? >=20 > "You can put all your passwords in one database, which is locked with o= ne > master key or a key-file which can be stored on an external storage > device." >=20 fixed. >=20 > >> + (license (list license:gpl2 license:gpl3)))) >=20 > 'COPYING' indicate this. >=20 > --8<---------------cut here---------------start------------->8--- > This program is free software: you can redistribute it and/or modify > it under the terms of the GNU General Public License as published by > the Free Software Foundation, either version 2 or (at your option) > version 3 of the License. > --8<---------------cut here---------------end--------------->8--- >=20 > And in 'LICENSE.GPL-3' you can find the "or later" so I think it's ok to > indicate only "license:gpl3+" like this >=20 > ;; Non functional parts use various licences. > (license license:gpl3+) I went with: ;; Non functional parts use various licenses. (license license:gpl3) as discussed further on. >=20 > Can you send an updated patch? >=20 > Thanks for your contribution, >=20 > -- > Mathieu Lirzin :) --=20 Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7=9D = =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --MP_/ysStBLTPQjAxl3YjwlJyHQ. Content-Type: text/x-patch Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename=0001-gnu-Add-keepassx.patch =46rom 2ac1cfa2b08eb98923c90b24a79ef97a3a931d7d Mon Sep 17 00:00:00 2001 From: Efraim Flashner Date: Wed, 16 Sep 2015 13:18:40 +0300 Subject: [PATCH] gnu: Add keepassx. * gnu/packages/password-utils.scm (keepassx): New variable. --- gnu/packages/password-utils.scm | 37 ++++++++++++++++++++++++++++++++++++- 1 file changed, 36 insertions(+), 1 deletion(-) diff --git a/gnu/packages/password-utils.scm b/gnu/packages/password-utils.= scm index 4aef371..78dfeff 100644 --- a/gnu/packages/password-utils.scm +++ b/gnu/packages/password-utils.scm @@ -1,5 +1,6 @@ ;;; GNU Guix --- Functional package management for GNU ;;; Copyright =C2=A9 2015 Steve Sprang +;;; Copyright =C2=A9 2015 Efraim Flashner ;;; ;;; This file is part of GNU Guix. ;;; @@ -19,8 +20,13 @@ (define-module (gnu packages password-utils) #:use-module ((guix licenses) #:prefix license:) #:use-module (guix build-system gnu) + #:use-module (guix build-system cmake) #:use-module (guix download) - #:use-module (guix packages)) + #:use-module (guix packages) + #:use-module (gnu packages compression) + #:use-module (gnu packages gnupg) + #:use-module (gnu packages qt) + #:use-module (gnu packages xorg)) =20 (define-public pwgen (package @@ -41,3 +47,32 @@ (description "Pwgen generates passwords which can be easily memorized = by a human.") (license license:gpl2))) + +(define-public keepassx + (package + (name "keepassx") + (version "2.0-beta2") + (source + (origin + (method url-fetch) + (uri (string-append "https://github.com/keepassx/keepassx/archive/" + version ".tar.gz")) + (file-name (string-append name "-" version ".tar.gz")) + (sha256 + (base32 "0ljf9ws3wh62zd0gyb0vk2qw6pqsmxrlybrfs5mqahf44q92ca2q")))) + (build-system cmake-build-system) + (inputs + `(("libgcrypt" ,libgcrypt) + ("libxtst" ,libxtst) + ("qt" ,qt-4))) + (native-inputs + `(("zlib" ,zlib))) + (home-page "https://www.keepassx.org") + (synopsis "Password manager") + (description "KeePassX is a password manager or safe which helps you to +manage your passwords in a secure way. You can put all your passwords in = one +database, which is locked with one master key or a key-file which can be s= tored +on an external storage device. The databases are encrypted using the +algorithms AES or Twofish.") + ;; Non functional parts use various licences. + (license license:gpl3))) --=20 2.5.1 --MP_/ysStBLTPQjAxl3YjwlJyHQ.-- --Sig_/TXvwweWnAkT5/Xfi1Tejrd6 Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCgAGBQJV+btZAAoJEPTB05F+rO6TLx8P/il5z0sr8RTIpUwXc/p898PF 7MYr0LgpTO6Co2YNaeXV8FK7G6GNoYYxR4lEi2E+3gCQcF+2O/1m5HW+FN2jINiy h3Ha9Dj73m7DQuCnkX8eLJQlUUo8EATSaxwOg1LsNBgSAXBPUfJkvz9ZjaNPZq7R rWly3YAU7w8amJKHZS4bgNwEWBgLRFeMEqfp0GqfwQdoTYbPV3hW5Bn6x3pCc2/p OHo0Y/cg8LWyPu96rRmh+0Hpas6gn9KvsU8Wn6XQIeYldhEDnk+l6uQ9ncy9TOcA TN94QBwrR9+LiC7xxmrWuGTn9pXXLwQ0n3h80U89iyedqVVeiLZ6H9+szYepoaXH uXj6AEdU1sUCwCJaBt1SPpa3sclFWDezuS6A8AnYWiq7A4AGmwa0ffoRM9RzTeAe c9topws+/Ruk62sTpDiADEZXgt3V4zopSdKdNZxM2bHKyXWnxEVt79JyqMHPpQz1 X98FAXIcNnc54rHFnVtSiO44hwa+AiHrkBxtYeyW2p0+xnqNYcQw/KsbOSCWlV6p Yn0KtZCfUB+/Sk3eLiTijxAlMu/VOSAx0FOOM9P0Wj7RPq4zHMbgxhLlHC75KaDm sPVtzyHEwW9YIO7ucIU8OE7Ly/Jbs/y2hFY00X4y4jsll/NaOG5lDUvIwx5Y5bJ5 Ak2as6hPiWbjaaOUMybP =BlVJ -----END PGP SIGNATURE----- --Sig_/TXvwweWnAkT5/Xfi1Tejrd6--