On Wed, 16 Sep 2015 19:33:04 +0200
Mathieu Lirzin <mthl@openmailbox.org> wrote:

> Efraim Flashner <efraim@flashner.co.il> writes:
> 
> > Efraim Flashner <efraim@flashner.co.il> wrote:
> >
> >> * gnu/packages/password-utils.scm (keepassx): New variable.
> 
> [...]
> 
> >> +(define-public keepassx
> >> +  (package
> >> +    (name "keepassx")
> >> +    (version "2.0-beta2")
>                       ^^^
> Any reason why you don't choose the stable version 0.4.3 ? If it builds
> correctly on guix, we should use it instead and change the name of this
> package definition to "keepassx-2".

keepass 0.4.3 was released in March 2010
https://www.keepassx.org/news/2010/03/213. work on 2.0 started that September
and has progressed slowly since then. The android port accepts version 1 or 2
of .kdb files.

also building 0.4.3 failed for me with the following error:
/tmp/nix-build-keepassx-0.4.3.drv-0/keepassx-0.4.3/src/lib/random.cpp: In
function ?void initStdRand()?:
/tmp/nix-build-keepassx-0.4.3.drv-0/keepassx-0.4.3/src/lib/random.cpp:98:19:
error: ?getpid? was not declared in this scope
  stream << getpid();
                   ^
src/CMakeFiles/keepassx.dir/build.make:611: recipe for target
'src/CMakeFiles/keepassx.dir/lib/random.cpp.o' failed
make[2]: *** [src/CMakeFiles/keepassx.dir/lib/random.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[2]: Leaving directory '/tmp/nix-build-keepassx-0.4.3.drv-0/build'
CMakeFiles/Makefile2:81: recipe for target 'src/CMakeFiles/keepassx.dir/all'
failed
make[1]: *** [src/CMakeFiles/keepassx.dir/all] Error 2
make[1]: Leaving directory '/tmp/nix-build-keepassx-0.4.3.drv-0/build'
Makefile:119: recipe for target 'all' failed
make: *** [all] Error 2
phase `build' failed after 47 seconds


> 
> >> +    (source
> >> +     (origin
> >> +       (method url-fetch)
> >> +       (uri (string-append
> >> "https://github.com/keepassx/keepassx/archive/"
> >> +                           version ".tar.gz"))
> >> +       (sha256
> >> +        (base32
> >> "0ljf9ws3wh62zd0gyb0vk2qw6pqsmxrlybrfs5mqahf44q92ca2q"))))
> 
> Guix lint is complaining about bad filename for the tarball, can you add
> this?
> 
>        (file-name (string-append name "-" version ".tar.gz"))

i'm normally better about spotting that

> 
> >> + (description " [...] You can put all your passwords in
> >> one database, which is locked with one master key or a thumb-drive.  You
> >> only have to remember one single master password or insert the
> >> thumb-drive to unlock the whole database. [...] ")
> 
> This two sentences seems redundant, what about something like this?
> 
>   "You can put all your passwords in one database, which is locked with one
>   master key or a key-file which can be stored on an external storage
> device."
> 

fixed.

> 
> >> +    (license (list license:gpl2 license:gpl3))))
> 
> 'COPYING' indicate this.
> 
> --8<---------------cut here---------------start------------->8---
> This program is free software: you can redistribute it and/or modify
> it under the terms of the GNU General Public License as published by
> the Free Software Foundation, either version 2 or (at your option)
> version 3 of the License.
> --8<---------------cut here---------------end--------------->8---
> 
> And in 'LICENSE.GPL-3' you can find the "or later" so I think it's ok to
> indicate only "license:gpl3+" like this
> 
>   ;; Non functional parts use various licences.
>   (license license:gpl3+)

I went with:
;; Non functional parts use various licenses.
(license license:gpl3)
as discussed further on.

> 
> Can you send an updated patch?
> 
> Thanks for your contribution,
> 
> --
> Mathieu Lirzin

:)

-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted