From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Bavier Subject: Re: [PATCH 12/13] gnu: Add xmonad. Date: Fri, 11 Sep 2015 03:38:13 -0500 Message-ID: <20150911033813.410d1d97@openmailbox.org> References: <1439930415-16938-1-git-send-email-sinisa@bidin.eu> <1439930415-16938-13-git-send-email-sinisa@bidin.eu> <20150823154729.4dd46618@openmailbox.org> <5edb43e2e6528f1b73be2dc115907b68@bidin.eu> <87si6z5ubf.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:39379) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZaOQ9-0006mK-JQ for guix-devel@gnu.org; Fri, 11 Sep 2015 09:31:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZaOQ5-0002WH-Id for guix-devel@gnu.org; Fri, 11 Sep 2015 09:31:17 -0400 Received: from smtp27.openmailbox.org ([62.4.1.61]:37105) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZaOQ5-0002V8-A2 for guix-devel@gnu.org; Fri, 11 Sep 2015 09:31:13 -0400 In-Reply-To: <87si6z5ubf.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Ludovic =?UTF-8?B?Q291cnTDqHM=?= , =?UTF-8?B?U2luacWh?= =?UTF-8?B?YSBCacSRaW4=?= Cc: guix-devel@gnu.org On Mon, 31 Aug 2015 17:52:36 +0200 ludo@gnu.org (Ludovic Court=C3=A8s) wrote: > Sini=C5=A1a Bi=C4=91in skribis: >=20 > > On 2015-08-23 22:47, Eric Bavier wrote: > >> I had to replace "Exec=3D/etc/X11/Session/xmonad" with "Exec=3Dxmonad" > >> in this xmonad.desktop file in order to launch an xmonad session from > >> Slim. Does this seem right? > > > > Definitely! >=20 > [...] >=20 > >> Does it make sense to fetch this file > >> from gentoo.org and then modify it? or should we rather just > >> generate it > >> ourselves? What do you/others think? > > > > I had followed ratpoison's example (also using gentoo.org), but it does > > feel dirty. I'm fine with generating it or having it stored in guix's > > repo, > > but couldn't find an example of any other package doing the same. >=20 > I think =E2=80=9Cgenerating=E2=80=9D it (or having it as a string literal= ) in the source > is preferable. >=20 > >>> + (propagated-inputs > >>> + `(("ghc-mtl" ,ghc-mtl) > >>> + ("ghc-utf8-string" ,ghc-utf8-string) > >>> + ("ghc-extensible-exceptions" ,ghc-extensible-exceptions) > >>> + ("ghc-x11" ,ghc-x11))) > >> > >> Do these inputs need to be propagated? I can start up an xmonad > >> session without propagating these inputs. Do they need to be available > >> for xmonad's 'mod-q' (i.e. restarting xmonad/loading a new config)? > > > > I think so, yes. For one, since xmonad is an executable and a library, > > if > > we don't propagate, "ghc-pkg list" will report it as broken. >=20 > Makes sense to me. >=20 > Could you post an updated patch that addresses these two things? I've pushed a modified commit that generates the .desktop files for xmonad, and adds the package instead to gnu/packages/wm.scm. This Xmonad's mod-q does not work as expected, but that isn't a problem if you like the default configuration ;). Anyhow, some more work will need to be done to support reconfiguration. I had thought GHC_PACKAGE_PATH would do what we need, but it doesn't seem to do what I had thought. Perhaps creating a custom package database for xmonad to use would work. Thanks again for the patch, and sorry for the delay in getting it pushed! `~Eric