Re: [PATCH 12/13] gnu: Add xmonad.

[Eric Bavier <ericbavier@openmailbox.org>]

On Mon, 31 Aug 2015 17:52:36 +0200
ludo@gnu.org (Ludovic Courtès) wrote:

> Siniša Biđin <sinisa@bidin.eu> skribis:
> 
> > On 2015-08-23 22:47, Eric Bavier wrote:
> >> I had to replace "Exec=/etc/X11/Session/xmonad" with "Exec=xmonad"
> >> in this xmonad.desktop file in order to launch an xmonad session from
> >> Slim.  Does this seem right?
> >
> > Definitely!
> 
> [...]
> 
> >> Does it make sense to fetch this file
> >> from gentoo.org and then modify it? or should we rather just
> >> generate it
> >> ourselves?  What do you/others think?
> >
> > I had followed ratpoison's example (also using gentoo.org), but it does
> > feel dirty. I'm fine with generating it or having it stored in guix's
> > repo,
> > but couldn't find an example of any other package doing the same.
> 
> I think “generating” it (or having it as a string literal) in the source
> is preferable.
> 
> >>> +    (propagated-inputs
> >>> +     `(("ghc-mtl" ,ghc-mtl)
> >>> +       ("ghc-utf8-string" ,ghc-utf8-string)
> >>> +       ("ghc-extensible-exceptions" ,ghc-extensible-exceptions)
> >>> +       ("ghc-x11" ,ghc-x11)))
> >>
> >> Do these inputs need to be propagated?  I can start up an xmonad
> >> session without propagating these inputs.  Do they need to be available
> >> for xmonad's 'mod-q' (i.e. restarting xmonad/loading a new config)?
> >
> > I think so, yes. For one, since xmonad is an executable and a library,
> > if
> > we don't propagate, "ghc-pkg list" will report it as broken.
> 
> Makes sense to me.
> 
> Could you post an updated patch that addresses these two things?

I've pushed a modified commit that generates the .desktop files for
xmonad, and adds the package instead to gnu/packages/wm.scm.

This Xmonad's mod-q does not work as expected, but that isn't a problem
if you like the default configuration ;).  Anyhow, some more work will
need to be done to support reconfiguration.  I had thought
GHC_PACKAGE_PATH would do what we need, but it doesn't seem to do what
I had thought.  Perhaps creating a custom package database for xmonad
to use would work.

Thanks again for the patch, and sorry for the delay in getting it
pushed!
`~Eric