From mboxrd@z Thu Jan 1 00:00:00 1970 From: Efraim Flashner Subject: Re: [PATCH 1/2] gnu: Add eyed3. Date: Mon, 24 Aug 2015 21:54:35 +0300 Message-ID: <20150824215435.600c8e8a@debian-netbook> References: <20150817225715.79d7df3d@debian-netbook> <87wpwqs2zx.fsf@gmail.com> <20150821080856.GA12215@debian> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/Jh948QevHKt_s82rVK7wAsK"; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:36403) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZTwtM-0007Ca-Ke for guix-devel@gnu.org; Mon, 24 Aug 2015 14:54:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZTwtJ-0000TF-Cw for guix-devel@gnu.org; Mon, 24 Aug 2015 14:54:48 -0400 Received: from [178.62.234.194] (port=43915 helo=flashner.co.il) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZTwtJ-0000TA-4B for guix-devel@gnu.org; Mon, 24 Aug 2015 14:54:45 -0400 In-Reply-To: <20150821080856.GA12215@debian> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Andreas Enge Cc: guix-devel@gnu.org --Sig_/Jh948QevHKt_s82rVK7wAsK Content-Type: multipart/mixed; boundary="MP_/vRv7KxY49aZZHSCu_jkNjS_" --MP_/vRv7KxY49aZZHSCu_jkNjS_ Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On Fri, 21 Aug 2015 10:08:56 +0200 Andreas Enge wrote: > On Thu, Aug 20, 2015 at 05:50:10PM +0800, =E5=AE=8B=E6=96=87=E6=AD=A6 wro= te: > > eyeD3 is both a tool and python library, I wonder whether > > 'python-eyed3' fits better. >=20 > Usually when a package provides binaries we do not use the "python" prefi= x. > It would also depend on whether there is a "python-" and a "python2-" > variant. If not, this could be seen as an indication that the binary > characteristic is stronger than the library property. >=20 > Andreas >=20 output of apt-{cache,file} show eyeD3: efraim@debian-netbook:~$ apt-cache search eyed3 eyed3 - Display and manipulate id3-tags on the command-line python-eyed3 - Python module for id3-tags manipulation efraim@debian-netbook:~$ apt-file show eyed3 eyed3: /usr/bin/eyeD3 eyed3: /usr/share/doc/eyed3/changelog.Debian.gz eyed3: /usr/share/doc/eyed3/changelog.gz eyed3: /usr/share/doc/eyed3/copyright eyed3: /usr/share/man/man1/eyeD3.1.gz python-eyed3: /usr/lib/python2.6/dist-packages/eyeD3-0.6.18.egg-info python-eyed3: /usr/lib/python2.6/dist-packages/eyeD3/__init__.py python-eyed3: /usr/lib/python2.6/dist-packages/eyeD3/binfuncs.py python-eyed3: /usr/lib/python2.6/dist-packages/eyeD3/frames.py python-eyed3: /usr/lib/python2.6/dist-packages/eyeD3/mp3.py python-eyed3: /usr/lib/python2.6/dist-packages/eyeD3/tag.py python-eyed3: /usr/lib/python2.6/dist-packages/eyeD3/utils.py python-eyed3: /usr/lib/python2.7/dist-packages/eyeD3-0.6.18.egg-info python-eyed3: /usr/lib/python2.7/dist-packages/eyeD3/__init__.py python-eyed3: /usr/lib/python2.7/dist-packages/eyeD3/binfuncs.py python-eyed3: /usr/lib/python2.7/dist-packages/eyeD3/frames.py python-eyed3: /usr/lib/python2.7/dist-packages/eyeD3/mp3.py python-eyed3: /usr/lib/python2.7/dist-packages/eyeD3/tag.py python-eyed3: /usr/lib/python2.7/dist-packages/eyeD3/utils.py python-eyed3: /usr/share/doc/python-eyed3/NEWS.gz python-eyed3: /usr/share/doc/python-eyed3/README.gz python-eyed3: /usr/share/doc/python-eyed3/README.html python-eyed3: /usr/share/doc/python-eyed3/TODO python-eyed3: /usr/share/doc/python-eyed3/changelog.Debian.gz python-eyed3: /usr/share/doc/python-eyed3/changelog.gz python-eyed3: /usr/share/doc/python-eyed3/copyright python-eyed3: /usr/share/pyshared/eyeD3-0.6.18.egg-info python-eyed3: /usr/share/pyshared/eyeD3/__init__.py python-eyed3: /usr/share/pyshared/eyeD3/binfuncs.py python-eyed3: /usr/share/pyshared/eyeD3/frames.py python-eyed3: /usr/share/pyshared/eyeD3/mp3.py python-eyed3: /usr/share/pyshared/eyeD3/tag.py python-eyed3: /usr/share/pyshared/eyeD3/utils.py The only dependencies of eyed3 are python-eyed3 and python, python-eyed3's only dependency is python2.7, and both are from the same source package. I think having the package called eyed3 and not python-eyed3 is the better choice. I've attached a patch with 'license:gpl2' changed to 'license:gpl2+'. --=20 Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7=9D = =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --MP_/vRv7KxY49aZZHSCu_jkNjS_ Content-Type: text/x-patch Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename=gnu-Add-eyed3.patch =46rom bc64fc363e144ac26f6a6b34565a1827c2ce31cf Mon Sep 17 00:00:00 2001 From: Efraim Flashner Date: Mon, 17 Aug 2015 22:17:32 +0300 Subject: [PATCH] gnu: Add eyed3. * gnu/packages/mp3.scm (eyed3): New variable. --- gnu/packages/mp3.scm | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+) diff --git a/gnu/packages/mp3.scm b/gnu/packages/mp3.scm index ddd90fb..8f73a11 100644 --- a/gnu/packages/mp3.scm +++ b/gnu/packages/mp3.scm @@ -2,6 +2,7 @@ ;;; Copyright =C2=A9 2013 Andreas Enge ;;; Copyright =C2=A9 2014, 2015 Ludovic Court=C3=A8s ;;; Copyright =C2=A9 2015 Mark H Weaver +;;; Copyright =C2=A9 2015 Efraim Flashner ;;; ;;; This file is part of GNU Guix. ;;; @@ -39,6 +40,7 @@ #:use-module (guix packages) #:use-module (guix download) #:use-module (guix build-system gnu) + #:use-module (guix build-system python) #:use-module (guix build-system cmake)) =20 (define-public libmad @@ -450,3 +452,26 @@ format.") "Mpc123 is a command-line player for files in the Musepack audio compression format (.mpc files).") (license license:gpl2+))) + +(define-public eyed3 + (package + (name "eyed3") + (version "0.7.8") + (source (origin + (method url-fetch) + (uri (string-append "http://eyed3.nicfit.net/releases/eyeD3-" + version ".tar.gz")) + (sha256 + (base32 + "1nv7nhfn1d0qm7rgkzksbccgqisng8klf97np0nwaqwd5dbmdf86")))) + (build-system python-build-system) + (arguments + `(#:tests? #f)) ;fail with: UserWarning: Duplicate name: 'paver/shell= .py' + (home-page "http://eyed3.nicfit.net/") + (synopsis "Display and manipulate id3-tags on mp3 files") + (description + "Eyed3 is a command-line editor to add/edit/remove ID3-tags on mp3 fi= les. +It supports version 1.0, 1.1, 2.3 and 2.4 of the ID3 standard. Additionall= y it +displays several information about the file such as length and bitrate fro= m an +MP3 file.") + (license license:gpl2+))) --=20 2.5.0 --MP_/vRv7KxY49aZZHSCu_jkNjS_-- --Sig_/Jh948QevHKt_s82rVK7wAsK Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCgAGBQJV22hrAAoJEPTB05F+rO6T00wQAJh8m+w1QXbMqoTpKi47HOkc SJPdYy2oCB0XZJPB2XsXVGlE7SwScTT8Vb9WlOJLIyLwmbGWpqrRFf/eptSBDOaa G5TQt9zbvKc4ekwleKVHtKNesigoDtRUk4ulxdjDxhNw4pApZZM5T9CBBtCToNjL 0lpkOhzQchon4QsaQF3PQcSJfXILUSz0GLvPn5YlvNQ7nXelSHR6zwHfbJfXQ9RO Tnr+iuSs71W328RWpZp9TIvnGKeo6TM2L9HtUcTBU6PF83qnEo1NARZEExJkntce +fHtiSFuJu8J3vDbn1y90j4CgD2HcQPRcr1E2Oze/6Y8XaxVFy+H2KE/tChAh/+H +TmUQnyOpM/I43GeXVpbrMCLzTNoD0yg8Xh7roAUenZ1ljqduCHeK8L+3ONNW341 9Wlrr+x3owvXh/n5XilEp6KqeGbNyN2XEEwFucWbOuhNj5P85Rjf00VAAkThMEkU m4wrm2WefwPogN4BOav1ZEsH7A5TNcC0qz9kXZWN8gZrJgzOiA9Feuc/WXKpgIoD mF+XtHiiQbRrtybT848BjGtZ4J2/pD6lZtHpu26xa9UIslcBqBNy7PsHkHBRWZJU iZZHn2lg5bZMvTVxEp5DvDfFFZ2G34aJNSiSacr3jeXpNrgjNUN31wqs4eGxDZOf 8yRXVsIzriBe7R+htLBr =o+Nd -----END PGP SIGNATURE----- --Sig_/Jh948QevHKt_s82rVK7wAsK--