all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* [PATCH 1/2] gnu: Add eyed3.
@ 2015-08-17 19:57 Efraim Flashner
  2015-08-20  9:50 ` 宋文武
  0 siblings, 1 reply; 11+ messages in thread
From: Efraim Flashner @ 2015-08-17 19:57 UTC (permalink / raw)
  To: guix-devel

[-- Attachment #1: Type: text/plain, Size: 1905 bytes --]

* gnu/packages/mp3.scm (eyed3): New variable.
---
 gnu/packages/mp3.scm | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/gnu/packages/mp3.scm b/gnu/packages/mp3.scm
index ddd90fb..629c585 100644
--- a/gnu/packages/mp3.scm
+++ b/gnu/packages/mp3.scm
@@ -2,6 +2,7 @@
 ;;; Copyright © 2013 Andreas Enge <andreas@enge.fr>
 ;;; Copyright © 2014, 2015 Ludovic Courtès <ludo@gnu.org>
 ;;; Copyright © 2015 Mark H Weaver <mhw@netris.org>
+;;; Copyright © 2015 Efraim Flashner <efraim@flashner.co.il>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -39,6 +40,7 @@
   #:use-module (guix packages)
   #:use-module (guix download)
   #:use-module (guix build-system gnu)
+  #:use-module (guix build-system python)
   #:use-module (guix build-system cmake))
 
 (define-public libmad
@@ -450,3 +452,26 @@ format.")
      "Mpc123 is a command-line player for files in the Musepack audio
 compression format (.mpc files).")
     (license license:gpl2+)))
+
+(define-public eyed3
+  (package
+    (name "eyed3")
+    (version "0.7.8")
+    (source (origin
+	      (method url-fetch)
+	      (uri (string-append "http://eyed3.nicfit.net/releases/eyeD3-"
+				  version ".tar.gz"))
+	      (sha256
+	       (base32
+		"1nv7nhfn1d0qm7rgkzksbccgqisng8klf97np0nwaqwd5dbmdf86"))))
+    (build-system python-build-system)
+    (arguments
+     `(#:tests? #f)) ;fail with: UserWarning: Duplicate name:
'paver/shell.py'
+    (home-page "http://eyed3.nicfit.net/")
+    (synopsis "Display and manipulate id3-tags on mp3 files")
+    (description
+     "Eyed3 is a command-line editor to add/edit/remove ID3-tags on mp3
files. +It supports version 1.0, 1.1, 2.3 and 2.4 of the ID3 standard.
Additionally it +displays several information about the file such as length
and bitrate from an +MP3 file.")
+    (license license:gpl2)))
-- 
2.5.0


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply related	[flat|nested] 11+ messages in thread

* Re: [PATCH 1/2] gnu: Add eyed3.
  2015-08-17 19:57 [PATCH 1/2] gnu: Add eyed3 Efraim Flashner
@ 2015-08-20  9:50 ` 宋文武
  2015-08-20 15:19   ` Efraim Flashner
                     ` (2 more replies)
  0 siblings, 3 replies; 11+ messages in thread
From: 宋文武 @ 2015-08-20  9:50 UTC (permalink / raw)
  To: Efraim Flashner, guix-devel

Efraim Flashner <efraim@flashner.co.il> writes:

> * gnu/packages/mp3.scm (eyed3): New variable.
> ---
>  gnu/packages/mp3.scm | 25 +++++++++++++++++++++++++
>  1 file changed, 25 insertions(+)
> [...]
> +    (license license:gpl2)))
The sources have "any later version", so it's 'gpl2+'.
> -- 
> 2.5.0
eyeD3 is both a tool and python library, I wonder whether
'python-eyed3' fits better.

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH 1/2] gnu: Add eyed3.
  2015-08-20  9:50 ` 宋文武
@ 2015-08-20 15:19   ` Efraim Flashner
  2015-08-24 22:48     ` Mark H Weaver
  2015-08-20 17:55   ` Efraim Flashner
  2015-08-21  8:08   ` Andreas Enge
  2 siblings, 1 reply; 11+ messages in thread
From: Efraim Flashner @ 2015-08-20 15:19 UTC (permalink / raw)
  To: 宋文武, guix-devel

[-- Attachment #1: Type: text/plain, Size: 1271 bytes --]

On Thu, 20 Aug 2015 17:50:10 +0800
宋文武 <iyzsong@gmail.com> wrote:

> Efraim Flashner <efraim@flashner.co.il> writes:
> 
> > * gnu/packages/mp3.scm (eyed3): New variable.
> > ---
> >  gnu/packages/mp3.scm | 25 +++++++++++++++++++++++++
> >  1 file changed, 25 insertions(+)
> > [...]
> > +    (license license:gpl2)))
> The sources have "any later version", so it's 'gpl2+'.

The website says: "eyeD3 is written and maintained by Travis Shirk and is
licensed under version 2 of the GPL." And that is backed up by the COPYING
file in the mercurial repo: https://bitbucket.org/nicfit/eyed3/src. Upon
checking the actual source files, it does indeed say "(at your option) any
later version", so it looks like I was mislead by not finding that wording in
the COPYING file.

> eyeD3 is both a tool and python library, I wonder whether
> 'python-eyed3' fits better.

'python-eyed3' is probably a better name. I wonder perhaps as a python
library it should be in python.scm instead of mp3.scm. Anyone have a
suggestion on that front?

-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH 1/2] gnu: Add eyed3.
  2015-08-20  9:50 ` 宋文武
  2015-08-20 15:19   ` Efraim Flashner
@ 2015-08-20 17:55   ` Efraim Flashner
  2015-08-21  8:08   ` Andreas Enge
  2 siblings, 0 replies; 11+ messages in thread
From: Efraim Flashner @ 2015-08-20 17:55 UTC (permalink / raw)
  To: guix-devel

[-- Attachment #1: Type: text/plain, Size: 1271 bytes --]

On Thu, 20 Aug 2015 17:50:10 +0800
宋文武 <iyzsong@gmail.com> wrote:

> Efraim Flashner <efraim@flashner.co.il> writes:
> 
> > * gnu/packages/mp3.scm (eyed3): New variable.
> > ---
> >  gnu/packages/mp3.scm | 25 +++++++++++++++++++++++++
> >  1 file changed, 25 insertions(+)
> > [...]
> > +    (license license:gpl2)))
> The sources have "any later version", so it's 'gpl2+'.

The website says: "eyeD3 is written and maintained by Travis Shirk and is
licensed under version 2 of the GPL." And that is backed up by the COPYING
file in the mercurial repo: https://bitbucket.org/nicfit/eyed3/src. Upon
checking the actual source files, it does indeed say "(at your option) any
later version", so it looks like I was mislead by not finding that wording in
the COPYING file.

> eyeD3 is both a tool and python library, I wonder whether
> 'python-eyed3' fits better.

'python-eyed3' is probably a better name. I wonder perhaps as a python
library it should be in python.scm instead of mp3.scm. Anyone have a
suggestion on that front?

-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH 1/2] gnu: Add eyed3.
  2015-08-20  9:50 ` 宋文武
  2015-08-20 15:19   ` Efraim Flashner
  2015-08-20 17:55   ` Efraim Flashner
@ 2015-08-21  8:08   ` Andreas Enge
  2015-08-24 18:54     ` Efraim Flashner
  2 siblings, 1 reply; 11+ messages in thread
From: Andreas Enge @ 2015-08-21  8:08 UTC (permalink / raw)
  To: 宋文武; +Cc: guix-devel

On Thu, Aug 20, 2015 at 05:50:10PM +0800, 宋文武 wrote:
> eyeD3 is both a tool and python library, I wonder whether
> 'python-eyed3' fits better.

Usually when a package provides binaries we do not use the "python" prefix.
It would also depend on whether there is a "python-" and a "python2-" variant.
If not, this could be seen as an indication that the binary characteristic
is stronger than the library property.

Andreas

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH 1/2] gnu: Add eyed3.
  2015-08-21  8:08   ` Andreas Enge
@ 2015-08-24 18:54     ` Efraim Flashner
  0 siblings, 0 replies; 11+ messages in thread
From: Efraim Flashner @ 2015-08-24 18:54 UTC (permalink / raw)
  To: Andreas Enge; +Cc: guix-devel


[-- Attachment #1.1: Type: text/plain, Size: 3153 bytes --]

On Fri, 21 Aug 2015 10:08:56 +0200
Andreas Enge <andreas@enge.fr> wrote:

> On Thu, Aug 20, 2015 at 05:50:10PM +0800, 宋文武 wrote:
> > eyeD3 is both a tool and python library, I wonder whether
> > 'python-eyed3' fits better.
> 
> Usually when a package provides binaries we do not use the "python" prefix.
> It would also depend on whether there is a "python-" and a "python2-"
> variant. If not, this could be seen as an indication that the binary
> characteristic is stronger than the library property.
> 
> Andreas
> 

output of apt-{cache,file} show eyeD3:

efraim@debian-netbook:~$ apt-cache search eyed3
eyed3 - Display and manipulate id3-tags on the command-line
python-eyed3 - Python module for id3-tags manipulation

efraim@debian-netbook:~$ apt-file show eyed3
eyed3: /usr/bin/eyeD3
eyed3: /usr/share/doc/eyed3/changelog.Debian.gz
eyed3: /usr/share/doc/eyed3/changelog.gz
eyed3: /usr/share/doc/eyed3/copyright
eyed3: /usr/share/man/man1/eyeD3.1.gz
python-eyed3: /usr/lib/python2.6/dist-packages/eyeD3-0.6.18.egg-info
python-eyed3: /usr/lib/python2.6/dist-packages/eyeD3/__init__.py
python-eyed3: /usr/lib/python2.6/dist-packages/eyeD3/binfuncs.py
python-eyed3: /usr/lib/python2.6/dist-packages/eyeD3/frames.py
python-eyed3: /usr/lib/python2.6/dist-packages/eyeD3/mp3.py
python-eyed3: /usr/lib/python2.6/dist-packages/eyeD3/tag.py
python-eyed3: /usr/lib/python2.6/dist-packages/eyeD3/utils.py
python-eyed3: /usr/lib/python2.7/dist-packages/eyeD3-0.6.18.egg-info
python-eyed3: /usr/lib/python2.7/dist-packages/eyeD3/__init__.py
python-eyed3: /usr/lib/python2.7/dist-packages/eyeD3/binfuncs.py
python-eyed3: /usr/lib/python2.7/dist-packages/eyeD3/frames.py
python-eyed3: /usr/lib/python2.7/dist-packages/eyeD3/mp3.py
python-eyed3: /usr/lib/python2.7/dist-packages/eyeD3/tag.py
python-eyed3: /usr/lib/python2.7/dist-packages/eyeD3/utils.py
python-eyed3: /usr/share/doc/python-eyed3/NEWS.gz
python-eyed3: /usr/share/doc/python-eyed3/README.gz
python-eyed3: /usr/share/doc/python-eyed3/README.html
python-eyed3: /usr/share/doc/python-eyed3/TODO
python-eyed3: /usr/share/doc/python-eyed3/changelog.Debian.gz
python-eyed3: /usr/share/doc/python-eyed3/changelog.gz
python-eyed3: /usr/share/doc/python-eyed3/copyright
python-eyed3: /usr/share/pyshared/eyeD3-0.6.18.egg-info
python-eyed3: /usr/share/pyshared/eyeD3/__init__.py
python-eyed3: /usr/share/pyshared/eyeD3/binfuncs.py
python-eyed3: /usr/share/pyshared/eyeD3/frames.py
python-eyed3: /usr/share/pyshared/eyeD3/mp3.py
python-eyed3: /usr/share/pyshared/eyeD3/tag.py
python-eyed3: /usr/share/pyshared/eyeD3/utils.py

The only dependencies of eyed3 are python-eyed3 and python, python-eyed3's
only dependency is python2.7, and both are from the same source package. I
think having the package called eyed3 and not python-eyed3 is the better
choice.

I've attached a patch with 'license:gpl2' changed to 'license:gpl2+'.

-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: gnu-Add-eyed3.patch --]
[-- Type: text/x-patch, Size: 2099 bytes --]

From bc64fc363e144ac26f6a6b34565a1827c2ce31cf Mon Sep 17 00:00:00 2001
From: Efraim Flashner <efraim@flashner.co.il>
Date: Mon, 17 Aug 2015 22:17:32 +0300
Subject: [PATCH] gnu: Add eyed3.

* gnu/packages/mp3.scm (eyed3): New variable.
---
 gnu/packages/mp3.scm | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/gnu/packages/mp3.scm b/gnu/packages/mp3.scm
index ddd90fb..8f73a11 100644
--- a/gnu/packages/mp3.scm
+++ b/gnu/packages/mp3.scm
@@ -2,6 +2,7 @@
 ;;; Copyright © 2013 Andreas Enge <andreas@enge.fr>
 ;;; Copyright © 2014, 2015 Ludovic Courtès <ludo@gnu.org>
 ;;; Copyright © 2015 Mark H Weaver <mhw@netris.org>
+;;; Copyright © 2015 Efraim Flashner <efraim@flashner.co.il>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -39,6 +40,7 @@
   #:use-module (guix packages)
   #:use-module (guix download)
   #:use-module (guix build-system gnu)
+  #:use-module (guix build-system python)
   #:use-module (guix build-system cmake))
 
 (define-public libmad
@@ -450,3 +452,26 @@ format.")
      "Mpc123 is a command-line player for files in the Musepack audio
 compression format (.mpc files).")
     (license license:gpl2+)))
+
+(define-public eyed3
+  (package
+    (name "eyed3")
+    (version "0.7.8")
+    (source (origin
+	      (method url-fetch)
+	      (uri (string-append "http://eyed3.nicfit.net/releases/eyeD3-"
+				  version ".tar.gz"))
+	      (sha256
+	       (base32
+		"1nv7nhfn1d0qm7rgkzksbccgqisng8klf97np0nwaqwd5dbmdf86"))))
+    (build-system python-build-system)
+    (arguments
+     `(#:tests? #f)) ;fail with: UserWarning: Duplicate name: 'paver/shell.py'
+    (home-page "http://eyed3.nicfit.net/")
+    (synopsis "Display and manipulate id3-tags on mp3 files")
+    (description
+     "Eyed3 is a command-line editor to add/edit/remove ID3-tags on mp3 files.
+It supports version 1.0, 1.1, 2.3 and 2.4 of the ID3 standard. Additionally it
+displays several information about the file such as length and bitrate from an
+MP3 file.")
+    (license license:gpl2+)))
-- 
2.5.0


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply related	[flat|nested] 11+ messages in thread

* Re: [PATCH 1/2] gnu: Add eyed3.
  2015-08-20 15:19   ` Efraim Flashner
@ 2015-08-24 22:48     ` Mark H Weaver
  2015-08-25  7:38       ` Efraim Flashner
  0 siblings, 1 reply; 11+ messages in thread
From: Mark H Weaver @ 2015-08-24 22:48 UTC (permalink / raw)
  To: Efraim Flashner; +Cc: guix-devel

Efraim Flashner <efraim@flashner.co.il> writes:

> On Thu, 20 Aug 2015 17:50:10 +0800
> 宋文武 <iyzsong@gmail.com> wrote:
>
>> Efraim Flashner <efraim@flashner.co.il> writes:
>> 
>> > * gnu/packages/mp3.scm (eyed3): New variable.
>> > ---
>> >  gnu/packages/mp3.scm | 25 +++++++++++++++++++++++++
>> >  1 file changed, 25 insertions(+)
>> > [...]
>> > +    (license license:gpl2)))
>> The sources have "any later version", so it's 'gpl2+'.
>
> The website says: "eyeD3 is written and maintained by Travis Shirk and is
> licensed under version 2 of the GPL." And that is backed up by the COPYING
> file in the mercurial repo: https://bitbucket.org/nicfit/eyed3/src. Upon
> checking the actual source files, it does indeed say "(at your option) any
> later version", so it looks like I was mislead by not finding that wording in
> the COPYING file.

I suppose it's not widely known, but what really matters is the copying
permission notices in the files themselves.  So indeed, this should be
gpl2+.

>> eyeD3 is both a tool and python library, I wonder whether
>> 'python-eyed3' fits better.
>
> 'python-eyed3' is probably a better name. I wonder perhaps as a python
> library it should be in python.scm instead of mp3.scm. Anyone have a
> suggestion on that front?

If it includes a library, then I think it should be named
'python-eyed3'.  This is our usual convention, and it has the advantage
that we can add 'python2-eyed3' later, in case someone wants it.

Also, your mail client seems to have applied word-wrapping to the patch,
so some of the "+" signs have been wrapped into the description.  This
is what I see:

--8<---------------cut here---------------start------------->8---
+    (description
+     "Eyed3 is a command-line editor to add/edit/remove ID3-tags on mp3
files. +It supports version 1.0, 1.1, 2.3 and 2.4 of the ID3 standard.
Additionally it +displays several information about the file such as length
and bitrate from an +MP3 file.")
--8<---------------cut here---------------end--------------->8---

This makes it difficult for us to apply it, since we'd have to fix it up
by hand.  Can you persuade your mail client to avoid word-wrapping?  You
could make it an attachment if needed.

     Thanks!
       Mark

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH 1/2] gnu: Add eyed3.
  2015-08-24 22:48     ` Mark H Weaver
@ 2015-08-25  7:38       ` Efraim Flashner
  2015-08-25  8:11         ` Efraim Flashner
  0 siblings, 1 reply; 11+ messages in thread
From: Efraim Flashner @ 2015-08-25  7:38 UTC (permalink / raw)
  To: Mark H Weaver; +Cc: guix-devel


[-- Attachment #1.1: Type: text/plain, Size: 1982 bytes --]

On Mon, 24 Aug 2015 18:48:04 -0400
Mark H Weaver <mhw@netris.org> wrote:

> Efraim Flashner <efraim@flashner.co.il> writes:
> 
> > On Thu, 20 Aug 2015 17:50:10 +0800
> > 宋文武 <iyzsong@gmail.com> wrote:
> >
> >> Efraim Flashner <efraim@flashner.co.il> writes:
> >> 
> >> eyeD3 is both a tool and python library, I wonder whether
> >> 'python-eyed3' fits better.
> >
> > 'python-eyed3' is probably a better name. I wonder perhaps as a python
> > library it should be in python.scm instead of mp3.scm. Anyone have a
> > suggestion on that front?
> 
> If it includes a library, then I think it should be named
> 'python-eyed3'.  This is our usual convention, and it has the advantage
> that we can add 'python2-eyed3' later, in case someone wants it.

Changed the package to python-eyed3 and moved it to python.scm.

> 
> Also, your mail client seems to have applied word-wrapping to the patch,
> so some of the "+" signs have been wrapped into the description.  This
> is what I see:
> 
> --8<---------------cut here---------------start------------->8---
> +    (description
> +     "Eyed3 is a command-line editor to add/edit/remove ID3-tags on mp3
> files. +It supports version 1.0, 1.1, 2.3 and 2.4 of the ID3 standard.
> Additionally it +displays several information about the file such as length
> and bitrate from an +MP3 file.")
> --8<---------------cut here---------------end--------------->8---
> 
> This makes it difficult for us to apply it, since we'd have to fix it up
> by hand.  Can you persuade your mail client to avoid word-wrapping?  You
> could make it an attachment if needed.
> 
>      Thanks!
>        Mark

I've turned off line wrapping so there shouldn't be any more wrapping in my email messages.

-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: 0001-gnu-Add-python-eyed3.patch --]
[-- Type: text/x-patch, Size: 1745 bytes --]

From b6830016d2bcd3cd68d7eec61f2627677141b13f Mon Sep 17 00:00:00 2001
From: Efraim Flashner <efraim@flashner.co.il>
Date: Tue, 25 Aug 2015 10:16:43 +0300
Subject: [PATCH] gnu: Add python-eyed3.

* gnu/packages/python.scm (python-eyed3): New variable.
---
 gnu/packages/python.scm | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 940efec..6ef4303 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -4629,3 +4629,25 @@ term.js Javascript terminal emulator library.")
                  ,python2-backport-ssl-match-hostname)
                 ,@(alist-delete "python-tornado"
                                 (package-propagated-inputs terminado)))))))
+
+(define-public python-eyed3
+  (package
+    (name "python-eyed3")
+    (version "0.7.8")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "http://eyed3.nicfit.net/releases/eyeD3-"
+                                  version ".tar.gz"))
+              (sha256
+               (base32
+                "1nv7nhfn1d0qm7rgkzksbccgqisng8klf97np0nwaqwd5dbmdf86"))))
+    (build-system python-build-system)
+    (arguments
+     `(#:tests? #f)) ;fail with: UserWarning: Duplicate name: 'paver/shell.py'
+     (home-page "http://eyed3.nicfit.net/")
+     (synopsis "Display and manipulate id3-tags on mp3 files")
+     (description "Eyed3 is a command-line editor to add/edit/remove ID3-tags 
+on mp3 files.  It supports version 1.0, 1.1, 2.3 and 2.4 of the ID3 standard. 
+Additionally it displays several information about the file such as length and
+bitrate from an MP3 file.")
+    (license gpl2+)))
-- 
2.5.0


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply related	[flat|nested] 11+ messages in thread

* Re: [PATCH 1/2] gnu: Add eyed3.
  2015-08-25  7:38       ` Efraim Flashner
@ 2015-08-25  8:11         ` Efraim Flashner
  2015-08-25  8:19           ` Efraim Flashner
  0 siblings, 1 reply; 11+ messages in thread
From: Efraim Flashner @ 2015-08-25  8:11 UTC (permalink / raw)
  To: Mark H Weaver; +Cc: guix-devel


[-- Attachment #1.1: Type: text/plain, Size: 2189 bytes --]

forgot the copyright line

On Tue, 25 Aug 2015 10:38:31 +0300
Efraim Flashner <efraim@flashner.co.il> wrote:

> On Mon, 24 Aug 2015 18:48:04 -0400
> Mark H Weaver <mhw@netris.org> wrote:
> 
> > Efraim Flashner <efraim@flashner.co.il> writes:
> > 
> > > On Thu, 20 Aug 2015 17:50:10 +0800
> > > 宋文武 <iyzsong@gmail.com> wrote:
> > >
> > >> Efraim Flashner <efraim@flashner.co.il> writes:
> > >> 
> > >> eyeD3 is both a tool and python library, I wonder whether
> > >> 'python-eyed3' fits better.
> > >
> > > 'python-eyed3' is probably a better name. I wonder perhaps as a python
> > > library it should be in python.scm instead of mp3.scm. Anyone have a
> > > suggestion on that front?
> > 
> > If it includes a library, then I think it should be named
> > 'python-eyed3'.  This is our usual convention, and it has the advantage
> > that we can add 'python2-eyed3' later, in case someone wants it.
> 
> Changed the package to python-eyed3 and moved it to python.scm.
> 
> > 
> > Also, your mail client seems to have applied word-wrapping to the patch,
> > so some of the "+" signs have been wrapped into the description.  This
> > is what I see:
> > 
> > --8<---------------cut here---------------start------------->8---
> > +    (description
> > +     "Eyed3 is a command-line editor to add/edit/remove ID3-tags on mp3
> > files. +It supports version 1.0, 1.1, 2.3 and 2.4 of the ID3 standard.
> > Additionally it +displays several information about the file such as length
> > and bitrate from an +MP3 file.")
> > --8<---------------cut here---------------end--------------->8---
> > 
> > This makes it difficult for us to apply it, since we'd have to fix it up
> > by hand.  Can you persuade your mail client to avoid word-wrapping?  You
> > could make it an attachment if needed.
> > 
> >      Thanks!
> >        Mark
> 
> I've turned off line wrapping so there shouldn't be any more wrapping in my email messages.
> 

-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: 0001-gnu-Add-python-eyed3.patch --]
[-- Type: text/x-patch, Size: 1745 bytes --]

From 9be04652a8e0cefb037d348c6c7e112a7056cc91 Mon Sep 17 00:00:00 2001
From: Efraim Flashner <efraim@flashner.co.il>
Date: Tue, 25 Aug 2015 10:16:43 +0300
Subject: [PATCH] gnu: Add python-eyed3.

* gnu/packages/python.scm (python-eyed3): New variable.
---
 gnu/packages/python.scm | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 940efec..6ef4303 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -4629,3 +4629,25 @@ term.js Javascript terminal emulator library.")
                  ,python2-backport-ssl-match-hostname)
                 ,@(alist-delete "python-tornado"
                                 (package-propagated-inputs terminado)))))))
+
+(define-public python-eyed3
+  (package
+    (name "python-eyed3")
+    (version "0.7.8")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "http://eyed3.nicfit.net/releases/eyeD3-"
+                                  version ".tar.gz"))
+              (sha256
+               (base32
+                "1nv7nhfn1d0qm7rgkzksbccgqisng8klf97np0nwaqwd5dbmdf86"))))
+    (build-system python-build-system)
+    (arguments
+     `(#:tests? #f)) ;fail with: UserWarning: Duplicate name: 'paver/shell.py'
+     (home-page "http://eyed3.nicfit.net/")
+     (synopsis "Display and manipulate id3-tags on mp3 files")
+     (description "Eyed3 is a command-line editor to add/edit/remove ID3-tags 
+on mp3 files.  It supports version 1.0, 1.1, 2.3 and 2.4 of the ID3 standard. 
+Additionally it displays several information about the file such as length and
+bitrate from an MP3 file.")
+    (license gpl2+)))
-- 
2.5.0


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply related	[flat|nested] 11+ messages in thread

* Re: [PATCH 1/2] gnu: Add eyed3.
  2015-08-25  8:11         ` Efraim Flashner
@ 2015-08-25  8:19           ` Efraim Flashner
  2015-09-17 12:12             ` Efraim Flashner
  0 siblings, 1 reply; 11+ messages in thread
From: Efraim Flashner @ 2015-08-25  8:19 UTC (permalink / raw)
  To: Mark H Weaver; +Cc: guix-devel


[-- Attachment #1.1: Type: text/plain, Size: 102 bytes --]

now I feel like I'm spamming the email list. Comitted the copyright line and made the patch...again.

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: 0001-gnu-Add-python-eyed3.patch --]
[-- Type: text/x-patch, Size: 2067 bytes --]

From ff94a5cf13b82d998324fb3d0a4a55dfb992cd86 Mon Sep 17 00:00:00 2001
From: Efraim Flashner <efraim@flashner.co.il>
Date: Tue, 25 Aug 2015 10:16:43 +0300
Subject: [PATCH] gnu: Add python-eyed3.

* gnu/packages/python.scm (python-eyed3): New variable.
---
 gnu/packages/python.scm | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 940efec..7f4d3c5 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -10,6 +10,7 @@
 ;;; Copyright © 2015 Ricardo Wurmus <rekado@elephly.net>
 ;;; Copyright © 2015 Christopher Allan Webber <cwebber@dustycloud.org>
 ;;; Copyright © 2015 Eric Dvorsak <eric@dvorsak.fr>
+;;; Copyright © 2015 Efraim Flashner <efraim@flashner.co.il>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -4629,3 +4630,25 @@ term.js Javascript terminal emulator library.")
                  ,python2-backport-ssl-match-hostname)
                 ,@(alist-delete "python-tornado"
                                 (package-propagated-inputs terminado)))))))
+
+(define-public python-eyed3
+  (package
+    (name "python-eyed3")
+    (version "0.7.8")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "http://eyed3.nicfit.net/releases/eyeD3-"
+                                  version ".tar.gz"))
+              (sha256
+               (base32
+                "1nv7nhfn1d0qm7rgkzksbccgqisng8klf97np0nwaqwd5dbmdf86"))))
+    (build-system python-build-system)
+    (arguments
+     `(#:tests? #f)) ;fail with: UserWarning: Duplicate name: 'paver/shell.py'
+     (home-page "http://eyed3.nicfit.net/")
+     (synopsis "Display and manipulate id3-tags on mp3 files")
+     (description "Eyed3 is a command-line editor to add/edit/remove ID3-tags 
+on mp3 files.  It supports version 1.0, 1.1, 2.3 and 2.4 of the ID3 standard. 
+Additionally it displays several information about the file such as length and
+bitrate from an MP3 file.")
+    (license gpl2+)))
-- 
2.5.0


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply related	[flat|nested] 11+ messages in thread

* Re: [PATCH 1/2] gnu: Add eyed3.
  2015-08-25  8:19           ` Efraim Flashner
@ 2015-09-17 12:12             ` Efraim Flashner
  0 siblings, 0 replies; 11+ messages in thread
From: Efraim Flashner @ 2015-09-17 12:12 UTC (permalink / raw)
  To: guix-devel

[-- Attachment #1: Type: text/plain, Size: 100 bytes --]

a little bump. this patch seems to have been forgotten, and I think this was
the resolved version

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2015-09-17 12:13 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-08-17 19:57 [PATCH 1/2] gnu: Add eyed3 Efraim Flashner
2015-08-20  9:50 ` 宋文武
2015-08-20 15:19   ` Efraim Flashner
2015-08-24 22:48     ` Mark H Weaver
2015-08-25  7:38       ` Efraim Flashner
2015-08-25  8:11         ` Efraim Flashner
2015-08-25  8:19           ` Efraim Flashner
2015-09-17 12:12             ` Efraim Flashner
2015-08-20 17:55   ` Efraim Flashner
2015-08-21  8:08   ` Andreas Enge
2015-08-24 18:54     ` Efraim Flashner

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.