From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eric Bavier <ericbavier@openmailbox.org>
Subject: Re: [PATCH 6/7] gnu: Add libconfuse.
Date: Sun, 16 Aug 2015 18:53:21 -0500
Message-ID: <20150816185321.69fd4fe8@openmailbox.org>
References: <1439780737-14209-1-git-send-email-eric@dvorsak.fr>
	<1439780737-14209-6-git-send-email-eric@dvorsak.fr>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43634)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ericbavier@openmailbox.org>) id 1ZRCJ2-0005XH-8E
	for guix-devel@gnu.org; Mon, 17 Aug 2015 00:45:57 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ericbavier@openmailbox.org>) id 1ZRCIz-000750-2d
	for guix-devel@gnu.org; Mon, 17 Aug 2015 00:45:56 -0400
Received: from smtp29.openmailbox.org ([62.4.1.63]:37450)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ericbavier@openmailbox.org>) id 1ZRCIy-00074u-T4
	for guix-devel@gnu.org; Mon, 17 Aug 2015 00:45:53 -0400
In-Reply-To: <1439780737-14209-6-git-send-email-eric@dvorsak.fr>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Eric Dvorsak <eric@dvorsak.fr>
Cc: guix-devel@gnu.org

On Mon, 17 Aug 2015 05:05:36 +0200
Eric Dvorsak <eric@dvorsak.fr> wrote:

> * gnu/packages/i3.scm (libconfuse): New variable.
> ---
>  gnu/packages/i3.scm | 22 ++++++++++++++++++++++
>  1 file changed, 22 insertions(+)
> 
> diff --git a/gnu/packages/i3.scm b/gnu/packages/i3.scm
> index bcb4888..725fdb6 100644
> --- a/gnu/packages/i3.scm
> +++ b/gnu/packages/i3.scm
> @@ -39,6 +39,28 @@
>    #:use-module (guix download)
>    #:use-module (guix git-download))
>  
> +(define-public libconfuse
> +  (package
> +    (name "libconfuse")
> +    (version "2.7")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append "http://savannah.nongnu.org/download/confuse/"
> +                                  "confuse-" version ".tar.gz"))
> +              (sha256
> +               (base32
> +
> "0y47r2ashz44wvnxdb18ivpmj8nxhw3y9bf7v9w0g5byhgyp89g3"))))
> +    (build-system gnu-build-system)
> +    (home-page "http://www.nongnu.org/confuse/")
> +    (synopsis "Configuration file parser library")
> +    (description "A configuration file parser library. It supports

"libconfuse is a configuration..."

Also, two spaces at the end of sentences.  'guix lint libconfuse'
should warn about this.

> +sections and (lists of) values (strings, integers, floats, booleans
> or +other sections), as well as some other features (such as
> +single/double-quoted strings, environment variable expansion,
> +functions and nested include statements).  It makes it very easy to
> +add configuration file capability to a program using a simple API. ")

"very easy" and "simple" seem too much like advertising.  Perhaps the
last sentence could be left out to keep the description more neutral.
WDYT?

Otherwise LGTM.

`~Eric