Re: [PATCH 2/7] gnu: Add libyajl.

[Eric Bavier <ericbavier@openmailbox.org>]

On Mon, 17 Aug 2015 04:05:57 +0200
Eric Dvorsak <eric@dvorsak.fr> wrote:

> * gnu/packages/web.scm (libyajl): New variable.
> ---
>  gnu/packages/web.scm | 19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)
> 
> diff --git a/gnu/packages/web.scm b/gnu/packages/web.scm
> index 48bfbc7..07054c2 100644
> --- a/gnu/packages/web.scm
> +++ b/gnu/packages/web.scm
> @@ -6,6 +6,7 @@
>  ;;; Copyright © 2015 Ricardo Wurmus <rekado@elephly.net>
>  ;;; Copyright © 2015 Taylan Ulrich Bayırlı/Kammer
> <taylanbayirli@gmail.com> ;;; Copyright © 2015 Eric Bavier
> <bavier@member.fsf.org> +;;; Copyright © 2015 Eric Dvorsak
> <eric@dvorsak.fr> ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -287,6 +288,24 @@ parse JSON formatted strings back into the C
> representation of JSON objects.") style API.")
>      (license l:expat)))
>  
> +(define-public libyajl
> +  (package
> +    (name "libyajl")
> +    (version "2.1.0")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append "https://github.com/lloyd/yajl/archive/" version ".tar.gz"))

Wrap this line to 80 characters.

It would also be nice to provide a "file-name" field so that the tarball
is put in the store with a meaningful name, rather than just
"2.1.0.tar.gz".  E.g.:

  (file-name (string-append name "-" version ".tar.gz"))

See the aardict package for an example.

> +              (sha256
> +               (base32
> +
> "0nmcqpaiq4pv7dymyg3n3jsd57yhp5npxl26a1hzw3m3lmj37drz"))))
> +    (build-system cmake-build-system)
> +    (home-page "https://lloyd.github.io/yajl/")
> +    (synopsis "C library for parsing JSON")
> +    (description "Yet Another JSON Library.  YAJL is a small
> +event-driven (SAX-style) JSON parser written in ANSI C, and a small
> +validating JSON generator.")
> +    (license isc)))
> +
>  (define-public libwebsockets
>    (package
>      (name "libwebsockets")

Otherwise looks good to me.

Thanks,
`~Eric