From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Bavier Subject: Re: [PATCH 1/7] gnu: Add Pod-Simple. Date: Sun, 16 Aug 2015 18:17:42 -0500 Message-ID: <20150816181742.18eedcb8@openmailbox.org> References: <1439777162-7769-1-git-send-email-eric@dvorsak.fr> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:36057) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZRBkY-00050p-Re for guix-devel@gnu.org; Mon, 17 Aug 2015 00:10:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZRBkU-00082P-Kl for guix-devel@gnu.org; Mon, 17 Aug 2015 00:10:18 -0400 Received: from smtp18.openmailbox.org ([62.4.1.52]:47345) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZRBkU-00082A-EO for guix-devel@gnu.org; Mon, 17 Aug 2015 00:10:14 -0400 In-Reply-To: <1439777162-7769-1-git-send-email-eric@dvorsak.fr> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Eric Dvorsak Cc: guix-devel@gnu.org On Mon, 17 Aug 2015 04:05:56 +0200 Eric Dvorsak wrote: > * gnu/packages/perl.scm (perl-pod-simple): New variable. > --- > gnu/packages/perl.scm | 21 +++++++++++++++++++++ > 1 file changed, 21 insertions(+) >=20 > diff --git a/gnu/packages/perl.scm b/gnu/packages/perl.scm > index d2e38cc..7318542 100644 > --- a/gnu/packages/perl.scm > +++ b/gnu/packages/perl.scm > @@ -3,6 +3,7 @@ > ;;; Copyright =C2=A9 2013 Andreas Enge > ;;; Copyright =C2=A9 2015 Ricardo Wurmus > ;;; Copyright =C2=A9 2015 Eric Bavier > +;;; Copyright =C2=A9 2015 Eric Dvorsak > ;;; > ;;; This file is part of GNU Guix. > ;;; > @@ -3941,6 +3942,26 @@ directory specifications in a cross-platform > manner.") for a given module is comprehensive.") > (license (package-license perl)))) > =20 > +(define-public perl-pod-simple > + (package > + (name "perl-pod-simple") > + (version "3.30_1") I think we should avoid using dev releases if we can. Is there anything preventing the use of the "3.30" release? > + (source (origin > + (method url-fetch) > + (uri (string-append "http://search.cpan.org/CPAN/authors/i= d/M/" Please use the "cpan" mirror: "mirror://cpan/authors/id/..." > + "MA/MARCGREEN/Pod-Simple-" version > + ".tar.gz")) > + (sha256 > + (base32 > + > "0yzy7mw2jriwcywmh38csjqrwxj207b2b7rlpvkdh1rq5828hary")))) > + (build-system perl-build-system) > + (home-page > "http://search.cpan.org/~marcgreen/Pod-Simple/lib/Pod/Simple.pod") Could you use the "http://search.cpan.org/dist/Pod-Simple" url instead? It prevents us from needing to update the home-page url if ownership is ever transferred. > + (synopsis "Parsing library for text in Pod format") > + (description "Pod::Simple is a Perl library for parsing text in > +the Pod (plain old documentation) markup language that is typically > +used for writing documentation for Perl and for Perl modules.") > + (license (package-license perl)))) > + > (define-public perl-posix-strftime-compiler > (package > (name "perl-posix-strftime-compiler") Thanks, `~Eric