bug#21010: eject fails because of hardcoded path to umount

bug#21010: eject fails because of hardcoded path to umount

[Alex Sassmannshausen]

Hello,

I'm running GuixSD.

I tried to 'eject' a pen drive today using
`sudo eject /mnt/usb`

The command failed with 
-------8<---------------->8-----------
eject: unable to exec /bin/umount of `/mnt/usb'
eject: unmount of `/mnt/usb' failed
-------8<---------------->8-----------

Some more information:
-------8<---------------->8-----------
# which eject
/run/current-system/profile/bin/eject
# mount /dev/sdb /mnt/usb
# eject /mnt/usb
eject: unable to exec /bin/umount of `/mnt/usb'
eject: unmount of `/mnt/usb' failed
-------8<---------------->8-----------

HTH, let me know if you want me to test or provide anything else.

Cheers,
Alex

bug#21010: eject fails because of hardcoded path to umount

[Andreas Enge]

On Wed, Jul 08, 2015 at 02:18:21PM +0200, Alex Sassmannshausen wrote:
> eject: unable to exec /bin/umount of `/mnt/usb'

The culprit is in the source code of util-linux-2.25.2/sys-utils/eject.c:
681:                    execl("/bin/umount", "/bin/umount", name, "-n", NULL);
683:                    execl("/bin/umount", "/bin/umount", name, NULL);
685:            errx(EXIT_FAILURE, _("unable to exec /bin/umount of `%s'"), name);

This should be easy to patch, but there are other utilities with the same
problem. A hopeless case seems to be "whereis": It looks for files in fixed
lists of locations such as
static const char *bindirs[] = {
        "/usr/bin",
        "/usr/sbin",
        "/usr/lib",
        "/usr/lib64",
        "/bin",
        "/sbin",
        "/etc",
        "/usr/etc",
        "/lib",
        "/lib64",
        "/usr/games",
        "/usr/games/bin",
        "/usr/games/lib",
        "/usr/emacs/etc",
        "/usr/lib/emacs/*/etc",
        "/usr/TeX/bin",
...

Andreas

bug#21010: eject fails because of hardcoded path to umount

[Ludovic Courtès]

Andreas Enge <andreas@enge.fr> skribis:

> On Wed, Jul 08, 2015 at 02:18:21PM +0200, Alex Sassmannshausen wrote:
>> eject: unable to exec /bin/umount of `/mnt/usb'
>
> The culprit is in the source code of util-linux-2.25.2/sys-utils/eject.c:
> 681:                    execl("/bin/umount", "/bin/umount", name, "-n", NULL);
> 683:                    execl("/bin/umount", "/bin/umount", name, NULL);
> 685:            errx(EXIT_FAILURE, _("unable to exec /bin/umount of `%s'"), name);

This should be fixed in core-updates.

> This should be easy to patch, but there are other utilities with the same
> problem. A hopeless case seems to be "whereis": It looks for files in fixed
> lists of locations such as
> static const char *bindirs[] = {
>         "/usr/bin",
>         "/usr/sbin",

I think we should check what this list is used for, and then prepend
entries accordingly.  Volunteering?  :-)

Ludo’.

bug#21010: eject fails because of hardcoded path to umount

[Ludovic Courtès]

Alex Sassmannshausen <alex.sassmannshausen@gmail.com> skribis:

> I tried to 'eject' a pen drive today using
> `sudo eject /mnt/usb`

BTW, if you add this user account to “cdrom”, you won’t even need
‘sudo’.

> The command failed with 
> -------8<---------------->8-----------
> eject: unable to exec /bin/umount of `/mnt/usb'
> eject: unmount of `/mnt/usb' failed
> -------8<---------------->8-----------

Fixed in 7e51249.

Thanks!

Ludo’.