From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eric Bavier <ericbavier@openmailbox.org>
Subject: Re: [PATCH 14/14] gnu: Add deal.II.
Date: Sun, 28 Jun 2015 11:05:35 -0500
Message-ID: <20150628110535.42177fd6@openmailbox.org>
References: <1435463151-32099-1-git-send-email-ericbavier@openmailbox.org>
	<1435463151-32099-15-git-send-email-ericbavier@openmailbox.org>
	<87lhf3twfn.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:32919)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ericbavier@openmailbox.org>) id 1Z9Jdg-0003p9-VW
	for guix-devel@gnu.org; Sun, 28 Jun 2015 16:57:21 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ericbavier@openmailbox.org>) id 1Z9Jdd-0001xJ-Pw
	for guix-devel@gnu.org; Sun, 28 Jun 2015 16:57:20 -0400
Received: from smtp18.openmailbox.org ([62.4.1.52]:60271)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ericbavier@openmailbox.org>) id 1Z9Jdd-0001xB-KA
	for guix-devel@gnu.org; Sun, 28 Jun 2015 16:57:17 -0400
In-Reply-To: <87lhf3twfn.fsf@gnu.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Ludovic =?UTF-8?B?Q291cnTDqHM=?= <ludo@gnu.org>
Cc: guix-devel@gnu.org, Eric Bavier <bavier@member.fsf.org>

On Sun, 28 Jun 2015 22:22:36 +0200
ludo@gnu.org (Ludovic Court=C3=A8s) wrote:

> ericbavier@openmailbox.org skribis:
>=20
> > From: Eric Bavier <bavier@member.fsf.org>
> >
> > * gnu/packages/maths.scm (deal.II, deal.II-openmpi): New variables.
> > * gnu/packages/patches/deal.II-p4est-interface.patch: New patch.
> > * gnu-system.am (dist_patch_DATA): Add it.
>=20
> [...]
>=20
> > +(define-public deal.II
> > +  (package
> > +    (name "deal.II")
>=20
> What about =E2=80=98deal-ii=E2=80=99 for both, or even =E2=80=98dealii=E2=
=80=99 (like the domain
> name)?

I would prefer to keep "deal.II" for the name at least, because that it
the software's declared name, despite the domain and tarball being
"dealii".  Are there arguments against it?

>=20
> Otherwise LGTM.

Thanks,
`~Eric