Re: [PATCH 10/14] gnu: Add MUMPS.

[Eric Bavier <ericbavier@openmailbox.org>]

On Sun, 28 Jun 2015 22:12:40 +0200
ludo@gnu.org (Ludovic Courtès) wrote:

> ericbavier@openmailbox.org skribis:
> 
> > From: Eric Bavier <bavier@member.fsf.org>
> >
> > * gnu/packages/maths.scm (mumps, mumps-metis, mumps-openmpi)
> >   (mumps-metis-openmpi): New variables.
> > * gnu/packages/patches/mumps-build-parallelism.patch: New patch.
> > * gnu-system.am (dist_patch_DATA): Add it.
> 
> ISTR that some time ago MUMPS included obfuscated code; I assume this
> is no longer the case?

Indeed, the 5.0.0 release no longer contains obfuscated code.  I had
not realized this; thanks for bringing it my attention! ;)

> 
> > +            (zero? (system* "make" "all"
> > +                            (format #f
> > "-j~a" (current-processor-count))))))
> 
> Rather ‘parallel-job-count’.

OK

> 
> > +          (lambda* (#:key (exec-prefix '()) #:allow-other-keys)
> > +            (with-directory-excursion "examples"
> > +              (use-modules (srfi srfi-1))
> > +              (every
> > +               (lambda (prec type)
> > +                 (use-modules (ice-9 popen))
> 
> Local ‘use-modules’ forms are not very nice (it’s not documented.)
> Rather use:
> 
>   #:modules ((srfi srfi-1)
>              (ice-9 popen)
>              ,@%gnu-build-system-modules)

Much nicer, yes.

> 
> > +                 (let ((tester (apply open-pipe*
> > +                                      `(,OPEN_WRITE
> > +                                        ,@exec-prefix
> > +                                        ,(string-append "./" prec
> > +
> > "simpletest"))))
> > +                       (input  (open-input-file
> > +                                (string-append "input_simpletest_"
> > type))))
> > +                   (begin
> > +                     (dump-port input tester)
> > +                     (close-port input)
> > +                     (zero? (close-pipe tester)))))
> > +               '("s" "d" "c" "z")
> > +               '("real" "real" "cmplx" "cmplx")))))
> 
> Please add a comment saying that this does, to appease the
> reader.  ;-)

Sure thing.

> 
> > +    (license license:public-domain)))
> 
> I think it’s CeCILL-C, see
> <http://mumps.enseeiht.fr/index.php?page=dwnld>.

Good catch.  Yes, this is also new in the 5.0.0 release.  I believe I
orginally started writing this recipe for 4.10.0.  

Thanks for the review,
`~Eric