Re: 01/01: gnu: bluez: Install the library and header files.

Re: 01/01: gnu: bluez: Install the library and header files.

[Mark H Weaver]

Hi Andreas,

Andreas Enge <andreas@enge.fr> writes:

> commit 53142109a06155980397514795d9a36afb418f54
> Author: Andreas Enge <andreas@enge.fr>
> Date:   Sat May 23 20:39:57 2015 +0200
>
>     gnu: bluez: Install the library and header files.
>     
>     * gnu/packages/linux.scm (bluez)[arguments]: Add --enable-library to
>       #:configure-flags.
> ---
>  gnu/packages/linux.scm |   11 ++++++-----
>  1 files changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
> index 26e9aa9..62a19f5 100644
> --- a/gnu/packages/linux.scm
> +++ b/gnu/packages/linux.scm
> @@ -1,6 +1,6 @@
>  ;;; GNU Guix --- Functional package management for GNU
>  ;;; Copyright © 2012, 2013, 2014, 2015 Ludovic Courtès <ludo@gnu.org>
> -;;; Copyright © 2013, 2014 Andreas Enge <andreas@enge.fr>
> +;;; Copyright © 2013, 2014, 2015 Andreas Enge <andreas@enge.fr>
>  ;;; Copyright © 2012 Nikita Karetnikov <nikita@karetnikov.org>
>  ;;; Copyright © 2014, 2015 Mark H Weaver <mhw@netris.org>
>  ;;; Copyright © 2015 Federico Beffa <beffa@fbengineering.ch>
> @@ -308,7 +308,7 @@ It has been modified to remove all non-free binary blobs.")
>      (license gpl2)
>      (home-page "http://www.gnu.org/software/linux-libre/"))))
>  
> -\f
> +
>  ;;;
>  ;;; Pluggable authentication modules (PAM).
>  ;;;
> @@ -354,7 +354,7 @@ be used through the PAM API to perform tasks, like authenticating a user
>  at login.  Local and dynamic reconfiguration are its key features")
>      (license bsd-3)))
>  
> -\f
> +
>  ;;;
>  ;;; Miscellaneous.
>  ;;;

The form feeds that you just removed were put in by civodul in commit
c84d0eca053cd524294ad10c1f49a877902932c4.  Presumably he put them there
intentionally.  Did you intend to remove them as part of this unrelated
bluez commit?

     Mark

Re: 01/01: gnu: bluez: Install the library and header files.

[Andreas Enge]

Hello,

On Sat, May 23, 2015 at 06:41:49PM -0400, Mark H Weaver wrote:
> The form feeds that you just removed were put in by civodul in commit
> c84d0eca053cd524294ad10c1f49a877902932c4.  Presumably he put them there
> intentionally.  Did you intend to remove them as part of this unrelated
> bluez commit?

this is just a consequence of my editor settings that remove white space
at the end of lines upon saving a file. I usually only see them when I
commit (and did not consider it harmful, except that it hides the real
changes in the diff). I just changed it so that only white space at the end
of lines I touched are concerned.

Andreas

Re: 01/01: gnu: bluez: Install the library and header files.

[Mark H Weaver]

Andreas Enge <andreas@enge.fr> writes:

> On Sat, May 23, 2015 at 06:41:49PM -0400, Mark H Weaver wrote:
>> The form feeds that you just removed were put in by civodul in commit
>> c84d0eca053cd524294ad10c1f49a877902932c4.  Presumably he put them there
>> intentionally.  Did you intend to remove them as part of this unrelated
>> bluez commit?
>
> this is just a consequence of my editor settings that remove white space
> at the end of lines upon saving a file. I usually only see them when I
> commit (and did not consider it harmful, except that it hides the real
> changes in the diff). I just changed it so that only white space at the end
> of lines I touched are concerned.

Sounds good, thanks!

     Mark