all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Andreas Enge <andreas@enge.fr>
To: Ricardo Wurmus <rekado@elephly.net>
Cc: guix-devel <guix-devel@gnu.org>
Subject: Re: [PATCH] gnu: Add IR.
Date: Sun, 26 Apr 2015 14:09:59 +0200	[thread overview]
Message-ID: <20150426120959.GA5194@debian> (raw)
In-Reply-To: <87siboyreg.fsf@mango.localdomain>

On Sat, Apr 25, 2015 at 08:49:43PM +0200, Ricardo Wurmus wrote:
> +          (chdir "libs") #t)

I would put "#t" onto a new line as it is a separate "command".

+            (("^LIBDIR =.*") "LIBDIR = lib\n"))

I think this adds a line break, which is not a problem.

> +     "Zita convolver is a C++ library implementing a real-time convolution
> +matrix.")

This I find difficult to understand. How can you implement a matrix?  What is
a real time matrix?  Maybe "for computing convolution matrices in real time"?
Or also add "double precision" (or whatever is correct) in front of
"convolution matrices".

Otherwise looks good.

Andreas

  reply	other threads:[~2015-04-26 12:10 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-25 18:49 [PATCH] gnu: Add IR Ricardo Wurmus
2015-04-26 12:09 ` Andreas Enge [this message]
2015-04-26 13:26   ` Ricardo Wurmus
2015-04-26 13:47     ` Andreas Enge
2015-04-26 12:12 ` Andreas Enge
2015-04-26 13:19   ` Ricardo Wurmus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150426120959.GA5194@debian \
    --to=andreas@enge.fr \
    --cc=guix-devel@gnu.org \
    --cc=rekado@elephly.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.