Re: Add guile-minikanren

[Andreas Enge <andreas@enge.fr>]

On Wed, Apr 22, 2015 at 10:15:27AM -0500, Christopher Allan Webber wrote:
> Here's a patch to add minikanren via ijp's port to r6rs packaging to
> Guix.  It's my first Guix patch... I hope I did okay!

Thanks for contributing!

> I named it guile-minikanren which isn't really accurate.  I'm not sure
> how else I could name it though?  I'd be open to suggestions!

There is a chapter in the documentation about this:
   https://www.gnu.org/software/guix/manual/guix.html#Package-Naming
The main idea is to not think too much, but to simply use the upstream
project name. Here this seems to be "minikanren" without "guile-".
We have special rules for perl and python; maybe we also need a special
rule for guile?

> +    (source (origin
> +              (method git-fetch)
> +              (uri (git-reference
> +                    (url "https://github.com/ijp/minikanren.git")
> +                    (commit "10d507785eab30b0f8b47bf8bb37d880731fc031")))

Is there no tarball? If possiblem we would prefer this.

> +              ;; sha256 goes here

Can be dropped.

> +    (native-inputs `(("guile" ,guile-2.0)))

"native-inputs" are used during the build of the package, which is not
the case here. Is guile needed at all as an input?

> +    (synopsis "The miniKanren declarative logic system, ported to Guile")

Do not start with an article, how about
"Guile implementation of the miniKanren domain specific language" ?

> +     "MiniKanren is a relational programming extension to the Scheme
> +programming Language, written as a smaller version of Kanren suitable for
> +pedagogical purposes. It is featured in the book, The Reasoned Schemer,

Use two spaces after ".". For such questions, you can run
   ./pre-inst-env guix lint PACKAGE

Concerning the content, I let the scheme specialists pronounce themselves.

Andreas