From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eric Bavier <bavier@member.fsf.org>
Subject: Re: [PATCH 2/3] gnu: Add UnQLite.
Date: Sun, 29 Mar 2015 14:13:35 -0500
Message-ID: <20150329141335.41c9e134@PocketWee>
References: <1427491480-27319-1-git-send-email-bavier@member.fsf.org>
	<1427491480-27319-3-git-send-email-bavier@member.fsf.org>
	<87h9t3ykuh.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37997)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bavier@member.fsf.org>) id 1YcIeC-0008Tp-V3
	for guix-devel@gnu.org; Sun, 29 Mar 2015 15:13:26 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <bavier@member.fsf.org>) id 1YcIe6-00028d-U9
	for guix-devel@gnu.org; Sun, 29 Mar 2015 15:13:24 -0400
Received: from mail.centurylink.net ([205.219.233.9]:5628
	helo=smtp.centurylink.net) by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bavier@member.fsf.org>) id 1YcIe6-00028D-Pp
	for guix-devel@gnu.org; Sun, 29 Mar 2015 15:13:18 -0400
In-Reply-To: <87h9t3ykuh.fsf@gnu.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Ludovic =?UTF-8?B?Q291cnTDqHM=?= <ludo@gnu.org>
Cc: guix-devel@gnu.org

On Sun, 29 Mar 2015 15:49:42 +0200
ludo@gnu.org (Ludovic Court=C3=A8s) wrote:

> Eric Bavier <bavier@member.fsf.org> skribis:
>=20
> > * gnu/packages/databases.scm (unqlite): New variable.
>=20
> [...]
>=20
> > +              ;; Contiains bug-fixes against the official release, and=
 has an
>                        ^^^       ^
> Typo.

Thanks.

> > +              ;; autotooled build system.
> > +              (uri (string-append "https://github.com/aidin36/tocc/rel=
eases/"
> > +                                  "download/v1.0.0/"
> > +                                  "unqlite-unofficial-" version ".tar.=
gz"))
>=20
> Still, it seems that we should be using the official version no?

The official distribution is somewhat of a mess.  The zip archive
requires a patch that must be applied during a build step because our
patch-and-repack can't handle "tarbombs".  There are not
installation scripts, and the trivial-build-system is much more
verbose.

> > +    (synopsis "NoSQL database engine")
>=20
> =E2=80=9CNoSQL=E2=80=9D says what it=E2=80=99s not, but not what it is.  =
Maybe =E2=80=9CIn-memory
> key/value database=E2=80=9D (IIUC) or something to that effect?

Yes, that would be more descriptive.  Perhaps "In-memory key/value and
document store".

> The rest LGTM.
>=20
> Thanks!

Thank you for the review.

`~Eric