Re: [PATCH v2] gnu: Add taskwarrior.

["Tomáš Čech" <sleep_walker@gnu.org>]

[-- Attachment #1: Type: text/plain, Size: 4275 bytes --]

On Thu, Mar 26, 2015 at 12:01:26AM +0100, Cyril Roelandt wrote:
>Sorry for the delay in reviewing this.
>
>On 03/25/2015 11:49 PM, Tomáš Čech wrote:
>> From: Tomáš Čech <sleep_walker@suse.cz>
>>
>> * gnu/packages/task.scm: New file.
>> * gnu-system.am (GNU_SYSTEM_MODULES): Add it.
>> ---
>>  gnu-system.am         |  1 +
>>  gnu/packages/task.scm | 67 +++++++++++++++++++++++++++++++++++++++++++++++++++
>>  2 files changed, 68 insertions(+)
>>  create mode 100644 gnu/packages/task.scm
>>
>> diff --git a/gnu-system.am b/gnu-system.am
>> index 1f2ebdf..d25c4df 100644
>> --- a/gnu-system.am
>> +++ b/gnu-system.am
>> @@ -275,6 +275,7 @@ GNU_SYSTEM_MODULES =				\
>>    gnu/packages/swig.scm				\
>>    gnu/packages/sxiv.scm				\
>>    gnu/packages/synergy.scm			\
>> +  gnu/packages/task.scm				\
>>    gnu/packages/tbb.scm				\
>>    gnu/packages/tcl.scm				\
>>    gnu/packages/tcsh.scm				\
>> diff --git a/gnu/packages/task.scm b/gnu/packages/task.scm
>> new file mode 100644
>> index 0000000..af14b14
>> --- /dev/null
>> +++ b/gnu/packages/task.scm
>> @@ -0,0 +1,67 @@
>> +;;; GNU Guix --- Functional package management for GNU
>> +;;; Copyright © 2015 Tomáš Čech <sleep_walker@suse.cz>
>> +;;;
>> +;;; This file is part of GNU Guix.
>> +;;;
>> +;;; GNU Guix is free software; you can redistribute it and/or modify it
>> +;;; under the terms of the GNU General Public License as published by
>> +;;; the Free Software Foundation; either version 3 of the License, or (at
>> +;;; your option) any later version.
>> +;;;
>> +;;; GNU Guix is distributed in the hope that it will be useful, but
>> +;;; WITHOUT ANY WARRANTY; without even the implied warranty of
>> +;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
>> +;;; GNU General Public License for more details.
>> +;;;
>> +;;; You should have received a copy of the GNU General Public License
>> +;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
>> +
>> +(define-module (gnu packages task)
>
>Why is this module called "task"?

Idea was task as for task management. Would task-management be better?

>
>> +  #:use-module ((guix licenses) #:prefix license:)
>> +  #:use-module (guix packages)
>> +  #:use-module (gnu packages base)
>> +  #:use-module (gnu packages gnutls)
>> +  #:use-module (gnu packages linux)
>> +  #:use-module (gnu packages lua)
>> +  #:use-module (guix download)
>> +  #:use-module (guix build-system cmake)
>> +  )
>
>This parenthesis should be moved to the previous line.

Thanks.

>> +
>> +(define-public taskwarrior
>> +  (package
>> +    (name "taskwarrior")
>> +    (version "2.4.1")
>> +    (source
>> +     (origin
>> +       (method url-fetch)
>> +       (uri (string-append
>> +             "http://taskwarrior.org/download/task-" version ".tar.gz"))
>> +       (sha256 (base32
>> +                "1qn2jwskrkqg3lszkcd37h06j4a1spfkr8z9yq17p59r8v34h3nr"))))
>> +    (build-system cmake-build-system)
>> +    (inputs
>> +     `(("gnutls" ,gnutls)
>> +       ("lua" ,lua)
>> +       ("util-linux" ,util-linux)))
>> +    (arguments
>> +     `(#:tests? #f ; skip tests
>
>Why are the tests skipped? The comment should be more verbose.

No tests implemented. Thanks - fixed.
>
>> +       #:phases
>> +       (alist-cons-before
>> +        'patch-source-shebangs 'remove-broken-symlinks
>> +        (lambda _
>> +          ;; these files are broken symlinks - lets just delete them
>> +          (delete-file "src/cal")
>> +          (delete-file "src/calendar")
>> +          (delete-file "src/tw"))
>> +        %standard-phases)))
>> +    (home-page "http://taskwarrior.org")
>> +    (synopsis
>> +     "Command line task manager")
>> +    (description
>> +     "Taskwarrior is mature command line task manager following Getting Things
>> +Done time management method.  It supports network synchronization, filtering
>> +and quering data, exposing task data in multiple formats to other tools which
>> +allowed to create healthy ecosystem of tools using taskwarrior.")
>> +    ;; Taskwarrior is licensed under MIT license, which is identical to
>> +    ;; Expat License
>> +    (license license:expat)))
>>
>
>Cyril.
>
>

[-- Attachment #2: Type: application/pgp-signature, Size: 181 bytes --]