[PATCH] gnu: sdcv: Add new variable.

[PATCH] gnu: sdcv: Add new variable.

[Tomáš Čech]

* gnu/packages/dictionaries.scm (sdcv): New variable.
---
 gnu/packages/dictionaries.scm | 47 ++++++++++++++++++++++++++++++++++++++-----
 1 file changed, 42 insertions(+), 5 deletions(-)

diff --git a/gnu/packages/dictionaries.scm b/gnu/packages/dictionaries.scm
index 345d0a2..b18e02a 100644
--- a/gnu/packages/dictionaries.scm
+++ b/gnu/packages/dictionaries.scm
@@ -17,14 +17,18 @@
 ;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
 
 (define-module (gnu packages dictionaries)
-  #:use-module (guix licenses)
+  #:use-module ((guix licenses) #:prefix license:)
   #:use-module (guix packages)
   #:use-module (guix download)
   #:use-module (guix build-system trivial)
+  #:use-module (guix build-system cmake)
   #:use-module (gnu packages base)
-  #:use-module (gnu packages texinfo)
-  #:use-module ((gnu packages compression)
-                #:select (gzip)))
+  #:use-module (gnu packages compression)
+  #:use-module (gnu packages gettext)
+  #:use-module (gnu packages glib)
+  #:use-module (gnu packages pkg-config)
+  #:use-module (gnu packages readline)
+  #:use-module (gnu packages texinfo))
 
 (define-public vera
   (package
@@ -75,4 +79,37 @@
     (description
      "V.E.R.A. (Virtual Entity of Relevant Acronyms) is a list of computing
 acronyms distributed as an info document.")
-    (license fdl1.3+)))
+    (license license:fdl1.3+)))
+
+(define-public sdcv
+  (package
+    (name "sdcv")
+    (version "0.5.0-beta4")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "mirror://sourceforge/project/sdcv/sdcv/sdcv-"
+                           version "-Source.tar.bz2"))
+       (sha256
+        (base32 "1b9v91al2c1499q6yx6q8jggid0714444mfj6myqgz3nvqjyrrqr"))))
+    (build-system cmake-build-system)
+    (native-inputs
+     `(("pkg-config" ,pkg-config)))
+    (inputs
+     `(("glib" ,glib)
+       ("gettext" ,gnu-gettext)
+       ("readline" ,readline)
+       ("zlib" ,zlib)))
+    (arguments
+     `(#:tests? #f ; no tests implemented
+       #:phases
+       ;; this is known workaround for missing lang files
+       (alist-cons-after 'build 'build-lang
+                         (lambda _ (zero? (system* "make" "lang")))
+                         %standard-phases)))
+    (home-page "http://sdcv.sourceforge.net/")
+    (synopsis "Command line variant of StarDict")
+    (description
+     "Sdcv is command line dictionary utility, which supports StarDict dictinary
+format.")
+    (license license:gpl2+)))
-- 
2.2.1

Re: [PATCH] gnu: sdcv: Add new variable.

[Andreas Enge]

Hello,

just a tiny comment: Please use

gnu: Add sdcv.

gnu: Add agg.

as first lines of your commits; I find this convention quite useful when
grepping through the output of "git log".

Andreas

Re: [PATCH] gnu: sdcv: Add new variable.

[Tomáš Čech]

On Mon, Mar 16, 2015 at 10:54:52AM +0100, Andreas Enge wrote:
>Hello,
>
>just a tiny comment: Please use
>
>gnu: Add sdcv.
>
>gnu: Add agg.
>
>as first lines of your commits; I find this convention quite useful when
>grepping through the output of "git log".

Will doo. Changed.

S_W

Re: [PATCH] gnu: sdcv: Add new variable.

[Ludovic Courtès]

Tomáš Čech <sleep_walker@gnu.org> skribis:

> * gnu/packages/dictionaries.scm (sdcv): New variable.

You pushed it already but I have some comments anyway:

> +(define-public sdcv
> +  (package
> +    (name "sdcv")
> +    (version "0.5.0-beta4")

The policy is to provide only stable versions, unless there’s a very
good reason to do otherwise.  Could we use the previous version until
0.5.0 is out?

> +    (synopsis "Command line variant of StarDict")

Could you change it to be self-contained–i.e., without referring to
StarDict (which I don’t know, and perhaps is not very well known.)

> +    (description
> +     "Sdcv is command line dictionary utility, which supports StarDict dictinary
> +format.")

Typo: “dictionary”.

Please expound, explaining what it does concretely.  Perhaps get
inspiration from the README or web page.

TIA,
Ludo’.

Re: [PATCH] gnu: sdcv: Add new variable.

[Tomáš Čech]

[-- Attachment #1: Type: text/plain, Size: 2124 bytes --]

On Wed, Mar 18, 2015 at 09:39:49AM +0100, Ludovic Courtès wrote:
>Tomáš Čech <sleep_walker@gnu.org> skribis:
>
>> * gnu/packages/dictionaries.scm (sdcv): New variable.
>
>You pushed it already but I have some comments anyway:

Oh, I took that there are no objections already. Sorry about that.
>
>> +(define-public sdcv
>> +  (package
>> +    (name "sdcv")
>> +    (version "0.5.0-beta4")
>
>The policy is to provide only stable versions, unless there’s a very
>good reason to do otherwise.  Could we use the previous version until
>0.5.0 is out?

Previous version of this tool is 0.4.2, which is 8 years old, it won't work with recent compilers (it's their statement, not my experiment though), could suffer with allignment issues on more exotic architectures (ARM among them).

I can add comment with the reasoning.

>> +    (synopsis "Command line variant of StarDict")
>
>Could you change it to be self-contained–i.e., without referring to
>StarDict (which I don’t know, and perhaps is not very well known.)

sdcv stands for - StarDict Command line Variant
This is where I took the synopsis from.

It's hard to believe that you have never heard of StarDict. I'm not
aware of any offline sotfware dictionary software which does not
support StarDict dictionary format and doesn't state it's relation to
stardict - be it GoldenDict, QStardict or this sdcv.

Is "Command line offline dictionary" satisfactory?
>> +    (description
>> +     "Sdcv is command line dictionary utility, which supports StarDict dictinary
>> +format.")
>
>Typo: “dictionary”.

Thanks.

>
>Please expound, explaining what it does concretely.  Perhaps get
>inspiration from the README or web page.

I'm afraid that their web or README is useless for this case.

Is this satisfactory?:
"Sdcv is command line dictionary utility with support of StarDict
dictionary format.  For word in one language it can find translation
in all installed dictionaries at the same time and without specifying
original language.  With proper dictionary it can also work as
encyclopedic dictionary."

[-- Attachment #2: Type: application/pgp-signature, Size: 181 bytes --]

Re: [PATCH] gnu: sdcv: Add new variable.

[Ludovic Courtès]

Tomáš Čech <sleep_walker@gnu.org> skribis:

> On Wed, Mar 18, 2015 at 09:39:49AM +0100, Ludovic Courtès wrote:
>>Tomáš Čech <sleep_walker@gnu.org> skribis:
>>
>>> * gnu/packages/dictionaries.scm (sdcv): New variable.
>>
>>You pushed it already but I have some comments anyway:
>
> Oh, I took that there are no objections already. Sorry about that.

That’s OK, I just happened to have comments.  ;-)

>>> +(define-public sdcv
>>> +  (package
>>> +    (name "sdcv")
>>> +    (version "0.5.0-beta4")
>>
>>The policy is to provide only stable versions, unless there’s a very
>>good reason to do otherwise.  Could we use the previous version until
>>0.5.0 is out?
>
> Previous version of this tool is 0.4.2, which is 8 years old, it won't work with recent compilers (it's their statement, not my experiment though), could suffer with allignment issues on more exotic architectures (ARM among them).

Sounds like a good reason.  “beta4” suggests 0.5.0 will soon be released
though, no?

> I can add comment with the reasoning.

Yes please.

>>> +    (synopsis "Command line variant of StarDict")
>>
>>Could you change it to be self-contained–i.e., without referring to
>>StarDict (which I don’t know, and perhaps is not very well known.)
>
> sdcv stands for - StarDict Command line Variant
> This is where I took the synopsis from.
>
> It's hard to believe that you have never heard of StarDict. I'm not
> aware of any offline sotfware dictionary software which does not
> support StarDict dictionary format and doesn't state it's relation to
> stardict - be it GoldenDict, QStardict or this sdcv.

What I have heard of doesn’t really matter–hopefully I’m not the only
user of this.  ;-)

Anyway, “StarDict-compatible command-line dictionary program” maybe?

Now that I try to learn about StarDict, I stumble upon this at
<http://stardict.sourceforge.net/>:

  The original StarDict project has recently been removed from
  SourceForge due to copyright infringement reports.

And at <http://sdcv.sourceforge.net/>, sdvc describes itself as the
“console version of [the] StarDict program”, which is not
confidence-inspiring.  Some files such as dictziplib.cpp do indeed seem
to come from StarDict.

Could you check if you can find more information?  It’s in Debian and
not on <http://libreplanet.org/wiki/NONFSDG>, which is encouraging.

> Is this satisfactory?:
> "Sdcv is command line dictionary utility with support of StarDict

“with support for the StarDict”

> dictionary format.  For word in one language it can find translation
> in all installed dictionaries at the same time and without specifying
> original language.

What about “It can translate words from any language to any other language
for which a dictionary is available.”?

> With proper dictionary it can also work as encyclopedic dictionary."

“can also work as an encyclopedia”

Thanks,
Ludo’.

Re: [PATCH] gnu: sdcv: Add new variable.

[Tomáš Čech]

[-- Attachment #1: Type: text/plain, Size: 4170 bytes --]

On Wed, Mar 18, 2015 at 02:28:25PM +0100, Ludovic Courtès wrote:
>Tomáš Čech <sleep_walker@gnu.org> skribis:
>
>> On Wed, Mar 18, 2015 at 09:39:49AM +0100, Ludovic Courtès wrote:
>>>Tomáš Čech <sleep_walker@gnu.org> skribis:
>>>
>>>> * gnu/packages/dictionaries.scm (sdcv): New variable.
>>>
>>>You pushed it already but I have some comments anyway:
>>
>> Oh, I took that there are no objections already. Sorry about that.
>
>That’s OK, I just happened to have comments.  ;-)
>
>>>> +(define-public sdcv
>>>> +  (package
>>>> +    (name "sdcv")
>>>> +    (version "0.5.0-beta4")
>>>
>>>The policy is to provide only stable versions, unless there’s a very
>>>good reason to do otherwise.  Could we use the previous version until
>>>0.5.0 is out?
>>
>> Previous version of this tool is 0.4.2, which is 8 years old, it won't work with recent compilers (it's their statement, not my experiment though), could suffer with allignment issues on more exotic architectures (ARM among them).
>
>Sounds like a good reason.  “beta4” suggests 0.5.0 will soon be released
>though, no?

I'd rather not speculate - beta2 was released 2013-07-07, beta4 was
released 2014-10-24. If there is planned beta7, it may be released
after GNU Hurd.

>> I can add comment with the reasoning.
>
>Yes please.
>
>>>> +    (synopsis "Command line variant of StarDict")
>>>
>>>Could you change it to be self-contained–i.e., without referring to
>>>StarDict (which I don’t know, and perhaps is not very well known.)
>>
>> sdcv stands for - StarDict Command line Variant
>> This is where I took the synopsis from.
>>
>> It's hard to believe that you have never heard of StarDict. I'm not
>> aware of any offline sotfware dictionary software which does not
>> support StarDict dictionary format and doesn't state it's relation to
>> stardict - be it GoldenDict, QStardict or this sdcv.
>
>What I have heard of doesn’t really matter–hopefully I’m not the only
>user of this.  ;-)
>
>Anyway, “StarDict-compatible command-line dictionary program” maybe?

OK.


>Now that I try to learn about StarDict, I stumble upon this at
><http://stardict.sourceforge.net/>:
>
>  The original StarDict project has recently been removed from
>  SourceForge due to copyright infringement reports.
>

It's hard to find anything now but AFAIR they hosted besides the
software also data, which weren't respecting copyright of original
source.

>And at <http://sdcv.sourceforge.net/>, sdvc describes itself as the
>“console version of [the] StarDict program”, which is not
>confidence-inspiring.  Some files such as dictziplib.cpp do indeed seem
>to come from StarDict.

I wasn't afraid before but now it works as FUD from the sf.net side
because the lack of information available.

>Could you check if you can find more information?  It’s in Debian and
>not on <http://libreplanet.org/wiki/NONFSDG>, which is encouraging.


The file you mentioned looks like from stardict project, but was
originally taken from dictd-1.9.7 as it states and during it's history
it always had GPL license (started with GPL1).


But there are also similarities between
stardict-3.0.4/dict/src/lib/mapfile.h
and
sdcv-0.5.0-beta4-Source/src/mapfile.hpp

and that is missing license in sdcv completely.

Further - distance.cpp (GPL) and distance.hpp (no license in header)
are probably related among projects.

Lets scratch it whole, I'm not laywer.

When there is webkit package, I may give a try to GoldenDict.

S_W


>> Is this satisfactory?:
>> "Sdcv is command line dictionary utility with support of StarDict
>
>“with support for the StarDict”
>
>> dictionary format.  For word in one language it can find translation
>> in all installed dictionaries at the same time and without specifying
>> original language.
>
>What about “It can translate words from any language to any other language
>for which a dictionary is available.”?
>
>> With proper dictionary it can also work as encyclopedic dictionary."
>
>“can also work as an encyclopedia”
>

Thanks for the fixes.

S_W

[-- Attachment #2: Type: application/pgp-signature, Size: 181 bytes --]

[PATCH] Revert "gnu: Add sdcv."

[Tomáš Čech]

This reverts commit 004eb31859971f9602f618cbdf6612f4bcaddd9c.
---
 gnu/packages/dictionaries.scm | 47 +++++--------------------------------------
 1 file changed, 5 insertions(+), 42 deletions(-)

diff --git a/gnu/packages/dictionaries.scm b/gnu/packages/dictionaries.scm
index b18e02a..345d0a2 100644
--- a/gnu/packages/dictionaries.scm
+++ b/gnu/packages/dictionaries.scm
@@ -17,18 +17,14 @@
 ;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
 
 (define-module (gnu packages dictionaries)
-  #:use-module ((guix licenses) #:prefix license:)
+  #:use-module (guix licenses)
   #:use-module (guix packages)
   #:use-module (guix download)
   #:use-module (guix build-system trivial)
-  #:use-module (guix build-system cmake)
   #:use-module (gnu packages base)
-  #:use-module (gnu packages compression)
-  #:use-module (gnu packages gettext)
-  #:use-module (gnu packages glib)
-  #:use-module (gnu packages pkg-config)
-  #:use-module (gnu packages readline)
-  #:use-module (gnu packages texinfo))
+  #:use-module (gnu packages texinfo)
+  #:use-module ((gnu packages compression)
+                #:select (gzip)))
 
 (define-public vera
   (package
@@ -79,37 +75,4 @@
     (description
      "V.E.R.A. (Virtual Entity of Relevant Acronyms) is a list of computing
 acronyms distributed as an info document.")
-    (license license:fdl1.3+)))
-
-(define-public sdcv
-  (package
-    (name "sdcv")
-    (version "0.5.0-beta4")
-    (source
-     (origin
-       (method url-fetch)
-       (uri (string-append "mirror://sourceforge/project/sdcv/sdcv/sdcv-"
-                           version "-Source.tar.bz2"))
-       (sha256
-        (base32 "1b9v91al2c1499q6yx6q8jggid0714444mfj6myqgz3nvqjyrrqr"))))
-    (build-system cmake-build-system)
-    (native-inputs
-     `(("pkg-config" ,pkg-config)))
-    (inputs
-     `(("glib" ,glib)
-       ("gettext" ,gnu-gettext)
-       ("readline" ,readline)
-       ("zlib" ,zlib)))
-    (arguments
-     `(#:tests? #f ; no tests implemented
-       #:phases
-       ;; this is known workaround for missing lang files
-       (alist-cons-after 'build 'build-lang
-                         (lambda _ (zero? (system* "make" "lang")))
-                         %standard-phases)))
-    (home-page "http://sdcv.sourceforge.net/")
-    (synopsis "Command line variant of StarDict")
-    (description
-     "Sdcv is command line dictionary utility, which supports StarDict dictinary
-format.")
-    (license license:gpl2+)))
+    (license fdl1.3+)))
-- 
2.2.1

Re: [PATCH] gnu: sdcv: Add new variable.

[Ludovic Courtès]

Tomáš Čech <sleep_walker@gnu.org> skribis:

> On Wed, Mar 18, 2015 at 02:28:25PM +0100, Ludovic Courtès wrote:
>>Tomáš Čech <sleep_walker@gnu.org> skribis:

[...]

>>And at <http://sdcv.sourceforge.net/>, sdvc describes itself as the
>>“console version of [the] StarDict program”, which is not
>>confidence-inspiring.  Some files such as dictziplib.cpp do indeed seem
>>to come from StarDict.
>
> I wasn't afraid before but now it works as FUD from the sf.net side
> because the lack of information available.
>
>>Could you check if you can find more information?  It’s in Debian and
>>not on <http://libreplanet.org/wiki/NONFSDG>, which is encouraging.
>
>
> The file you mentioned looks like from stardict project, but was
> originally taken from dictd-1.9.7 as it states and during it's history
> it always had GPL license (started with GPL1).

Good.

> But there are also similarities between
> stardict-3.0.4/dict/src/lib/mapfile.h
> and
> sdcv-0.5.0-beta4-Source/src/mapfile.hpp
>
> and that is missing license in sdcv completely.
>
> Further - distance.cpp (GPL) and distance.hpp (no license in header)
> are probably related among projects.

OK.

> Lets scratch it whole, I'm not laywer.
>
> When there is webkit package, I may give a try to GoldenDict.

GNU Dico and the original dictd projects seem to provide comparable
replacements.  Would these fulfill the same use cases?

If the answer is yes, then indeed, let’s remove sdcv and add these
instead.  If the answer is no, it may be best to get advice from
gnu-linux-libre@nongnu.org.

Thanks for investigating!

Ludo’.

Re: [PATCH] gnu: sdcv: Add new variable.

[Tomáš Čech]

[-- Attachment #1: Type: text/plain, Size: 1941 bytes --]

On Thu, Mar 19, 2015 at 05:02:05PM +0100, Ludovic Courtès wrote:
>Tomáš Čech <sleep_walker@gnu.org> skribis:
>
>> On Wed, Mar 18, 2015 at 02:28:25PM +0100, Ludovic Courtès wrote:
>>>Tomáš Čech <sleep_walker@gnu.org> skribis:
>
>[...]
>
>>>And at <http://sdcv.sourceforge.net/>, sdvc describes itself as the
>>>“console version of [the] StarDict program”, which is not
>>>confidence-inspiring.  Some files such as dictziplib.cpp do indeed seem
>>>to come from StarDict.
>>
>> I wasn't afraid before but now it works as FUD from the sf.net side
>> because the lack of information available.
>>
>>>Could you check if you can find more information?  It’s in Debian and
>>>not on <http://libreplanet.org/wiki/NONFSDG>, which is encouraging.
>>
>>
>> The file you mentioned looks like from stardict project, but was
>> originally taken from dictd-1.9.7 as it states and during it's history
>> it always had GPL license (started with GPL1).
>
>Good.
>
>> But there are also similarities between
>> stardict-3.0.4/dict/src/lib/mapfile.h
>> and
>> sdcv-0.5.0-beta4-Source/src/mapfile.hpp
>>
>> and that is missing license in sdcv completely.
>>
>> Further - distance.cpp (GPL) and distance.hpp (no license in header)
>> are probably related among projects.
>
>OK.
>
>> Lets scratch it whole, I'm not laywer.
>>
>> When there is webkit package, I may give a try to GoldenDict.
>
>GNU Dico and the original dictd projects seem to provide comparable
>replacements.  Would these fulfill the same use cases?
>
>If the answer is yes, then indeed, let’s remove sdcv and add these
>instead.  If the answer is no, it may be best to get advice from
>gnu-linux-libre@nongnu.org.

I don't think I want to invest more time in this package. The code is
ready and can be found on mailing list if anyone would like to revive
it and request audit.

I applied the reverted patch.

Thanks.

S_W

[-- Attachment #2: Type: application/pgp-signature, Size: 181 bytes --]