taskwarrior

taskwarrior

[Tomáš Čech]

I prepared taskwarrior package in new file gnu/packages/task.scm since I
couldn't find better place. But I'm taking advices.

Thanks in advance for review

S_W

[PATCH v2] gnu: Add taskwarrior.

[Tomáš Čech]

* gnu/packages/task.scm: New file.
* gnu-system.am (GNU_SYSTEM_MODULES): Add new file here.
---
 gnu-system.am         |  1 +
 gnu/packages/task.scm | 68 +++++++++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 69 insertions(+)
 create mode 100644 gnu/packages/task.scm

diff --git a/gnu-system.am b/gnu-system.am
index 2175605..f4c92dd 100644
--- a/gnu-system.am
+++ b/gnu-system.am
@@ -273,6 +273,7 @@ GNU_SYSTEM_MODULES =				\
   gnu/packages/swig.scm				\
   gnu/packages/sxiv.scm				\
   gnu/packages/synergy.scm			\
+  gnu/packages/task.scm				\
   gnu/packages/tbb.scm				\
   gnu/packages/tcl.scm				\
   gnu/packages/tcsh.scm				\
diff --git a/gnu/packages/task.scm b/gnu/packages/task.scm
new file mode 100644
index 0000000..d643146
--- /dev/null
+++ b/gnu/packages/task.scm
@@ -0,0 +1,68 @@
+;;; GNU Guix --- Functional package management for GNU
+;;; Copyright © 2015 Tomáš Čech <sleep_walker@suse.cz>
+;;;
+;;; This file is part of GNU Guix.
+;;;
+;;; GNU Guix is free software; you can redistribute it and/or modify it
+;;; under the terms of the GNU General Public License as published by
+;;; the Free Software Foundation; either version 3 of the License, or (at
+;;; your option) any later version.
+;;;
+;;; GNU Guix is distributed in the hope that it will be useful, but
+;;; WITHOUT ANY WARRANTY; without even the implied warranty of
+;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+;;; GNU General Public License for more details.
+;;;
+;;; You should have received a copy of the GNU General Public License
+;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
+
+(define-module (gnu packages task)
+  #:use-module ((guix licenses) #:prefix license:)
+  #:use-module (guix packages)
+  #:use-module (gnu packages base)
+  #:use-module (gnu packages gnutls)
+  #:use-module (gnu packages linux)
+  #:use-module (gnu packages lua)
+  #:use-module (guix download)
+  #:use-module (guix build-system cmake)
+  )
+
+(define-public taskwarrior
+  (package
+    (name "taskwarrior")
+    (version "2.4.1")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "http://taskwarrior.org/download/task-" version ".tar.gz"))
+       (sha256 (base32
+                "1qn2jwskrkqg3lszkcd37h06j4a1spfkr8z9yq17p59r8v34h3nr"))))
+    (build-system cmake-build-system)
+    (inputs
+     `(("util-linux" ,util-linux)
+       ("gnutls" ,gnutls)
+       ("lua" ,lua)
+       ("coreutils" ,coreutils)))
+    (arguments
+     `(#:tests? #f ; skip tests
+       #:phases
+       (alist-cons-before
+        'patch-source-shebangs 'remove-broken-symlinks
+        (lambda _
+          ;; these files are broken symlinks - lets just delete them
+          (delete-file "src/cal")
+          (delete-file "src/calendar")
+          (delete-file "src/tw"))
+        %standard-phases))
+    (home-page "http://taskwarrior.org")
+    (synopsis
+     "Command line task manager")
+    (description
+     "Taskwarrior is mature command line task manager following Getting Things
+Done time management method.  It supports network synchronization, filtering
+and quering data, exposing task data in multiple formats to other tools which
+allowed to create healthy ecosystem of tools using taskwarrior.")
+    ;; Taskwarrior is licensed under MIT license, which is identical to
+    ;; Expat License
+    (license license:expat)))
-- 
2.2.1

Re: [PATCH v2] gnu: Add taskwarrior.

[Tomáš Čech]

[-- Attachment #1: Type: text/plain, Size: 3152 bytes --]

On Fri, Mar 13, 2015 at 01:57:01AM +0100, Tomáš Čech wrote:
>* gnu/packages/task.scm: New file.
>* gnu-system.am (GNU_SYSTEM_MODULES): Add new file here.
>---
> gnu-system.am         |  1 +
> gnu/packages/task.scm | 68 +++++++++++++++++++++++++++++++++++++++++++++++++++
> 2 files changed, 69 insertions(+)
> create mode 100644 gnu/packages/task.scm
>
>diff --git a/gnu-system.am b/gnu-system.am
>index 2175605..f4c92dd 100644
>--- a/gnu-system.am
>+++ b/gnu-system.am
>@@ -273,6 +273,7 @@ GNU_SYSTEM_MODULES =				\
>   gnu/packages/swig.scm				\
>   gnu/packages/sxiv.scm				\
>   gnu/packages/synergy.scm			\
>+  gnu/packages/task.scm				\
>   gnu/packages/tbb.scm				\
>   gnu/packages/tcl.scm				\
>   gnu/packages/tcsh.scm				\
>diff --git a/gnu/packages/task.scm b/gnu/packages/task.scm
>new file mode 100644
>index 0000000..d643146
>--- /dev/null
>+++ b/gnu/packages/task.scm
>@@ -0,0 +1,68 @@
>+;;; GNU Guix --- Functional package management for GNU
>+;;; Copyright © 2015 Tomáš Čech <sleep_walker@suse.cz>
>+;;;
>+;;; This file is part of GNU Guix.
>+;;;
>+;;; GNU Guix is free software; you can redistribute it and/or modify it
>+;;; under the terms of the GNU General Public License as published by
>+;;; the Free Software Foundation; either version 3 of the License, or (at
>+;;; your option) any later version.
>+;;;
>+;;; GNU Guix is distributed in the hope that it will be useful, but
>+;;; WITHOUT ANY WARRANTY; without even the implied warranty of
>+;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
>+;;; GNU General Public License for more details.
>+;;;
>+;;; You should have received a copy of the GNU General Public License
>+;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
>+
>+(define-module (gnu packages task)
>+  #:use-module ((guix licenses) #:prefix license:)
>+  #:use-module (guix packages)
>+  #:use-module (gnu packages base)
>+  #:use-module (gnu packages gnutls)
>+  #:use-module (gnu packages linux)
>+  #:use-module (gnu packages lua)
>+  #:use-module (guix download)
>+  #:use-module (guix build-system cmake)
>+  )
>+
>+(define-public taskwarrior
>+  (package
>+    (name "taskwarrior")
>+    (version "2.4.1")
>+    (source
>+     (origin
>+       (method url-fetch)
>+       (uri (string-append
>+             "http://taskwarrior.org/download/task-" version ".tar.gz"))
>+       (sha256 (base32
>+                "1qn2jwskrkqg3lszkcd37h06j4a1spfkr8z9yq17p59r8v34h3nr"))))
>+    (build-system cmake-build-system)
>+    (inputs
>+     `(("util-linux" ,util-linux)
>+       ("gnutls" ,gnutls)
>+       ("lua" ,lua)
>+       ("coreutils" ,coreutils)))
>+    (arguments
>+     `(#:tests? #f ; skip tests
>+       #:phases
>+       (alist-cons-before
>+        'patch-source-shebangs 'remove-broken-symlinks
>+        (lambda _
>+          ;; these files are broken symlinks - lets just delete them
>+          (delete-file "src/cal")
>+          (delete-file "src/calendar")
>+          (delete-file "src/tw"))
>+        %standard-phases))

Here is missing one parenthesis ')'.

S_W

[-- Attachment #2: Type: application/pgp-signature, Size: 181 bytes --]

Re: [PATCH v2] gnu: Add taskwarrior.

[Eric Bavier]

On 2015-03-12 19:57, Tomáš Čech wrote:
> * gnu/packages/task.scm: New file.
> * gnu-system.am (GNU_SYSTEM_MODULES): Add new file here.
> ---
>  gnu-system.am         |  1 +
>  gnu/packages/task.scm | 68 
> +++++++++++++++++++++++++++++++++++++++++++++++++++
[...]
> +    (inputs
> +     `(("util-linux" ,util-linux)
> +       ("gnutls" ,gnutls)
> +       ("lua" ,lua)
> +       ("coreutils" ,coreutils)))

Can coreutils be left out here, since it is an implicit input?

> +    ;; Taskwarrior is licensed under MIT license, which is identical 
> to
> +    ;; Expat License
> +    (license license:expat)))

Is it actually the Expat license, or the X11 license, which is also 
sometimes called the "MIT license"?  In either case, I would perhaps put 
quotation marks around "MIT license" to indicate the ambiguity.

-- 
`~Eric

Re: [PATCH v2] gnu: Add taskwarrior.

[Tomáš Čech]

[-- Attachment #1: Type: text/plain, Size: 1891 bytes --]

Thank you for your review.

On Fri, Mar 13, 2015 at 02:16:00PM -0500, Eric Bavier wrote:
>On 2015-03-12 19:57, Tomáš Čech wrote:
>>* gnu/packages/task.scm: New file.
>>* gnu-system.am (GNU_SYSTEM_MODULES): Add new file here.
>>---
>> gnu-system.am         |  1 +
>> gnu/packages/task.scm | 68 
>>+++++++++++++++++++++++++++++++++++++++++++++++++++
>[...]
>>+    (inputs
>>+     `(("util-linux" ,util-linux)
>>+       ("gnutls" ,gnutls)
>>+       ("lua" ,lua)
>>+       ("coreutils" ,coreutils)))
>
>Can coreutils be left out here, since it is an implicit input?

OK, I will omit it.

>
>>+    ;; Taskwarrior is licensed under MIT license, which is 
>>identical to
>>+    ;; Expat License
>>+    (license license:expat)))
>
>Is it actually the Expat license, or the X11 license, which is also
>sometimes called the "MIT license"?  In either case, I would perhaps 
>put quotation marks around "MIT license" to indicate the ambiguity.

I did comparison and it is Expat license as intended in
(guix licenses).

X11 license has aditional paragraph on use of trademarks.

You can have a look here to make your opinion:

https://git.tasktools.org/projects/TM/repos/task/browse/COPYING

I'm not lawyer and I don't feel like authority in this area but

1] I believe that intention of authors is obvious with the URL in the
   end of file. They choose MIT as their license, they used
   opensource.org license list to express their will. And I respect
   their choice.

2] MIT license is also recognized by spdx.org
   https://spdx.org/licenses/MIT

   In my experience openSUSE, Gentoo uses the same license name, Debian
   at least mentions Expat (https://www.debian.org/legal/licenses/mit).

So I'd rather not put quotation marks around "MIT license". I'd even like
to have MIT license as alias or separate license.

Best regards,

S_W

[-- Attachment #2: Type: application/pgp-signature, Size: 181 bytes --]

(unknown),

[Tomáš Čech]

I haven't seen any further reaction for 12 days so I hope you don't mind that
I resend it again.

[PATCH v2] gnu: Add taskwarrior.

[Tomáš Čech]

From: Tomáš Čech <sleep_walker@suse.cz>

* gnu/packages/task.scm: New file.
* gnu-system.am (GNU_SYSTEM_MODULES): Add it.
---
 gnu-system.am         |  1 +
 gnu/packages/task.scm | 67 +++++++++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 68 insertions(+)
 create mode 100644 gnu/packages/task.scm

diff --git a/gnu-system.am b/gnu-system.am
index 1f2ebdf..d25c4df 100644
--- a/gnu-system.am
+++ b/gnu-system.am
@@ -275,6 +275,7 @@ GNU_SYSTEM_MODULES =				\
   gnu/packages/swig.scm				\
   gnu/packages/sxiv.scm				\
   gnu/packages/synergy.scm			\
+  gnu/packages/task.scm				\
   gnu/packages/tbb.scm				\
   gnu/packages/tcl.scm				\
   gnu/packages/tcsh.scm				\
diff --git a/gnu/packages/task.scm b/gnu/packages/task.scm
new file mode 100644
index 0000000..af14b14
--- /dev/null
+++ b/gnu/packages/task.scm
@@ -0,0 +1,67 @@
+;;; GNU Guix --- Functional package management for GNU
+;;; Copyright © 2015 Tomáš Čech <sleep_walker@suse.cz>
+;;;
+;;; This file is part of GNU Guix.
+;;;
+;;; GNU Guix is free software; you can redistribute it and/or modify it
+;;; under the terms of the GNU General Public License as published by
+;;; the Free Software Foundation; either version 3 of the License, or (at
+;;; your option) any later version.
+;;;
+;;; GNU Guix is distributed in the hope that it will be useful, but
+;;; WITHOUT ANY WARRANTY; without even the implied warranty of
+;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+;;; GNU General Public License for more details.
+;;;
+;;; You should have received a copy of the GNU General Public License
+;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
+
+(define-module (gnu packages task)
+  #:use-module ((guix licenses) #:prefix license:)
+  #:use-module (guix packages)
+  #:use-module (gnu packages base)
+  #:use-module (gnu packages gnutls)
+  #:use-module (gnu packages linux)
+  #:use-module (gnu packages lua)
+  #:use-module (guix download)
+  #:use-module (guix build-system cmake)
+  )
+
+(define-public taskwarrior
+  (package
+    (name "taskwarrior")
+    (version "2.4.1")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "http://taskwarrior.org/download/task-" version ".tar.gz"))
+       (sha256 (base32
+                "1qn2jwskrkqg3lszkcd37h06j4a1spfkr8z9yq17p59r8v34h3nr"))))
+    (build-system cmake-build-system)
+    (inputs
+     `(("gnutls" ,gnutls)
+       ("lua" ,lua)
+       ("util-linux" ,util-linux)))
+    (arguments
+     `(#:tests? #f ; skip tests
+       #:phases
+       (alist-cons-before
+        'patch-source-shebangs 'remove-broken-symlinks
+        (lambda _
+          ;; these files are broken symlinks - lets just delete them
+          (delete-file "src/cal")
+          (delete-file "src/calendar")
+          (delete-file "src/tw"))
+        %standard-phases)))
+    (home-page "http://taskwarrior.org")
+    (synopsis
+     "Command line task manager")
+    (description
+     "Taskwarrior is mature command line task manager following Getting Things
+Done time management method.  It supports network synchronization, filtering
+and quering data, exposing task data in multiple formats to other tools which
+allowed to create healthy ecosystem of tools using taskwarrior.")
+    ;; Taskwarrior is licensed under MIT license, which is identical to
+    ;; Expat License
+    (license license:expat)))
-- 
2.2.1

Re: [PATCH v2] gnu: Add taskwarrior.

[Cyril Roelandt]

Sorry for the delay in reviewing this.

On 03/25/2015 11:49 PM, Tomáš Čech wrote:
> From: Tomáš Čech <sleep_walker@suse.cz>
> 
> * gnu/packages/task.scm: New file.
> * gnu-system.am (GNU_SYSTEM_MODULES): Add it.
> ---
>  gnu-system.am         |  1 +
>  gnu/packages/task.scm | 67 +++++++++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 68 insertions(+)
>  create mode 100644 gnu/packages/task.scm
> 
> diff --git a/gnu-system.am b/gnu-system.am
> index 1f2ebdf..d25c4df 100644
> --- a/gnu-system.am
> +++ b/gnu-system.am
> @@ -275,6 +275,7 @@ GNU_SYSTEM_MODULES =				\
>    gnu/packages/swig.scm				\
>    gnu/packages/sxiv.scm				\
>    gnu/packages/synergy.scm			\
> +  gnu/packages/task.scm				\
>    gnu/packages/tbb.scm				\
>    gnu/packages/tcl.scm				\
>    gnu/packages/tcsh.scm				\
> diff --git a/gnu/packages/task.scm b/gnu/packages/task.scm
> new file mode 100644
> index 0000000..af14b14
> --- /dev/null
> +++ b/gnu/packages/task.scm
> @@ -0,0 +1,67 @@
> +;;; GNU Guix --- Functional package management for GNU
> +;;; Copyright © 2015 Tomáš Čech <sleep_walker@suse.cz>
> +;;;
> +;;; This file is part of GNU Guix.
> +;;;
> +;;; GNU Guix is free software; you can redistribute it and/or modify it
> +;;; under the terms of the GNU General Public License as published by
> +;;; the Free Software Foundation; either version 3 of the License, or (at
> +;;; your option) any later version.
> +;;;
> +;;; GNU Guix is distributed in the hope that it will be useful, but
> +;;; WITHOUT ANY WARRANTY; without even the implied warranty of
> +;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> +;;; GNU General Public License for more details.
> +;;;
> +;;; You should have received a copy of the GNU General Public License
> +;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
> +
> +(define-module (gnu packages task)

Why is this module called "task"?

> +  #:use-module ((guix licenses) #:prefix license:)
> +  #:use-module (guix packages)
> +  #:use-module (gnu packages base)
> +  #:use-module (gnu packages gnutls)
> +  #:use-module (gnu packages linux)
> +  #:use-module (gnu packages lua)
> +  #:use-module (guix download)
> +  #:use-module (guix build-system cmake)
> +  )

This parenthesis should be moved to the previous line.

> +
> +(define-public taskwarrior
> +  (package
> +    (name "taskwarrior")
> +    (version "2.4.1")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append
> +             "http://taskwarrior.org/download/task-" version ".tar.gz"))
> +       (sha256 (base32
> +                "1qn2jwskrkqg3lszkcd37h06j4a1spfkr8z9yq17p59r8v34h3nr"))))
> +    (build-system cmake-build-system)
> +    (inputs
> +     `(("gnutls" ,gnutls)
> +       ("lua" ,lua)
> +       ("util-linux" ,util-linux)))
> +    (arguments
> +     `(#:tests? #f ; skip tests

Why are the tests skipped? The comment should be more verbose.

> +       #:phases
> +       (alist-cons-before
> +        'patch-source-shebangs 'remove-broken-symlinks
> +        (lambda _
> +          ;; these files are broken symlinks - lets just delete them
> +          (delete-file "src/cal")
> +          (delete-file "src/calendar")
> +          (delete-file "src/tw"))
> +        %standard-phases)))
> +    (home-page "http://taskwarrior.org")
> +    (synopsis
> +     "Command line task manager")
> +    (description
> +     "Taskwarrior is mature command line task manager following Getting Things
> +Done time management method.  It supports network synchronization, filtering
> +and quering data, exposing task data in multiple formats to other tools which
> +allowed to create healthy ecosystem of tools using taskwarrior.")
> +    ;; Taskwarrior is licensed under MIT license, which is identical to
> +    ;; Expat License
> +    (license license:expat)))
> 

Cyril.

Re: [PATCH v2] gnu: Add taskwarrior.

[Tomáš Čech]

[-- Attachment #1: Type: text/plain, Size: 4275 bytes --]

On Thu, Mar 26, 2015 at 12:01:26AM +0100, Cyril Roelandt wrote:
>Sorry for the delay in reviewing this.
>
>On 03/25/2015 11:49 PM, Tomáš Čech wrote:
>> From: Tomáš Čech <sleep_walker@suse.cz>
>>
>> * gnu/packages/task.scm: New file.
>> * gnu-system.am (GNU_SYSTEM_MODULES): Add it.
>> ---
>>  gnu-system.am         |  1 +
>>  gnu/packages/task.scm | 67 +++++++++++++++++++++++++++++++++++++++++++++++++++
>>  2 files changed, 68 insertions(+)
>>  create mode 100644 gnu/packages/task.scm
>>
>> diff --git a/gnu-system.am b/gnu-system.am
>> index 1f2ebdf..d25c4df 100644
>> --- a/gnu-system.am
>> +++ b/gnu-system.am
>> @@ -275,6 +275,7 @@ GNU_SYSTEM_MODULES =				\
>>    gnu/packages/swig.scm				\
>>    gnu/packages/sxiv.scm				\
>>    gnu/packages/synergy.scm			\
>> +  gnu/packages/task.scm				\
>>    gnu/packages/tbb.scm				\
>>    gnu/packages/tcl.scm				\
>>    gnu/packages/tcsh.scm				\
>> diff --git a/gnu/packages/task.scm b/gnu/packages/task.scm
>> new file mode 100644
>> index 0000000..af14b14
>> --- /dev/null
>> +++ b/gnu/packages/task.scm
>> @@ -0,0 +1,67 @@
>> +;;; GNU Guix --- Functional package management for GNU
>> +;;; Copyright © 2015 Tomáš Čech <sleep_walker@suse.cz>
>> +;;;
>> +;;; This file is part of GNU Guix.
>> +;;;
>> +;;; GNU Guix is free software; you can redistribute it and/or modify it
>> +;;; under the terms of the GNU General Public License as published by
>> +;;; the Free Software Foundation; either version 3 of the License, or (at
>> +;;; your option) any later version.
>> +;;;
>> +;;; GNU Guix is distributed in the hope that it will be useful, but
>> +;;; WITHOUT ANY WARRANTY; without even the implied warranty of
>> +;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
>> +;;; GNU General Public License for more details.
>> +;;;
>> +;;; You should have received a copy of the GNU General Public License
>> +;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
>> +
>> +(define-module (gnu packages task)
>
>Why is this module called "task"?

Idea was task as for task management. Would task-management be better?

>
>> +  #:use-module ((guix licenses) #:prefix license:)
>> +  #:use-module (guix packages)
>> +  #:use-module (gnu packages base)
>> +  #:use-module (gnu packages gnutls)
>> +  #:use-module (gnu packages linux)
>> +  #:use-module (gnu packages lua)
>> +  #:use-module (guix download)
>> +  #:use-module (guix build-system cmake)
>> +  )
>
>This parenthesis should be moved to the previous line.

Thanks.

>> +
>> +(define-public taskwarrior
>> +  (package
>> +    (name "taskwarrior")
>> +    (version "2.4.1")
>> +    (source
>> +     (origin
>> +       (method url-fetch)
>> +       (uri (string-append
>> +             "http://taskwarrior.org/download/task-" version ".tar.gz"))
>> +       (sha256 (base32
>> +                "1qn2jwskrkqg3lszkcd37h06j4a1spfkr8z9yq17p59r8v34h3nr"))))
>> +    (build-system cmake-build-system)
>> +    (inputs
>> +     `(("gnutls" ,gnutls)
>> +       ("lua" ,lua)
>> +       ("util-linux" ,util-linux)))
>> +    (arguments
>> +     `(#:tests? #f ; skip tests
>
>Why are the tests skipped? The comment should be more verbose.

No tests implemented. Thanks - fixed.
>
>> +       #:phases
>> +       (alist-cons-before
>> +        'patch-source-shebangs 'remove-broken-symlinks
>> +        (lambda _
>> +          ;; these files are broken symlinks - lets just delete them
>> +          (delete-file "src/cal")
>> +          (delete-file "src/calendar")
>> +          (delete-file "src/tw"))
>> +        %standard-phases)))
>> +    (home-page "http://taskwarrior.org")
>> +    (synopsis
>> +     "Command line task manager")
>> +    (description
>> +     "Taskwarrior is mature command line task manager following Getting Things
>> +Done time management method.  It supports network synchronization, filtering
>> +and quering data, exposing task data in multiple formats to other tools which
>> +allowed to create healthy ecosystem of tools using taskwarrior.")
>> +    ;; Taskwarrior is licensed under MIT license, which is identical to
>> +    ;; Expat License
>> +    (license license:expat)))
>>
>
>Cyril.
>
>

[-- Attachment #2: Type: application/pgp-signature, Size: 181 bytes --]

Re: [PATCH v2] gnu: Add taskwarrior.

[Ludovic Courtès]

Tomáš Čech <sleep_walker@gnu.org> skribis:

> From: Tomáš Čech <sleep_walker@suse.cz>
>
> * gnu/packages/task.scm: New file.
> * gnu-system.am (GNU_SYSTEM_MODULES): Add it.

To complement Cyril’s review:

> +(define-module (gnu packages task)

‘task-management’, as you proposed, would be better.  Would there be
other packages in there?

> +    (description
> +     "Taskwarrior is mature command line task manager following Getting Things

Missing articles: “a mature”, “following the Getting Things Done ... method”.

> +Done time management method.  It supports network synchronization, filtering
> +and quering data, exposing task data in multiple formats to other tools which
> +allowed to create healthy ecosystem of tools using taskwarrior.")

Please remove “which allowed ...” (marketing stuff.)

> +    ;; Taskwarrior is licensed under MIT license, which is identical to
> +    ;; Expat License

Please remove this comment.  It’s just that “MIT license” is an
ambiguous name for the Expat license.

Could you send an updated patch?

Thanks!

Ludo’.

Re: [PATCH v2] gnu: Add taskwarrior.

[Tomáš Čech]

[-- Attachment #1: Type: text/plain, Size: 1468 bytes --]

On Thu, Mar 26, 2015 at 06:03:45PM +0100, Ludovic Courtès wrote:
>Tomáš Čech <sleep_walker@gnu.org> skribis:
>
>> From: Tomáš Čech <sleep_walker@suse.cz>
>>
>> * gnu/packages/task.scm: New file.
>> * gnu-system.am (GNU_SYSTEM_MODULES): Add it.
>
>To complement Cyril’s review:
>
>> +(define-module (gnu packages task)
>
>‘task-management’, as you proposed, would be better.  Would there be
>other packages in there?

I don't plan more packages ATM.

>> +    (description
>> +     "Taskwarrior is mature command line task manager following Getting Things
>
>Missing articles: “a mature”, “following the Getting Things Done ... method”.

Fixed.

>
>> +Done time management method.  It supports network synchronization, filtering
>> +and quering data, exposing task data in multiple formats to other tools which
>> +allowed to create healthy ecosystem of tools using taskwarrior.")
>
>Please remove “which allowed ...” (marketing stuff.)

Fixed. (it's my opinion, not marketing :)
>
>> +    ;; Taskwarrior is licensed under MIT license, which is identical to
>> +    ;; Expat License
>
>Please remove this comment.  It’s just that “MIT license” is an
>ambiguous name for the Expat license.

I'm really not friend of this. But I asked authors and they don't mind
call their license Expat in spite of their choice so I changed that as
you wish.

>Could you send an updated patch?

Sent.

Tomas

[-- Attachment #2: Type: application/pgp-signature, Size: 181 bytes --]

Re: [PATCH v2] gnu: Add taskwarrior.

[Tomáš Čech]

[-- Attachment #1: Type: text/plain, Size: 321 bytes --]

On Fri, Mar 27, 2015 at 08:54:08PM +0100, Tomáš Čech wrote:
>On Thu, Mar 26, 2015 at 06:03:45PM +0100, Ludovic Courtès wrote:
>>Could you send an updated patch?
>
>Sent.

I can't find patch version 3 in ML so I'd rather resend it. If I'm
only selectively and temporary blind, please, just ignore that.

S_W

[-- Attachment #2: Type: application/pgp-signature, Size: 181 bytes --]