From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andreas Enge Subject: Re: [PATCH] gnu: Add quvi. Date: Sat, 7 Mar 2015 00:05:39 +0100 Message-ID: <20150306230539.GA30428@debian> References: <87385ke82v.fsf@taylan.uni.cx> <20150306215436.GA32174@debian> <877futlp4x.fsf@netris.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:43490) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YU1JT-0001VO-Qb for guix-devel@gnu.org; Fri, 06 Mar 2015 18:05:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YU1JQ-0000aN-7P for guix-devel@gnu.org; Fri, 06 Mar 2015 18:05:47 -0500 Received: from mout.kundenserver.de ([212.227.17.24]:56254) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YU1JP-0000Y7-UL for guix-devel@gnu.org; Fri, 06 Mar 2015 18:05:44 -0500 Content-Disposition: inline In-Reply-To: <877futlp4x.fsf@netris.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Mark H Weaver Cc: guix-devel@gnu.org On Fri, Mar 06, 2015 at 05:47:26PM -0500, Mark H Weaver wrote: > I'm familiar with these packages, and I tend to agree that they are so > closely tied that it's reasonable to commit them together. That is not common practice so far, no? I do not see what would be the problem when committing them separately. > > Your indentation (here and further down) is not quite consistens, sometimes > > it it one, sometimes two spaces. > He's using the auto-indenter of Emacs Scheme Mode, which faithfully > follows the rules in our .dir-locals.el file. Curious. Why does it use sometimes one, sometimes two spaces? Can this be explained so that non-emacs users follow the same style? > >> + (string-append "liblua_LIBS=-L" lua "/libs -llua"))))) > > These are two flags and should be two entries in the list. > What Taylan wrote above looks right to me. The -L[...] and -llua are > two flags, but the variable setting "liblua_LIBS=-L[...]/libs -llua" > needs to be one argument to configure. I do not get this. Why should two flags be one argument? Do you mean that on the command line, one would write: ./configure "liblua_LIBS=-L/gnu/store/.../libs -llua" and that the call of system* adds these quotation marks implicitly? Andreas