all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Andreas Enge <andreas@enge.fr>
To: Mark H Weaver <mhw@netris.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: Add quvi.
Date: Sat, 7 Mar 2015 00:05:39 +0100	[thread overview]
Message-ID: <20150306230539.GA30428@debian> (raw)
In-Reply-To: <877futlp4x.fsf@netris.org>

On Fri, Mar 06, 2015 at 05:47:26PM -0500, Mark H Weaver wrote:
> I'm familiar with these packages, and I tend to agree that they are so
> closely tied that it's reasonable to commit them together.

That is not common practice so far, no? I do not see what would be
the problem when committing them separately.

> > Your indentation (here and further down) is not quite consistens, sometimes
> > it it one, sometimes two spaces.
> He's using the auto-indenter of Emacs Scheme Mode, which faithfully
> follows the rules in our .dir-locals.el file.

Curious. Why does it use sometimes one, sometimes two spaces? Can this be
explained so that non-emacs users follow the same style?

> >> +          (string-append "liblua_LIBS=-L" lua "/libs -llua")))))
> > These are two flags and should be two entries in the list.
> What Taylan wrote above looks right to me.  The -L[...] and -llua are
> two flags, but the variable setting "liblua_LIBS=-L[...]/libs -llua"
> needs to be one argument to configure.

I do not get this. Why should two flags be one argument? Do you mean that
on the command line, one would write:
  ./configure "liblua_LIBS=-L/gnu/store/.../libs -llua"
and that the call of system* adds these quotation marks implicitly?

Andreas

  reply	other threads:[~2015-03-06 23:05 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-04 22:00 [PATCH] gnu: Add quvi Taylan Ulrich Bayırlı/Kammer
2015-03-06 21:54 ` Andreas Enge
2015-03-06 22:47   ` Mark H Weaver
2015-03-06 23:05     ` Andreas Enge [this message]
2015-03-06 23:32       ` Mark H Weaver
2015-03-06 23:48         ` Andreas Enge

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150306230539.GA30428@debian \
    --to=andreas@enge.fr \
    --cc=guix-devel@gnu.org \
    --cc=mhw@netris.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.