all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Andreas Enge <andreas@enge.fr>
To: "Tomáš Čech" <sleep_walker@suse.cz>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 1/5] gnu: Add efl.
Date: Thu, 26 Feb 2015 22:05:14 +0100	[thread overview]
Message-ID: <20150226210514.GD12643@debian> (raw)
In-Reply-To: <1424910673-17665-1-git-send-email-sleep_walker@suse.cz>

Hello,

a few more comments:

On Thu, Feb 26, 2015 at 01:31:09AM +0100, Tomáš Čech wrote:
> +    (propagated-inputs
> +     `(("bullet" ,bullet)
> +       ("dbus" ,dbus)
> +       ("eudev" ,eudev)
> +       ("fontconfig" ,fontconfig)
> +       ("freetype" ,freetype)
> +       ("fribidi" ,fribidi)
> +       ("glib" ,glib)
> +       ("libpng" ,libpng)
> +       ("libsndfile" ,libsndfile)
> +       ("luajit" ,luajit)
> +       ("openssl" ,openssl)
> +       ("pulseaudio" ,pulseaudio)
> +       ("util-linux" ,util-linux)))

Why do all these need to be propagated? Are the all dlopenend? If they are
linked normally into executables and libraries, are ld-wrapper should take
care of them. If all or some of them need to be propagated, it would be good
to add a comment.

> * gnu/packages/efl (elementary): New variable.

This one looks safe (except for the line length of 80 characters already
mentioned by 宋文武).

> * gnu/packages/efl.scm (evas-generic-loaders): New variable.
> +       ("poppler" ,poppler)
> +       ))

The "))" should be at the end of the previous line. Apart from that,
it looks good.

> * gnu/packages/efl.scm (emotion-generic-players): New variable.

Looks good.

> * gnu/packages/efl.scm (terminology): New variable.

Looks good, too!

Andreas

  parent reply	other threads:[~2015-02-26 21:05 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-26  0:31 [PATCH 1/5] gnu: Add efl Tomáš Čech
2015-02-26  0:31 ` [PATCH 2/5] gnu: Add elementary Tomáš Čech
2015-02-27 17:01   ` Ludovic Courtès
2015-02-26  0:31 ` [PATCH 3/5] gnu: Add evas-generic-loaders Tomáš Čech
2015-02-27 17:02   ` Ludovic Courtès
2015-02-26  0:31 ` [PATCH 4/5] gnu: Add emotion-generic-players Tomáš Čech
2015-02-26 10:23   ` Andreas Enge
2015-02-26 11:14     ` Tomáš Čech
2015-02-26 12:03       ` Andreas Enge
2015-02-26 12:47       ` 宋文武
2015-02-26 18:09         ` Tomáš Čech
2015-02-26 18:16           ` Andreas Enge
2015-02-27 16:58   ` Ludovic Courtès
2015-02-26  0:31 ` [PATCH 5/5] gnu: Add terminology Tomáš Čech
2015-02-26 12:30   ` 宋文武
2015-02-27 17:04   ` Ludovic Courtès
2015-02-26 20:58 ` [PATCH 1/5] gnu: Add efl Andreas Enge
2015-02-26 21:05 ` Andreas Enge [this message]
2015-02-27 16:56 ` Ludovic Courtès
  -- strict thread matches above, loose matches on Subject: below --
2015-02-28 22:11 EFL, elementary, loaders, players and terminology - round 2 Tomáš Čech
2015-02-28 22:11 ` [PATCH 1/5] gnu: Add efl Tomáš Čech
2015-03-01 19:24   ` Andreas Enge
2015-03-01 19:43     ` tcech
2015-03-01 20:21       ` Andreas Enge
2015-03-01 20:26     ` Ludovic Courtès
2015-03-01 20:31   ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150226210514.GD12643@debian \
    --to=andreas@enge.fr \
    --cc=guix-devel@gnu.org \
    --cc=sleep_walker@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.