all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Tomáš Čech" <sleep_walker@suse.cz>
To: Andreas Enge <andreas@enge.fr>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 4/5] gnu: Add emotion-generic-players
Date: Thu, 26 Feb 2015 12:14:43 +0100	[thread overview]
Message-ID: <20150226111443.GB10407@venom> (raw)
In-Reply-To: <20150226102308.GA3600@debian.math.u-bordeaux1.fr>

[-- Attachment #1: Type: text/plain, Size: 1692 bytes --]

Hello,

thanks for review.

On Thu, Feb 26, 2015 at 11:23:27AM +0100, Andreas Enge wrote:
>Hello,
>
>just a quick comment on the descriptions. It would be good to write full
>sentences, for instance:
>
>On Thu, Feb 26, 2015 at 01:31:12AM +0100, Tomáš Čech wrote:
>> +     "Set of generic media players allowing to open video files through emotion. Useful only for emotion library based applications.")
>
>"Emotion Generic Players provides/consists of/is a set of generic ...
>It is useful only for ...".

I agree that sentences may be better, I only suck at it. I'll try
to improvide it  or I can accept any recommendations in the meantime.

>I think it would also be good to expand a bit where possible, and to introduce
>the word "enlightenment" in each of these packages (by replacing "EFL" with
>"Enlightenment Foundation Libraries",

I do agree that use of "Enlightenment Foundation Libraries" instead of
"EFL" could make it more enjoyable to read, but we could expand also
Gimp toolkit, Tool Command Language, ...

Those who would need such these packages will know and it won't help
to others anyway.

Synopsis of efl package will show you "Enlightenment Foundation Libraries".

>for instance, or adding a sentence like
>"It is part of the Enlightenment desktop environment").

Enlightenment is using the same libraries (they were developed for
Enlightenment) but the libraries are much more generic. It's like
relationship between Qt and KDE, only with reversed history order.

>Maybe call the file enlightenment.scm?

I believe efl.scm is more accurate as the packages there would be EFL
based but not necessarily Enlightenment related.

[-- Attachment #2: Type: application/pgp-signature, Size: 181 bytes --]

  reply	other threads:[~2015-02-26 11:14 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-26  0:31 [PATCH 1/5] gnu: Add efl Tomáš Čech
2015-02-26  0:31 ` [PATCH 2/5] gnu: Add elementary Tomáš Čech
2015-02-27 17:01   ` Ludovic Courtès
2015-02-26  0:31 ` [PATCH 3/5] gnu: Add evas-generic-loaders Tomáš Čech
2015-02-27 17:02   ` Ludovic Courtès
2015-02-26  0:31 ` [PATCH 4/5] gnu: Add emotion-generic-players Tomáš Čech
2015-02-26 10:23   ` Andreas Enge
2015-02-26 11:14     ` Tomáš Čech [this message]
2015-02-26 12:03       ` Andreas Enge
2015-02-26 12:47       ` 宋文武
2015-02-26 18:09         ` Tomáš Čech
2015-02-26 18:16           ` Andreas Enge
2015-02-27 16:58   ` Ludovic Courtès
2015-02-26  0:31 ` [PATCH 5/5] gnu: Add terminology Tomáš Čech
2015-02-26 12:30   ` 宋文武
2015-02-27 17:04   ` Ludovic Courtès
2015-02-26 20:58 ` [PATCH 1/5] gnu: Add efl Andreas Enge
2015-02-26 21:05 ` Andreas Enge
2015-02-27 16:56 ` Ludovic Courtès
  -- strict thread matches above, loose matches on Subject: below --
2015-02-28 22:11 EFL, elementary, loaders, players and terminology - round 2 Tomáš Čech
2015-02-28 22:11 ` [PATCH 4/5] gnu: Add emotion-generic-players Tomáš Čech
2015-03-01 20:35   ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150226111443.GB10407@venom \
    --to=sleep_walker@suse.cz \
    --cc=andreas@enge.fr \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.