From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andreas Enge Subject: Re: [PATCH 4/5] gnu: Add emotion-generic-players Date: Thu, 26 Feb 2015 11:23:27 +0100 Message-ID: <20150226102308.GA3600@debian.math.u-bordeaux1.fr> References: <1424910673-17665-1-git-send-email-sleep_walker@suse.cz> <1424910673-17665-4-git-send-email-sleep_walker@suse.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:49148) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YQvc5-0003Hw-La for guix-devel@gnu.org; Thu, 26 Feb 2015 05:24:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YQvc0-0000do-ND for guix-devel@gnu.org; Thu, 26 Feb 2015 05:24:13 -0500 Received: from mout.kundenserver.de ([212.227.17.24]:57914) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YQvc0-0000dg-EY for guix-devel@gnu.org; Thu, 26 Feb 2015 05:24:08 -0500 Content-Disposition: inline In-Reply-To: <1424910673-17665-4-git-send-email-sleep_walker@suse.cz> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: =?utf-8?B?VG9tw6HFoSDEjGVjaA==?= Cc: guix-devel@gnu.org Hello, just a quick comment on the descriptions. It would be good to write full sentences, for instance: On Thu, Feb 26, 2015 at 01:31:12AM +0100, Tomáš Čech wrote: > + "Set of generic media players allowing to open video files through emotion. Useful only for emotion library based applications.") "Emotion Generic Players provides/consists of/is a set of generic ... It is useful only for ...". I think it would also be good to expand a bit where possible, and to introduce the word "enlightenment" in each of these packages (by replacing "EFL" with "Enlightenment Foundation Libraries", for instance, or adding a sentence like "It is part of the Enlightenment desktop environment"). Maybe call the file enlightenment.scm? Andreas