From: Andreas Enge <andreas@enge.fr>
To: "Taylan Ulrich Bayırlı/Kammer" <taylanbayirli@gmail.com>
Cc: guix-devel@gnu.org
Subject: Re: ffmpeg patches
Date: Wed, 25 Feb 2015 16:07:01 +0100 [thread overview]
Message-ID: <20150225150701.GA5733@debian.math.u-bordeaux1.fr> (raw)
In-Reply-To: <87fv9u6nzp.fsf@taylan.uni.cx>
Hello,
On Wed, Feb 25, 2015 at 03:54:02PM +0100, Taylan Ulrich Bayırlı/Kammer wrote:
> - The second adds a (gnu packages audio) import to (gnu packages video),
> which makes sense I think because video media usually contains audio,
> but in my Audacity patch I had added (gnu packages video) to (gnu
> packages audio) because Audacity uses FFmpeg, and that would be a
> circular import. I would say Audacity should go into its own module,
> and we will have to remember that we cannot import video from audio.
that sounds convincing to me.
> Date: Mon, 23 Feb 2015 14:13:00 +0100
> Subject: [PATCH 1/3] gnu: ffmpeg: Fix comment.
> * gnu/packages/video.scm (ffmpeg): Remove libmp3lame from the comments listing
> additional optional dependencies, because it's already been added on the
> meanwhile.
Frankly, I would just include this silently into the second patch, dropping
a comment that has obviously become useless does not warrant its own commit
(others may have different opinons).
Is there a patch number 3?
Andreas
next prev parent reply other threads:[~2015-02-25 15:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-25 14:54 ffmpeg patches Taylan Ulrich Bayırlı/Kammer
2015-02-25 15:07 ` Andreas Enge [this message]
2015-02-25 15:51 ` Taylan Ulrich Bayırlı/Kammer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150225150701.GA5733@debian.math.u-bordeaux1.fr \
--to=andreas@enge.fr \
--cc=guix-devel@gnu.org \
--cc=taylanbayirli@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.