Re: [PATCH] gnu: Add gnugo.

[Andreas Enge <andreas@enge.fr>]

Hello,

thanks, and congratulations for your first (I think) package!

Alex Kost has already made a few comments, so I will just add what I found.
I compiled the package successfully, but did not try the binary.

On Thu, Feb 19, 2015 at 07:57:21AM -0600, David Hashe wrote:
> +++ b/gnu/packages/gnugo.scm

How about adding the package into the games.scm module?

> +  #:use-module (gnu packages texinfo))
> +              ("texinfo", texinfo)))

This is not needed, I think.

The package contains a number of perl, python and pike scripts. They are
not installed, but maybe used during "make check"? (I wonder because some
of them are in the "regression" directory.) In that case, you should add
the perl and python interpreters as native-inputs (since they would be
executed during package building).

Could you please send an updated patch taking our comments into account?

Thanks!

Andreas