[PATCH] gnu: Add gambc.

[PATCH] gnu: Add gambc.

[Taylan Ulrich Bayırlı/Kammer]

[-- Attachment #1: patch --]
[-- Type: text/x-diff, Size: 3262 bytes --]

From 81fdfe2ef50f0cb9f92ae4d913e9d1705926b3ab Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Taylan=20Ulrich=20Bay=C4=B1rl=C4=B1/Kammer?=
 <taylanbayirli@gmail.com>
Date: Mon, 16 Feb 2015 13:29:36 +0100
Subject: [PATCH] gnu: Add gambc.

* gnu/packages/scheme.scm (gambc): New variable.
---
 gnu/packages/scheme.scm | 46 ++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 46 insertions(+)

diff --git a/gnu/packages/scheme.scm b/gnu/packages/scheme.scm
index 8afc0ab..b8466e5 100644
--- a/gnu/packages/scheme.scm
+++ b/gnu/packages/scheme.scm
@@ -1,5 +1,6 @@
 ;;; GNU Guix --- Functional package management for GNU
 ;;; Copyright © 2013, 2014, 2015 Ludovic Courtès <ludo@gnu.org>
+;;; Copyright © 2015 Taylan Ulrich Bayırlı/Kammer <taylanbayirli@gmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -21,6 +22,7 @@
   #:use-module (guix licenses)
   #:use-module (guix packages)
   #:use-module (guix download)
+  #:use-module (guix utils)
   #:use-module (guix build-system gnu)
   #:use-module (gnu packages m4)
   #:use-module (gnu packages multiprecision)
@@ -428,3 +430,47 @@ R6RS) and related languages, such as Typed Racket.  It features a compiler and
 a virtual machine with just-in-time native compilation, as well as a large set
 of libraries.")
     (license lgpl2.0+)))
+
+(define-public gambc
+  (package
+    (name "gambc")
+    (version "v4.7.4")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "http://www.iro.umontreal.ca/~gambit/download/gambit/"
+             (version-major+minor version) "/source/gambc-"
+             (string-map (lambda (c) (if (char=? c #\.) #\_ c)) version)
+             ".tgz"))
+       (sha256
+        (base32 "0y2pklh4k65yrmxv63ass76xckrk9wqimbdad2gha35v2mi7blhs"))))
+    (build-system gnu-build-system)
+    (arguments
+     '(#:configure-flags
+       ;; According to the ./configure script, this makes the build slower and
+       ;; use >= 1 GB memory, but makes Gambit much faster.
+       '("--enable-single-host")
+       #:phases
+       (alist-cons-before
+        'check 'fix-tests
+        (lambda _
+          (substitute* '("tests/makefile")
+            ;; '-:' is how run-time options are set.  'tl' sets some terminal
+            ;; option, which makes it fail in our build environment.  It
+            ;; recommends using 'd-' as a solution, which sets the REPL
+            ;; interaction channel to stdin/stdout.
+            (("gsi -:tl") "gsi -:d-,tl")))
+        %standard-phases)))
+    (home-page "http://www.iro.umontreal.ca/~gambit/")
+    (synopsis "Efficient Scheme interpreter and compiler")
+    (description
+     "Gambit consists of two main programs: gsi, the Gambit Scheme
+interpreter, and gsc, the Gambit Scheme compiler.  The interpreter contains
+the complete execution and debugging environment.  The compiler is the
+interpreter extended with the capability of generating executable files.  The
+compiler can produce standalone executables or compiled modules which can be
+loaded at run time.  Interpreted code and compiled code can be freely
+mixed.")
+    ;; Dual license.
+    (license (list lgpl2.1+ asl2.0))))
-- 
2.2.1

Re: [PATCH] gnu: Add gambc.

[Mark H Weaver]

taylanbayirli@gmail.com (Taylan Ulrich "Bayırlı/Kammer") writes:

> From 81fdfe2ef50f0cb9f92ae4d913e9d1705926b3ab Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Taylan=20Ulrich=20Bay=C4=B1rl=C4=B1/Kammer?=
>  <taylanbayirli@gmail.com>
> Date: Mon, 16 Feb 2015 13:29:36 +0100
> Subject: [PATCH] gnu: Add gambc.
>
> * gnu/packages/scheme.scm (gambc): New variable.

I think the name of the package and variable should be 'gambit-c'.  I
know that Debian calls it 'gambc', but Parabola and Fedora both call it
'gambit-c', and IMO that's much more readable.

Also, 'version' should be "4.7.4", not "v4.7.4".  Please make sure to
test the download again by deleting the tarball from your store (with
guix gc -d) and then downloading it again with the updated package.

Okay to push with these changes.

     Thanks!
       Mark

Re: [PATCH] gnu: Add gambc.

[Andreas Enge]

Hello,

On Mon, Feb 16, 2015 at 07:57:49PM -0500, Mark H Weaver wrote:
> I think the name of the package and variable should be 'gambit-c'.  I
> know that Debian calls it 'gambc', but Parabola and Fedora both call it
> 'gambit-c', and IMO that's much more readable.

according to the packaging guidelines, the name should be derived from the
tarball name. So here it would indeed be "gambc" (and for the other package,
"chibi-scheme" as you suggest).

Andreas

Re: [PATCH] gnu: Add gambc.

[Taylan Ulrich Bayırlı/Kammer]

Andreas Enge <andreas@enge.fr> writes:

> Hello,
>
> On Mon, Feb 16, 2015 at 07:57:49PM -0500, Mark H Weaver wrote:
>> I think the name of the package and variable should be 'gambit-c'.  I
>> know that Debian calls it 'gambc', but Parabola and Fedora both call it
>> 'gambit-c', and IMO that's much more readable.
>
> according to the packaging guidelines, the name should be derived from the
> tarball name. So here it would indeed be "gambc" (and for the other package,
> "chibi-scheme" as you suggest).
>
> Andreas

FYI I already pushed it as gambit-c.  

Tell me if you want me to push a patch to change it.

Taylan

Re: [PATCH] gnu: Add gambc.

[Andreas Enge]

On Tue, Feb 17, 2015 at 10:23:32AM +0100, Taylan Ulrich Bayırlı/Kammer wrote:
> FYI I already pushed it as gambit-c.  

I saw it just after sending my own message.

> Tell me if you want me to push a patch to change it.

I think it would be nice to be consistent, so yes, please.

Andreas

Re: [PATCH] gnu: Add gambc.

[Mark H Weaver]

Andreas Enge <andreas@enge.fr> writes:

> On Tue, Feb 17, 2015 at 10:23:32AM +0100, Taylan Ulrich Bayırlı/Kammer wrote:
>> FYI I already pushed it as gambit-c.  
>
> I saw it just after sending my own message.
>
>> Tell me if you want me to push a patch to change it.
>
> I think it would be nice to be consistent, so yes, please.

Andreas: we have a disagreement here, so let's please discuss it before
you ask Taylan to push a change that overrides my wishes.  Thanks.

> according to the packaging guidelines, the name should be derived from
> the tarball name.

Where is this documented?  I looked for it in the "Packaging Guidelines"
section of our manual, and also the subsection "Package Naming", and
couldn't find it.  Anyway, even if such a guideline were documented, I
would oppose it as a general rule.

       Mark

Re: [PATCH] gnu: Add gambc.

[Andreas Enge]

On Tue, Feb 17, 2015 at 01:30:31PM -0500, Mark H Weaver wrote:
> Where is this documented?  I looked for it in the "Packaging Guidelines"
> section of our manual, and also the subsection "Package Naming", and
> couldn't find it.  Anyway, even if such a guideline were documented, I
> would oppose it as a general rule.

What I meant is the following paragraph, which is indeed ambiguous:

"Both are usually the same and correspond to the lowercase conversion of
the project name chosen upstream, with underscores replaced with
hyphens.  For instance, GNUnet is available as @code{gnunet}, and
SDL_net as @code{sdl-net}."

The "upstream project name" is not clearly defined. I wrote this paragraph
quite some time ago. Normally, I understood the "upstream project name"
as the tarball name; usually, both are the same so there is no problem.
The idea was to have a mainly mechanical process to avoid per-package
discussions. So in general, I think one _can_ choose the tarball name,
but if it is too weird, that may not be a good idea.

For the package in question, it is referred to everywhere on its homepage
   http://dynamo.iro.umontreal.ca/wiki/index.php/Main_Page
as "Gambit". For instance at the bottom: "Gambit is Copyright ...".

In the middle, it speaks of "Gambit-C", as in
"Gambit-C is a version of the programming system ...".
There does not seem to be any other version, though, so in practice,
"Gambit" and "Gambit-C" appear to be synonyms.

All in all, I think that all three package names "gambc", "gambit" and
"gambit-c" are defendable. We may follow the path of lowest resistance
and keep the name as it is now.

Andreas

Re: [PATCH] gnu: Add gambc.

[Taylan Ulrich Bayırlı/Kammer]

Andreas Enge <andreas@enge.fr> writes:

> All in all, I think that all three package names "gambc", "gambit" and
> "gambit-c" are defendable.

"Gambit" would have been best I guess but then there's another program
of that name, <https://packages.debian.org/wheezy/math/gambit>, which is
probably the reason package repositories call it gambc or gambit-c.

> We may follow the path of lowest resistance and keep the name as it is
> now.

OK, leaving it as is then. :-)

Taylan