Re: [PATCH]: Add Ant.

[Andreas Enge <andreas@enge.fr>]

Hello,

On Sun, Feb 15, 2015 at 02:54:54PM +0100, Ricardo Wurmus wrote:
> I already packaged ant-minimal with only the most basic features
> enabled, as most additional features depend on libraries that need ant
> in order to build them.  Here's the latest version of my patch to add
> the ant-minimal package for which I'm waiting for a final OK before
> pushing

indeed, I was a bit confused since I remembered discussions about ANT_HOME,
which led me to believe that it had made it into the distribution. Please
do not hesitate to send out a ping if you do not get a reaction to a patch!

So a few comments. First of all, it builds. :-)
Then it is already enough to build my android project, apparently I do not
need a more advanced ant.

Using icedtea6 as a native input also seems to work. Actually, I set neither
ANT_HOME nor JAVA_HOME and have the impression that ant simply uses the
binaries it finds in the path.

On Mon, Feb 09, 2015 at 03:51:40PM +0100, Ricardo Wurmus wrote:
> +(define-public ant-minimal

If I understood correctly, you saw this essentially as a bootstrap-ant.
So once you add the "real" one, you may wish to hide this one with
"define" instead of "define-public".

> +     `(#:tests? #f ; Tests require hamcrest-core, which needs Ant to build.
> +       #:phases
> +       (alist-cons-after
> +        'unpack 'remove-scripts
> +        ;; Remove bat / cmd scripts for DOS as well as the antRun and runant
> +        ;; wrappers.
> +        (lambda _
> +          (for-each delete-file
> +                    (find-files "src/script"
> +                                "(.*\\.(bat|cmd)|runant.*|antRun.*)")))

Is this needed to prevent installation?

> +           ;; disable tests to avoid dependecy on hamcrest-core

Typo, missing "n" in "depende_n_cy".

> +           (substitute* "build.xml"
> +             (("depends=\"jars,test-jar\"") "depends=\"jars\""))

How does this relate do disabling tests above? Are both needed?

> +           (system* "bash" "bootstrap.sh"
> +                    (string-append "-Ddist.dir="
> +                                   (assoc-ref %outputs "out"))))

Here you may wish to check the return value with "zero?" as this is
the last command in the phase.


Then, please push! This is indeed very useful for me.

Andreas