From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andreas Enge <andreas@enge.fr>
Subject: Re: [PATCH] gnu: Add freeimage.
Date: Sun, 2 Nov 2014 18:46:52 +0100
Message-ID: <20141102174652.GD6865@debian>
References: <87egtmx6ox.fsf@izanagi.i-did-not-set--mail-host-address--so-tickle-me>
	<20141101165950.GA10580@debian>
	<87bnoqx2do.fsf@izanagi.i-did-not-set--mail-host-address--so-tickle-me>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41028)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <andreas@enge.fr>) id 1XkzF2-0006Qm-1x
	for guix-devel@gnu.org; Sun, 02 Nov 2014 12:47:11 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <andreas@enge.fr>) id 1XkzEu-0007Z3-HO
	for guix-devel@gnu.org; Sun, 02 Nov 2014 12:47:03 -0500
Received: from mout.kundenserver.de ([212.227.17.13]:50024)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <andreas@enge.fr>) id 1XkzEu-0007YY-8E
	for guix-devel@gnu.org; Sun, 02 Nov 2014 12:46:56 -0500
Content-Disposition: inline
In-Reply-To: <87bnoqx2do.fsf@izanagi.i-did-not-set--mail-host-address--so-tickle-me>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: David Thompson <dthompson2@worcester.edu>
Cc: guix-devel@gnu.org

On Sat, Nov 01, 2014 at 01:21:55PM -0400, David Thompson wrote:
> +    '(#:phases (alist-replace
> +                'unpack
> +                (lambda* (#:key source #:allow-other-keys)
> +                  (and (zero? (system* "unzip" source))
> +                       (chdir "FreeImage")))
> +                (alist-delete
> +                 'configure
> +                 (alist-cons-before
> +                  'build 'patch-makefile
> +                  (lambda* (#:key outputs #:allow-other-keys)
> +                    (substitute* "Makefile.gnu"
> +                      (("/usr") (assoc-ref outputs "out"))
> +                      (("-o root -g root") "")))
> +                  %standard-phases)))

I think that instead of adding patch-makefile before build, I would let it
replace configure. But this is just a matter of taste, so please do as you
please.

Andreas