all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Pjotr Prins <pjotr.public12@thebird.nl>
To: Mark H Weaver <mhw@netris.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: Add ruby 1.8.7
Date: Mon, 27 Oct 2014 02:56:50 +0100	[thread overview]
Message-ID: <20141027015650.GB21971@thebird.nl> (raw)
In-Reply-To: <87siiap9s5.fsf@yeeloong.lan>

On Sun, Oct 26, 2014 at 09:43:22PM -0400, Mark H Weaver wrote:
> In broad strokes, we use the GNU changelog conventions:
> 
>   http://www.gnu.org/prep/standards/html_node/Change-Logs.html
> 
> but with some minor formatting differences.  However, the best thing is
> to look in the commit history for examples close to what you're doing.
> 
> There is brief mention of this in the "Submitting Patches" section of
> the HACKING file in the source tree.

I read those earlier. I used a commit message we used before. I think
that if you are serious about convention you should point to a real
list of allowed standard messages. Now it looks arbitrary and
makes the submitter look stupid.

> >> It looks like the 'native-search-paths' field needs to be overridden,
> >> since the existing one has "2.1.3" in it.
> >
> > I don't think it is used by 1.8.7. Does that matter?
> 
> Yes, otherwise users who install ruby 1.8.7 will be advised to set
> GEM_PATH to $HOME/.guix-profile/lib/ruby/gems/2.1.3.

Ah, that is what it is for. Actually the build did not give me that
message. I DO get a load of messages such as

  strip:/gnu/store/icz59y35qqmm4jcrnkqx7d73xlzsq0lq-ruby-1.8.7-p374/lib/ruby/1.8/rexml/attlistdecl.rb:
  File format not recognized

is there a way to prevent files with a .rb extension or ruby shebang
to be stripped?

Pj.

  reply	other threads:[~2014-10-27  1:57 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-26 20:31 [PATCH] gnu: Add ruby 1.8.7 Pjotr Prins
2014-10-26 23:33 ` Mark H Weaver
2014-10-26 23:44   ` Pjotr Prins
2014-10-26 23:53     ` Pjotr Prins
2014-10-27  0:53       ` David Thompson
2014-10-27  1:44         ` Pjotr Prins
2014-10-27  1:43     ` Mark H Weaver
2014-10-27  1:56       ` Pjotr Prins [this message]
2014-10-27  4:11         ` Mark H Weaver
2014-10-27  9:05           ` ‘strip’ phase Ludovic Courtès
2014-10-27  9:28             ` Mark H Weaver
2014-10-27 12:16               ` Ludovic Courtès
2014-10-27 14:23                 ` Mark H Weaver
2014-11-22 11:53                   ` Ludovic Courtès
2014-10-27  5:17   ` [PATCH] gnu: Add ruby 1.8.7 Pjotr Prins

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141027015650.GB21971@thebird.nl \
    --to=pjotr.public12@thebird.nl \
    --cc=guix-devel@gnu.org \
    --cc=mhw@netris.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.