From: Pjotr Prins <pjotr.public12@thebird.nl>
To: Mark H Weaver <mhw@netris.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: Add ruby 1.8.7
Date: Mon, 27 Oct 2014 00:44:36 +0100 [thread overview]
Message-ID: <20141026234436.GA21721@thebird.nl> (raw)
In-Reply-To: <87wq7mpfs0.fsf@yeeloong.lan>
On Sun, Oct 26, 2014 at 07:33:51PM -0400, Mark H Weaver wrote:
> Pjotr Prins <pjotr.public12@thebird.nl> writes:
> > * gnu/packages/ruby.scm: Added older Ruby 1.8.7
>
> According to our conventions, this should be:
>
> * gnu/packages/ruby.scm (ruby-1.8): New variable.
Is a new package a variable?
We used the same message with ruby2. Where can I find these
conventions, btw?
> > ---
> > gnu/packages/ruby.scm | 27 +++++++++++++++++++++++++++
> > 1 file changed, 27 insertions(+)
> >
> > diff --git a/gnu/packages/ruby.scm b/gnu/packages/ruby.scm
> > index ac751f5..31cbe54 100644
> > --- a/gnu/packages/ruby.scm
> > +++ b/gnu/packages/ruby.scm
> > @@ -89,6 +89,33 @@ a focus on simplicity and productivity.")
> > (home-page "https://ruby-lang.org")
> > (license license:ruby)))
> >
> > +(define-public ruby-1.8
> > + (package (inherit ruby)
> > + (name "ruby")
>
> Is there a reason to repeat the 'name' field here?
> It should be inherited.
Good point. It is a remnant of trying things.
> > + (version "1.8.7-p374")
> > + (source
> > + (origin
> > + (method url-fetch)
> > + (uri (string-append "ftp://ftp.ruby-lang.org/pub/ruby/1.8/"
> > + name "-" version ".tar.bz2"))
>
> In the ruby-2.1.3 package description, we used the http URI starting
> with "http://cache.ruby-lang.org/pub/ruby/". It's probably better to
> use that one, since 'http' has some advantages and our http client is
> more robust.
OK
> > + (sha256
> > + (base32
> > + "1qq7khilwkayrhwmzlxk83scrmiqfi7lgsn4c63znyvz2c1lgqxl"))))
> > + (arguments
> > + `(#:test-target "test"
> > + #:parallel-tests? #f
> > + #:phases
> > + (alist-cons-before
> > + 'configure 'replace-bin-sh
> > + (lambda _
> > + (substitute* '("Makefile.in"
> > + "ext/pty/pty.c"
> > + "io.c"
> > + "lib/mkmf.rb"
> > + "process.c")
> > + (("/bin/sh") (which "sh"))))
> > + %standard-phases)))))
>
> It looks like the 'native-search-paths' field needs to be overridden,
> since the existing one has "2.1.3" in it.
I don't think it is used by 1.8.7. Does that matter?
Pj.
next prev parent reply other threads:[~2014-10-26 23:45 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-26 20:31 [PATCH] gnu: Add ruby 1.8.7 Pjotr Prins
2014-10-26 23:33 ` Mark H Weaver
2014-10-26 23:44 ` Pjotr Prins [this message]
2014-10-26 23:53 ` Pjotr Prins
2014-10-27 0:53 ` David Thompson
2014-10-27 1:44 ` Pjotr Prins
2014-10-27 1:43 ` Mark H Weaver
2014-10-27 1:56 ` Pjotr Prins
2014-10-27 4:11 ` Mark H Weaver
2014-10-27 9:05 ` ‘strip’ phase Ludovic Courtès
2014-10-27 9:28 ` Mark H Weaver
2014-10-27 12:16 ` Ludovic Courtès
2014-10-27 14:23 ` Mark H Weaver
2014-11-22 11:53 ` Ludovic Courtès
2014-10-27 5:17 ` [PATCH] gnu: Add ruby 1.8.7 Pjotr Prins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141026234436.GA21721@thebird.nl \
--to=pjotr.public12@thebird.nl \
--cc=guix-devel@gnu.org \
--cc=mhw@netris.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.