From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Denhardt Subject: Re: [PATCH v2 1/1] Factor out a common pattern into a procedure. Date: Mon, 20 Oct 2014 14:47:07 -0400 Message-ID: <20141020184706.582.44183@rook.local.tld> References: <87fveix3th.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/signed; protocol="application/pgp-signature"; micalg="pgp-sha1"; boundary="===============5183670506215003948==" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:43871) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XgHye-0006aE-Np for guix-devel@gnu.org; Mon, 20 Oct 2014 14:46:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XgHyZ-00028B-GG for guix-devel@gnu.org; Mon, 20 Oct 2014 14:46:44 -0400 Content-Disposition: inline In-Reply-To: <87fveix3th.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Ludovic =?utf-8?Q?Court=C3=A8s?= Cc: guix-devel@gnu.org --===============5183670506215003948== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Quoting Ludovic Court=C3=A8s (2014-10-20 09:34:34) > Ian Denhardt skribis: > Thanks, pushed! I=E2=80=99ve made the subject line more explicit. You're welcome, and thank you! I agree your subject line is better. = > Also, note that the paragraph above isn=E2=80=99t strictly necessary beca= use > these procedures have docstrings anyway. Yeah, I know -- but it seems sensible to have a "this is what this patch is all about" right upfront. Actually, most (all?) of the commits in the repo have a fair amount of information that's obvious from the diff -- I see lots of `foo/bar/baz.scm: New file`, for example. -Ian --===============5183670506215003948== MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Description: signature Content-Type: application/pgp-signature; name="signature.asc"; charset="us-ascii" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABAgAGBQJURViqAAoJEPZUuMfUyjy4S2UP/Am7VjuEXAhe/spoOBGrRedr BbNjvnDVCKFAAXOGFZwq6ez50/qG/ignugyOab6iAUtUdSKomsJcGu7ch2qLe2Ph EvyKkIjtTG5YEgOLzDgzJ1bdU4HUPRsUgpksVzhCRY0ObtcpyJQt4S4dnyIZEHte grg69QskXwaV2v2FbaTxN6ZGFkCReS8kmof9G1BWWh4ruE1iutVyPBfjsgzDoQ2/ PB5KiBtD961HZLNN+B66cxxkigTumz2qJThB8SF75rek8wfVhFvVN1DN/z7YGdNu qTpmrsON4T1hQ5am6gv55C1kI2rpdEWjCjhkrQunkYFkxiu7ilksJUdhHkgKZksa kQMOBcLTP9PPJfMxm2fZz6j9vGTeU2zZy2kJkDuZ4186A18zOvSp0h84fqi8Xm1y qhQbOWBbcLaJXDSD0OhqItGRyQGGoFG5SG4k7VVW8Wwk6JxOBcZZd06C8nfrO7U8 OAPF9LGYx0Is5arOYNAIFsDW2wH9ySWK6ijwjroQ7Trh3+kp2F0amB/HIo3OvpBG KSB+tD1ezg408LcdakdWq6ZIlz+GimoJAzhk0JG6N1NCjmTFWhSfKF/4OTdIMSks bmHJGKekyGph5h0sOGpMTt+q9b/W0yJIJ7KbAjbP+XVpbSBsA8dRo+jihodBhP0w /uhAxxXcajrjMEnd3jtU =DV3k -----END PGP SIGNATURE----- --===============5183670506215003948==--