From mboxrd@z Thu Jan 1 00:00:00 1970 From: John Darrington Subject: Re: [PATCH 5/6] gnu: Enable gnome-doc-utils tests Date: Tue, 15 Jul 2014 23:43:38 +0200 Message-ID: <20140715214338.GB16482@jocasta.intra> References: <1405449096-29230-1-git-send-email-jmd@gnu.org> <1405449096-29230-5-git-send-email-jmd@gnu.org> <87r41ml4nu.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="NMuMz9nt05w80d4+" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:49539) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X7AVw-0003fQ-92 for guix-devel@gnu.org; Tue, 15 Jul 2014 17:44:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X7AVr-0001vC-Lu for guix-devel@gnu.org; Tue, 15 Jul 2014 17:43:56 -0400 Content-Disposition: inline In-Reply-To: <87r41ml4nu.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Ludovic Court??s Cc: guix-devel@gnu.org, John Darrington --NMuMz9nt05w80d4+ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jul 15, 2014 at 10:59:17PM +0200, Ludovic Court??s wrote: > + (arguments > + `(#:phases > + (alist-cons-before > + 'check 'pre-check > + (lambda* (#:key inputs #:allow-other-keys #:rest args) > + ;; This is needed, because without it, xmlint etc tries > + ;; to download docbookx.dtd from the net > + (setenv "XML_CATALOG_FILES"=20 > + (string-append (assoc-ref inputs "docbook-xml")= =20 > + "/xml/dtd/docbook/catalog.xml"))) > + %standard-phases))) > (native-inputs > `(("intltool" ,intltool) > + ("docbook-xml" ,docbook-xml-4.4) =20 We can???t copy that around forever. =20 The problem is that ???search-path-specification??? is meant for $PATH= -like variables that list directories, not files. That occurred to me too. But what problems does it actually cause? =20 So I see two solutions: =20 1. Patch libxml2 so that it honors a new variable, say $XML_CATALOG_DIRECTORIES, which would allow us to use ???search-path-specification???. =20 2. Augment support for search paths to allow file-based search paths. =20 (2) may be best in the long run, but it has ramifications in different places. =20 (1) seems like a good idea only if upstream can be persuaded to adopt it. What are the ramifications of (2) ? =20 --=20 PGP Public key ID: 1024D/2DE827B3=20 fingerprint =3D 8797 A26D 0854 2EAB 0285 A290 8A67 719C 2DE8 27B3 See http://sks-keyservers.net or any PGP keyserver for public key. --NMuMz9nt05w80d4+ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iEYEARECAAYFAlPFoIoACgkQimdxnC3oJ7MKLACePQiQLpemv7W9pbDI7fKDC7g2 wZQAni+mAe4SvpvflGcdHSDsLSlzXcNz =yg3d -----END PGP SIGNATURE----- --NMuMz9nt05w80d4+--