all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Andreas Enge <andreas@enge.fr>
To: guix-devel@gnu.org
Subject: [PATCH] build: cmake: Add input libraries to the rpath.
Date: Fri, 25 Apr 2014 09:13:46 +0200	[thread overview]
Message-ID: <20140425071346.GA12585@debian> (raw)

[-- Attachment #1: Type: text/plain, Size: 1006 bytes --]

In a discussion we had yesterday, Ludovic mentioned the need to pass a
special flag to the cmake configure phase to modify the rpath of installed
libraries, as done for the package slim. I then noticed I needed the same
flag for clucene. The attached patch applies it globally in the cmake build
system. This should also avoid the need for the add-libs-to-runpath phase
in the gmsh package Eric Bavier posted yesterday.

In slim, there is another flag:
    ;; Don't build libslim.so, because then the build
    ;; system is unable to set the right RUNPATH on the
    ;; 'slim' binary.
    "-DBUILD_SHARED_LIBS=OFF"
I wonder if we should instead use another of the rpath setting variables
given at
   http://www.cmake.org/Wiki/CMake_RPATH_handling

Moreover, libclucene-core.so needs to be linked to libclucene-shared.so.1
from the same package. Here we usually employ patchelf, but maybe yet again
a cmake flag could solve the problem directly.

Comments from cmake specialists are very welcome!

Andreas


[-- Attachment #2: 0001-build-cmake-Add-input-libraries-to-the-rpath.patch --]
[-- Type: text/plain, Size: 870 bytes --]

From f5089b7ca46ac8199aa89f582efc04f12add8cbc Mon Sep 17 00:00:00 2001
From: Andreas Enge <andreas@enge.fr>
Date: Fri, 25 Apr 2014 09:00:03 +0200
Subject: [PATCH] build: cmake: Add input libraries to the rpath.

* guix/build/cmake-build-system.scm (configure): Add flag.
---
 guix/build/cmake-build-system.scm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/guix/build/cmake-build-system.scm b/guix/build/cmake-build-system.scm
index 7599856..fb07b99 100644
--- a/guix/build/cmake-build-system.scm
+++ b/guix/build/cmake-build-system.scm
@@ -48,6 +48,7 @@
 
     (let ((args `(,srcdir
                   ,(string-append "-DCMAKE_INSTALL_PREFIX=" out)
+                  "-DCMAKE_SKIP_BUILD_RPATH=ON"
                   ,@configure-flags)))
       (setenv "CMAKE_LIBRARY_PATH" (getenv "LIBRARY_PATH"))
       (setenv "CMAKE_INCLUDE_PATH" (getenv "CPATH"))
-- 
1.8.4


             reply	other threads:[~2014-04-25  7:14 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-25  7:13 Andreas Enge [this message]
2014-04-25 11:31 ` [PATCH] build: cmake: Add input libraries to the rpath Ludovic Courtès
2014-04-25 17:44 ` Eric Bavier
2014-04-26  8:52   ` Ludovic Courtès
2014-04-27  8:59   ` Andreas Enge
2014-04-27  9:57     ` Andreas Enge
2014-04-27 17:17       ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140425071346.GA12585@debian \
    --to=andreas@enge.fr \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.