From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andreas Enge <andreas@enge.fr>
Subject: Re: [PATCH] Add MPD
Date: Mon, 24 Feb 2014 22:20:54 +0100
Message-ID: <20140224212054.GA8987@debian>
References: <87txbpjte8.fsf@izanagi.i-did-not-set--mail-host-address--so-tickle-me>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46808)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <andreas@enge.fr>) id 1WI2xX-0003vE-Kt
	for guix-devel@gnu.org; Mon, 24 Feb 2014 16:21:15 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <andreas@enge.fr>) id 1WI2xQ-0004QO-6Y
	for guix-devel@gnu.org; Mon, 24 Feb 2014 16:21:07 -0500
Received: from moutng.kundenserver.de ([212.227.126.130]:50337)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <andreas@enge.fr>) id 1WI2xP-0004QH-TR
	for guix-devel@gnu.org; Mon, 24 Feb 2014 16:21:00 -0500
Content-Disposition: inline
In-Reply-To: <87txbpjte8.fsf@izanagi.i-did-not-set--mail-host-address--so-tickle-me>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: David Thompson <dthompson2@worcester.edu>
Cc: guix-devel@gnu.org

Hello,

On Sun, Feb 23, 2014 at 06:34:07PM -0500, David Thompson wrote:
> Attached is a patch with basic package recipes for libmpdclient and MPD.
> MPD has a lot of optional dependencies and I've included as inputs all
> of the ones that Guix currently has packages for.  libmpdclient requires
> doxygen in order to generate documentation and since Guix does not have
> a package for this yet I've disabled the documentation for now.

the approach looks good. I think I would prepare two separate patches,
adding the packages one by one. And I would prepend the comment "Needs
doxygen" by "FIXME", so we know there is a TODO item.

If you feel like it, you can also add in comment a list of all the optional
inputs, so that it will be easier to add them once they are available (see
ffmpeg for an example).

Andreas